[VOTE] Apache Ignite 1.5.0.final

[Anton Vinogradov-2]

Dear Sirs!

We have uploaded release candidate to
https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/

This is very important release containing initial versions of Ignite.NET
and Ignite C++ and many other important features.

Tag name is
1.5.0.final-rc1

1.5.0 changes:
* Ignite.NET: Initial Release.
* Ignite C++: Initial Release.
* Massive performance improvements for cache operations and SQL.
* Added new binary cache object marshalling implementation.
* Added IgniteSemaphore data structure.
* Added MQTT Streamer.
* Added Twitter Streamer.
* Added Ignite Sink (integration with Apache Flume).
* Fixed optimistic serializable transactions: implemented "deadlock-free"
locking algorithm.
* Fixed failover for continuous queries.
* Fixed compilation and runtime errors under OpenJDK and IBM JDK.
* Fixed Integer.size limitation for cache.
* Fixed and improved cache types configuration.
* Fixed cache rebalancing.
* Many stability and fault-tolerance fixes.
* Added example to demonstrate the usage of EntryProcessor.

Complete list of closed issues:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed

DEVNOTES
https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1

RELEASENOTES
https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1

Please start voting.

+1 - to accept Apache Ignite 1.5.0.final
0 - don't care either way
-1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)

This vote will go for 72 hours.

[Nikolay Tikhonov]

+1 (binding)

On Fri, Dec 25, 2015 at 4:00 PM, Anton Vinogradov <[hidden email]> wrote:

> Dear Sirs!
>
> We have uploaded release candidate to
> https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
>
> This is very important release containing initial versions of Ignite.NET
> and Ignite C++ and many other important features.
>
> Tag name is
> 1.5.0.final-rc1
>
> 1.5.0 changes:
> * Ignite.NET: Initial Release.
> * Ignite C++: Initial Release.
> * Massive performance improvements for cache operations and SQL.
> * Added new binary cache object marshalling implementation.
> * Added IgniteSemaphore data structure.
> * Added MQTT Streamer.
> * Added Twitter Streamer.
> * Added Ignite Sink (integration with Apache Flume).
> * Fixed optimistic serializable transactions: implemented "deadlock-free"
> locking algorithm.
> * Fixed failover for continuous queries.
> * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> * Fixed Integer.size limitation for cache.
> * Fixed and improved cache types configuration.
> * Fixed cache rebalancing.
> * Many stability and fault-tolerance fixes.
> * Added example to demonstrate the usage of EntryProcessor.
>
> Complete list of closed issues:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
>
> DEVNOTES
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> RELEASENOTES
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> Please start voting.
>
> +1 - to accept Apache Ignite 1.5.0.final
> 0 - don't care either way
> -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
>
> This vote will go for 72 hours.
>

[Anton Vinogradov]

+1 (binding)

On Fri, Dec 25, 2015 at 4:19 PM, Nikolay Tikhonov <[hidden email]>
wrote:

> +1 (binding)
>
> On Fri, Dec 25, 2015 at 4:00 PM, Anton Vinogradov <[hidden email]> wrote:
>
> > Dear Sirs!
> >
> > We have uploaded release candidate to
> > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
> >
> > This is very important release containing initial versions of Ignite.NET
> > and Ignite C++ and many other important features.
> >
> > Tag name is
> > 1.5.0.final-rc1
> >
> > 1.5.0 changes:
> > * Ignite.NET: Initial Release.
> > * Ignite C++: Initial Release.
> > * Massive performance improvements for cache operations and SQL.
> > * Added new binary cache object marshalling implementation.
> > * Added IgniteSemaphore data structure.
> > * Added MQTT Streamer.
> > * Added Twitter Streamer.
> > * Added Ignite Sink (integration with Apache Flume).
> > * Fixed optimistic serializable transactions: implemented "deadlock-free"
> > locking algorithm.
> > * Fixed failover for continuous queries.
> > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> > * Fixed Integer.size limitation for cache.
> > * Fixed and improved cache types configuration.
> > * Fixed cache rebalancing.
> > * Many stability and fault-tolerance fixes.
> > * Added example to demonstrate the usage of EntryProcessor.
> >
> > Complete list of closed issues:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
> >
> > DEVNOTES
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >
> > RELEASENOTES
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >
> > Please start voting.
> >
> > +1 - to accept Apache Ignite 1.5.0.final
> > 0 - don't care either way
> > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
> >
> > This vote will go for 72 hours.
> >
>

[Alexey Goncharuk]

+1 (binding)

[Alexey Kuznetsov-2]

+1 (NOT binding)

On Fri, Dec 25, 2015 at 9:12 PM, Alexey Goncharuk <
[hidden email]> wrote:

> +1 (binding)
>



--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

[Denis Magda]

+ 1 (binding)

On 12/25/2015 4:00 PM, Anton Vinogradov wrote:

> Dear Sirs!
>
> We have uploaded release candidate to
> https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
>
> This is very important release containing initial versions of Ignite.NET
> and Ignite C++ and many other important features.
>
> Tag name is
> 1.5.0.final-rc1
>
> 1.5.0 changes:
> * Ignite.NET: Initial Release.
> * Ignite C++: Initial Release.
> * Massive performance improvements for cache operations and SQL.
> * Added new binary cache object marshalling implementation.
> * Added IgniteSemaphore data structure.
> * Added MQTT Streamer.
> * Added Twitter Streamer.
> * Added Ignite Sink (integration with Apache Flume).
> * Fixed optimistic serializable transactions: implemented "deadlock-free"
> locking algorithm.
> * Fixed failover for continuous queries.
> * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> * Fixed Integer.size limitation for cache.
> * Fixed and improved cache types configuration.
> * Fixed cache rebalancing.
> * Many stability and fault-tolerance fixes.
> * Added example to demonstrate the usage of EntryProcessor.
>
> Complete list of closed issues:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
>
> DEVNOTES
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> RELEASENOTES
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> Please start voting.
>
> +1 - to accept Apache Ignite 1.5.0.final
> 0 - don't care either way
> -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
>
> This vote will go for 72 hours.
>

[Konstantin Boudnik-2]

Looks like a -1 [binding] is order

1) RAT check fails on
    modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
2) release archive includes binary files under
    /modules/platforms/dotnet/bin
    /modules/platforms/dotnet/bin/x86/
3) build fails with
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on project
ignite-clients: An Ant BuildException has occured: Execute failed:
java.io.IOException: Cannot run program "doxygen" (in directory
"/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
error=2, No such file or directory

Cheers,
  Cos

On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:

> Dear Sirs!
>
> We have uploaded release candidate to
> https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
>
> This is very important release containing initial versions of Ignite.NET
> and Ignite C++ and many other important features.
>
> Tag name is
> 1.5.0.final-rc1
>
> 1.5.0 changes:
> * Ignite.NET: Initial Release.
> * Ignite C++: Initial Release.
> * Massive performance improvements for cache operations and SQL.
> * Added new binary cache object marshalling implementation.
> * Added IgniteSemaphore data structure.
> * Added MQTT Streamer.
> * Added Twitter Streamer.
> * Added Ignite Sink (integration with Apache Flume).
> * Fixed optimistic serializable transactions: implemented "deadlock-free"
> locking algorithm.
> * Fixed failover for continuous queries.
> * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> * Fixed Integer.size limitation for cache.
> * Fixed and improved cache types configuration.
> * Fixed cache rebalancing.
> * Many stability and fault-tolerance fixes.
> * Added example to demonstrate the usage of EntryProcessor.
>
> Complete list of closed issues:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
>
> DEVNOTES
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> RELEASENOTES
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
>
> Please start voting.
>
> +1 - to accept Apache Ignite 1.5.0.final
> 0 - don't care either way
> -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
>
> This vote will go for 72 hours.

[Vladimir Ozerov]

Cos,

p.1 and p.2 appear to be the same - folder "modules/platforms/dotnet/bin"
should not exist in source release, only in binary build.
p.3 - looks like we need make .NET and CPP docs creation step off by
default and enable it only if particular flag is set. For now behavior is
the opposite - docs are generated by default unless "!isClientDocs" flag is
set.


On Sat, Dec 26, 2015 at 10:46 AM, Konstantin Boudnik <[hidden email]> wrote:

> Looks like a -1 [binding] is order
>
> 1) RAT check fails on
>     modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
> 2) release archive includes binary files under
>     /modules/platforms/dotnet/bin
>     /modules/platforms/dotnet/bin/x86/
> 3) build fails with
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on project
> ignite-clients: An Ant BuildException has occured: Execute failed:
> java.io.IOException: Cannot run program "doxygen" (in directory
>
> "/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
> error=2, No such file or directory
>
> Cheers,
>   Cos
>
> On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:
> > Dear Sirs!
> >
> > We have uploaded release candidate to
> > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
> >
> > This is very important release containing initial versions of Ignite.NET
> > and Ignite C++ and many other important features.
> >
> > Tag name is
> > 1.5.0.final-rc1
> >
> > 1.5.0 changes:
> > * Ignite.NET: Initial Release.
> > * Ignite C++: Initial Release.
> > * Massive performance improvements for cache operations and SQL.
> > * Added new binary cache object marshalling implementation.
> > * Added IgniteSemaphore data structure.
> > * Added MQTT Streamer.
> > * Added Twitter Streamer.
> > * Added Ignite Sink (integration with Apache Flume).
> > * Fixed optimistic serializable transactions: implemented "deadlock-free"
> > locking algorithm.
> > * Fixed failover for continuous queries.
> > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> > * Fixed Integer.size limitation for cache.
> > * Fixed and improved cache types configuration.
> > * Fixed cache rebalancing.
> > * Many stability and fault-tolerance fixes.
> > * Added example to demonstrate the usage of EntryProcessor.
> >
> > Complete list of closed issues:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
> >
> > DEVNOTES
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >
> > RELEASENOTES
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >
> > Please start voting.
> >
> > +1 - to accept Apache Ignite 1.5.0.final
> > 0 - don't care either way
> > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
> >
> > This vote will go for 72 hours.
>

[Sergey Kozlov]

Hi

I analyzed the build log for Apache Ignite 1.5.0.final-rc1 and found that
we make a source archive after building of fabric edition. It seems it
caused the issue raised by Cos.
I propose to move the step of source archiving  before any build steps and
may be run RAT against source zip file.



On Sat, Dec 26, 2015 at 11:12 AM, Vladimir Ozerov <[hidden email]>
wrote:

> Cos,
>
> p.1 and p.2 appear to be the same - folder "modules/platforms/dotnet/bin"
> should not exist in source release, only in binary build.
> p.3 - looks like we need make .NET and CPP docs creation step off by
> default and enable it only if particular flag is set. For now behavior is
> the opposite - docs are generated by default unless "!isClientDocs" flag is
> set.
>
>
> On Sat, Dec 26, 2015 at 10:46 AM, Konstantin Boudnik <[hidden email]>
> wrote:
>
> > Looks like a -1 [binding] is order
> >
> > 1) RAT check fails on
> >     modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
> > 2) release archive includes binary files under
> >     /modules/platforms/dotnet/bin
> >     /modules/platforms/dotnet/bin/x86/
> > 3) build fails with
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on
> project
> > ignite-clients: An Ant BuildException has occured: Execute failed:
> > java.io.IOException: Cannot run program "doxygen" (in directory
> >
> >
> "/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
> > error=2, No such file or directory
> >
> > Cheers,
> >   Cos
> >
> > On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:
> > > Dear Sirs!
> > >
> > > We have uploaded release candidate to
> > > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
> > >
> > > This is very important release containing initial versions of
> Ignite.NET
> > > and Ignite C++ and many other important features.
> > >
> > > Tag name is
> > > 1.5.0.final-rc1
> > >
> > > 1.5.0 changes:
> > > * Ignite.NET: Initial Release.
> > > * Ignite C++: Initial Release.
> > > * Massive performance improvements for cache operations and SQL.
> > > * Added new binary cache object marshalling implementation.
> > > * Added IgniteSemaphore data structure.
> > > * Added MQTT Streamer.
> > > * Added Twitter Streamer.
> > > * Added Ignite Sink (integration with Apache Flume).
> > > * Fixed optimistic serializable transactions: implemented
> "deadlock-free"
> > > locking algorithm.
> > > * Fixed failover for continuous queries.
> > > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> > > * Fixed Integer.size limitation for cache.
> > > * Fixed and improved cache types configuration.
> > > * Fixed cache rebalancing.
> > > * Many stability and fault-tolerance fixes.
> > > * Added example to demonstrate the usage of EntryProcessor.
> > >
> > > Complete list of closed issues:
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
> > >
> > > DEVNOTES
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
> > >
> > > RELEASENOTES
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
> > >
> > > Please start voting.
> > >
> > > +1 - to accept Apache Ignite 1.5.0.final
> > > 0 - don't care either way
> > > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
> > >
> > > This vote will go for 72 hours.
> >
>

--
Sergey Kozlov

[Anton Vinogradov]

Hi,

1-2)
Seems that we have to have dotnet build folder located at "regular" java
target folder which will be automatically excluded at source package build.
Another way is to configure "source-release-assembly" at "apache-release"
profile somehow.
And last one case is to build source package at separate step (without
using dotnet assemblies)

1 & 2 way is preffered.

Thoughts?

3) We have tip about this issue at
https://apacheignite.readme.io/docs/getting-started, but I agree with
Vladimir.

Cos, in case we will fix sourcess manually (for issue 1-2) and regenerate
md5 & sha will you change your decision?

On Sat, Dec 26, 2015 at 2:29 PM, Sergey Kozlov <[hidden email]> wrote:

> Hi
>
> I analyzed the build log for Apache Ignite 1.5.0.final-rc1 and found that
> we make a source archive after building of fabric edition. It seems it
> caused the issue raised by Cos.
> I propose to move the step of source archiving  before any build steps and
> may be run RAT against source zip file.
>
>
>
> On Sat, Dec 26, 2015 at 11:12 AM, Vladimir Ozerov <[hidden email]>
> wrote:
>
>> Cos,
>>
>> p.1 and p.2 appear to be the same - folder "modules/platforms/dotnet/bin"
>> should not exist in source release, only in binary build.
>> p.3 - looks like we need make .NET and CPP docs creation step off by
>> default and enable it only if particular flag is set. For now behavior is
>> the opposite - docs are generated by default unless "!isClientDocs" flag
>> is
>> set.
>>
>>
>> On Sat, Dec 26, 2015 at 10:46 AM, Konstantin Boudnik <[hidden email]>
>> wrote:
>>
>> > Looks like a -1 [binding] is order
>> >
>> > 1) RAT check fails on
>> >     modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
>> > 2) release archive includes binary files under
>> >     /modules/platforms/dotnet/bin
>> >     /modules/platforms/dotnet/bin/x86/
>> > 3) build fails with
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on
>> project
>> > ignite-clients: An Ant BuildException has occured: Execute failed:
>> > java.io.IOException: Cannot run program "doxygen" (in directory
>> >
>> >
>> "/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
>> > error=2, No such file or directory
>> >
>> > Cheers,
>> >   Cos
>> >
>> > On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:
>> > > Dear Sirs!
>> > >
>> > > We have uploaded release candidate to
>> > > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
>> > >
>> > > This is very important release containing initial versions of
>> Ignite.NET
>> > > and Ignite C++ and many other important features.
>> > >
>> > > Tag name is
>> > > 1.5.0.final-rc1
>> > >
>> > > 1.5.0 changes:
>> > > * Ignite.NET: Initial Release.
>> > > * Ignite C++: Initial Release.
>> > > * Massive performance improvements for cache operations and SQL.
>> > > * Added new binary cache object marshalling implementation.
>> > > * Added IgniteSemaphore data structure.
>> > > * Added MQTT Streamer.
>> > > * Added Twitter Streamer.
>> > > * Added Ignite Sink (integration with Apache Flume).
>> > > * Fixed optimistic serializable transactions: implemented
>> "deadlock-free"
>> > > locking algorithm.
>> > > * Fixed failover for continuous queries.
>> > > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
>> > > * Fixed Integer.size limitation for cache.
>> > > * Fixed and improved cache types configuration.
>> > > * Fixed cache rebalancing.
>> > > * Many stability and fault-tolerance fixes.
>> > > * Added example to demonstrate the usage of EntryProcessor.
>> > >
>> > > Complete list of closed issues:
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
>> > >
>> > > DEVNOTES
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
>> > >
>> > > RELEASENOTES
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
>> > >
>> > > Please start voting.
>> > >
>> > > +1 - to accept Apache Ignite 1.5.0.final
>> > > 0 - don't care either way
>> > > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
>> > >
>> > > This vote will go for 72 hours.
>> >
>>
>
>
>
> --
> Sergey Kozlov
>
>

[dsetrakyan]

Why not just properly fix all the points? I like Vladimir’s suggestion for
(3). Should we add/change build instructions in the DEVNOTES.txt?

On Sat, Dec 26, 2015 at 8:20 AM, Anton Vinogradov <[hidden email]>
wrote:

> Hi,
>
> 1-2)
> Seems that we have to have dotnet build folder located at "regular" java
> target folder which will be automatically excluded at source package build.
> Another way is to configure "source-release-assembly" at "apache-release"
> profile somehow.
> And last one case is to build source package at separate step (without
> using dotnet assemblies)
>
> 1 & 2 way is preffered.
>
> Thoughts?
>
> 3) We have tip about this issue at
> https://apacheignite.readme.io/docs/getting-started, but I agree with
> Vladimir.
>
> Cos, in case we will fix sourcess manually (for issue 1-2) and regenerate
> md5 & sha will you change your decision?
>
> On Sat, Dec 26, 2015 at 2:29 PM, Sergey Kozlov <[hidden email]>
> wrote:
>
> > Hi
> >
> > I analyzed the build log for Apache Ignite 1.5.0.final-rc1 and found that
> > we make a source archive after building of fabric edition. It seems it
> > caused the issue raised by Cos.
> > I propose to move the step of source archiving  before any build steps
> and
> > may be run RAT against source zip file.
> >
> >
> >
> > On Sat, Dec 26, 2015 at 11:12 AM, Vladimir Ozerov <[hidden email]>
> > wrote:
> >
> >> Cos,
> >>
> >> p.1 and p.2 appear to be the same - folder
> "modules/platforms/dotnet/bin"
> >> should not exist in source release, only in binary build.
> >> p.3 - looks like we need make .NET and CPP docs creation step off by
> >> default and enable it only if particular flag is set. For now behavior
> is
> >> the opposite - docs are generated by default unless "!isClientDocs" flag
> >> is
> >> set.
> >>
> >>
> >> On Sat, Dec 26, 2015 at 10:46 AM, Konstantin Boudnik <[hidden email]>
> >> wrote:
> >>
> >> > Looks like a -1 [binding] is order
> >> >
> >> > 1) RAT check fails on
> >> >     modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
> >> > 2) release archive includes binary files under
> >> >     /modules/platforms/dotnet/bin
> >> >     /modules/platforms/dotnet/bin/x86/
> >> > 3) build fails with
> >> > [ERROR] Failed to execute goal
> >> > org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on
> >> project
> >> > ignite-clients: An Ant BuildException has occured: Execute failed:
> >> > java.io.IOException: Cannot run program "doxygen" (in directory
> >> >
> >> >
> >>
> "/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
> >> > error=2, No such file or directory
> >> >
> >> > Cheers,
> >> >   Cos
> >> >
> >> > On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:
> >> > > Dear Sirs!
> >> > >
> >> > > We have uploaded release candidate to
> >> > > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
> >> > >
> >> > > This is very important release containing initial versions of
> >> Ignite.NET
> >> > > and Ignite C++ and many other important features.
> >> > >
> >> > > Tag name is
> >> > > 1.5.0.final-rc1
> >> > >
> >> > > 1.5.0 changes:
> >> > > * Ignite.NET: Initial Release.
> >> > > * Ignite C++: Initial Release.
> >> > > * Massive performance improvements for cache operations and SQL.
> >> > > * Added new binary cache object marshalling implementation.
> >> > > * Added IgniteSemaphore data structure.
> >> > > * Added MQTT Streamer.
> >> > > * Added Twitter Streamer.
> >> > > * Added Ignite Sink (integration with Apache Flume).
> >> > > * Fixed optimistic serializable transactions: implemented
> >> "deadlock-free"
> >> > > locking algorithm.
> >> > > * Fixed failover for continuous queries.
> >> > > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> >> > > * Fixed Integer.size limitation for cache.
> >> > > * Fixed and improved cache types configuration.
> >> > > * Fixed cache rebalancing.
> >> > > * Many stability and fault-tolerance fixes.
> >> > > * Added example to demonstrate the usage of EntryProcessor.
> >> > >
> >> > > Complete list of closed issues:
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
> >> > >
> >> > > DEVNOTES
> >> > >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >> > >
> >> > > RELEASENOTES
> >> > >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >> > >
> >> > > Please start voting.
> >> > >
> >> > > +1 - to accept Apache Ignite 1.5.0.final
> >> > > 0 - don't care either way
> >> > > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
> >> > >
> >> > > This vote will go for 72 hours.
> >> >
> >>
> >
> >
> >
> > --
> > Sergey Kozlov
> >
> >
>

[Konstantin Boudnik-2]

Agree with Sergey - the source archive should be build independently, perhaps
as a part of the release target.

Fixing source manually won't work, because then the content of the release
tarball will be different from the release commit. These seem to be a
relatively point-fixes and should require the full release re-testing, IMO.

Thanks
  Cos

On Sat, Dec 26, 2015 at 07:20PM, Anton Vinogradov wrote:

> Hi,
>
> 1-2)
> Seems that we have to have dotnet build folder located at "regular" java
> target folder which will be automatically excluded at source package build.
> Another way is to configure "source-release-assembly" at "apache-release"
> profile somehow.
> And last one case is to build source package at separate step (without
> using dotnet assemblies)
>
> 1 & 2 way is preffered.
>
> Thoughts?
>
> 3) We have tip about this issue at
> https://apacheignite.readme.io/docs/getting-started, but I agree with
> Vladimir.
>
> Cos, in case we will fix sourcess manually (for issue 1-2) and regenerate
> md5 & sha will you change your decision?
>
> On Sat, Dec 26, 2015 at 2:29 PM, Sergey Kozlov <[hidden email]> wrote:
>
> > Hi
> >
> > I analyzed the build log for Apache Ignite 1.5.0.final-rc1 and found that
> > we make a source archive after building of fabric edition. It seems it
> > caused the issue raised by Cos.
> > I propose to move the step of source archiving  before any build steps and
> > may be run RAT against source zip file.
> >
> >
> >
> > On Sat, Dec 26, 2015 at 11:12 AM, Vladimir Ozerov <[hidden email]>
> > wrote:
> >
> >> Cos,
> >>
> >> p.1 and p.2 appear to be the same - folder "modules/platforms/dotnet/bin"
> >> should not exist in source release, only in binary build.
> >> p.3 - looks like we need make .NET and CPP docs creation step off by
> >> default and enable it only if particular flag is set. For now behavior is
> >> the opposite - docs are generated by default unless "!isClientDocs" flag
> >> is
> >> set.
> >>
> >>
> >> On Sat, Dec 26, 2015 at 10:46 AM, Konstantin Boudnik <[hidden email]>
> >> wrote:
> >>
> >> > Looks like a -1 [binding] is order
> >> >
> >> > 1) RAT check fails on
> >> >     modules/platforms/dotnet/bin/Apache.Ignite.Core.xml
> >> > 2) release archive includes binary files under
> >> >     /modules/platforms/dotnet/bin
> >> >     /modules/platforms/dotnet/bin/x86/
> >> > 3) build fails with
> >> > [ERROR] Failed to execute goal
> >> > org.apache.maven.plugins:maven-antrun-plugin:1.7:run (dotnetdoc) on
> >> project
> >> > ignite-clients: An Ant BuildException has occured: Execute failed:
> >> > java.io.IOException: Cannot run program "doxygen" (in directory
> >> >
> >> >
> >> "/ws/build/ignite-hadoop/rpm/BUILD/ignite-hadoop-1.5.0.final/modules/platforms/dotnet"):
> >> > error=2, No such file or directory
> >> >
> >> > Cheers,
> >> >   Cos
> >> >
> >> > On Fri, Dec 25, 2015 at 04:00PM, Anton Vinogradov wrote:
> >> > > Dear Sirs!
> >> > >
> >> > > We have uploaded release candidate to
> >> > > https://dist.apache.org/repos/dist/dev/ignite/1.5.0.final-rc1/
> >> > >
> >> > > This is very important release containing initial versions of
> >> Ignite.NET
> >> > > and Ignite C++ and many other important features.
> >> > >
> >> > > Tag name is
> >> > > 1.5.0.final-rc1
> >> > >
> >> > > 1.5.0 changes:
> >> > > * Ignite.NET: Initial Release.
> >> > > * Ignite C++: Initial Release.
> >> > > * Massive performance improvements for cache operations and SQL.
> >> > > * Added new binary cache object marshalling implementation.
> >> > > * Added IgniteSemaphore data structure.
> >> > > * Added MQTT Streamer.
> >> > > * Added Twitter Streamer.
> >> > > * Added Ignite Sink (integration with Apache Flume).
> >> > > * Fixed optimistic serializable transactions: implemented
> >> "deadlock-free"
> >> > > locking algorithm.
> >> > > * Fixed failover for continuous queries.
> >> > > * Fixed compilation and runtime errors under OpenJDK and IBM JDK.
> >> > > * Fixed Integer.size limitation for cache.
> >> > > * Fixed and improved cache types configuration.
> >> > > * Fixed cache rebalancing.
> >> > > * Many stability and fault-tolerance fixes.
> >> > > * Added example to demonstrate the usage of EntryProcessor.
> >> > >
> >> > > Complete list of closed issues:
> >> > >
> >> >
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20fixVersion%20%3D%201.5%20AND%20status%20%3D%20closed
> >> > >
> >> > > DEVNOTES
> >> > >
> >> >
> >> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >> > >
> >> > > RELEASENOTES
> >> > >
> >> >
> >> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=refs/tags/1.5.0.final-rc1
> >> > >
> >> > > Please start voting.
> >> > >
> >> > > +1 - to accept Apache Ignite 1.5.0.final
> >> > > 0 - don't care either way
> >> > > -1 - DO NOT accept Apache Ignite 1.5.0.final (explain why)
> >> > >
> >> > > This vote will go for 72 hours.
> >> >
> >>
> >
> >
> >
> > --
> > Sergey Kozlov
> >
> >