Re: Maven conflicts within ignite-core from duplicated classes
Locked
Re: Maven conflicts within ignite-core from duplicated classes
 
|
Hi Pete,
CC-ing Ignite dev list to the thread as well. Igniters, up to today is there any reason why we need to include sources of Nullable JetBrain’s annotation in Ignite sources? As I see we can rather import that latest version from the maven repository https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 <https://maven-repository.com/artifact/org.jetbrains/annotations/15.0> Anton, please take a look at Pete issue and suggest a workaround and generic solution overall. — Denis > On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> wrote: > > Hello, > > I've come across an issue where there are a couple of classes duplicated from org.jetbrains.annotations within the ignite-core module which conflict with other part of our code base. > > As these files are duplicated rather than being referenced as a maven dependency I am unable to exclude them or reference a specific version of the org.jetbrains.annotations artifact. > > Specifically, the included version cannot be used to annotate types > ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE}) > annotations-15.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) > > As far as I know there isn't an easy way of excluding these files from within the ignite-core module. Is there are reason why these "external" files have been duplicated within the ignite code base rather than being referenced as a maven dependency? Or alternatively, has anyone come across a way of avoiding these conflicts? > > Thanks > Pete > |
|
|
Hi Denis,
Thanks for your reply. I'm think it's straight-forward to use the jetbrains source so am happy to make the change if deemed sensible. Thanks Pete |
Re: Maven conflicts within ignite-core from duplicated classes
|
|
In reply to this post by Denis Magda
Denis,
I've created issue: https://issues.apache.org/jira/browse/IGNITE-3323 On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda <[hidden email]> wrote: > Hi Pete, > > CC-ing Ignite dev list to the thread as well. > > Igniters, up to today is there any reason why we need to include sources > of Nullable JetBrain’s annotation in Ignite sources? > > As I see we can rather import that latest version from the maven repository > https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 > > *Anton, *please take a look at Pete issue and suggest a workaround and > generic solution overall. > > — > Denis > > On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> wrote: > > Hello, > > I've come across an issue where there are a couple of classes duplicated > from org.jetbrains.annotations within the ignite-core module which conflict > with other part of our code base. > > As these files are duplicated rather than being referenced as a maven > dependency I am unable to exclude them or reference a specific version of > the org.jetbrains.annotations artifact. > > Specifically, the included version cannot be used to annotate types > ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > ElementType.LOCAL_VARIABLE}) > annotations-15.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) > > As far as I know there isn't an easy way of excluding these files from > within the ignite-core module. Is there are reason why these "external" > files have been duplicated within the ignite code base rather than being > referenced as a maven dependency? Or alternatively, has anyone come across > a way of avoiding these conflicts? > > Thanks > Pete > > > |
Re: Maven conflicts within ignite-core from duplicated classes
|
|
In reply to this post by Denis Magda
As far as I know the only reason sources of Nullable are in Ignite - we did
not want to have any dependecy for 'core' module. On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda <[hidden email]> wrote: > Hi Pete, > > CC-ing Ignite dev list to the thread as well. > > Igniters, up to today is there any reason why we need to include sources > of Nullable JetBrain’s annotation in Ignite sources? > > As I see we can rather import that latest version from the maven repository > https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 > > *Anton, *please take a look at Pete issue and suggest a workaround and > generic solution overall. > > — > Denis > > On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> wrote: > > Hello, > > I've come across an issue where there are a couple of classes duplicated > from org.jetbrains.annotations within the ignite-core module which conflict > with other part of our code base. > > As these files are duplicated rather than being referenced as a maven > dependency I am unable to exclude them or reference a specific version of > the org.jetbrains.annotations artifact. > > Specifically, the included version cannot be used to annotate types > ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > ElementType.LOCAL_VARIABLE}) > annotations-15.0.jar:org.jetbrains.annotations.Nullable ... > @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) > > As far as I know there isn't an easy way of excluding these files from > within the ignite-core module. Is there are reason why these "external" > files have been duplicated within the ignite code base rather than being > referenced as a maven dependency? Or alternatively, has anyone come across > a way of avoiding these conflicts? > > Thanks > Pete > > > |
Re: Maven conflicts within ignite-core from duplicated classes
|
|
Why not just rename these classes?
On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov <[hidden email]> wrote: > As far as I know the only reason sources of Nullable are in Ignite - we > did not want to have any dependecy for 'core' module. > > On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda <[hidden email]> wrote: > >> Hi Pete, >> >> CC-ing Ignite dev list to the thread as well. >> >> Igniters, up to today is there any reason why we need to include sources >> of Nullable JetBrain’s annotation in Ignite sources? >> >> As I see we can rather import that latest version from the maven >> repository >> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 >> >> *Anton, *please take a look at Pete issue and suggest a workaround and >> generic solution overall. >> >> — >> Denis >> >> On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> wrote: >> >> Hello, >> >> I've come across an issue where there are a couple of classes duplicated >> from org.jetbrains.annotations within the ignite-core module which conflict >> with other part of our code base. >> >> As these files are duplicated rather than being referenced as a maven >> dependency I am unable to exclude them or reference a specific version of >> the org.jetbrains.annotations artifact. >> >> Specifically, the included version cannot be used to annotate types >> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, >> ElementType.LOCAL_VARIABLE}) >> annotations-15.0.jar:org.jetbrains.annotations.Nullable ... >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, >> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) >> >> As far as I know there isn't an easy way of excluding these files from >> within the ignite-core module. Is there are reason why these "external" >> files have been duplicated within the ignite code base rather than being >> referenced as a maven dependency? Or alternatively, has anyone come across >> a way of avoiding these conflicts? >> >> Thanks >> Pete >> >> >> > |
Re: Maven conflicts within ignite-core from duplicated classes
|
|
And why do we afraid this dependency? It has "CLASS" retention so users do
not need them in runtime, AFAIK. On Thu, Jun 16, 2016 at 11:19 AM, Vladislav Pyatkov <[hidden email]> wrote: > Why not just rename these classes? > > On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov <[hidden email]> > wrote: > > > As far as I know the only reason sources of Nullable are in Ignite - we > > did not want to have any dependecy for 'core' module. > > > > On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda <[hidden email]> > wrote: > > > >> Hi Pete, > >> > >> CC-ing Ignite dev list to the thread as well. > >> > >> Igniters, up to today is there any reason why we need to include sources > >> of Nullable JetBrain’s annotation in Ignite sources? > >> > >> As I see we can rather import that latest version from the maven > >> repository > >> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 > >> > >> *Anton, *please take a look at Pete issue and suggest a workaround and > >> generic solution overall. > >> > >> — > >> Denis > >> > >> On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> > wrote: > >> > >> Hello, > >> > >> I've come across an issue where there are a couple of classes duplicated > >> from org.jetbrains.annotations within the ignite-core module which > conflict > >> with other part of our code base. > >> > >> As these files are duplicated rather than being referenced as a maven > >> dependency I am unable to exclude them or reference a specific version > of > >> the org.jetbrains.annotations artifact. > >> > >> Specifically, the included version cannot be used to annotate types > >> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > >> ElementType.LOCAL_VARIABLE}) > >> annotations-15.0.jar:org.jetbrains.annotations.Nullable ... > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > >> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) > >> > >> As far as I know there isn't an easy way of excluding these files from > >> within the ignite-core module. Is there are reason why these "external" > >> files have been duplicated within the ignite code base rather than being > >> referenced as a maven dependency? Or alternatively, has anyone come > across > >> a way of avoiding these conflicts? > >> > >> Thanks > >> Pete > >> > >> > >> > > > |
Re: Maven conflicts within ignite-core from duplicated classes
|
|
We already have 2 dependencies at ignite-core:
*javax.cache.cache-api* and *org.gridgain.ignite-shmem* (ASAIK we have an issue to redeploy org.gridgain.ignite-shmem as org.apache.ignite.ignite-shmem) On Thu, Jun 16, 2016 at 11:57 AM, Vladimir Ozerov <[hidden email]> wrote: > And why do we afraid this dependency? It has "CLASS" retention so users do > not need them in runtime, AFAIK. > > On Thu, Jun 16, 2016 at 11:19 AM, Vladislav Pyatkov <[hidden email] > > > wrote: > > > Why not just rename these classes? > > > > On Thu, Jun 16, 2016 at 11:16 AM, Semyon Boikov <[hidden email]> > > wrote: > > > > > As far as I know the only reason sources of Nullable are in Ignite - we > > > did not want to have any dependecy for 'core' module. > > > > > > On Mon, Jun 13, 2016 at 10:04 AM, Denis Magda <[hidden email]> > > wrote: > > > > > >> Hi Pete, > > >> > > >> CC-ing Ignite dev list to the thread as well. > > >> > > >> Igniters, up to today is there any reason why we need to include > sources > > >> of Nullable JetBrain’s annotation in Ignite sources? > > >> > > >> As I see we can rather import that latest version from the maven > > >> repository > > >> https://maven-repository.com/artifact/org.jetbrains/annotations/15.0 > > >> > > >> *Anton, *please take a look at Pete issue and suggest a workaround and > > >> generic solution overall. > > >> > > >> — > > >> Denis > > >> > > >> On Jun 9, 2016, at 1:32 PM, Pete Campton <[hidden email]> > > wrote: > > >> > > >> Hello, > > >> > > >> I've come across an issue where there are a couple of classes > duplicated > > >> from org.jetbrains.annotations within the ignite-core module which > > conflict > > >> with other part of our code base. > > >> > > >> As these files are duplicated rather than being referenced as a maven > > >> dependency I am unable to exclude them or reference a specific version > > of > > >> the org.jetbrains.annotations artifact. > > >> > > >> Specifically, the included version cannot be used to annotate types > > >> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ... > > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > > >> ElementType.LOCAL_VARIABLE}) > > >> annotations-15.0.jar:org.jetbrains.annotations.Nullable ... > > >> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, > > >> ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE}) > > >> > > >> As far as I know there isn't an easy way of excluding these files from > > >> within the ignite-core module. Is there are reason why these > "external" > > >> files have been duplicated within the ignite code base rather than > being > > >> referenced as a maven dependency? Or alternatively, has anyone come > > across > > >> a way of avoiding these conflicts? > > >> > > >> Thanks > > >> Pete > > >> > > >> > > >> > > > > > > |
«
Return to Apache Ignite Developers - Legacy Mail Archive
|
1 view|%1 views
| Free forum by Nabble | Edit this page |