PHP thin client

[Alexey Kosenchuk]

Hi folks,

PHP thin client is ready for review.

Jira with the scope of work - [1].

Implementation, examples, tests:
   PR - [2],
   repository - [3].

API spec - [4].

Readme (how to for the client, instructions for the examples and tests,
etc.) - [5].

Regards,
-Alexey

[1] https://issues.apache.org/jira/browse/IGNITE-7783
[2] https://github.com/apache/ignite/pull/4649
[3]
https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
[4]
https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
[5]
https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md

[Igor Sapego-2]

Great,

I'll take a look

Best Regards,
Igor


On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
[hidden email]> wrote:

> Hi folks,
>
> PHP thin client is ready for review.
>
> Jira with the scope of work - [1].
>
> Implementation, examples, tests:
>    PR - [2],
>    repository - [3].
>
> API spec - [4].
>
> Readme (how to for the client, instructions for the examples and tests,
> etc.) - [5].
>
> Regards,
> -Alexey
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7783
> [2] https://github.com/apache/ignite/pull/4649
> [3]
> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
> [4]
>
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> [5]
>
> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>

[Igor Sapego-2]

Guys, I've reviewed the API (which looks good), run tests and examples and
here are my commments:

1. Main page for documentation is empty.

2. More output for Auth example is needed. This is not a test, after all,
but example.

3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
fail with the following message:
Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to parse
address "127.0.0.1" in
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
Stack trace:
#0
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
#1
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
#2
/home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
#3
/home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
Apache\Ignite\Tests\TestingHelper::init()
#4
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
#5
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#6
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#7
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
Array, true)
#8
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
PHPUnit\TextUI\Command->run(Array, true)
#9
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
PHPUnit\TextUI\Command::main()
#10 {main}

4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800,
they fail with the following message:
Apache\Ignite\Exception\OperationStatusUnknownException: Error while
reading data from the server in
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
Stack trace:
#0
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
4)
#1
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
#2
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
#3
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
Apache\Ignite\Internal\Connection\ClientSocket->connect()
#4
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
#5
/home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
#6
/home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
#7
/home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
Apache\Ignite\Tests\TestingHelper::init()
#8
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
#9
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#10
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#11
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
Array, true)
#12
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
PHPUnit\TextUI\Command->run(Array, true)
#13
/home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
PHPUnit\TextUI\Command::main()
#14 {main}
    Am I doing something wrong?

5. When "maven package" command is executed on Ignite, no php directory
appears
    in target/release-package-fabric/platforms directory. You need to edit
    ignite/assembly/release-fabric-base.xml file and add appropriate "copy"
commands.
    Search "cpp" or "dotnet" for example.

Best Regards,
Igor


On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]> wrote:

> Great,
>
> I'll take a look
>
> Best Regards,
> Igor
>
>
> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
> [hidden email]> wrote:
>
>> Hi folks,
>>
>> PHP thin client is ready for review.
>>
>> Jira with the scope of work - [1].
>>
>> Implementation, examples, tests:
>>    PR - [2],
>>    repository - [3].
>>
>> API spec - [4].
>>
>> Readme (how to for the client, instructions for the examples and tests,
>> etc.) - [5].
>>
>> Regards,
>> -Alexey
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
>> [2] https://github.com/apache/ignite/pull/4649
>> [3]
>> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
>> [4]
>>
>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>> [5]
>>
>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>>
>

[Igor Sapego-2]

By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
to be PhpUnit 7.3 (not sure here).

Best Regards,
Igor


On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <[hidden email]> wrote:

> Guys, I've reviewed the API (which looks good), run tests and examples and
> here are my commments:
>
> 1. Main page for documentation is empty.
>
> 2. More output for Auth example is needed. This is not a test, after all,
> but example.
>
> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
> fail with the following message:
> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to parse
> address "127.0.0.1" in
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
> Stack trace:
> #0
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> #1
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> #2
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> #3
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> Apache\Ignite\Tests\TestingHelper::init()
> #4
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> #5
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> #6
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> #7
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> Array, true)
> #8
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> PHPUnit\TextUI\Command->run(Array, true)
> #9
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> PHPUnit\TextUI\Command::main()
> #10 {main}
>
> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800,
> they fail with the following message:
> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
> reading data from the server in
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
> Stack trace:
> #0
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
> 4)
> #1
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
> #2
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
> #3
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
> Apache\Ignite\Internal\Connection\ClientSocket->connect()
> #4
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> #5
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> #6
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> #7
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> Apache\Ignite\Tests\TestingHelper::init()
> #8
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> #9
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> #10
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> #11
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> Array, true)
> #12
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> PHPUnit\TextUI\Command->run(Array, true)
> #13
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> PHPUnit\TextUI\Command::main()
> #14 {main}
>     Am I doing something wrong?
>
> 5. When "maven package" command is executed on Ignite, no php directory
> appears
>     in target/release-package-fabric/platforms directory. You need to edit
>     ignite/assembly/release-fabric-base.xml file and add appropriate
> "copy" commands.
>     Search "cpp" or "dotnet" for example.
>
> Best Regards,
> Igor
>
>
> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]> wrote:
>
>> Great,
>>
>> I'll take a look
>>
>> Best Regards,
>> Igor
>>
>>
>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
>> [hidden email]> wrote:
>>
>>> Hi folks,
>>>
>>> PHP thin client is ready for review.
>>>
>>> Jira with the scope of work - [1].
>>>
>>> Implementation, examples, tests:
>>>    PR - [2],
>>>    repository - [3].
>>>
>>> API spec - [4].
>>>
>>> Readme (how to for the client, instructions for the examples and tests,
>>> etc.) - [5].
>>>
>>> Regards,
>>> -Alexey
>>>
>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
>>> [2] https://github.com/apache/ignite/pull/4649
>>> [3]
>>>
>>> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
>>> [4]
>>>
>>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>> [5]
>>>
>>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>>>
>>

[Alexey Kosenchuk]

Hi Igor,

thanks for the review.

Pls see below...

 >> 1. Main page for documentation is empty.

What is the main page for documentation?

As wrote,
the auto-generated API spec is here:
https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html

All other docs are here:
https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
Going to be placed on readme.io by Prachi (thanks!)
https://issues.apache.org/jira/browse/IGNITE-9523

 >> 2. More output for Auth example is needed. This is not a test, after
all, but example.

Will add a log when a connection happens with the details of the
connection. Nothing else to output in this trivial example.
In fact, the real profit for a user here is the source code with an
example of TLS/auth cfg for the client.

 >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
they fail

Do you mean 10800 should be the default port when not specified by a user?
Will add.

 >> 4. If I try run test with
APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800, they fail

Double checked exactly in the same environment you have. It works.

Please try again.
Do you use a server with all default settings? Did not you try with the
server after the Auth example?
Do other examples work with the same server?
If you still see the problem with the tests, please send the server's
log to us. And/or switch the client's debug on - call setDebug(true) -
and share the client's output.

 >> 5. When "maven package" command is executed on Ignite, no php
directory appears

Need a help from experts / release engineer.

Thanks,
-Alexey

10.09.2018 15:34, Igor Sapego пишет:

> By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
> to be PhpUnit 7.3 (not sure here).
>
> Best Regards,
> Igor
>
>
> On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <[hidden email]> wrote:
>
>> Guys, I've reviewed the API (which looks good), run tests and examples and
>> here are my commments:
>>
>> 1. Main page for documentation is empty.
>>
>> 2. More output for Auth example is needed. This is not a test, after all,
>> but example.
>>
>> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
>> fail with the following message:
>> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to parse
>> address "127.0.0.1" in
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
>> Stack trace:
>> #0
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>> #1
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>> #2
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>> #3
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>> Apache\Ignite\Tests\TestingHelper::init()
>> #4
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>> #5
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>> #6
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>> #7
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>> Array, true)
>> #8
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>> PHPUnit\TextUI\Command->run(Array, true)
>> #9
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>> PHPUnit\TextUI\Command::main()
>> #10 {main}
>>
>> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800,
>> they fail with the following message:
>> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
>> reading data from the server in
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
>> Stack trace:
>> #0
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
>> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
>> 4)
>> #1
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
>> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
>> #2
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
>> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
>> #3
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
>> Apache\Ignite\Internal\Connection\ClientSocket->connect()
>> #4
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>> #5
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>> #6
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>> #7
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>> Apache\Ignite\Tests\TestingHelper::init()
>> #8
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>> #9
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>> #10
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>> #11
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>> Array, true)
>> #12
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>> PHPUnit\TextUI\Command->run(Array, true)
>> #13
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>> PHPUnit\TextUI\Command::main()
>> #14 {main}
>>      Am I doing something wrong?
>>
>> 5. When "maven package" command is executed on Ignite, no php directory
>> appears
>>      in target/release-package-fabric/platforms directory. You need to edit
>>      ignite/assembly/release-fabric-base.xml file and add appropriate
>> "copy" commands.
>>      Search "cpp" or "dotnet" for example.
>>
>> Best Regards,
>> Igor
>>
>>
>> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]> wrote:
>>
>>> Great,
>>>
>>> I'll take a look
>>>
>>> Best Regards,
>>> Igor
>>>
>>>
>>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
>>> [hidden email]> wrote:
>>>
>>>> Hi folks,
>>>>
>>>> PHP thin client is ready for review.
>>>>
>>>> Jira with the scope of work - [1].
>>>>
>>>> Implementation, examples, tests:
>>>>     PR - [2],
>>>>     repository - [3].
>>>>
>>>> API spec - [4].
>>>>
>>>> Readme (how to for the client, instructions for the examples and tests,
>>>> etc.) - [5].
>>>>
>>>> Regards,
>>>> -Alexey
>>>>
>>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
>>>> [2] https://github.com/apache/ignite/pull/4649
>>>> [3]
>>>>
>>>> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
>>>> [4]
>>>>
>>>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>>> [5]
>>>>
>>>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>>>>
>>>
>

[Igor Sapego-2]

1) I meant auto-generated doc, this page: [1]. By the way,
    many methods do not have any description as well.
2) You can, for example, print object as you generate and
    then get them from cache.
3) Yes, 10800 should be the default port.
4) You are right, I've just used server with SSL enabled.
    Everything works now.
5) Ok, can you just provide a list of directories/files, that
    should be copied to binary release?

[1] -
https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html

Best Regards,
Igor


On Tue, Sep 11, 2018 at 1:31 AM Alexey Kosenchuk <
[hidden email]> wrote:

> Hi Igor,
>
> thanks for the review.
>
> Pls see below...
>
>  >> 1. Main page for documentation is empty.
>
> What is the main page for documentation?
>
> As wrote,
> the auto-generated API spec is here:
>
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>
> All other docs are here:
>
> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
> Going to be placed on readme.io by Prachi (thanks!)
> https://issues.apache.org/jira/browse/IGNITE-9523
>
>  >> 2. More output for Auth example is needed. This is not a test, after
> all, but example.
>
> Will add a log when a connection happens with the details of the
> connection. Nothing else to output in this trivial example.
> In fact, the real profit for a user here is the source code with an
> example of TLS/auth cfg for the client.
>
>  >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
> they fail
>
> Do you mean 10800 should be the default port when not specified by a user?
> Will add.
>
>  >> 4. If I try run test with
> APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800, they fail
>
> Double checked exactly in the same environment you have. It works.
>
> Please try again.
> Do you use a server with all default settings? Did not you try with the
> server after the Auth example?
> Do other examples work with the same server?
> If you still see the problem with the tests, please send the server's
> log to us. And/or switch the client's debug on - call setDebug(true) -
> and share the client's output.
>
>  >> 5. When "maven package" command is executed on Ignite, no php
> directory appears
>
> Need a help from experts / release engineer.
>
> Thanks,
> -Alexey
>
> 10.09.2018 15:34, Igor Sapego пишет:
> > By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
> > to be PhpUnit 7.3 (not sure here).
> >
> > Best Regards,
> > Igor
> >
> >
> > On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <[hidden email]> wrote:
> >
> >> Guys, I've reviewed the API (which looks good), run tests and examples
> and
> >> here are my commments:
> >>
> >> 1. Main page for documentation is empty.
> >>
> >> 2. More output for Auth example is needed. This is not a test, after
> all,
> >> but example.
> >>
> >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
> >> fail with the following message:
> >> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to
> parse
> >> address "127.0.0.1" in
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
> >> Stack trace:
> >> #0
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> >> #1
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> >> #2
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> >> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> >> #3
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> >> Apache\Ignite\Tests\TestingHelper::init()
> >> #4
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> >> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> >> #5
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> >> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >> #6
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> >> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >> #7
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> >> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> >> Array, true)
> >> #8
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> >> PHPUnit\TextUI\Command->run(Array, true)
> >> #9
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> >> PHPUnit\TextUI\Command::main()
> >> #10 {main}
> >>
> >> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=
> 127.0.0.1:10800,
> >> they fail with the following message:
> >> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
> >> reading data from the server in
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
> >> Stack trace:
> >> #0
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
> >> 4)
> >> #1
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
> >> #2
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
> >> #3
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
> >> Apache\Ignite\Internal\Connection\ClientSocket->connect()
> >> #4
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> >> #5
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> >> #6
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> >> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> >> #7
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> >> Apache\Ignite\Tests\TestingHelper::init()
> >> #8
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> >> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> >> #9
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> >> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >> #10
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> >> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >> #11
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> >> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> >> Array, true)
> >> #12
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> >> PHPUnit\TextUI\Command->run(Array, true)
> >> #13
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> >> PHPUnit\TextUI\Command::main()
> >> #14 {main}
> >>      Am I doing something wrong?
> >>
> >> 5. When "maven package" command is executed on Ignite, no php directory
> >> appears
> >>      in target/release-package-fabric/platforms directory. You need to
> edit
> >>      ignite/assembly/release-fabric-base.xml file and add appropriate
> >> "copy" commands.
> >>      Search "cpp" or "dotnet" for example.
> >>
> >> Best Regards,
> >> Igor
> >>
> >>
> >> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]> wrote:
> >>
> >>> Great,
> >>>
> >>> I'll take a look
> >>>
> >>> Best Regards,
> >>> Igor
> >>>
> >>>
> >>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
> >>> [hidden email]> wrote:
> >>>
> >>>> Hi folks,
> >>>>
> >>>> PHP thin client is ready for review.
> >>>>
> >>>> Jira with the scope of work - [1].
> >>>>
> >>>> Implementation, examples, tests:
> >>>>     PR - [2],
> >>>>     repository - [3].
> >>>>
> >>>> API spec - [4].
> >>>>
> >>>> Readme (how to for the client, instructions for the examples and
> tests,
> >>>> etc.) - [5].
> >>>>
> >>>> Regards,
> >>>> -Alexey
> >>>>
> >>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
> >>>> [2] https://github.com/apache/ignite/pull/4649
> >>>> [3]
> >>>>
> >>>>
> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
> >>>> [4]
> >>>>
> >>>>
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> >>>> [5]
> >>>>
> >>>>
> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
> >>>>
> >>>
> >
>

[Alexey Kosenchuk]

11.09.2018 14:46, Igor Sapego пишет:
> 1) I meant auto-generated doc, this page: [1]. By the way,
>      many methods do not have any description as well.

Updated - introduction sentences placed on the main page of the
autogenerated API spec.
All public methods have description, except setters for cache
configuration which do not need it.

> 2) You can, for example, print object as you generate and
>      then get them from cache.

Done.

> 3) Yes, 10800 should be the default port.

Done.

All changes are in the updated PR.

> 4) You are right, I've just used server with SSL enabled.
>      Everything works now.

Good.

> 5) Ok, can you just provide a list of directories/files, that
>      should be copied to binary release?

ignite/modules/platforms/php/composer.json
ignite/modules/platforms/php/src
ignite/modules/platforms/php/examples

If cfg file to generate the API spec should be in the release
ignite/modules/platforms/php/api_docs/Doxyfile

If tests should be in the release
ignite/modules/platforms/php/tests

Regards,
-Alexey

>
> [1] -
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>
> Best Regards,
> Igor
>
>
> On Tue, Sep 11, 2018 at 1:31 AM Alexey Kosenchuk <
> [hidden email]> wrote:
>
>> Hi Igor,
>>
>> thanks for the review.
>>
>> Pls see below...
>>
>>   >> 1. Main page for documentation is empty.
>>
>> What is the main page for documentation?
>>
>> As wrote,
>> the auto-generated API spec is here:
>>
>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>
>> All other docs are here:
>>
>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>> Going to be placed on readme.io by Prachi (thanks!)
>> https://issues.apache.org/jira/browse/IGNITE-9523
>>
>>   >> 2. More output for Auth example is needed. This is not a test, after
>> all, but example.
>>
>> Will add a log when a connection happens with the details of the
>> connection. Nothing else to output in this trivial example.
>> In fact, the real profit for a user here is the source code with an
>> example of TLS/auth cfg for the client.
>>
>>   >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
>> they fail
>>
>> Do you mean 10800 should be the default port when not specified by a user?
>> Will add.
>>
>>   >> 4. If I try run test with
>> APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800, they fail
>>
>> Double checked exactly in the same environment you have. It works.
>>
>> Please try again.
>> Do you use a server with all default settings? Did not you try with the
>> server after the Auth example?
>> Do other examples work with the same server?
>> If you still see the problem with the tests, please send the server's
>> log to us. And/or switch the client's debug on - call setDebug(true) -
>> and share the client's output.
>>
>>   >> 5. When "maven package" command is executed on Ignite, no php
>> directory appears
>>
>> Need a help from experts / release engineer.
>>
>> Thanks,
>> -Alexey
>>
>> 10.09.2018 15:34, Igor Sapego пишет:
>>> By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
>>> to be PhpUnit 7.3 (not sure here).
>>>
>>> Best Regards,
>>> Igor
>>>
>>>
>>> On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <[hidden email]> wrote:
>>>
>>>> Guys, I've reviewed the API (which looks good), run tests and examples
>> and
>>>> here are my commments:
>>>>
>>>> 1. Main page for documentation is empty.
>>>>
>>>> 2. More output for Auth example is needed. This is not a test, after
>> all,
>>>> but example.
>>>>
>>>> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, they
>>>> fail with the following message:
>>>> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to
>> parse
>>>> address "127.0.0.1" in
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
>>>> Stack trace:
>>>> #0
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>>>> #1
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #2
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>>>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #3
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>>>> Apache\Ignite\Tests\TestingHelper::init()
>>>> #4
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>>>> #5
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #6
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #7
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>>>> Array, true)
>>>> #8
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>>>> PHPUnit\TextUI\Command->run(Array, true)
>>>> #9
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>>>> PHPUnit\TextUI\Command::main()
>>>> #10 {main}
>>>>
>>>> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=
>> 127.0.0.1:10800,
>>>> they fail with the following message:
>>>> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
>>>> reading data from the server in
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
>>>> Stack trace:
>>>> #0
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
>>>> 4)
>>>> #1
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
>>>> #2
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
>>>>
>> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
>>>> #3
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
>>>> Apache\Ignite\Internal\Connection\ClientSocket->connect()
>>>> #4
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
>>>> #5
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
>>>>
>> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #6
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
>>>> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
>>>> #7
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
>>>> Apache\Ignite\Tests\TestingHelper::init()
>>>> #8
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
>>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
>>>> #9
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #10
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
>>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
>>>> #11
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
>>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
>>>> Array, true)
>>>> #12
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
>>>> PHPUnit\TextUI\Command->run(Array, true)
>>>> #13
>>>>
>> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
>>>> PHPUnit\TextUI\Command::main()
>>>> #14 {main}
>>>>       Am I doing something wrong?
>>>>
>>>> 5. When "maven package" command is executed on Ignite, no php directory
>>>> appears
>>>>       in target/release-package-fabric/platforms directory. You need to
>> edit
>>>>       ignite/assembly/release-fabric-base.xml file and add appropriate
>>>> "copy" commands.
>>>>       Search "cpp" or "dotnet" for example.
>>>>
>>>> Best Regards,
>>>> Igor
>>>>
>>>>
>>>> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]> wrote:
>>>>
>>>>> Great,
>>>>>
>>>>> I'll take a look
>>>>>
>>>>> Best Regards,
>>>>> Igor
>>>>>
>>>>>
>>>>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
>>>>> [hidden email]> wrote:
>>>>>
>>>>>> Hi folks,
>>>>>>
>>>>>> PHP thin client is ready for review.
>>>>>>
>>>>>> Jira with the scope of work - [1].
>>>>>>
>>>>>> Implementation, examples, tests:
>>>>>>      PR - [2],
>>>>>>      repository - [3].
>>>>>>
>>>>>> API spec - [4].
>>>>>>
>>>>>> Readme (how to for the client, instructions for the examples and
>> tests,
>>>>>> etc.) - [5].
>>>>>>
>>>>>> Regards,
>>>>>> -Alexey
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
>>>>>> [2] https://github.com/apache/ignite/pull/4649
>>>>>> [3]
>>>>>>
>>>>>>
>> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
>>>>>> [4]
>>>>>>
>>>>>>
>> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
>>>>>> [5]
>>>>>>
>>>>>>
>> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
>>>>>>
>>>>>
>>>
>>
>

[Igor Sapego-2]

Good.

5) I've filed a separate ticket, so it can be taken by a someone,
    who is familiar with our build system: [1]

[1] - https://issues.apache.org/jira/browse/IGNITE-9465

Best Regards,
Igor


On Thu, Sep 13, 2018 at 5:07 PM Alexey Kosenchuk <
[hidden email]> wrote:

> 11.09.2018 14:46, Igor Sapego пишет:
> > 1) I meant auto-generated doc, this page: [1]. By the way,
> >      many methods do not have any description as well.
>
> Updated - introduction sentences placed on the main page of the
> autogenerated API spec.
> All public methods have description, except setters for cache
> configuration which do not need it.
>
> > 2) You can, for example, print object as you generate and
> >      then get them from cache.
>
> Done.
>
> > 3) Yes, 10800 should be the default port.
>
> Done.
>
> All changes are in the updated PR.
>
> > 4) You are right, I've just used server with SSL enabled.
> >      Everything works now.
>
> Good.
>
> > 5) Ok, can you just provide a list of directories/files, that
> >      should be copied to binary release?
>
> ignite/modules/platforms/php/composer.json
> ignite/modules/platforms/php/src
> ignite/modules/platforms/php/examples
>
> If cfg file to generate the API spec should be in the release
> ignite/modules/platforms/php/api_docs/Doxyfile
>
> If tests should be in the release
> ignite/modules/platforms/php/tests
>
> Regards,
> -Alexey
>
> >
> > [1] -
> >
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> >
> > Best Regards,
> > Igor
> >
> >
> > On Tue, Sep 11, 2018 at 1:31 AM Alexey Kosenchuk <
> > [hidden email]> wrote:
> >
> >> Hi Igor,
> >>
> >> thanks for the review.
> >>
> >> Pls see below...
> >>
> >>   >> 1. Main page for documentation is empty.
> >>
> >> What is the main page for documentation?
> >>
> >> As wrote,
> >> the auto-generated API spec is here:
> >>
> >>
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> >>
> >> All other docs are here:
> >>
> >>
> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
> >> Going to be placed on readme.io by Prachi (thanks!)
> >> https://issues.apache.org/jira/browse/IGNITE-9523
> >>
> >>   >> 2. More output for Auth example is needed. This is not a test,
> after
> >> all, but example.
> >>
> >> Will add a log when a connection happens with the details of the
> >> connection. Nothing else to output in this trivial example.
> >> In fact, the real profit for a user here is the source code with an
> >> example of TLS/auth cfg for the client.
> >>
> >>   >> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
> >> they fail
> >>
> >> Do you mean 10800 should be the default port when not specified by a
> user?
> >> Will add.
> >>
> >>   >> 4. If I try run test with
> >> APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1:10800, they fail
> >>
> >> Double checked exactly in the same environment you have. It works.
> >>
> >> Please try again.
> >> Do you use a server with all default settings? Did not you try with the
> >> server after the Auth example?
> >> Do other examples work with the same server?
> >> If you still see the problem with the tests, please send the server's
> >> log to us. And/or switch the client's debug on - call setDebug(true) -
> >> and share the client's output.
> >>
> >>   >> 5. When "maven package" command is executed on Ignite, no php
> >> directory appears
> >>
> >> Need a help from experts / release engineer.
> >>
> >> Thanks,
> >> -Alexey
> >>
> >> 10.09.2018 15:34, Igor Sapego пишет:
> >>> By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems
> >>> to be PhpUnit 7.3 (not sure here).
> >>>
> >>> Best Regards,
> >>> Igor
> >>>
> >>>
> >>> On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego <[hidden email]>
> wrote:
> >>>
> >>>> Guys, I've reviewed the API (which looks good), run tests and examples
> >> and
> >>>> here are my commments:
> >>>>
> >>>> 1. Main page for documentation is empty.
> >>>>
> >>>> 2. More output for Auth example is needed. This is not a test, after
> >> all,
> >>>> but example.
> >>>>
> >>>> 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1,
> they
> >>>> fail with the following message:
> >>>> Apache\Ignite\Exception\NoConnectionException: [127.0.0.1] Failed to
> >> parse
> >>>> address "127.0.0.1" in
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php:107
> >>>> Stack trace:
> >>>> #0
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> >>>> #1
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> >>>> #2
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> >>>>
> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> >>>> #3
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> >>>> Apache\Ignite\Tests\TestingHelper::init()
> >>>> #4
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> >>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> >>>> #5
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> >>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >>>> #6
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> >>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >>>> #7
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> >>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> >>>> Array, true)
> >>>> #8
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> >>>> PHPUnit\TextUI\Command->run(Array, true)
> >>>> #9
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> >>>> PHPUnit\TextUI\Command::main()
> >>>> #10 {main}
> >>>>
> >>>> 4. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=
> >> 127.0.0.1:10800,
> >>>> they fail with the following message:
> >>>> Apache\Ignite\Exception\OperationStatusUnknownException: Error while
> >>>> reading data from the server in
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php:168
> >>>> Stack trace:
> >>>> #0
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(178):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->receive(Object(Apache\Ignite\Internal\Binary\MessageBuffer),
> >>>> 4)
> >>>> #1
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(159):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->processResponse(Object(Apache\Ignite\Internal\Binary\Request))
> >>>> #2
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientSocket.php(107):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientSocket->processRequest(Object(Apache\Ignite\Internal\Binary\Request))
> >>>> #3
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(96):
> >>>> Apache\Ignite\Internal\Connection\ClientSocket->connect()
> >>>> #4
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Internal/Connection/ClientFailoverSocket.php(54):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->failoverConnect()
> >>>> #5
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/src/Apache/Ignite/Client.php(61):
> >>>>
> >>
> Apache\Ignite\Internal\Connection\ClientFailoverSocket->connect(Object(Apache\Ignite\ClientConfiguration))
> >>>> #6
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/TestingHelper.php(52):
> >>>>
> Apache\Ignite\Client->connect(Object(Apache\Ignite\ClientConfiguration))
> >>>> #7
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/tests/SqlQueryTest.php(49):
> >>>> Apache\Ignite\Tests\TestingHelper::init()
> >>>> #8
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(703):
> >>>> Apache\Ignite\Tests\SqlQueryTestCase::setUpBeforeClass()
> >>>> #9
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/Framework/TestSuite.php(750):
> >>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >>>> #10
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(587):
> >>>> PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
> >>>> #11
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(203):
> >>>> PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite),
> >>>> Array, true)
> >>>> #12
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/src/TextUI/Command.php(159):
> >>>> PHPUnit\TextUI\Command->run(Array, true)
> >>>> #13
> >>>>
> >>
> /home/isapego/work/ignite/modules/platforms/php/vendor/phpunit/phpunit/phpunit(53):
> >>>> PHPUnit\TextUI\Command::main()
> >>>> #14 {main}
> >>>>       Am I doing something wrong?
> >>>>
> >>>> 5. When "maven package" command is executed on Ignite, no php
> directory
> >>>> appears
> >>>>       in target/release-package-fabric/platforms directory. You need
> to
> >> edit
> >>>>       ignite/assembly/release-fabric-base.xml file and add appropriate
> >>>> "copy" commands.
> >>>>       Search "cpp" or "dotnet" for example.
> >>>>
> >>>> Best Regards,
> >>>> Igor
> >>>>
> >>>>
> >>>> On Tue, Sep 4, 2018 at 3:21 PM Igor Sapego <[hidden email]>
> wrote:
> >>>>
> >>>>> Great,
> >>>>>
> >>>>> I'll take a look
> >>>>>
> >>>>> Best Regards,
> >>>>> Igor
> >>>>>
> >>>>>
> >>>>> On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk <
> >>>>> [hidden email]> wrote:
> >>>>>
> >>>>>> Hi folks,
> >>>>>>
> >>>>>> PHP thin client is ready for review.
> >>>>>>
> >>>>>> Jira with the scope of work - [1].
> >>>>>>
> >>>>>> Implementation, examples, tests:
> >>>>>>      PR - [2],
> >>>>>>      repository - [3].
> >>>>>>
> >>>>>> API spec - [4].
> >>>>>>
> >>>>>> Readme (how to for the client, instructions for the examples and
> >> tests,
> >>>>>> etc.) - [5].
> >>>>>>
> >>>>>> Regards,
> >>>>>> -Alexey
> >>>>>>
> >>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-7783
> >>>>>> [2] https://github.com/apache/ignite/pull/4649
> >>>>>> [3]
> >>>>>>
> >>>>>>
> >>
> https://github.com/nobitlost/ignite/tree/ignite-7783/modules/platforms/php
> >>>>>> [4]
> >>>>>>
> >>>>>>
> >>
> https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html
> >>>>>> [5]
> >>>>>>
> >>>>>>
> >>
> https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md
> >>>>>>
> >>>>>
> >>>
> >>
> >
>

[Stepan Pilshchikov]

Sorry for interruption but im also review this feature and have couple
questions about documentation

1. Why exists second branches with all documentation? I mean they looks good
together, why need to separate?
Also, one place when i found this branch it is this thread, not in jira, not
in a github
2. Examples in readme.md have better look in php/examples. I mean
php/examples have one set of examples and readme have second one, they not
match and they both looks good. Why doesn't add readme examples in
php/examples?



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[Alexey Kosenchuk]

Hi Stepan,

> 1. Why exists second branches with all documentation? I mean they looks good
> together, why need to separate?

Because finally the docs should not be in the repo (unfortunately) but
on readme.io.
There is a task for that: https://issues.apache.org/jira/browse/IGNITE-9523

> Also, one place when i found this branch it is this thread, not in jira, not
> in a github

Added the link in the jira.

> 2. Examples in readme.md have better look in php/examples. I mean
> php/examples have one set of examples and readme have second one, they not
> match and they both looks good. Why doesn't add readme examples in
> php/examples?

Examples in readme.md are more like code snippets (mostly not big)
intended to help better understanding the usage of the client along the
reading.
Examples in php/examples are more meaningful and fully cover the
examples in readme.md.

Thanks,
-Alexey

[Stepan Pilshchikov]

> 1. Because finally the docs should not be in the repo (unfortunately) but
> on readme.io.
> There is a task for that:
> https://issues.apache.org/jira/browse/IGNITE-9523
> Added the link in the jira.

Ok

> 2. Examples in readme.md are more like code snippets (mostly not big)
> intended to help better understanding the usage of the client along the
> reading.
> Examples in php/examples are more meaningful and fully cover the
> examples in readme.md.

Oh, now i get it
But now in PR we have no readme at all
Agree with examples on readme.io, but other information (how to install, how
to configurate, install from sources, basic description) may be in sources,
it help a lot
Or it also should be on readme.io?

This question because in other platforms have readme exist and they have
this basic information in it



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[Alexey Kosenchuk]

> But now in PR we have no readme at all
> Agree with examples on readme.io, but other information (how to install, how
> to configurate, install from sources, basic description) may be in sources,
> it help a lot
> Or it also should be on readme.io?
>
> This question because in other platforms have readme exist and they have
> this basic information in it

You know, I'm confused with all this documentation stuff...
For nodejs client all docs were moved from the repo to readme.io but the
readme.md keeps the installation instructions (duplicated with
readme.io). Probably, that's ok.
Will add similar short readme.md to the PHP PR.

Thanks,
-Alexey

[Stepan Pilshchikov]

> You know, I'm confused with all this documentation stuff...
> For nodejs client all docs were moved from the repo to readme.io but the
> readme.md keeps the installation instructions (duplicated with
> readme.io). Probably, that's ok.
> Will add similar short readme.md to the PHP PR.

Its good

What i think (and how it partially now):
All user documentation should be on readme.io (how to install, use it,
configurate, description for examples)
All developers documentation (how to release, how to start develop) and(!)
basic description should be in repository




--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[Prachi Garg]

Hi Stephan, Alexey

That's exactly what readme.io contains - installation instructions,
configuration, and examples for key-value, sql, etc. for thin clients. For
example, see these documentation pages for Node.js (currently hidden in the
latest version of the doc) :

https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security

This how Python and PHP thin clients will also be documented on readme.io

-Prachi




On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
[hidden email]> wrote:

> > You know, I'm confused with all this documentation stuff...
> > For nodejs client all docs were moved from the repo to readme.io but
> the
> > readme.md keeps the installation instructions (duplicated with
> > readme.io). Probably, that's ok.
> > Will add similar short readme.md to the PHP PR.
>
> Its good
>
> What i think (and how it partially now):
> All user documentation should be on readme.io (how to install, use it,
> configurate, description for examples)
> All developers documentation (how to release, how to start develop) and(!)
> basic description should be in repository
>
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>

[Igor Sapego-2]

As the seem to be everything OK with the code and tests and
no one had any comment for quite some time, I've merged the
PHP to Ignite's master.

Great job, guys!


Best Regards,
Igor


On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]> wrote:

> Hi Stephan, Alexey
>
> That's exactly what readme.io contains - installation instructions,
> configuration, and examples for key-value, sql, etc. for thin clients. For
> example, see these documentation pages for Node.js (currently hidden in the
> latest version of the doc) :
>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>
> This how Python and PHP thin clients will also be documented on readme.io
>
> -Prachi
>
>
>
>
> On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> [hidden email]> wrote:
>
> > > You know, I'm confused with all this documentation stuff...
> > > For nodejs client all docs were moved from the repo to readme.io but
> > the
> > > readme.md keeps the installation instructions (duplicated with
> > > readme.io). Probably, that's ok.
> > > Will add similar short readme.md to the PHP PR.
> >
> > Its good
> >
> > What i think (and how it partially now):
> > All user documentation should be on readme.io (how to install, use it,
> > configurate, description for examples)
> > All developers documentation (how to release, how to start develop)
> and(!)
> > basic description should be in repository
> >
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

[daradurvs]

Great work guys, thanks!

I've noticed TC fails in the build plan "Licenses Headers" which Igor
have fixed already by excluding Doxyfile from checking.

I've filled a ticket [1] and I'd suggest fixing the test in another
way by adding the license header to Doxyfile.

Igor, please, have a look at prepared PR [2] (tests passed [3]).

[1] https://issues.apache.org/jira/browse/IGNITE-9832
[2] https://github.com/apache/ignite/pull/4938/files
[3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <[hidden email]> wrote:

>
> As the seem to be everything OK with the code and tests and
> no one had any comment for quite some time, I've merged the
> PHP to Ignite's master.
>
> Great job, guys!
>
>
> Best Regards,
> Igor
>
>
> On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]> wrote:
>
> > Hi Stephan, Alexey
> >
> > That's exactly what readme.io contains - installation instructions,
> > configuration, and examples for key-value, sql, etc. for thin clients. For
> > example, see these documentation pages for Node.js (currently hidden in the
> > latest version of the doc) :
> >
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> >
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> >
> > This how Python and PHP thin clients will also be documented on readme.io
> >
> > -Prachi
> >
> >
> >
> >
> > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> > [hidden email]> wrote:
> >
> > > > You know, I'm confused with all this documentation stuff...
> > > > For nodejs client all docs were moved from the repo to readme.io but
> > > the
> > > > readme.md keeps the installation instructions (duplicated with
> > > > readme.io). Probably, that's ok.
> > > > Will add similar short readme.md to the PHP PR.
> > >
> > > Its good
> > >
> > > What i think (and how it partially now):
> > > All user documentation should be on readme.io (how to install, use it,
> > > configurate, description for examples)
> > > All developers documentation (how to release, how to start develop)
> > and(!)
> > > basic description should be in repository
> > >
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> >

--
Best Regards, Vyacheslav D.

[Igor Sapego-2]

Vyacheslav,

In this case, we should do the same with all existing doxygen
files, not only this one (see files with .dxg extension)

Vova, Pavel,

Were there historically any reasons to exclude doxygen files
from check instead of adding a license header?

Best Regards,
Igor


On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <[hidden email]>
wrote:

> Great work guys, thanks!
>
> I've noticed TC fails in the build plan "Licenses Headers" which Igor
> have fixed already by excluding Doxyfile from checking.
>
> I've filled a ticket [1] and I'd suggest fixing the test in another
> way by adding the license header to Doxyfile.
>
> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9832
> [2] https://github.com/apache/ignite/pull/4938/files
> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <[hidden email]> wrote:
> >
> > As the seem to be everything OK with the code and tests and
> > no one had any comment for quite some time, I've merged the
> > PHP to Ignite's master.
> >
> > Great job, guys!
> >
> >
> > Best Regards,
> > Igor
> >
> >
> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]> wrote:
> >
> > > Hi Stephan, Alexey
> > >
> > > That's exactly what readme.io contains - installation instructions,
> > > configuration, and examples for key-value, sql, etc. for thin clients.
> For
> > > example, see these documentation pages for Node.js (currently hidden
> in the
> > > latest version of the doc) :
> > >
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> > >
> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> > >
> > > This how Python and PHP thin clients will also be documented on
> readme.io
> > >
> > > -Prachi
> > >
> > >
> > >
> > >
> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> > > [hidden email]> wrote:
> > >
> > > > > You know, I'm confused with all this documentation stuff...
> > > > > For nodejs client all docs were moved from the repo to readme.io
> but
> > > > the
> > > > > readme.md keeps the installation instructions (duplicated with
> > > > > readme.io). Probably, that's ok.
> > > > > Will add similar short readme.md to the PHP PR.
> > > >
> > > > Its good
> > > >
> > > > What i think (and how it partially now):
> > > > All user documentation should be on readme.io (how to install, use
> it,
> > > > configurate, description for examples)
> > > > All developers documentation (how to release, how to start develop)
> > > and(!)
> > > > basic description should be in repository
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > > >
> > >
>
>
>
> --
> Best Regards, Vyacheslav D.
>

[Vladimir Ozerov]

I am not sure there is an answer. This is just how we handled it before.
IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
several hours ago.

On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <[hidden email]> wrote:

> Vyacheslav,
>
> In this case, we should do the same with all existing doxygen
> files, not only this one (see files with .dxg extension)
>
> Vova, Pavel,
>
> Were there historically any reasons to exclude doxygen files
> from check instead of adding a license header?
>
> Best Regards,
> Igor
>
>
> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <[hidden email]>
> wrote:
>
>> Great work guys, thanks!
>>
>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
>> have fixed already by excluding Doxyfile from checking.
>>
>> I've filled a ticket [1] and I'd suggest fixing the test in another
>> way by adding the license header to Doxyfile.
>>
>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>> [2] https://github.com/apache/ignite/pull/4938/files
>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <[hidden email]> wrote:
>> >
>> > As the seem to be everything OK with the code and tests and
>> > no one had any comment for quite some time, I've merged the
>> > PHP to Ignite's master.
>> >
>> > Great job, guys!
>> >
>> >
>> > Best Regards,
>> > Igor
>> >
>> >
>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]> wrote:
>> >
>> > > Hi Stephan, Alexey
>> > >
>> > > That's exactly what readme.io contains - installation instructions,
>> > > configuration, and examples for key-value, sql, etc. for thin
>> clients. For
>> > > example, see these documentation pages for Node.js (currently hidden
>> in the
>> > > latest version of the doc) :
>> > >
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>> > >
>> > >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>> > >
>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>> > >
>> > > This how Python and PHP thin clients will also be documented on
>> readme.io
>> > >
>> > > -Prachi
>> > >
>> > >
>> > >
>> > >
>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>> > > [hidden email]> wrote:
>> > >
>> > > > > You know, I'm confused with all this documentation stuff...
>> > > > > For nodejs client all docs were moved from the repo to readme.io
>> but
>> > > > the
>> > > > > readme.md keeps the installation instructions (duplicated with
>> > > > > readme.io). Probably, that's ok.
>> > > > > Will add similar short readme.md to the PHP PR.
>> > > >
>> > > > Its good
>> > > >
>> > > > What i think (and how it partially now):
>> > > > All user documentation should be on readme.io (how to install, use
>> it,
>> > > > configurate, description for examples)
>> > > > All developers documentation (how to release, how to start develop)
>> > > and(!)
>> > > > basic description should be in repository
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>> > > >
>> > >
>>
>>
>>
>> --
>> Best Regards, Vyacheslav D.
>>
>

[Igor Sapego-2]

Alexey,

Since PHP thin client is now in master, can you please add it to our
"Thin clients features" wiki page, so we can track the feature parity
of our clients?

[1] -
https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features

Best Regards,
Igor


On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <[hidden email]>
wrote:

> I am not sure there is an answer. This is just how we handled it before.
> IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
> several hours ago.
>
> On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <[hidden email]> wrote:
>
>> Vyacheslav,
>>
>> In this case, we should do the same with all existing doxygen
>> files, not only this one (see files with .dxg extension)
>>
>> Vova, Pavel,
>>
>> Were there historically any reasons to exclude doxygen files
>> from check instead of adding a license header?
>>
>> Best Regards,
>> Igor
>>
>>
>> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <[hidden email]>
>> wrote:
>>
>>> Great work guys, thanks!
>>>
>>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
>>> have fixed already by excluding Doxyfile from checking.
>>>
>>> I've filled a ticket [1] and I'd suggest fixing the test in another
>>> way by adding the license header to Doxyfile.
>>>
>>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
>>>
>>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
>>> [2] https://github.com/apache/ignite/pull/4938/files
>>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
>>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <[hidden email]> wrote:
>>> >
>>> > As the seem to be everything OK with the code and tests and
>>> > no one had any comment for quite some time, I've merged the
>>> > PHP to Ignite's master.
>>> >
>>> > Great job, guys!
>>> >
>>> >
>>> > Best Regards,
>>> > Igor
>>> >
>>> >
>>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]>
>>> wrote:
>>> >
>>> > > Hi Stephan, Alexey
>>> > >
>>> > > That's exactly what readme.io contains - installation instructions,
>>> > > configuration, and examples for key-value, sql, etc. for thin
>>> clients. For
>>> > > example, see these documentation pages for Node.js (currently hidden
>>> in the
>>> > > latest version of the doc) :
>>> > >
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
>>> > >
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
>>> > >
>>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
>>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
>>> > >
>>> > > This how Python and PHP thin clients will also be documented on
>>> readme.io
>>> > >
>>> > > -Prachi
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
>>> > > [hidden email]> wrote:
>>> > >
>>> > > > > You know, I'm confused with all this documentation stuff...
>>> > > > > For nodejs client all docs were moved from the repo to readme.io
>>> but
>>> > > > the
>>> > > > > readme.md keeps the installation instructions (duplicated with
>>> > > > > readme.io). Probably, that's ok.
>>> > > > > Will add similar short readme.md to the PHP PR.
>>> > > >
>>> > > > Its good
>>> > > >
>>> > > > What i think (and how it partially now):
>>> > > > All user documentation should be on readme.io (how to install,
>>> use it,
>>> > > > configurate, description for examples)
>>> > > > All developers documentation (how to release, how to start develop)
>>> > > and(!)
>>> > > > basic description should be in repository
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>>> > > >
>>> > >
>>>
>>>
>>>
>>> --
>>> Best Regards, Vyacheslav D.
>>>
>>

[Stepan Pilshchikov]

Alexey,

Hi

I'm trying to use PHP client for some times and discover one problem with
DATA and TIMESTAMP data types
I'ts appear when you trying to use DATA or TIMESTAMP as cache key

All description in ticket:
https://issues.apache.org/jira/browse/IGNITE-9951

Can you help with that, please?

чт, 11 окт. 2018 г. в 16:02, Igor Sapego <[hidden email]>:

> Alexey,
>
> Since PHP thin client is now in master, can you please add it to our
> "Thin clients features" wiki page, so we can track the feature parity
> of our clients?
>
> [1] -
> https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features
>
> Best Regards,
> Igor
>
>
> On Wed, Oct 10, 2018 at 2:56 PM Vladimir Ozerov <[hidden email]>
> wrote:
>
> > I am not sure there is an answer. This is just how we handled it before.
> > IMO both approaches works fine. BTW, I already merged Vyacheslav's PR
> > several hours ago.
> >
> > On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <[hidden email]> wrote:
> >
> >> Vyacheslav,
> >>
> >> In this case, we should do the same with all existing doxygen
> >> files, not only this one (see files with .dxg extension)
> >>
> >> Vova, Pavel,
> >>
> >> Were there historically any reasons to exclude doxygen files
> >> from check instead of adding a license header?
> >>
> >> Best Regards,
> >> Igor
> >>
> >>
> >> On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <[hidden email]
> >
> >> wrote:
> >>
> >>> Great work guys, thanks!
> >>>
> >>> I've noticed TC fails in the build plan "Licenses Headers" which Igor
> >>> have fixed already by excluding Doxyfile from checking.
> >>>
> >>> I've filled a ticket [1] and I'd suggest fixing the test in another
> >>> way by adding the license header to Doxyfile.
> >>>
> >>> Igor, please, have a look at prepared PR [2] (tests passed [3]).
> >>>
> >>> [1] https://issues.apache.org/jira/browse/IGNITE-9832
> >>> [2] https://github.com/apache/ignite/pull/4938/files
> >>> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206
> >>> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <[hidden email]> wrote:
> >>> >
> >>> > As the seem to be everything OK with the code and tests and
> >>> > no one had any comment for quite some time, I've merged the
> >>> > PHP to Ignite's master.
> >>> >
> >>> > Great job, guys!
> >>> >
> >>> >
> >>> > Best Regards,
> >>> > Igor
> >>> >
> >>> >
> >>> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <[hidden email]>
> >>> wrote:
> >>> >
> >>> > > Hi Stephan, Alexey
> >>> > >
> >>> > > That's exactly what readme.io contains - installation
> instructions,
> >>> > > configuration, and examples for key-value, sql, etc. for thin
> >>> clients. For
> >>> > > example, see these documentation pages for Node.js (currently
> hidden
> >>> in the
> >>> > > latest version of the doc) :
> >>> > >
> >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client
> >>> > >
> >>> > >
> >>>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration
> >>> > >
> >>> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value
> >>> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql
> >>> > >
> >>>
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types
> >>> > >
> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security
> >>> > >
> >>> > > This how Python and PHP thin clients will also be documented on
> >>> readme.io
> >>> > >
> >>> > > -Prachi
> >>> > >
> >>> > >
> >>> > >
> >>> > >
> >>> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov <
> >>> > > [hidden email]> wrote:
> >>> > >
> >>> > > > > You know, I'm confused with all this documentation stuff...
> >>> > > > > For nodejs client all docs were moved from the repo to
> readme.io
> >>> but
> >>> > > > the
> >>> > > > > readme.md keeps the installation instructions (duplicated with
> >>> > > > > readme.io). Probably, that's ok.
> >>> > > > > Will add similar short readme.md to the PHP PR.
> >>> > > >
> >>> > > > Its good
> >>> > > >
> >>> > > > What i think (and how it partially now):
> >>> > > > All user documentation should be on readme.io (how to install,
> >>> use it,
> >>> > > > configurate, description for examples)
> >>> > > > All developers documentation (how to release, how to start
> develop)
> >>> > > and(!)
> >>> > > > basic description should be in repository
> >>> > > >
> >>> > > >
> >>> > > >
> >>> > > >
> >>> > > > --
> >>> > > > Sent from:
> http://apache-ignite-developers.2346864.n4.nabble.com/
> >>> > > >
> >>> > >
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards, Vyacheslav D.
> >>>
> >>
>