Apache Ignite Developers - Legacy Mail Archive

Migration of spring-data modules to ignite-extensions

Classic

List

Threaded

15 messages Options

Mikhail Petrov

Migration of spring-data modules to ignite-extensions

Igniters,

I propose to migrate spring-data modules from ignite main repository to
ignite-extensions.

Are there any objections?

I've created ticket [1] and PR to both ignite [2] and ignite-extensions
[3] repositories.

[1] - https://issues.apache.org/jira/browse/IGNITE-13559

[2] - https://github.com/apache/ignite/pull/8334

[3] - https://github.com/apache/ignite-extensions/pull/25

Nikita Amelchev

Re: Migration of spring-data modules to ignite-extensions

Mikhail,

+1 for migrate

чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:

>
> Igniters,
>
> I propose to migrate spring-data modules from ignite main repository to
> ignite-extensions.
>
>
> Are there any objections?
>
>
> I've created ticket [1] and PR to both ignite [2] and ignite-extensions
> [3] repositories.
>
>
> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>
> [2] - https://github.com/apache/ignite/pull/8334
>
> [3] - https://github.com/apache/ignite-extensions/pull/25
>

--
Best wishes,
Amelchev Nikita

Nikolay Izhikov-2

Re: Migration of spring-data modules to ignite-extensions

+1.

Saikat, can you, please, take a look?

> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]> написал(а):
>
> Mikhail,
>
> +1 for migrate
>
> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
>>
>> Igniters,
>>
>> I propose to migrate spring-data modules from ignite main repository to
>> ignite-extensions.
>>
>>
>> Are there any objections?
>>
>>
>> I've created ticket [1] and PR to both ignite [2] and ignite-extensions
>> [3] repositories.
>>
>>
>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>>
>> [2] - https://github.com/apache/ignite/pull/8334
>>
>> [3] - https://github.com/apache/ignite-extensions/pull/25
>>
>
>
> --
> Best wishes,
> Amelchev Nikita

Ilya Kasnacheev

Re: Migration of spring-data modules to ignite-extensions

Hello!

-1 from me for now.

"Since Spring Data integration is actively used (compared to most others),
I would argue that it should only moved to extensions last, when this
process is debugged thoroughly and when we have at least one "essentials +
extensions" release shipped with feedback.

I think such release would be 2.9, so I think we should only move Spring
Data to extensions after 2.9 is released and feedback from this release is
processed."

Regards,
--
Ilya Kasnacheev

пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:

> +1.
>
> Saikat, can you, please, take a look?
>
> > 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
> написал(а):
> >
> > Mikhail,
> >
> > +1 for migrate
> >
> > чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
> >>
> >> Igniters,
> >>
> >> I propose to migrate spring-data modules from ignite main repository to
> >> ignite-extensions.
> >>
> >>
> >> Are there any objections?
> >>
> >>
> >> I've created ticket [1] and PR to both ignite [2] and ignite-extensions
> >> [3] repositories.
> >>
> >>
> >> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
> >>
> >> [2] - https://github.com/apache/ignite/pull/8334
> >>
> >> [3] - https://github.com/apache/ignite-extensions/pull/25
> >>
> >
> >
> > --
> > Best wishes,
> > Amelchev Nikita
>
>

Nikolay Izhikov-2

Re: Migration of spring-data modules to ignite-extensions

Ilya, we should move modules that is not related to Ignite core to extension.
We shouldn’t support all possible integrations in the Ignite itself.

> I would argue that it should only moved to extensions last,
> when this process is debugged thoroughly and when we have at least one "essentials + extensions" release shipped with feedback.

Each extension should be released separately.
What is «essentials + extensions» release do you have in mind?

Moreover, ignite-spring-data release is not related to any Ignite releases.
Why do we have to wait Ignite release to get spring-data fixes or updates?

> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]> написал(а):
>
> Hello!
>
> -1 from me for now.
>
> "Since Spring Data integration is actively used (compared to most others),
> I would argue that it should only moved to extensions last, when this
> process is debugged thoroughly and when we have at least one "essentials +
> extensions" release shipped with feedback.
>
> I think such release would be 2.9, so I think we should only move Spring
> Data to extensions after 2.9 is released and feedback from this release is
> processed."
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
>
>> +1.
>>
>> Saikat, can you, please, take a look?
>>
>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
>> написал(а):
>>>
>>> Mikhail,
>>>
>>> +1 for migrate
>>>
>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
>>>>
>>>> Igniters,
>>>>
>>>> I propose to migrate spring-data modules from ignite main repository to
>>>> ignite-extensions.
>>>>
>>>>
>>>> Are there any objections?
>>>>
>>>>
>>>> I've created ticket [1] and PR to both ignite [2] and ignite-extensions
>>>> [3] repositories.
>>>>
>>>>
>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>>>>
>>>> [2] - https://github.com/apache/ignite/pull/8334
>>>>
>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
>>>>
>>>
>>>
>>> --
>>> Best wishes,
>>> Amelchev Nikita
>>
>>

Данилов Семён

Re: Migration of spring-data modules to ignite-extensions

+1
And, as a matter of fact, I think that spring data integration should be in spring-projects organization, just like spring-data-neo4j, spring-data-mongodb and the others. This way we will always have spring-data integration working correctly with the latest version of spring-data.

09.10.2020, 12:42, "Nikolay Izhikov" <[hidden email]>:

> Ilya, we should move modules that is not related to Ignite core to extension.
> We shouldn’t support all possible integrations in the Ignite itself.
>
>> I would argue that it should only moved to extensions last,
>> when this process is debugged thoroughly and when we have at least one "essentials + extensions" release shipped with feedback.
>
> Each extension should be released separately.
> What is «essentials + extensions» release do you have in mind?
>
> Moreover, ignite-spring-data release is not related to any Ignite releases.
> Why do we have to wait Ignite release to get spring-data fixes or updates?
>
>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]> написал(а):
>>
>> Hello!
>>
>> -1 from me for now.
>>
>> "Since Spring Data integration is actively used (compared to most others),
>> I would argue that it should only moved to extensions last, when this
>> process is debugged thoroughly and when we have at least one "essentials +
>> extensions" release shipped with feedback.
>>
>> I think such release would be 2.9, so I think we should only move Spring
>> Data to extensions after 2.9 is released and feedback from this release is
>> processed."
>>
>> Regards,
>> --
>> Ilya Kasnacheev
>>
>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
>>
>>> +1.
>>>
>>> Saikat, can you, please, take a look?
>>>
>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
>>> написал(а):
>>>> Mikhail,
>>>>
>>>> +1 for migrate
>>>>
>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
>>>>> Igniters,
>>>>>
>>>>> I propose to migrate spring-data modules from ignite main repository to
>>>>> ignite-extensions.
>>>>>
>>>>> Are there any objections?
>>>>>
>>>>> I've created ticket [1] and PR to both ignite [2] and ignite-extensions
>>>>> [3] repositories.
>>>>>
>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>>>>>
>>>>> [2] - https://github.com/apache/ignite/pull/8334
>>>>>
>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
>>>>
>>>> --
>>>> Best wishes,
>>>> Amelchev Nikita

Ilya Kasnacheev

Re: Migration of spring-data modules to ignite-extensions

In reply to this post by Nikolay Izhikov-2

Hello!

I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
Once we get that in the wild and gather a few months of feedback (or lack
thereof) then we can go on with it.

Regards,
--
Ilya Kasnacheev

пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:

> Ilya, we should move modules that is not related to Ignite core to
> extension.
> We shouldn’t support all possible integrations in the Ignite itself.
>
> > I would argue that it should only moved to extensions last,
> > when this process is debugged thoroughly and when we have at least one
> "essentials + extensions" release shipped with feedback.
>
> Each extension should be released separately.
> What is «essentials + extensions» release do you have in mind?
>
>
> Moreover, ignite-spring-data release is not related to any Ignite releases.
> Why do we have to wait Ignite release to get spring-data fixes or updates?
>
> > 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]>
> написал(а):
> >
> > Hello!
> >
> > -1 from me for now.
> >
> > "Since Spring Data integration is actively used (compared to most
> others),
> > I would argue that it should only moved to extensions last, when this
> > process is debugged thoroughly and when we have at least one "essentials
> +
> > extensions" release shipped with feedback.
> >
> > I think such release would be 2.9, so I think we should only move Spring
> > Data to extensions after 2.9 is released and feedback from this release
> is
> > processed."
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
> >
> >> +1.
> >>
> >> Saikat, can you, please, take a look?
> >>
> >>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
> >> написал(а):
> >>>
> >>> Mikhail,
> >>>
> >>> +1 for migrate
> >>>
> >>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
> >>>>
> >>>> Igniters,
> >>>>
> >>>> I propose to migrate spring-data modules from ignite main repository
> to
> >>>> ignite-extensions.
> >>>>
> >>>>
> >>>> Are there any objections?
> >>>>
> >>>>
> >>>> I've created ticket [1] and PR to both ignite [2] and
> ignite-extensions
> >>>> [3] repositories.
> >>>>
> >>>>
> >>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
> >>>>
> >>>> [2] - https://github.com/apache/ignite/pull/8334
> >>>>
> >>>> [3] - https://github.com/apache/ignite-extensions/pull/25
> >>>>
> >>>
> >>>
> >>> --
> >>> Best wishes,
> >>> Amelchev Nikita
> >>
> >>
>
>

Mikhail Petrov

Re: Migration of spring-data modules to ignite-extensions

Ilya, I haven't meant that removal of spring-data from Ignite main
repository should be done before the 2.9 release and be included in it.

Migration of spring-data to ignite-extensions could help us to make
SpringData integration updates available for users earlier then the next
Ignite release. For example adding support of thin client for SpringData.

On 09.10.2020 14:25, Ilya Kasnacheev wrote:
> Hello!
>
> I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
> Once we get that in the wild and gather a few months of feedback (or lack
> thereof) then we can go on with it.
>
> Regards,

Nikolay Izhikov-2

Re: Migration of spring-data modules to ignite-extensions

In reply to this post by Ilya Kasnacheev

Ilya.

My understanding is the following - there is no such thing as «Ignite Extensions release»
We can and should release each module separately.

You can take as an example - spring-boot-autoconfigure extension release.
I made it without releasing any other modules.

This mean - we can release spring-data modules as frequently as we want.
No correlation with the other extensions.

> 9 окт. 2020 г., в 14:25, Ilya Kasnacheev <[hidden email]> написал(а):
>
> Hello!
>
> I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
> Once we get that in the wild and gather a few months of feedback (or lack
> thereof) then we can go on with it.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:
>
>> Ilya, we should move modules that is not related to Ignite core to
>> extension.
>> We shouldn’t support all possible integrations in the Ignite itself.
>>
>>> I would argue that it should only moved to extensions last,
>>> when this process is debugged thoroughly and when we have at least one
>> "essentials + extensions" release shipped with feedback.
>>
>> Each extension should be released separately.
>> What is «essentials + extensions» release do you have in mind?
>>
>>
>> Moreover, ignite-spring-data release is not related to any Ignite releases.
>> Why do we have to wait Ignite release to get spring-data fixes or updates?
>>
>>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]>
>> написал(а):
>>>
>>> Hello!
>>>
>>> -1 from me for now.
>>>
>>> "Since Spring Data integration is actively used (compared to most
>> others),
>>> I would argue that it should only moved to extensions last, when this
>>> process is debugged thoroughly and when we have at least one "essentials
>> +
>>> extensions" release shipped with feedback.
>>>
>>> I think such release would be 2.9, so I think we should only move Spring
>>> Data to extensions after 2.9 is released and feedback from this release
>> is
>>> processed."
>>>
>>> Regards,
>>> --
>>> Ilya Kasnacheev
>>>
>>>
>>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
>>>
>>>> +1.
>>>>
>>>> Saikat, can you, please, take a look?
>>>>
>>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
>>>> написал(а):
>>>>>
>>>>> Mikhail,
>>>>>
>>>>> +1 for migrate
>>>>>
>>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
>>>>>>
>>>>>> Igniters,
>>>>>>
>>>>>> I propose to migrate spring-data modules from ignite main repository
>> to
>>>>>> ignite-extensions.
>>>>>>
>>>>>>
>>>>>> Are there any objections?
>>>>>>
>>>>>>
>>>>>> I've created ticket [1] and PR to both ignite [2] and
>> ignite-extensions
>>>>>> [3] repositories.
>>>>>>
>>>>>>
>>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>>>>>>
>>>>>> [2] - https://github.com/apache/ignite/pull/8334
>>>>>>
>>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best wishes,
>>>>> Amelchev Nikita
>>>>
>>>>
>>
>>

Maksim Stepachev

Re: Migration of spring-data modules to ignite-extensions

+1
I said about it few months ago.

пт, 9 окт. 2020 г., 15:13 Nikolay Izhikov <[hidden email]>:

> Ilya.
>
> My understanding is the following - there is no such thing as «Ignite
> Extensions release»
> We can and should release each module separately.
>
> You can take as an example - spring-boot-autoconfigure extension release.
> I made it without releasing any other modules.
>
> This mean - we can release spring-data modules as frequently as we want.
> No correlation with the other extensions.
>
>
> > 9 окт. 2020 г., в 14:25, Ilya Kasnacheev <[hidden email]>
> написал(а):
> >
> > Hello!
> >
> > I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
> > Once we get that in the wild and gather a few months of feedback (or lack
> > thereof) then we can go on with it.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:
> >
> >> Ilya, we should move modules that is not related to Ignite core to
> >> extension.
> >> We shouldn’t support all possible integrations in the Ignite itself.
> >>
> >>> I would argue that it should only moved to extensions last,
> >>> when this process is debugged thoroughly and when we have at least one
> >> "essentials + extensions" release shipped with feedback.
> >>
> >> Each extension should be released separately.
> >> What is «essentials + extensions» release do you have in mind?
> >>
> >>
> >> Moreover, ignite-spring-data release is not related to any Ignite
> releases.
> >> Why do we have to wait Ignite release to get spring-data fixes or
> updates?
> >>
> >>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]>
> >> написал(а):
> >>>
> >>> Hello!
> >>>
> >>> -1 from me for now.
> >>>
> >>> "Since Spring Data integration is actively used (compared to most
> >> others),
> >>> I would argue that it should only moved to extensions last, when this
> >>> process is debugged thoroughly and when we have at least one
> "essentials
> >> +
> >>> extensions" release shipped with feedback.
> >>>
> >>> I think such release would be 2.9, so I think we should only move
> Spring
> >>> Data to extensions after 2.9 is released and feedback from this release
> >> is
> >>> processed."
> >>>
> >>> Regards,
> >>> --
> >>> Ilya Kasnacheev
> >>>
> >>>
> >>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
> >>>
> >>>> +1.
> >>>>
> >>>> Saikat, can you, please, take a look?
> >>>>
> >>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
> >>>> написал(а):
> >>>>>
> >>>>> Mikhail,
> >>>>>
> >>>>> +1 for migrate
> >>>>>
> >>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]>:
> >>>>>>
> >>>>>> Igniters,
> >>>>>>
> >>>>>> I propose to migrate spring-data modules from ignite main repository
> >> to
> >>>>>> ignite-extensions.
> >>>>>>
> >>>>>>
> >>>>>> Are there any objections?
> >>>>>>
> >>>>>>
> >>>>>> I've created ticket [1] and PR to both ignite [2] and
> >> ignite-extensions
> >>>>>> [3] repositories.
> >>>>>>
> >>>>>>
> >>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
> >>>>>>
> >>>>>> [2] - https://github.com/apache/ignite/pull/8334
> >>>>>>
> >>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Best wishes,
> >>>>> Amelchev Nikita
> >>>>
> >>>>
> >>
> >>
>
>

Ilya Kasnacheev

Re: Migration of spring-data modules to ignite-extensions

In reply to this post by Nikolay Izhikov-2

Hello!

In any case, we need to release *something* and wait for it to be used by
actual users.

Currently this is not happening since 2.8.1 contains all extensions as
modules.

Regards,
--
Ilya Kasnacheev

пт, 9 окт. 2020 г. в 15:12, Nikolay Izhikov <[hidden email]>:

dmagda

Re: Migration of spring-data modules to ignite-extensions

How do we release all the modules that have already been moved to the
extensions repository?
https://github.com/apache/ignite-extensions/tree/master/modules

For instance, when 2.9 comes out and the users start bumping up their
Ignite versions in pom.xml, what should they set for Kafka, camel, etc.
that are already in the extensions? 2.9 or..?

-
Denis

On Fri, Oct 9, 2020 at 8:54 AM Ilya Kasnacheev <[hidden email]>
wrote:

> Hello!
>
> In any case, we need to release *something* and wait for it to be used by
> actual users.
>
> Currently this is not happening since 2.8.1 contains all extensions as
> modules.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пт, 9 окт. 2020 г. в 15:12, Nikolay Izhikov <[hidden email]>:
>
> > Ilya.
> >
> > My understanding is the following - there is no such thing as «Ignite
> > Extensions release»
> > We can and should release each module separately.
> >
> > You can take as an example - spring-boot-autoconfigure extension release.
> > I made it without releasing any other modules.
> >
> > This mean - we can release spring-data modules as frequently as we want.
> > No correlation with the other extensions.
> >
> >
> > > 9 окт. 2020 г., в 14:25, Ilya Kasnacheev <[hidden email]>
> > написал(а):
> > >
> > > Hello!
> > >
> > > I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
> > > Once we get that in the wild and gather a few months of feedback (or
> lack
> > > thereof) then we can go on with it.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:
> > >
> > >> Ilya, we should move modules that is not related to Ignite core to
> > >> extension.
> > >> We shouldn’t support all possible integrations in the Ignite itself.
> > >>
> > >>> I would argue that it should only moved to extensions last,
> > >>> when this process is debugged thoroughly and when we have at least
> one
> > >> "essentials + extensions" release shipped with feedback.
> > >>
> > >> Each extension should be released separately.
> > >> What is «essentials + extensions» release do you have in mind?
> > >>
> > >>
> > >> Moreover, ignite-spring-data release is not related to any Ignite
> > releases.
> > >> Why do we have to wait Ignite release to get spring-data fixes or
> > updates?
> > >>
> > >>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <[hidden email]>
> > >> написал(а):
> > >>>
> > >>> Hello!
> > >>>
> > >>> -1 from me for now.
> > >>>
> > >>> "Since Spring Data integration is actively used (compared to most
> > >> others),
> > >>> I would argue that it should only moved to extensions last, when this
> > >>> process is debugged thoroughly and when we have at least one
> > "essentials
> > >> +
> > >>> extensions" release shipped with feedback.
> > >>>
> > >>> I think such release would be 2.9, so I think we should only move
> > Spring
> > >>> Data to extensions after 2.9 is released and feedback from this
> release
> > >> is
> > >>> processed."
> > >>>
> > >>> Regards,
> > >>> --
> > >>> Ilya Kasnacheev
> > >>>
> > >>>
> > >>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
> > >>>
> > >>>> +1.
> > >>>>
> > >>>> Saikat, can you, please, take a look?
> > >>>>
> > >>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
> > >>>> написал(а):
> > >>>>>
> > >>>>> Mikhail,
> > >>>>>
> > >>>>> +1 for migrate
> > >>>>>
> > >>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <[hidden email]
> >:
> > >>>>>>
> > >>>>>> Igniters,
> > >>>>>>
> > >>>>>> I propose to migrate spring-data modules from ignite main
> repository
> > >> to
> > >>>>>> ignite-extensions.
> > >>>>>>
> > >>>>>>
> > >>>>>> Are there any objections?
> > >>>>>>
> > >>>>>>
> > >>>>>> I've created ticket [1] and PR to both ignite [2] and
> > >> ignite-extensions
> > >>>>>> [3] repositories.
> > >>>>>>
> > >>>>>>
> > >>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
> > >>>>>>
> > >>>>>> [2] - https://github.com/apache/ignite/pull/8334
> > >>>>>>
> > >>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Best wishes,
> > >>>>> Amelchev Nikita
> > >>>>
> > >>>>
> > >>
> > >>
> >
> >
>

Saikat Maitra

Re: Migration of spring-data modules to ignite-extensions

Hi Nikolay,

I have reviewed the PR and shared my comments.

Ilya,

My thoughts are that as soon the ignite 2.9.0 is released we should be able
to release the ignite-extensions module 1st version pointing to
ignite-core 2.9.0
version. So, for example ignite-flink-ext version 1.0.0 will be dependent
on ignite-core version 2.9.0 etc.

Denis,

I am thinking that users will just start consuming new to be released
extensions modules like for example kafka would be as following:

<dependency>
<groupId>org.apache.ignite</groupId>
<artifactId>ignite-kafka-ext</artifactId>
<version>1.0.0</version>
</dependency>

Regards,
Saikat

On Fri, Oct 9, 2020 at 3:58 PM Denis Magda <[hidden email]> wrote:

> How do we release all the modules that have already been moved to the
> extensions repository?
> https://github.com/apache/ignite-extensions/tree/master/modules
>
> For instance, when 2.9 comes out and the users start bumping up their
> Ignite versions in pom.xml, what should they set for Kafka, camel, etc.
> that are already in the extensions? 2.9 or..?
>
>
> -
> Denis
>
>
> On Fri, Oct 9, 2020 at 8:54 AM Ilya Kasnacheev <[hidden email]>
> wrote:
>
> > Hello!
> >
> > In any case, we need to release *something* and wait for it to be used by
> > actual users.
> >
> > Currently this is not happening since 2.8.1 contains all extensions as
> > modules.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 9 окт. 2020 г. в 15:12, Nikolay Izhikov <[hidden email]>:
> >
> > > Ilya.
> > >
> > > My understanding is the following - there is no such thing as «Ignite
> > > Extensions release»
> > > We can and should release each module separately.
> > >
> > > You can take as an example - spring-boot-autoconfigure extension
> release.
> > > I made it without releasing any other modules.
> > >
> > > This mean - we can release spring-data modules as frequently as we
> want.
> > > No correlation with the other extensions.
> > >
> > >
> > > > 9 окт. 2020 г., в 14:25, Ilya Kasnacheev <[hidden email]>
> > > написал(а):
> > > >
> > > > Hello!
> > > >
> > > > I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0
> release.
> > > > Once we get that in the wild and gather a few months of feedback (or
> > lack
> > > > thereof) then we can go on with it.
> > > >
> > > > Regards,
> > > > --
> > > > Ilya Kasnacheev
> > > >
> > > >
> > > > пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:
> > > >
> > > >> Ilya, we should move modules that is not related to Ignite core to
> > > >> extension.
> > > >> We shouldn’t support all possible integrations in the Ignite itself.
> > > >>
> > > >>> I would argue that it should only moved to extensions last,
> > > >>> when this process is debugged thoroughly and when we have at least
> > one
> > > >> "essentials + extensions" release shipped with feedback.
> > > >>
> > > >> Each extension should be released separately.
> > > >> What is «essentials + extensions» release do you have in mind?
> > > >>
> > > >>
> > > >> Moreover, ignite-spring-data release is not related to any Ignite
> > > releases.
> > > >> Why do we have to wait Ignite release to get spring-data fixes or
> > > updates?
> > > >>
> > > >>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <
> [hidden email]>
> > > >> написал(а):
> > > >>>
> > > >>> Hello!
> > > >>>
> > > >>> -1 from me for now.
> > > >>>
> > > >>> "Since Spring Data integration is actively used (compared to most
> > > >> others),
> > > >>> I would argue that it should only moved to extensions last, when
> this
> > > >>> process is debugged thoroughly and when we have at least one
> > > "essentials
> > > >> +
> > > >>> extensions" release shipped with feedback.
> > > >>>
> > > >>> I think such release would be 2.9, so I think we should only move
> > > Spring
> > > >>> Data to extensions after 2.9 is released and feedback from this
> > release
> > > >> is
> > > >>> processed."
> > > >>>
> > > >>> Regards,
> > > >>> --
> > > >>> Ilya Kasnacheev
> > > >>>
> > > >>>
> > > >>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
> > > >>>
> > > >>>> +1.
> > > >>>>
> > > >>>> Saikat, can you, please, take a look?
> > > >>>>
> > > >>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
> > > >>>> написал(а):
> > > >>>>>
> > > >>>>> Mikhail,
> > > >>>>>
> > > >>>>> +1 for migrate
> > > >>>>>
> > > >>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <
> [hidden email]
> > >:
> > > >>>>>>
> > > >>>>>> Igniters,
> > > >>>>>>
> > > >>>>>> I propose to migrate spring-data modules from ignite main
> > repository
> > > >> to
> > > >>>>>> ignite-extensions.
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> Are there any objections?
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> I've created ticket [1] and PR to both ignite [2] and
> > > >> ignite-extensions
> > > >>>>>> [3] repositories.
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
> > > >>>>>>
> > > >>>>>> [2] - https://github.com/apache/ignite/pull/8334
> > > >>>>>>
> > > >>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
> > > >>>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> --
> > > >>>>> Best wishes,
> > > >>>>> Amelchev Nikita
> > > >>>>
> > > >>>>
> > > >>
> > > >>
> > >
> > >
> >
>

Saikat Maitra

Re: Migration of spring-data modules to ignite-extensions

In reply to this post by Mikhail Petrov

Hi Mikhail,

Also once the changes are complete please add modules details and
Testsuites in the teamcity build config
https://ci.ignite.apache.org/admin/editBuildParams.html?id=buildType:Tests_IgniteExtensions_Build

Regards,
Saikat

On Fri, Oct 9, 2020 at 7:09 AM Mikhail Petrov <[hidden email]> wrote:

> Ilya, I haven't meant that removal of spring-data from Ignite main
> repository should be done before the 2.9 release and be included in it.
>
> Migration of spring-data to ignite-extensions could help us to make
> SpringData integration updates available for users earlier then the next
> Ignite release. For example adding support of thin client for SpringData.
>
>
> On 09.10.2020 14:25, Ilya Kasnacheev wrote:
> > Hello!
> >
> > I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0 release.
> > Once we get that in the wild and gather a few months of feedback (or lack
> > thereof) then we can go on with it.
> >
> > Regards,
>

Mikhail Petrov

Re: Migration of spring-data modules to ignite-extensions

In reply to this post by Saikat Maitra

Saikat,

Thanks a lot for the review.

Anyone else want to review PR [1] with migration of spring-data to
ignite-extensions repository?

[1] - https://github.com/apache/ignite-extensions/pull/25

On 10.10.2020 07:15, Saikat Maitra wrote:

> Hi Nikolay,
>
> I have reviewed the PR and shared my comments.
>
> Ilya,
>
> My thoughts are that as soon the ignite 2.9.0 is released we should be able
> to release the ignite-extensions module 1st version pointing to
> ignite-core 2.9.0
> version. So, for example ignite-flink-ext version 1.0.0 will be dependent
> on ignite-core version 2.9.0 etc.
>
>
> Denis,
>
> I am thinking that users will just start consuming new to be released
> extensions modules like for example kafka would be as following:
>
> <dependency>
> <groupId>org.apache.ignite</groupId>
> <artifactId>ignite-kafka-ext</artifactId>
> <version>1.0.0</version>
> </dependency>
>
>
> Regards,
> Saikat
>
>
> On Fri, Oct 9, 2020 at 3:58 PM Denis Magda <[hidden email]> wrote:
>
>> How do we release all the modules that have already been moved to the
>> extensions repository?
>> https://github.com/apache/ignite-extensions/tree/master/modules
>>
>> For instance, when 2.9 comes out and the users start bumping up their
>> Ignite versions in pom.xml, what should they set for Kafka, camel, etc.
>> that are already in the extensions? 2.9 or..?
>>
>>
>> -
>> Denis
>>
>>
>> On Fri, Oct 9, 2020 at 8:54 AM Ilya Kasnacheev <[hidden email]>
>> wrote:
>>
>>> Hello!
>>>
>>> In any case, we need to release *something* and wait for it to be used by
>>> actual users.
>>>
>>> Currently this is not happening since 2.8.1 contains all extensions as
>>> modules.
>>>
>>> Regards,
>>> --
>>> Ilya Kasnacheev
>>>
>>>
>>> пт, 9 окт. 2020 г. в 15:12, Nikolay Izhikov <[hidden email]>:
>>>
>>>> Ilya.
>>>>
>>>> My understanding is the following - there is no such thing as «Ignite
>>>> Extensions release»
>>>> We can and should release each module separately.
>>>>
>>>> You can take as an example - spring-boot-autoconfigure extension
>> release.
>>>> I made it without releasing any other modules.
>>>>
>>>> This mean - we can release spring-data modules as frequently as we
>> want.
>>>> No correlation with the other extensions.
>>>>
>>>>
>>>>> 9 окт. 2020 г., в 14:25, Ilya Kasnacheev <[hidden email]>
>>>> написал(а):
>>>>> Hello!
>>>>>
>>>>> I mean the Apache Ignite 2.9 release and Ignite Extensions 1.0
>> release.
>>>>> Once we get that in the wild and gather a few months of feedback (or
>>> lack
>>>>> thereof) then we can go on with it.
>>>>>
>>>>> Regards,
>>>>> --
>>>>> Ilya Kasnacheev
>>>>>
>>>>>
>>>>> пт, 9 окт. 2020 г. в 12:42, Nikolay Izhikov <[hidden email]>:
>>>>>
>>>>>> Ilya, we should move modules that is not related to Ignite core to
>>>>>> extension.
>>>>>> We shouldn’t support all possible integrations in the Ignite itself.
>>>>>>
>>>>>>> I would argue that it should only moved to extensions last,
>>>>>>> when this process is debugged thoroughly and when we have at least
>>> one
>>>>>> "essentials + extensions" release shipped with feedback.
>>>>>>
>>>>>> Each extension should be released separately.
>>>>>> What is «essentials + extensions» release do you have in mind?
>>>>>>
>>>>>>
>>>>>> Moreover, ignite-spring-data release is not related to any Ignite
>>>> releases.
>>>>>> Why do we have to wait Ignite release to get spring-data fixes or
>>>> updates?
>>>>>>> 9 окт. 2020 г., в 12:34, Ilya Kasnacheev <
>> [hidden email]>
>>>>>> написал(а):
>>>>>>> Hello!
>>>>>>>
>>>>>>> -1 from me for now.
>>>>>>>
>>>>>>> "Since Spring Data integration is actively used (compared to most
>>>>>> others),
>>>>>>> I would argue that it should only moved to extensions last, when
>> this
>>>>>>> process is debugged thoroughly and when we have at least one
>>>> "essentials
>>>>>> +
>>>>>>> extensions" release shipped with feedback.
>>>>>>>
>>>>>>> I think such release would be 2.9, so I think we should only move
>>>> Spring
>>>>>>> Data to extensions after 2.9 is released and feedback from this
>>> release
>>>>>> is
>>>>>>> processed."
>>>>>>>
>>>>>>> Regards,
>>>>>>> --
>>>>>>> Ilya Kasnacheev
>>>>>>>
>>>>>>>
>>>>>>> пт, 9 окт. 2020 г. в 12:10, Nikolay Izhikov <[hidden email]>:
>>>>>>>
>>>>>>>> +1.
>>>>>>>>
>>>>>>>> Saikat, can you, please, take a look?
>>>>>>>>
>>>>>>>>> 9 окт. 2020 г., в 11:54, Nikita Amelchev <[hidden email]>
>>>>>>>> написал(а):
>>>>>>>>> Mikhail,
>>>>>>>>>
>>>>>>>>> +1 for migrate
>>>>>>>>>
>>>>>>>>> чт, 8 окт. 2020 г. в 18:34, Mikhail Petrov <
>> [hidden email]
>>>> :
>>>>>>>>>> Igniters,
>>>>>>>>>>
>>>>>>>>>> I propose to migrate spring-data modules from ignite main
>>> repository
>>>>>> to
>>>>>>>>>> ignite-extensions.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Are there any objections?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I've created ticket [1] and PR to both ignite [2] and
>>>>>> ignite-extensions
>>>>>>>>>> [3] repositories.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13559
>>>>>>>>>>
>>>>>>>>>> [2] - https://github.com/apache/ignite/pull/8334
>>>>>>>>>>
>>>>>>>>>> [3] - https://github.com/apache/ignite-extensions/pull/25
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Best wishes,
>>>>>>>>> Amelchev Nikita
>>>>>>>>
>>>>>>
>>>>