Apache Ignite Developers - Legacy Mail Archive

Ignite 2.7.5 Release scope

Classic

List

Threaded

45 messages Options

123

Dmitry Pavlov

Ignite 2.7.5 Release scope

Hi Ignite Developers,

In a separate discussion, I've shared a log with all commits.

As far as I can see, nobody removed commits from this sheet, so the scope
of release will be discussed in another way: only explicitly declared
commits will be cherry-picked.

Sincerely,
Dmitriy Pavlov

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

Hi Igniters,

Meanwhile, Java 12 GA is available. I suggest at least test our new tests
scripts with a couple of Java builds. WDYT?

Sincerely,
Dmitriy Pavlov

ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:

> Hi Ignite Developers,
>
> In a separate discussion, I've shared a log with all commits.
>
> As far as I can see, nobody removed commits from this sheet, so the scope
> of release will be discussed in another way: only explicitly declared
> commits will be cherry-picked.
>
> Sincerely,
> Dmitriy Pavlov
>

vveider

Re: Ignite 2.7.5 Release scope

Huge +1

Will try to add new JDK in nearest time to our Teamcity.

> On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]> wrote:
>
> Hi Igniters,
>
> Meanwhile, Java 12 GA is available. I suggest at least test our new tests
> scripts with a couple of Java builds. WDYT?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
>
>> Hi Ignite Developers,
>>
>> In a separate discussion, I've shared a log with all commits.
>>
>> As far as I can see, nobody removed commits from this sheet, so the scope
>> of release will be discussed in another way: only explicitly declared
>> commits will be cherry-picked.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

Hi Igniters,

fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait on
processWrite during SSL handshake.
seems to be blocker cause it is related to Java 11

I see Maxim M left some comments. Ilya K., Maxim M.were these comments
addressed?

The ticket is in Patch Available. Reviewer needed. Changes located in
GridNioServer.

Sincerely,
Dmitriy Pavlov

P.S. a quite obvious ticket came to sope, as well:
https://issues.apache.org/jira/browse/IGNITE-11600

чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:

> Huge +1
>
> Will try to add new JDK in nearest time to our Teamcity.
>
>
> > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]> wrote:
> >
> > Hi Igniters,
> >
> > Meanwhile, Java 12 GA is available. I suggest at least test our new tests
> > scripts with a couple of Java builds. WDYT?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
> >
> >> Hi Ignite Developers,
> >>
> >> In a separate discussion, I've shared a log with all commits.
> >>
> >> As far as I can see, nobody removed commits from this sheet, so the
> scope
> >> of release will be discussed in another way: only explicitly declared
> >> commits will be cherry-picked.
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
>
>

Mmuzaf

Re: Ignite 2.7.5 Release scope

Dmitry, Ilya,

Yes, I've looked through those changes [1] as they can affect my local
PR. Basically, changes look good to me.

I'm not an expert with CommunicationSpi component, so can miss some
details and I haven't tested these changes under Java 11. One more
thing I'd like to say, I would add additional tests to PR that will
explicitly highlight the problem being solved.

[1] https://issues.apache.org/jira/browse/IGNITE-11299

On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]> wrote:

>
> Hi Igniters,
>
> fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait on
> processWrite during SSL handshake.
> seems to be blocker cause it is related to Java 11
>
> I see Maxim M left some comments. Ilya K., Maxim M.were these comments
> addressed?
>
> The ticket is in Patch Available. Reviewer needed. Changes located in
> GridNioServer.
>
> Sincerely,
> Dmitriy Pavlov
>
> P.S. a quite obvious ticket came to sope, as well:
> https://issues.apache.org/jira/browse/IGNITE-11600
>
>
> чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
>
> > Huge +1
> >
> > Will try to add new JDK in nearest time to our Teamcity.
> >
> >
> > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]> wrote:
> > >
> > > Hi Igniters,
> > >
> > > Meanwhile, Java 12 GA is available. I suggest at least test our new tests
> > > scripts with a couple of Java builds. WDYT?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
> > >
> > >> Hi Ignite Developers,
> > >>
> > >> In a separate discussion, I've shared a log with all commits.
> > >>
> > >> As far as I can see, nobody removed commits from this sheet, so the
> > scope
> > >> of release will be discussed in another way: only explicitly declared
> > >> commits will be cherry-picked.
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> >
> >

Ilya Kasnacheev

Re: Ignite 2.7.5 Release scope

Hello!

Basically there is a test that explicitly highlights this problem, that is
running SSL tests on Windows + Java 11. They will hang on Master but pass
with this patch.

I have started that on TC, results will probably be available later today:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
(mind the Java version).

Regards,
--
Ilya Kasnacheev

пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:

> Dmitry, Ilya,
>
> Yes, I've looked through those changes [1] as they can affect my local
> PR. Basically, changes look good to me.
>
> I'm not an expert with CommunicationSpi component, so can miss some
> details and I haven't tested these changes under Java 11. One more
> thing I'd like to say, I would add additional tests to PR that will
> explicitly highlight the problem being solved.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-11299
>
> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]> wrote:
> >
> > Hi Igniters,
> >
> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait
> on
> > processWrite during SSL handshake.
> > seems to be blocker cause it is related to Java 11
> >
> > I see Maxim M left some comments. Ilya K., Maxim M.were these comments
> > addressed?
> >
> > The ticket is in Patch Available. Reviewer needed. Changes located in
> > GridNioServer.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > P.S. a quite obvious ticket came to sope, as well:
> > https://issues.apache.org/jira/browse/IGNITE-11600
> >
> >
> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> >
> > > Huge +1
> > >
> > > Will try to add new JDK in nearest time to our Teamcity.
> > >
> > >
> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]> wrote:
> > > >
> > > > Hi Igniters,
> > > >
> > > > Meanwhile, Java 12 GA is available. I suggest at least test our new
> tests
> > > > scripts with a couple of Java builds. WDYT?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
> > > >
> > > >> Hi Ignite Developers,
> > > >>
> > > >> In a separate discussion, I've shared a log with all commits.
> > > >>
> > > >> As far as I can see, nobody removed commits from this sheet, so the
> > > scope
> > > >> of release will be discussed in another way: only explicitly
> declared
> > > >> commits will be cherry-picked.
> > > >>
> > > >> Sincerely,
> > > >> Dmitriy Pavlov
> > > >>
> > >
> > >
>

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

Hi Igniters,

Let me share a couple more links related to release
https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5

Tests (now tests use Java 8):
https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAllNightly&baseBranchForTc=ignite-2.7&branchForTc=ignite-2.7.5&action=Latest

TC bot had corruption, so for now, it is a number of blockers tests, I hope
runs during the weekend will help to re-collect stat for 2.7

https://mtcga.gridgain.com/current.html?branch=ignite-2.7.5-nightly

Also, I've changed scripts to allow to run Ignite under Java 12+, please
review/test changes https://issues.apache.org/jira/browse/IGNITE-11600
https://github.com/apache/ignite/pull/6326

Sincerely,
Dmitriy Pavlov

пт, 22 мар. 2019 г. в 17:00, Ilya Kasnacheev <[hidden email]>:

> Hello!
>
> Basically there is a test that explicitly highlights this problem, that is
> running SSL tests on Windows + Java 11. They will hang on Master but pass
> with this patch.
>
> I have started that on TC, results will probably be available later today:
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> (mind the Java version).
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
>
> > Dmitry, Ilya,
> >
> > Yes, I've looked through those changes [1] as they can affect my local
> > PR. Basically, changes look good to me.
> >
> > I'm not an expert with CommunicationSpi component, so can miss some
> > details and I haven't tested these changes under Java 11. One more
> > thing I'd like to say, I would add additional tests to PR that will
> > explicitly highlight the problem being solved.
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-11299
> >
> > On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]> wrote:
> > >
> > > Hi Igniters,
> > >
> > > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait
> > on
> > > processWrite during SSL handshake.
> > > seems to be blocker cause it is related to Java 11
> > >
> > > I see Maxim M left some comments. Ilya K., Maxim M.were these comments
> > > addressed?
> > >
> > > The ticket is in Patch Available. Reviewer needed. Changes located in
> > > GridNioServer.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > P.S. a quite obvious ticket came to sope, as well:
> > > https://issues.apache.org/jira/browse/IGNITE-11600
> > >
> > >
> > > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> > >
> > > > Huge +1
> > > >
> > > > Will try to add new JDK in nearest time to our Teamcity.
> > > >
> > > >
> > > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> wrote:
> > > > >
> > > > > Hi Igniters,
> > > > >
> > > > > Meanwhile, Java 12 GA is available. I suggest at least test our new
> > tests
> > > > > scripts with a couple of Java builds. WDYT?
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
> > > > >
> > > > >> Hi Ignite Developers,
> > > > >>
> > > > >> In a separate discussion, I've shared a log with all commits.
> > > > >>
> > > > >> As far as I can see, nobody removed commits from this sheet, so
> the
> > > > scope
> > > > >> of release will be discussed in another way: only explicitly
> > declared
> > > > >> commits will be cherry-picked.
> > > > >>
> > > > >> Sincerely,
> > > > >> Dmitriy Pavlov
> > > > >>
> > > >
> > > >
> >
>

Ilya Kasnacheev

Re: Ignite 2.7.5 Release scope

In reply to this post by Ilya Kasnacheev

Hello!

It seems that I can no longer test this case, on account of
TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
hanging every time under Java 11 on Windows.

Alexey, Ivan, can you please take a look?

https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__

Regards,

--
Ilya Kasnacheev

пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]>:

> Hello!
>
> Basically there is a test that explicitly highlights this problem, that is
> running SSL tests on Windows + Java 11. They will hang on Master but pass
> with this patch.
>
> I have started that on TC, results will probably be available later today:
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> (mind the Java version).
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
>
>> Dmitry, Ilya,
>>
>> Yes, I've looked through those changes [1] as they can affect my local
>> PR. Basically, changes look good to me.
>>
>> I'm not an expert with CommunicationSpi component, so can miss some
>> details and I haven't tested these changes under Java 11. One more
>> thing I'd like to say, I would add additional tests to PR that will
>> explicitly highlight the problem being solved.
>>
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-11299
>>
>> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]> wrote:
>> >
>> > Hi Igniters,
>> >
>> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait
>> on
>> > processWrite during SSL handshake.
>> > seems to be blocker cause it is related to Java 11
>> >
>> > I see Maxim M left some comments. Ilya K., Maxim M.were these comments
>> > addressed?
>> >
>> > The ticket is in Patch Available. Reviewer needed. Changes located in
>> > GridNioServer.
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> > P.S. a quite obvious ticket came to sope, as well:
>> > https://issues.apache.org/jira/browse/IGNITE-11600
>> >
>> >
>> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
>> >
>> > > Huge +1
>> > >
>> > > Will try to add new JDK in nearest time to our Teamcity.
>> > >
>> > >
>> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
>> wrote:
>> > > >
>> > > > Hi Igniters,
>> > > >
>> > > > Meanwhile, Java 12 GA is available. I suggest at least test our new
>> tests
>> > > > scripts with a couple of Java builds. WDYT?
>> > > >
>> > > > Sincerely,
>> > > > Dmitriy Pavlov
>> > > >
>> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
>> > > >
>> > > >> Hi Ignite Developers,
>> > > >>
>> > > >> In a separate discussion, I've shared a log with all commits.
>> > > >>
>> > > >> As far as I can see, nobody removed commits from this sheet, so the
>> > > scope
>> > > >> of release will be discussed in another way: only explicitly
>> declared
>> > > >> commits will be cherry-picked.
>> > > >>
>> > > >> Sincerely,
>> > > >> Dmitriy Pavlov
>> > > >>
>> > >
>> > >
>>
>

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

Hi Ignite Developers,

So because nobody raised any feature I would like to call for scope freeze
for 2.7.5.

The scope is limited with corruption fix, Java 11 issues addressed.
https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5

Also, launch scripts will be tested for Java 12.

We entered the Rampdown phase. See more info in
https://cwiki.apache.org/confluence/display/IGNITE/Release+Process

Issues can be added to the scope only through discussion.

Sincerely,
Dmitriy Pavlov

пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:

> Hello!
>
> It seems that I can no longer test this case, on account of
>
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> hanging every time under Java 11 on Windows.
>
> Alexey, Ivan, can you please take a look?
>
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
>
> Regards,
>
> --
> Ilya Kasnacheev
>
>
> пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]>:
>
> > Hello!
> >
> > Basically there is a test that explicitly highlights this problem, that
> is
> > running SSL tests on Windows + Java 11. They will hang on Master but pass
> > with this patch.
> >
> > I have started that on TC, results will probably be available later
> today:
> >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > (mind the Java version).
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> >
> >> Dmitry, Ilya,
> >>
> >> Yes, I've looked through those changes [1] as they can affect my local
> >> PR. Basically, changes look good to me.
> >>
> >> I'm not an expert with CommunicationSpi component, so can miss some
> >> details and I haven't tested these changes under Java 11. One more
> >> thing I'd like to say, I would add additional tests to PR that will
> >> explicitly highlight the problem being solved.
> >>
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> >>
> >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> wrote:
> >> >
> >> > Hi Igniters,
> >> >
> >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> wait
> >> on
> >> > processWrite during SSL handshake.
> >> > seems to be blocker cause it is related to Java 11
> >> >
> >> > I see Maxim M left some comments. Ilya K., Maxim M.were these comments
> >> > addressed?
> >> >
> >> > The ticket is in Patch Available. Reviewer needed. Changes located in
> >> > GridNioServer.
> >> >
> >> > Sincerely,
> >> > Dmitriy Pavlov
> >> >
> >> > P.S. a quite obvious ticket came to sope, as well:
> >> > https://issues.apache.org/jira/browse/IGNITE-11600
> >> >
> >> >
> >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> >> >
> >> > > Huge +1
> >> > >
> >> > > Will try to add new JDK in nearest time to our Teamcity.
> >> > >
> >> > >
> >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> >> wrote:
> >> > > >
> >> > > > Hi Igniters,
> >> > > >
> >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
> new
> >> tests
> >> > > > scripts with a couple of Java builds. WDYT?
> >> > > >
> >> > > > Sincerely,
> >> > > > Dmitriy Pavlov
> >> > > >
> >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]>:
> >> > > >
> >> > > >> Hi Ignite Developers,
> >> > > >>
> >> > > >> In a separate discussion, I've shared a log with all commits.
> >> > > >>
> >> > > >> As far as I can see, nobody removed commits from this sheet, so
> the
> >> > > scope
> >> > > >> of release will be discussed in another way: only explicitly
> >> declared
> >> > > >> commits will be cherry-picked.
> >> > > >>
> >> > > >> Sincerely,
> >> > > >> Dmitriy Pavlov
> >> > > >>
> >> > >
> >> > >
> >>
> >
>

Roman Shtykh

Re: Ignite 2.7.5 Release scope

Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the cluster down" thread?

-- Roman

On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov <[hidden email]> wrote:

Hi Ignite Developers,

So because nobody raised any feature I would like to call for scope freeze
for 2.7.5.

The scope is limited with corruption fix, Java 11 issues addressed.
https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5

Also, launch scripts will be tested for Java 12.

We entered the Rampdown phase. See more info in
https://cwiki.apache.org/confluence/display/IGNITE/Release+Process

Issues can be added to the scope only through discussion.

Sincerely,
Dmitriy Pavlov

пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:

Andrey Kuznetsov

Re: Ignite 2.7.5 Release scope

Roman, I think the worst thing we can do is to hide the bug you discovered.
The sane options are either fix it urgently or classify it as non-critical
and postpone.

вт, 26 мар. 2019 г. в 05:13, Roman Shtykh <[hidden email]>:

> Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION
> (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as
> suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the
> cluster down" thread?
>
> -- Roman
>
>
> On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov <
> [hidden email]> wrote:
>
> Hi Ignite Developers,
>
> So because nobody raised any feature I would like to call for scope freeze
> for 2.7.5.
>
> The scope is limited with corruption fix, Java 11 issues addressed.
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5
>
> Also, launch scripts will be tested for Java 12.
>
> We entered the Rampdown phase. See more info in
> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process
>
> Issues can be added to the scope only through discussion.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:
>
> > Hello!
> >
> > It seems that I can no longer test this case, on account of
> >
> >
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> > hanging every time under Java 11 on Windows.
> >
> > Alexey, Ivan, can you please take a look?
> >
> >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >
> > Regards,
> >
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]
> >:
> >
> > > Hello!
> > >
> > > Basically there is a test that explicitly highlights this problem, that
> > is
> > > running SSL tests on Windows + Java 11. They will hang on Master but
> pass
> > > with this patch.
> > >
> > > I have started that on TC, results will probably be available later
> > today:
> > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > > (mind the Java version).
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> > >
> > >> Dmitry, Ilya,
> > >>
> > >> Yes, I've looked through those changes [1] as they can affect my local
> > >> PR. Basically, changes look good to me.
> > >>
> > >> I'm not an expert with CommunicationSpi component, so can miss some
> > >> details and I haven't tested these changes under Java 11. One more
> > >> thing I'd like to say, I would add additional tests to PR that will
> > >> explicitly highlight the problem being solved.
> > >>
> > >>
> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> > >>
> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> > wrote:
> > >> >
> > >> > Hi Igniters,
> > >> >
> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> > wait
> > >> on
> > >> > processWrite during SSL handshake.
> > >> > seems to be blocker cause it is related to Java 11
> > >> >
> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> comments
> > >> > addressed?
> > >> >
> > >> > The ticket is in Patch Available. Reviewer needed. Changes located
> in
> > >> > GridNioServer.
> > >> >
> > >> > Sincerely,
> > >> > Dmitriy Pavlov
> > >> >
> > >> > P.S. a quite obvious ticket came to sope, as well:
> > >> > https://issues.apache.org/jira/browse/IGNITE-11600
> > >> >
> > >> >
> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> > >> >
> > >> > > Huge +1
> > >> > >
> > >> > > Will try to add new JDK in nearest time to our Teamcity.
> > >> > >
> > >> > >
> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> > >> wrote:
> > >> > > >
> > >> > > > Hi Igniters,
> > >> > > >
> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
> > new
> > >> tests
> > >> > > > scripts with a couple of Java builds. WDYT?
> > >> > > >
> > >> > > > Sincerely,
> > >> > > > Dmitriy Pavlov
> > >> > > >
> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]
> >:
> > >> > > >
> > >> > > >> Hi Ignite Developers,
> > >> > > >>
> > >> > > >> In a separate discussion, I've shared a log with all commits.
> > >> > > >>
> > >> > > >> As far as I can see, nobody removed commits from this sheet, so
> > the
> > >> > > scope
> > >> > > >> of release will be discussed in another way: only explicitly
> > >> declared
> > >> > > >> commits will be cherry-picked.
> > >> > > >>
> > >> > > >> Sincerely,
> > >> > > >> Dmitriy Pavlov
> > >> > > >>
> > >> > >
> > >> > >
> > >>
> > >
> >

--
Best regards,
Andrey Kuznetsov.

Roman Shtykh

Re: Ignite 2.7.5 Release scope

Andrey, hmm, I don't think putting back the behavior (if it's safe) we used to have with all those exceptions being logged etc. is hiding. I would never propose something like that.
Btw, I have fixed the issue. If it looks good let's merge.

-- Roman

On Tuesday, March 26, 2019, 2:46:08 p.m. GMT+9, Andrey Kuznetsov <[hidden email]> wrote:

Roman, I think the worst thing we can do is to hide the bug you discovered. The sane options are either fix it urgently or classify it as non-critical and postpone.
вт, 26 мар. 2019 г. в 05:13, Roman Shtykh <[hidden email]>:

Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the cluster down" thread?

-- Roman

On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov <[hidden email]> wrote:

Hi Ignite Developers,

So because nobody raised any feature I would like to call for scope freeze
for 2.7.5.

The scope is limited with corruption fix, Java 11 issues addressed.
https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5

Also, launch scripts will be tested for Java 12.

We entered the Rampdown phase. See more info in
https://cwiki.apache.org/confluence/display/IGNITE/Release+Process

Issues can be added to the scope only through discussion.

Sincerely,
Dmitriy Pavlov

пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:

--
Best regards,
Andrey Kuznetsov.

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

+0.5 from me from release point of view. If community agrees with solution,
I can cherry pick fix later.

вт, 26 мар. 2019 г., 8:59 Roman Shtykh <[hidden email]>:

> Andrey, hmm, I don't think putting back the behavior (if it's safe) we
> used to have with all those exceptions being logged etc. is hiding. I would
> never propose something like that.
> Btw, I have fixed the issue. If it looks good let's merge.
>
> -- Roman
>
>
> On Tuesday, March 26, 2019, 2:46:08 p.m. GMT+9, Andrey Kuznetsov <
> [hidden email]> wrote:
>
> Roman, I think the worst thing we can do is to hide the bug you
> discovered. The sane options are either fix it urgently or classify it as
> non-critical and postpone.
> вт, 26 мар. 2019 г. в 05:13, Roman Shtykh <[hidden email]>:
>
> Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION
> (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as
> suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the
> cluster down" thread?
>
> -- Roman
>
>
> On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov <
> [hidden email]> wrote:
>
> Hi Ignite Developers,
>
> So because nobody raised any feature I would like to call for scope freeze
> for 2.7.5.
>
> The scope is limited with corruption fix, Java 11 issues addressed.
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5
>
> Also, launch scripts will be tested for Java 12.
>
> We entered the Rampdown phase. See more info in
> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process
>
> Issues can be added to the scope only through discussion.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:
>
> > Hello!
> >
> > It seems that I can no longer test this case, on account of
> >
> >
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> > hanging every time under Java 11 on Windows.
> >
> > Alexey, Ivan, can you please take a look?
> >
> >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >
> > Regards,
> >
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]
> >:
> >
> > > Hello!
> > >
> > > Basically there is a test that explicitly highlights this problem, that
> > is
> > > running SSL tests on Windows + Java 11. They will hang on Master but
> pass
> > > with this patch.
> > >
> > > I have started that on TC, results will probably be available later
> > today:
> > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > > (mind the Java version).
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> > >
> > >> Dmitry, Ilya,
> > >>
> > >> Yes, I've looked through those changes [1] as they can affect my local
> > >> PR. Basically, changes look good to me.
> > >>
> > >> I'm not an expert with CommunicationSpi component, so can miss some
> > >> details and I haven't tested these changes under Java 11. One more
> > >> thing I'd like to say, I would add additional tests to PR that will
> > >> explicitly highlight the problem being solved.
> > >>
> > >>
> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> > >>
> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> > wrote:
> > >> >
> > >> > Hi Igniters,
> > >> >
> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> > wait
> > >> on
> > >> > processWrite during SSL handshake.
> > >> > seems to be blocker cause it is related to Java 11
> > >> >
> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> comments
> > >> > addressed?
> > >> >
> > >> > The ticket is in Patch Available. Reviewer needed. Changes located
> in
> > >> > GridNioServer.
> > >> >
> > >> > Sincerely,
> > >> > Dmitriy Pavlov
> > >> >
> > >> > P.S. a quite obvious ticket came to sope, as well:
> > >> > https://issues.apache.org/jira/browse/IGNITE-11600
> > >> >
> > >> >
> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> > >> >
> > >> > > Huge +1
> > >> > >
> > >> > > Will try to add new JDK in nearest time to our Teamcity.
> > >> > >
> > >> > >
> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> > >> wrote:
> > >> > > >
> > >> > > > Hi Igniters,
> > >> > > >
> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
> > new
> > >> tests
> > >> > > > scripts with a couple of Java builds. WDYT?
> > >> > > >
> > >> > > > Sincerely,
> > >> > > > Dmitriy Pavlov
> > >> > > >
> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]
> >:
> > >> > > >
> > >> > > >> Hi Ignite Developers,
> > >> > > >>
> > >> > > >> In a separate discussion, I've shared a log with all commits.
> > >> > > >>
> > >> > > >> As far as I can see, nobody removed commits from this sheet, so
> > the
> > >> > > scope
> > >> > > >> of release will be discussed in another way: only explicitly
> > >> declared
> > >> > > >> commits will be cherry-picked.
> > >> > > >>
> > >> > > >> Sincerely,
> > >> > > >> Dmitriy Pavlov
> > >> > > >>
> > >> > >
> > >> > >
> > >>
> > >
> >
>
>
> --
> Best regards,
> Andrey Kuznetsov.
>

Ilya Kasnacheev

Re: Ignite 2.7.5 Release scope

Hello!

If you ask me I vote +0,5 either, I am not entirely confident but I answer
a huge volume of questions on userlist which boil down to prematory
SYSTEM_WORKER_TERMINATION.

Regards,
--
Ilya Kasnacheev

вт, 26 мар. 2019 г. в 11:24, Dmitriy Pavlov <[hidden email]>:

> +0.5 from me from release point of view. If community agrees with solution,
> I can cherry pick fix later.
>
> вт, 26 мар. 2019 г., 8:59 Roman Shtykh <[hidden email]>:
>
> > Andrey, hmm, I don't think putting back the behavior (if it's safe) we
> > used to have with all those exceptions being logged etc. is hiding. I
> would
> > never propose something like that.
> > Btw, I have fixed the issue. If it looks good let's merge.
> >
> > -- Roman
> >
> >
> > On Tuesday, March 26, 2019, 2:46:08 p.m. GMT+9, Andrey Kuznetsov <
> > [hidden email]> wrote:
> >
> > Roman, I think the worst thing we can do is to hide the bug you
> > discovered. The sane options are either fix it urgently or classify it as
> > non-critical and postpone.
> > вт, 26 мар. 2019 г. в 05:13, Roman Shtykh <[hidden email]>:
> >
> > Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION
> > (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as
> > suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the
> > cluster down" thread?
> >
> > -- Roman
> >
> >
> > On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov <
> > [hidden email]> wrote:
> >
> > Hi Ignite Developers,
> >
> > So because nobody raised any feature I would like to call for scope
> freeze
> > for 2.7.5.
> >
> > The scope is limited with corruption fix, Java 11 issues addressed.
> > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5
> >
> > Also, launch scripts will be tested for Java 12.
> >
> > We entered the Rampdown phase. See more info in
> > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process
> >
> > Issues can be added to the scope only through discussion.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]
> >:
> >
> > > Hello!
> > >
> > > It seems that I can no longer test this case, on account of
> > >
> > >
> >
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> > > hanging every time under Java 11 on Windows.
> > >
> > > Alexey, Ivan, can you please take a look?
> > >
> > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > >
> > > Regards,
> > >
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <
> [hidden email]
> > >:
> > >
> > > > Hello!
> > > >
> > > > Basically there is a test that explicitly highlights this problem,
> that
> > > is
> > > > running SSL tests on Windows + Java 11. They will hang on Master but
> > pass
> > > > with this patch.
> > > >
> > > > I have started that on TC, results will probably be available later
> > > today:
> > > >
> > > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > > > (mind the Java version).
> > > >
> > > > Regards,
> > > > --
> > > > Ilya Kasnacheev
> > > >
> > > >
> > > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> > > >
> > > >> Dmitry, Ilya,
> > > >>
> > > >> Yes, I've looked through those changes [1] as they can affect my
> local
> > > >> PR. Basically, changes look good to me.
> > > >>
> > > >> I'm not an expert with CommunicationSpi component, so can miss some
> > > >> details and I haven't tested these changes under Java 11. One more
> > > >> thing I'd like to say, I would add additional tests to PR that will
> > > >> explicitly highlight the problem being solved.
> > > >>
> > > >>
> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> > > >>
> > > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> > > wrote:
> > > >> >
> > > >> > Hi Igniters,
> > > >> >
> > > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> > > wait
> > > >> on
> > > >> > processWrite during SSL handshake.
> > > >> > seems to be blocker cause it is related to Java 11
> > > >> >
> > > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> > comments
> > > >> > addressed?
> > > >> >
> > > >> > The ticket is in Patch Available. Reviewer needed. Changes located
> > in
> > > >> > GridNioServer.
> > > >> >
> > > >> > Sincerely,
> > > >> > Dmitriy Pavlov
> > > >> >
> > > >> > P.S. a quite obvious ticket came to sope, as well:
> > > >> > https://issues.apache.org/jira/browse/IGNITE-11600
> > > >> >
> > > >> >
> > > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> > > >> >
> > > >> > > Huge +1
> > > >> > >
> > > >> > > Will try to add new JDK in nearest time to our Teamcity.
> > > >> > >
> > > >> > >
> > > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> > > >> wrote:
> > > >> > > >
> > > >> > > > Hi Igniters,
> > > >> > > >
> > > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test
> our
> > > new
> > > >> tests
> > > >> > > > scripts with a couple of Java builds. WDYT?
> > > >> > > >
> > > >> > > > Sincerely,
> > > >> > > > Dmitriy Pavlov
> > > >> > > >
> > > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <
> [hidden email]
> > >:
> > > >> > > >
> > > >> > > >> Hi Ignite Developers,
> > > >> > > >>
> > > >> > > >> In a separate discussion, I've shared a log with all commits.
> > > >> > > >>
> > > >> > > >> As far as I can see, nobody removed commits from this sheet,
> so
> > > the
> > > >> > > scope
> > > >> > > >> of release will be discussed in another way: only explicitly
> > > >> declared
> > > >> > > >> commits will be cherry-picked.
> > > >> > > >>
> > > >> > > >> Sincerely,
> > > >> > > >> Dmitriy Pavlov
> > > >> > > >>
> > > >> > >
> > > >> > >
> > > >>
> > > >
> > >
> >
> >
> > --
> > Best regards,
> > Andrey Kuznetsov.
> >
>

Alexey Goncharuk

Re: Ignite 2.7.5 Release scope

In reply to this post by Ilya Kasnacheev

Hello Ilya,

I do not see any issues with the mentioned test. I see the following output
in the logs:

[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
Stopping test:
TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
in 37768 ms <<<
[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
Starting test class: IgniteClientConnectTest <<<

The issue with Windows may be long connection timeouts, in this case we
should either split the suite into multiple ones or decrease the SPI
timeouts.

пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:

Zhenya Stanilovsky

Ignite 2.7.5 Release scope

I suppose this ticket [1] : is very useful too.

[1] https://issues.apache.org/jira/browse/IGNITE-10873 [ CorruptedTreeException during simultaneous cache put operations ]

>
>
>------- Forwarded message -------
>From: "Alexey Goncharuk" < [hidden email] >
>To: dev < [hidden email] >
>Cc:
>Subject: Re: Ignite 2.7.5 Release scope
>Date: Tue, 26 Mar 2019 13:42:59 +0300
>
>Hello Ilya,
>
>I do not see any issues with the mentioned test. I see the following output
>in the logs:
>
>[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
>Stopping test:
>TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
>in 37768 ms <<<
>[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
>Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
>[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
>Starting test class: IgniteClientConnectTest <<<
>
>The issue with Windows may be long connection timeouts, in this case we
>should either split the suite into multiple ones or decrease the SPI
>timeouts.
>
>пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev < [hidden email] >:
>
>> Hello!
>>
>> It seems that I can no longer test this case, on account of
>>
>> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
>> hanging every time under Java 11 on Windows.
>>
>> Alexey, Ivan, can you please take a look?
>>
>>
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
>>
>> Regards,
>>
>> --
>> Ilya Kasnacheev
>>
>>
>> пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev < [hidden email] >:
>>
>> > Hello!
>> >
>> > Basically there is a test that explicitly highlights this problem, that
>> is
>> > running SSL tests on Windows + Java 11. They will hang on Master but
>> pass
>> > with this patch.
>> >
>> > I have started that on TC, results will probably be available later
>> today:
>> >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
>> > (mind the Java version).
>> >
>> > Regards,
>> > --
>> > Ilya Kasnacheev
>> >
>> >
>> > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov < [hidden email] >:
>> >
>> >> Dmitry, Ilya,
>> >>
>> >> Yes, I've looked through those changes [1] as they can affect my local
>> >> PR. Basically, changes look good to me.
>> >>
>> >> I'm not an expert with CommunicationSpi component, so can miss some
>> >> details and I haven't tested these changes under Java 11. One more
>> >> thing I'd like to say, I would add additional tests to PR that will
>> >> explicitly highlight the problem being solved.
>> >>
>> >>
>> >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
>> >>
>> >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov < [hidden email] >
>> wrote:
>> >> >
>> >> > Hi Igniters,
>> >> >
>> >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
>> wait
>> >> on
>> >> > processWrite during SSL handshake.
>> >> > seems to be blocker cause it is related to Java 11
>> >> >
>> >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
>> comments
>> >> > addressed?
>> >> >
>> >> > The ticket is in Patch Available. Reviewer needed. Changes located
>> in
>> >> > GridNioServer.
>> >> >
>> >> > Sincerely,
>> >> > Dmitriy Pavlov
>> >> >
>> >> > P.S. a quite obvious ticket came to sope, as well:
>> >> > https://issues.apache.org/jira/browse/IGNITE-11600
>> >> >
>> >> >
>> >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov < [hidden email] >:
>> >> >
>> >> > > Huge +1
>> >> > >
>> >> > > Will try to add new JDK in nearest time to our Teamcity.
>> >> > >
>> >> > >
>> >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov < [hidden email] >
>> >> wrote:
>> >> > > >
>> >> > > > Hi Igniters,
>> >> > > >
>> >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
>> new
>> >> tests
>> >> > > > scripts with a couple of Java builds. WDYT?
>> >> > > >
>> >> > > > Sincerely,
>> >> > > > Dmitriy Pavlov
>> >> > > >
>> >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov
>> < [hidden email] >:
>> >> > > >
>> >> > > >> Hi Ignite Developers,
>> >> > > >>
>> >> > > >> In a separate discussion, I've shared a log with all commits.
>> >> > > >>
>> >> > > >> As far as I can see, nobody removed commits from this sheet, so
>> the
>> >> > > scope
>> >> > > >> of release will be discussed in another way: only explicitly
>> >> declared
>> >> > > >> commits will be cherry-picked.
>> >> > > >>
>> >> > > >> Sincerely,
>> >> > > >> Dmitriy Pavlov
>> >> > > >>
>> >> > >
>> >> > >
>> >>
>> >

--
Zhenya Stanilovsky

Ilya Kasnacheev

Re: Ignite 2.7.5 Release scope

In reply to this post by Alexey Goncharuk

Hello.

Yes, locally this test seems to pass. However, no luck on TC. Maybe my
commit is positioned on top of especially unlucky HEAD.

Anyway, my point was thatTcpDiscoverySslTrustedUntrustedTest (or any other
intra-node SSL test) is a sufficient test for IGNITE-11299.

It will very reliably hang on Windows/Java 11 without patch and will always
pass with my patch (and TLSv1.2).

So no additional test is needed - we are testing a known regression here.

Regards,
--
Ilya Kasnacheev

вт, 26 мар. 2019 г. в 13:43, Alexey Goncharuk <[hidden email]>:

> Hello Ilya,
>
> I do not see any issues with the mentioned test. I see the following output
> in the logs:
>
> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
> Stopping test:
>
> TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
> in 37768 ms <<<
> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> Starting test class: IgniteClientConnectTest <<<
>
> The issue with Windows may be long connection timeouts, in this case we
> should either split the suite into multiple ones or decrease the SPI
> timeouts.
>
> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:
>
> > Hello!
> >
> > It seems that I can no longer test this case, on account of
> >
> >
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> > hanging every time under Java 11 on Windows.
> >
> > Alexey, Ivan, can you please take a look?
> >
> >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >
> > Regards,
> >
> > --
> > Ilya Kasnacheev
> >
> >
> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]
> >:
> >
> > > Hello!
> > >
> > > Basically there is a test that explicitly highlights this problem, that
> > is
> > > running SSL tests on Windows + Java 11. They will hang on Master but
> pass
> > > with this patch.
> > >
> > > I have started that on TC, results will probably be available later
> > today:
> > >
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> > > (mind the Java version).
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> > >
> > >> Dmitry, Ilya,
> > >>
> > >> Yes, I've looked through those changes [1] as they can affect my local
> > >> PR. Basically, changes look good to me.
> > >>
> > >> I'm not an expert with CommunicationSpi component, so can miss some
> > >> details and I haven't tested these changes under Java 11. One more
> > >> thing I'd like to say, I would add additional tests to PR that will
> > >> explicitly highlight the problem being solved.
> > >>
> > >>
> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> > >>
> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> > wrote:
> > >> >
> > >> > Hi Igniters,
> > >> >
> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> > wait
> > >> on
> > >> > processWrite during SSL handshake.
> > >> > seems to be blocker cause it is related to Java 11
> > >> >
> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> comments
> > >> > addressed?
> > >> >
> > >> > The ticket is in Patch Available. Reviewer needed. Changes located
> in
> > >> > GridNioServer.
> > >> >
> > >> > Sincerely,
> > >> > Dmitriy Pavlov
> > >> >
> > >> > P.S. a quite obvious ticket came to sope, as well:
> > >> > https://issues.apache.org/jira/browse/IGNITE-11600
> > >> >
> > >> >
> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> > >> >
> > >> > > Huge +1
> > >> > >
> > >> > > Will try to add new JDK in nearest time to our Teamcity.
> > >> > >
> > >> > >
> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
> > >> wrote:
> > >> > > >
> > >> > > > Hi Igniters,
> > >> > > >
> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
> > new
> > >> tests
> > >> > > > scripts with a couple of Java builds. WDYT?
> > >> > > >
> > >> > > > Sincerely,
> > >> > > > Dmitriy Pavlov
> > >> > > >
> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <[hidden email]
> >:
> > >> > > >
> > >> > > >> Hi Ignite Developers,
> > >> > > >>
> > >> > > >> In a separate discussion, I've shared a log with all commits.
> > >> > > >>
> > >> > > >> As far as I can see, nobody removed commits from this sheet, so
> > the
> > >> > > scope
> > >> > > >> of release will be discussed in another way: only explicitly
> > >> declared
> > >> > > >> commits will be cherry-picked.
> > >> > > >>
> > >> > > >> Sincerely,
> > >> > > >> Dmitriy Pavlov
> > >> > > >>
> > >> > >
> > >> > >
> > >>
> > >
> >
>

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

In reply to this post by Zhenya Stanilovsky

Hi,

I've cherry-picked this commit. It seems it is critical because it also
fixes storage corruption.

Sincerely,
Dmitriy Pavlov

вт, 26 мар. 2019 г. в 14:14, Zhenya Stanilovsky <[hidden email]
>:

> I suppose this ticket [1] : is very useful too.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-10873 [
> CorruptedTreeException during simultaneous cache put operations ]
>
> >
> >
> >------- Forwarded message -------
> >From: "Alexey Goncharuk" < [hidden email] >
> >To: dev < [hidden email] >
> >Cc:
> >Subject: Re: Ignite 2.7.5 Release scope
> >Date: Tue, 26 Mar 2019 13:42:59 +0300
> >
> >Hello Ilya,
> >
> >I do not see any issues with the mentioned test. I see the following
> output
> >in the logs:
> >
> >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
> >Stopping test:
>
> >TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
> >in 37768 ms <<<
> >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> >Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
> >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> >Starting test class: IgniteClientConnectTest <<<
> >
> >The issue with Windows may be long connection timeouts, in this case we
> >should either split the suite into multiple ones or decrease the SPI
> >timeouts.
> >
> >пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev < [hidden email]
> >:
> >
> >> Hello!
> >>
> >> It seems that I can no longer test this case, on account of
> >>
> >>
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> >> hanging every time under Java 11 on Windows.
> >>
> >> Alexey, Ivan, can you please take a look?
> >>
> >>
> >>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >>
> >> Regards,
> >>
> >> --
> >> Ilya Kasnacheev
> >>
> >>
> >> пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <
> [hidden email] >:
> >>
> >> > Hello!
> >> >
> >> > Basically there is a test that explicitly highlights this problem,
> that
> >> is
> >> > running SSL tests on Windows + Java 11. They will hang on Master but
> >> pass
> >> > with this patch.
> >> >
> >> > I have started that on TC, results will probably be available later
> >> today:
> >> >
> >> >
> >>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >> > (mind the Java version).
> >> >
> >> > Regards,
> >> > --
> >> > Ilya Kasnacheev
> >> >
> >> >
> >> > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov < [hidden email] >:
> >> >
> >> >> Dmitry, Ilya,
> >> >>
> >> >> Yes, I've looked through those changes [1] as they can affect my
> local
> >> >> PR. Basically, changes look good to me.
> >> >>
> >> >> I'm not an expert with CommunicationSpi component, so can miss some
> >> >> details and I haven't tested these changes under Java 11. One more
> >> >> thing I'd like to say, I would add additional tests to PR that will
> >> >> explicitly highlight the problem being solved.
> >> >>
> >> >>
> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> >> >>
> >> >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov < [hidden email] >
> >> wrote:
> >> >> >
> >> >> > Hi Igniters,
> >> >> >
> >> >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
> >> wait
> >> >> on
> >> >> > processWrite during SSL handshake.
> >> >> > seems to be blocker cause it is related to Java 11
> >> >> >
> >> >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> >> comments
> >> >> > addressed?
> >> >> >
> >> >> > The ticket is in Patch Available. Reviewer needed. Changes located
> >> in
> >> >> > GridNioServer.
> >> >> >
> >> >> > Sincerely,
> >> >> > Dmitriy Pavlov
> >> >> >
> >> >> > P.S. a quite obvious ticket came to sope, as well:
> >> >> > https://issues.apache.org/jira/browse/IGNITE-11600
> >> >> >
> >> >> >
> >> >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov < [hidden email] >:
> >> >> >
> >> >> > > Huge +1
> >> >> > >
> >> >> > > Will try to add new JDK in nearest time to our Teamcity.
> >> >> > >
> >> >> > >
> >> >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov < [hidden email]
> >
> >> >> wrote:
> >> >> > > >
> >> >> > > > Hi Igniters,
> >> >> > > >
> >> >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
> >> new
> >> >> tests
> >> >> > > > scripts with a couple of Java builds. WDYT?
> >> >> > > >
> >> >> > > > Sincerely,
> >> >> > > > Dmitriy Pavlov
> >> >> > > >
> >> >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov
> >> < [hidden email] >:
> >> >> > > >
> >> >> > > >> Hi Ignite Developers,
> >> >> > > >>
> >> >> > > >> In a separate discussion, I've shared a log with all commits.
> >> >> > > >>
> >> >> > > >> As far as I can see, nobody removed commits from this sheet,
> so
> >> the
> >> >> > > scope
> >> >> > > >> of release will be discussed in another way: only explicitly
> >> >> declared
> >> >> > > >> commits will be cherry-picked.
> >> >> > > >>
> >> >> > > >> Sincerely,
> >> >> > > >> Dmitriy Pavlov
> >> >> > > >>
> >> >> > >
> >> >> > >
> >> >>
> >> >
>
>
> --
> Zhenya Stanilovsky
>

Ilya Kasnacheev

Re: Ignite 2.7.5 Release scope

In reply to this post by Ilya Kasnacheev

Hello!

So after rebasing I was actually able to get it to pass:
https://ci.ignite.apache.org/viewLog.html?buildId=3431647&buildTypeId=IgniteTests24Java8_SpiWindows
- Java 11, passed
https://ci.ignite.apache.org/viewLog.html?buildId=3431619&buildTypeId=IgniteTests24Java8_SpiWindows
- Java 11 without fix, will fail every time

Regards,
--
Ilya Kasnacheev

вт, 26 мар. 2019 г. в 19:41, Ilya Kasnacheev <[hidden email]>:

> Hello.
>
> Yes, locally this test seems to pass. However, no luck on TC. Maybe my
> commit is positioned on top of especially unlucky HEAD.
>
> Anyway, my point was thatTcpDiscoverySslTrustedUntrustedTest (or any other
> intra-node SSL test) is a sufficient test for IGNITE-11299.
>
> It will very reliably hang on Windows/Java 11 without patch and will
> always pass with my patch (and TLSv1.2).
>
> So no additional test is needed - we are testing a known regression here.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 26 мар. 2019 г. в 13:43, Alexey Goncharuk <[hidden email]
> >:
>
>> Hello Ilya,
>>
>> I do not see any issues with the mentioned test. I see the following
>> output
>> in the logs:
>>
>> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
>> Stopping test:
>>
>> TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
>> in 37768 ms <<<
>> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
>> Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
>> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
>> Starting test class: IgniteClientConnectTest <<<
>>
>> The issue with Windows may be long connection timeouts, in this case we
>> should either split the suite into multiple ones or decrease the SPI
>> timeouts.
>>
>> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]>:
>>
>> > Hello!
>> >
>> > It seems that I can no longer test this case, on account of
>> >
>> >
>> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
>> > hanging every time under Java 11 on Windows.
>> >
>> > Alexey, Ivan, can you please take a look?
>> >
>> >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
>> >
>> > Regards,
>> >
>> > --
>> > Ilya Kasnacheev
>> >
>> >
>> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <[hidden email]
>> >:
>> >
>> > > Hello!
>> > >
>> > > Basically there is a test that explicitly highlights this problem,
>> that
>> > is
>> > > running SSL tests on Windows + Java 11. They will hang on Master but
>> pass
>> > > with this patch.
>> > >
>> > > I have started that on TC, results will probably be available later
>> > today:
>> > >
>> > >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
>> > > (mind the Java version).
>> > >
>> > > Regards,
>> > > --
>> > > Ilya Kasnacheev
>> > >
>> > >
>> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
>> > >
>> > >> Dmitry, Ilya,
>> > >>
>> > >> Yes, I've looked through those changes [1] as they can affect my
>> local
>> > >> PR. Basically, changes look good to me.
>> > >>
>> > >> I'm not an expert with CommunicationSpi component, so can miss some
>> > >> details and I haven't tested these changes under Java 11. One more
>> > >> thing I'd like to say, I would add additional tests to PR that will
>> > >> explicitly highlight the problem being solved.
>> > >>
>> > >>
>> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
>> > >>
>> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
>> > wrote:
>> > >> >
>> > >> > Hi Igniters,
>> > >> >
>> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy
>> > wait
>> > >> on
>> > >> > processWrite during SSL handshake.
>> > >> > seems to be blocker cause it is related to Java 11
>> > >> >
>> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
>> comments
>> > >> > addressed?
>> > >> >
>> > >> > The ticket is in Patch Available. Reviewer needed. Changes located
>> in
>> > >> > GridNioServer.
>> > >> >
>> > >> > Sincerely,
>> > >> > Dmitriy Pavlov
>> > >> >
>> > >> > P.S. a quite obvious ticket came to sope, as well:
>> > >> > https://issues.apache.org/jira/browse/IGNITE-11600
>> > >> >
>> > >> >
>> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
>> > >> >
>> > >> > > Huge +1
>> > >> > >
>> > >> > > Will try to add new JDK in nearest time to our Teamcity.
>> > >> > >
>> > >> > >
>> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]>
>> > >> wrote:
>> > >> > > >
>> > >> > > > Hi Igniters,
>> > >> > > >
>> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our
>> > new
>> > >> tests
>> > >> > > > scripts with a couple of Java builds. WDYT?
>> > >> > > >
>> > >> > > > Sincerely,
>> > >> > > > Dmitriy Pavlov
>> > >> > > >
>> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <
>> [hidden email]>:
>> > >> > > >
>> > >> > > >> Hi Ignite Developers,
>> > >> > > >>
>> > >> > > >> In a separate discussion, I've shared a log with all commits.
>> > >> > > >>
>> > >> > > >> As far as I can see, nobody removed commits from this sheet,
>> so
>> > the
>> > >> > > scope
>> > >> > > >> of release will be discussed in another way: only explicitly
>> > >> declared
>> > >> > > >> commits will be cherry-picked.
>> > >> > > >>
>> > >> > > >> Sincerely,
>> > >> > > >> Dmitriy Pavlov
>> > >> > > >>
>> > >> > >
>> > >> > >
>> > >>
>> > >
>> >
>>
>

Dmitry Pavlov

Re: Ignite 2.7.5 Release scope

I've played with 2.7.5-RC-1 and Java 12, and unfortunately, Ignite can't
start without changes:

Exception in thread "main" java.lang.ExceptionInInitializerError
at
org.apache.ignite.internal.util.IgniteUtils.<clinit>(IgniteUtils.java:795)
at org.apache.ignite.internal.IgnitionEx.<clinit>(IgnitionEx.java:209)
at org.apache.ignite.Ignition.start(Ignition.java:348)
at
org.apache.ignite.examples.ExampleNodeStartup.main(ExampleNodeStartup.java:34)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131)
Caused by: java.lang.RuntimeException: jdk.internal.misc.JavaNioAccess
class is unavailable.
at
org.apache.ignite.internal.util.GridUnsafe.javaNioAccessObject(GridUnsafe.java:1453)
at org.apache.ignite.internal.util.GridUnsafe.<clinit>(GridUnsafe.java:112)
... 9 more
Caused by: java.lang.ClassNotFoundException: jdk.internal.misc.SharedSecrets
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:332)
at
org.apache.ignite.internal.util.GridUnsafe.javaNioAccessObject(GridUnsafe.java:1446)
... 10 more

I'm not sure we can workaround it. So probably fix with JDK.ver>11 is not
correct because for 12 we need some changes.

ср, 27 мар. 2019 г. в 17:44, Ilya Kasnacheev <[hidden email]>:

> Hello!
>
> So after rebasing I was actually able to get it to pass:
>
> https://ci.ignite.apache.org/viewLog.html?buildId=3431647&buildTypeId=IgniteTests24Java8_SpiWindows
> - Java 11, passed
>
> https://ci.ignite.apache.org/viewLog.html?buildId=3431619&buildTypeId=IgniteTests24Java8_SpiWindows
> - Java 11 without fix, will fail every time
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 26 мар. 2019 г. в 19:41, Ilya Kasnacheev <[hidden email]>:
>
> > Hello.
> >
> > Yes, locally this test seems to pass. However, no luck on TC. Maybe my
> > commit is positioned on top of especially unlucky HEAD.
> >
> > Anyway, my point was thatTcpDiscoverySslTrustedUntrustedTest (or any
> other
> > intra-node SSL test) is a sufficient test for IGNITE-11299.
> >
> > It will very reliably hang on Windows/Java 11 without patch and will
> > always pass with my patch (and TLSv1.2).
> >
> > So no additional test is needed - we are testing a known regression here.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > вт, 26 мар. 2019 г. в 13:43, Alexey Goncharuk <
> [hidden email]
> > >:
> >
> >> Hello Ilya,
> >>
> >> I do not see any issues with the mentioned test. I see the following
> >> output
> >> in the logs:
> >>
> >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>>
> >> Stopping test:
> >>
> >>
> TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode
> >> in 37768 ms <<<
> >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> >> Stopping test class: TcpDiscoveryCoordinatorFailureTest <<<
> >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>>
> >> Starting test class: IgniteClientConnectTest <<<
> >>
> >> The issue with Windows may be long connection timeouts, in this case we
> >> should either split the suite into multiple ones or decrease the SPI
> >> timeouts.
> >>
> >> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[hidden email]
> >:
> >>
> >> > Hello!
> >> >
> >> > It seems that I can no longer test this case, on account of
> >> >
> >> >
> >>
> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized
> >> > hanging every time under Java 11 on Windows.
> >> >
> >> > Alexey, Ivan, can you please take a look?
> >> >
> >> >
> >> >
> >>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >> >
> >> > Regards,
> >> >
> >> > --
> >> > Ilya Kasnacheev
> >> >
> >> >
> >> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <
> [hidden email]
> >> >:
> >> >
> >> > > Hello!
> >> > >
> >> > > Basically there is a test that explicitly highlights this problem,
> >> that
> >> > is
> >> > > running SSL tests on Windows + Java 11. They will hang on Master but
> >> pass
> >> > > with this patch.
> >> > >
> >> > > I have started that on TC, results will probably be available later
> >> > today:
> >> > >
> >> > >
> >> >
> >>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__
> >> > > (mind the Java version).
> >> > >
> >> > > Regards,
> >> > > --
> >> > > Ilya Kasnacheev
> >> > >
> >> > >
> >> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[hidden email]>:
> >> > >
> >> > >> Dmitry, Ilya,
> >> > >>
> >> > >> Yes, I've looked through those changes [1] as they can affect my
> >> local
> >> > >> PR. Basically, changes look good to me.
> >> > >>
> >> > >> I'm not an expert with CommunicationSpi component, so can miss some
> >> > >> details and I haven't tested these changes under Java 11. One more
> >> > >> thing I'd like to say, I would add additional tests to PR that will
> >> > >> explicitly highlight the problem being solved.
> >> > >>
> >> > >>
> >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299
> >> > >>
> >> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[hidden email]>
> >> > wrote:
> >> > >> >
> >> > >> > Hi Igniters,
> >> > >> >
> >> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid
> busy
> >> > wait
> >> > >> on
> >> > >> > processWrite during SSL handshake.
> >> > >> > seems to be blocker cause it is related to Java 11
> >> > >> >
> >> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these
> >> comments
> >> > >> > addressed?
> >> > >> >
> >> > >> > The ticket is in Patch Available. Reviewer needed. Changes
> located
> >> in
> >> > >> > GridNioServer.
> >> > >> >
> >> > >> > Sincerely,
> >> > >> > Dmitriy Pavlov
> >> > >> >
> >> > >> > P.S. a quite obvious ticket came to sope, as well:
> >> > >> > https://issues.apache.org/jira/browse/IGNITE-11600
> >> > >> >
> >> > >> >
> >> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[hidden email]>:
> >> > >> >
> >> > >> > > Huge +1
> >> > >> > >
> >> > >> > > Will try to add new JDK in nearest time to our Teamcity.
> >> > >> > >
> >> > >> > >
> >> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[hidden email]
> >
> >> > >> wrote:
> >> > >> > > >
> >> > >> > > > Hi Igniters,
> >> > >> > > >
> >> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test
> our
> >> > new
> >> > >> tests
> >> > >> > > > scripts with a couple of Java builds. WDYT?
> >> > >> > > >
> >> > >> > > > Sincerely,
> >> > >> > > > Dmitriy Pavlov
> >> > >> > > >
> >> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <
> >> [hidden email]>:
> >> > >> > > >
> >> > >> > > >> Hi Ignite Developers,
> >> > >> > > >>
> >> > >> > > >> In a separate discussion, I've shared a log with all
> commits.
> >> > >> > > >>
> >> > >> > > >> As far as I can see, nobody removed commits from this sheet,
> >> so
> >> > the
> >> > >> > > scope
> >> > >> > > >> of release will be discussed in another way: only explicitly
> >> > >> declared
> >> > >> > > >> commits will be cherry-picked.
> >> > >> > > >>
> >> > >> > > >> Sincerely,
> >> > >> > > >> Dmitriy Pavlov
> >> > >> > > >>
> >> > >> > >
> >> > >> > >
> >> > >>
> >> > >
> >> >
> >>
> >
>

123