Apache Ignite Developers - Legacy Mail Archive

IGNITE-6252 patch

Classic

List

Threaded

8 messages Options

Sunny Chan, CLSA

IGNITE-6252 patch

Hello,

During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable?

Thanks.
The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
CLSA is ISO14001 certified and committed to reducing environmental impact.

dmagda

Re: IGNITE-6252 patch (Cassandra Integration Bug Fix)

Hi, thanks for the contribution!

Igor R., could you review the change?

—
Denis

> On Oct 30, 2017, at 12:57 AM, Sunny Chan, CLSA <[hidden email]> wrote:
>
> Hello,
>
> During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable?
>
> Thanks.
> The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
> CLSA is ISO14001 certified and committed to reducing environmental impact.

Nikolai Tikhonov

Re: IGNITE-6252 patch

In reply to this post by Sunny Chan, CLSA

Hello,

Thank you for your contribution! I've reviewed your changes and left
comment to ticket. Could you look jira https://issues.apache.org/
jira/browse/IGNITE-6252?

On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <[hidden email]>
wrote:

> Hello,
>
> During our testing we have found an issue and I have raised a JIRA ticket
> https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a
> patch that would fix the issue. Could someone take a look and see whether
> the patch is acceptable?
>
> Thanks.
> The content of this communication is intended for the recipient and is
> subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to
> you upon request.
> CLSA is ISO14001 certified and committed to reducing environmental impact.
>

Sunny Chan, CLSA

RE: IGNITE-6252 patch

I have reviewed and it looks good.

From: Nikolai Tikhonov [mailto:[hidden email]]
Sent: Tuesday, October 31, 2017 11:50 PM
To: [hidden email]; Sunny Chan, CLSA
Subject: Re: IGNITE-6252 patch

Hello,

Thank you for your contribution! I've reviewed your changes and left comment to ticket. Could you look jira https://issues.apache.org/jira/browse/IGNITE-6252?

On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <[hidden email]<mailto:[hidden email]>> wrote:
Hello,

During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable?

Thanks.
The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
CLSA is ISO14001 certified and committed to reducing environmental impact.

The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
CLSA is ISO14001 certified and committed to reducing environmental impact.

Sunny Chan, CLSA

RE: IGNITE-6252 patch

In reply to this post by Nikolai Tikhonov

Hello,

I have replied to the comment in November and I am okay with your updated patch – what do I need to do to move this forward?

From: Nikolai Tikhonov [mailto:[hidden email]]
Sent: Tuesday, October 31, 2017 11:50 PM
To: [hidden email]; Sunny Chan, CLSA
Subject: Re: IGNITE-6252 patch

Hello,

Thank you for your contribution! I've reviewed your changes and left comment to ticket. Could you look jira https://issues.apache.org/jira/browse/IGNITE-6252?

On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <[hidden email]<mailto:[hidden email]>> wrote:
Hello,

During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable?

Thanks.
The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
CLSA is ISO14001 certified and committed to reducing environmental impact.

The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
CLSA is ISO14001 certified and committed to reducing environmental impact.

dmagda

Re: IGNITE-6252 patch

Hello,

I hope Igor R. will review the changes as soon as prolonged holidays are over.

—
Denis

> On Jan 2, 2018, at 5:24 PM, Sunny Chan, CLSA <[hidden email]> wrote:
>
> Hello,
>
> I have replied to the comment in November and I am okay with your updated patch – what do I need to do to move this forward?
>
> From: Nikolai Tikhonov [mailto:[hidden email]]
> Sent: Tuesday, October 31, 2017 11:50 PM
> To: [hidden email]; Sunny Chan, CLSA
> Subject: Re: IGNITE-6252 patch
>
> Hello,
>
> Thank you for your contribution! I've reviewed your changes and left comment to ticket. Could you look jira https://issues.apache.org/jira/browse/IGNITE-6252?
>
> On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <[hidden email]<mailto:[hidden email]>> wrote:
> Hello,
>
> During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable?
>
> Thanks.
> The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
> CLSA is ISO14001 certified and committed to reducing environmental impact.
>
> The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
> CLSA is ISO14001 certified and committed to reducing environmental impact.

Sunny Chan, CLSA

RE: IGNITE-6252 patch

Hi Igor,

Any luck with the review and merge of the patch?

Thanks

-----Original Message-----
From: Denis Magda [mailto:[hidden email]]
Sent: Friday, January 05, 2018 4:29 AM
To: [hidden email]; Igor Rudyak
Cc: Nikolai Tikhonov
Subject: Re: IGNITE-6252 patch

Hello,

I hope Igor R. will review the changes as soon as prolonged holidays are over.

—
Denis

The content of this communication is intended for the recipient and is subject to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
Please consider before printing. CLSA is ISO14001 certified and committed to reducing its impact on the environment.

irudyak

Re: IGNITE-6252 patch

Hi Sunny,

Thanks for the notification. Just found this PR. Will review it a bit later.

Igor

On Tue, Jan 16, 2018 at 7:15 PM, Sunny Chan, CLSA <[hidden email]>
wrote:

> Hi Igor,
>
> Any luck with the review and merge of the patch?
>
> Thanks
>
> -----Original Message-----
> From: Denis Magda [mailto:[hidden email]]
> Sent: Friday, January 05, 2018 4:29 AM
> To: [hidden email]; Igor Rudyak
> Cc: Nikolai Tikhonov
> Subject: Re: IGNITE-6252 patch
>
> Hello,
>
> I hope Igor R. will review the changes as soon as prolonged holidays are
> over.
>
> —
> Denis
>
> > On Jan 2, 2018, at 5:24 PM, Sunny Chan, CLSA <[hidden email]>
> wrote:
> >
> > Hello,
> >
> > I have replied to the comment in November and I am okay with your
> updated patch – what do I need to do to move this forward?
> >
> > From: Nikolai Tikhonov [mailto:[hidden email]]
> > Sent: Tuesday, October 31, 2017 11:50 PM
> > To: [hidden email]; Sunny Chan, CLSA
> > Subject: Re: IGNITE-6252 patch
> >
> > Hello,
> >
> > Thank you for your contribution! I've reviewed your changes and left
> comment to ticket. Could you look jira https://issues.apache.org/
> jira/browse/IGNITE-6252?
> >
> > On Mon, Oct 30, 2017 at 10:57 AM, Sunny Chan, CLSA <[hidden email]
> <mailto:[hidden email]>> wrote:
> > Hello,
> >
> > During our testing we have found an issue and I have raised a JIRA
> ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also
> provided a patch that would fix the issue. Could someone take a look and
> see whether the patch is acceptable?
> >
> > Thanks.
> > The content of this communication is intended for the recipient and is
> subject to CLSA Legal and Regulatory Notices.
> > These can be viewed at https://www.clsa.com/disclaimer.html or sent to
> you upon request.
> > CLSA is ISO14001 certified and committed to reducing environmental
> impact.
> >
> > The content of this communication is intended for the recipient and is
> subject to CLSA Legal and Regulatory Notices.
> > These can be viewed at https://www.clsa.com/disclaimer.html or sent to
> you upon request.
> > CLSA is ISO14001 certified and committed to reducing environmental
> impact.
>
>
> The content of this communication is intended for the recipient and is
> subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to
> you upon request.
> Please consider before printing. CLSA is ISO14001 certified and committed
> to reducing its impact on the environment.
>