Raul,
Here are my comments on jms streamer readme io article.
Can you please fix them?
1. "Features supported" and "Instantiating a JMS Streamer" sections both
contain description of streamer parameters. It seems to be a better
approach to organize all streamer properties as table with description,
allowed and default values (see for example
https://apacheignite.readme.io/v1.4/docs/jdbc-driver#jdbc-connection). Both
mentioned sections can be merged into one "Configuration" section.
2. "Instantiating a JMS Streamer" sections describes class parameters. It
seems that Javadoc is better place for it.
3. Example doesn't conform project coding guidelines (
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines).
Thanks!
--Yakov
2015-09-20 21:55 GMT+03:00 Raul Kripalani <
[hidden email]>:
> Hey guys,
>
> I've documented this feature on readme.io, on branch 1.4:
>
https://apacheignite.readme.io/v1.4/docs/jms-data-streamer.
>
> Since this is the first piece of document I contribute, your suggestions
> are welcome.
>
> Regards,
>
> *Raúl Kripalani*
> Apache Camel PMC Member & Committer | Enterprise Architect, Open Source
> Integration specialist
>
http://about.me/raulkripalani |
http://www.linkedin.com/in/raulkripalani>
http://blog.raulkr.net | twitter: @raulvk
>
> On Mon, Aug 10, 2015 at 5:35 PM, Dmitriy Setrakyan <
[hidden email]>
> wrote:
>
> > Hi Raul,
> >
> > Thanks for your contribution!
> >
> > Hope some of the committers can pick this up for a review soon.
> >
> > D.
> >
> > On Sat, Aug 8, 2015 at 4:12 PM, Raul Kripalani <
[hidden email]> wrote:
> >
> > > Hey guys,
> > >
> > > Work completed on this one. Sent in a pull request via Github.
> > >
> > > Regards,
> > >
> > > *Raúl Kripalani*
> > > Apache Camel PMC Member & Committer | Enterprise Architect, Open Source
> > > Integration specialist
> > >
http://about.me/raulkripalani |
>
http://www.linkedin.com/in/raulkripalani> > >
http://blog.raulkr.net | twitter: @raulvk
> > >
> >
>
Locked
