Apache Ignite Developers - Legacy Mail Archive

IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Classic

List

Threaded

25 messages Options

Roman Shtykh

IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Igniters,
Please review the issue.https://issues.apache.org/jira/browse/IGNITE-3066

Thank you,Roman

Denis Magda

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman,

Would you mind making a pull-request? It’s not clear and easy to review using the branch you provided
https://github.com/apache/ignite/tree/ignite-2788 <https://github.com/apache/ignite/tree/ignite-2788>

This link provides details how to achieve this
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request>

Let us know if you have any issue preparing the pull-request.

—
Denis

> On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]> wrote:
>
> Igniters,
> Please review the issue.https://issues.apache.org/jira/browse/IGNITE-3066
>
> Thank you,Roman

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Denis,
It is https://github.com/apache/ignite/pull/1212

Thank you,
Roman

On Saturday, November 5, 2016 4:56 AM, Denis Magda <[hidden email]> wrote:

Roman,

Would you mind making a pull-request? It’s not clear and easy to review using the branch you provided
https://github.com/apache/ignite/tree/ignite-2788 <https://github.com/apache/ignite/tree/ignite-2788>

This link provides details how to achieve this
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request>

Let us know if you have any issue preparing the pull-request.

—
Denis

> On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]> wrote:
>
> Igniters,
> Please review the issue.https://issues.apache.org/jira/browse/IGNITE-3066
>
> Thank you,Roman

Alexey Kuznetsov

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

I will take a look on PR today.

On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh <[hidden email]>
wrote:

> Denis,
> It is https://github.com/apache/ignite/pull/1212
>
> Thank you,
> Roman
>
>
> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> [hidden email]> wrote:
>
>
> Roman,
>
> Would you mind making a pull-request? It’s not clear and easy to review
> using the branch you provided
> https://github.com/apache/ignite/tree/ignite-2788 <
> https://github.com/apache/ignite/tree/ignite-2788>
>
> This link provides details how to achieve this
> https://cwiki.apache.org/confluence/display/IGNITE/How+
> to+Contribute#HowtoContribute-1.CreateGitHubpull-request <
> https://cwiki.apache.org/confluence/display/IGNITE/How+
> to+Contribute#HowtoContribute-1.CreateGitHubpull-request>
>
> Let us know if you have any issue preparing the pull-request.
>
> —
> Denis
>
> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]>
> wrote:
> >
> > Igniters,
> > Please review the issue.https://issues.apache.
> org/jira/browse/IGNITE-3066
> >
> > Thank you,Roman
>
>
>
>

--
Alexey Kuznetsov

Alexey Kuznetsov

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman,

I made one more review, see my comments in JIRA issue.

On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <[hidden email]>
wrote:

> I will take a look on PR today.
>
> On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh <[hidden email]>
> wrote:
>
>> Denis,
>> It is https://github.com/apache/ignite/pull/1212
>>
>> Thank you,
>> Roman
>>
>>
>> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
>> [hidden email]> wrote:
>>
>>
>> Roman,
>>
>> Would you mind making a pull-request? It’s not clear and easy to review
>> using the branch you provided
>> https://github.com/apache/ignite/tree/ignite-2788 <
>> https://github.com/apache/ignite/tree/ignite-2788>
>>
>> This link provides details how to achieve this
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
>> Contribute#HowtoContribute-1.CreateGitHubpull-request <
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
>> Contribute#HowtoContribute-1.CreateGitHubpull-request>
>>
>> Let us know if you have any issue preparing the pull-request.
>>
>> —
>> Denis
>>
>> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]>
>> wrote:
>> >
>> > Igniters,
>> > Please review the issue.https://issues.apache.or
>> g/jira/browse/IGNITE-3066
>> >
>> > Thank you,Roman
>>
>>
>>
>>
>
>
>
> --
> Alexey Kuznetsov
>

--
Alexey Kuznetsov

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Alexey,
Thank you!I answered and pushed the changes.
-Roman

On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <[hidden email]> wrote:

Roman,

I made one more review, see my comments in JIRA issue.

On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <[hidden email]>
wrote:

--
Alexey Kuznetsov

Alexey Kuznetsov

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman,

I reviewed your code and now it looks good for me.
But I added two minor comments in JIRA.

Also I think Andrey Novikov should take a look, as he has some experience
in ignite-rest module.

Andrey, take a look:

Issue: https://issues.apache.org/jira/browse/IGNITE-3066
PR: https://github.com/apache/ignite/pull/1212

On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh <[hidden email]>
wrote:

> Alexey,
> Thank you!I answered and pushed the changes.
> -Roman
>
>
> On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> [hidden email]> wrote:
>
>
> Roman,
>
> I made one more review, see my comments in JIRA issue.
>
> On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <[hidden email]>
> wrote:
>
> > I will take a look on PR today.
> >
> > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh <[hidden email]
> >
> > wrote:
> >
> >> Denis,
> >> It is https://github.com/apache/ignite/pull/1212
> >>
> >> Thank you,
> >> Roman
> >>
> >>
> >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> >> [hidden email]> wrote:
> >>
> >>
> >> Roman,
> >>
> >> Would you mind making a pull-request? It’s not clear and easy to review
> >> using the branch you provided
> >> https://github.com/apache/ignite/tree/ignite-2788 <
> >> https://github.com/apache/ignite/tree/ignite-2788>
> >>
> >> This link provides details how to achieve this
> >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> >>
> >> Let us know if you have any issue preparing the pull-request.
> >>
> >> —
> >> Denis
> >>
> >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]>
> >> wrote:
> >> >
> >> > Igniters,
> >> > Please review the issue.https://issues.apache.or
> >> g/jira/browse/IGNITE-3066
> >> >
> >> > Thank you,Roman
> >>
> >>
> >>
> >>
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
>
>
>
> --
> Alexey Kuznetsov
>
>
>

--
Alexey Kuznetsov

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Alexey,
Thank you for your thorough reviews! I fixed the issues.
-Roman

On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <[hidden email]> wrote:

Roman,

I reviewed your code and now it looks good for me.
But I added two minor comments in JIRA.

Also I think Andrey Novikov should take a look, as he has some experience
in ignite-rest module.

Andrey, take a look:

Issue: https://issues.apache.org/jira/browse/IGNITE-3066
PR: https://github.com/apache/ignite/pull/1212

On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh <[hidden email]>
wrote:

--
Alexey Kuznetsov

Andrey Novikov-3

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman,

I reviewed your code and added comments in JIRA.

May we will try to use Upsource (http://reviews.ignite.apache.org/) for code
review?

On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh <[hidden email]>
wrote:

> Alexey,
> Thank you for your thorough reviews! I fixed the issues.
> -Roman
>
>
> On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> [hidden email]> wrote:
>
>
> Roman,
>
> I reviewed your code and now it looks good for me.
> But I added two minor comments in JIRA.
>
> Also I think Andrey Novikov should take a look, as he has some experience
> in ignite-rest module.
>
> Andrey, take a look:
>
> Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> PR: https://github.com/apache/ignite/pull/1212
>
>
> On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> > Alexey,
> > Thank you!I answered and pushed the changes.
> > -Roman
> >
> >
> > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > [hidden email]> wrote:
> >
> >
> > Roman,
> >
> > I made one more review, see my comments in JIRA issue.
> >
> > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <[hidden email]>
> > wrote:
> >
> > > I will take a look on PR today.
> > >
> > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > >> Denis,
> > >> It is https://github.com/apache/ignite/pull/1212
> > >>
> > >> Thank you,
> > >> Roman
> > >>
> > >>
> > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > >> [hidden email]> wrote:
> > >>
> > >>
> > >> Roman,
> > >>
> > >> Would you mind making a pull-request? It’s not clear and easy to
> review
> > >> using the branch you provided
> > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > >> https://github.com/apache/ignite/tree/ignite-2788>
> > >>
> > >> This link provides details how to achieve this
> > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > >>
> > >> Let us know if you have any issue preparing the pull-request.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]
> >
> > >> wrote:
> > >> >
> > >> > Igniters,
> > >> > Please review the issue.https://issues.apache.or
> > >> g/jira/browse/IGNITE-3066
> > >> >
> > >> > Thank you,Roman
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
> >
> >
>
>
>
> --
> Alexey Kuznetsov
>
>
>

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Andrey,
Sure, but I couldn't sign up -- "Cannot complete request due to license limitations."Let's use github for now.
Thank you for your review!
-Roman

On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <[hidden email]> wrote:

Roman,

I reviewed your code and added comments in JIRA.

May we will try to use Upsource (http://reviews.ignite.apache.org/) for code
review?

On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh <[hidden email]>
wrote:

Andrey Novikov-3

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman,

I reviewed your PR. Changed it a little and merged to master.
Thanks for your contribution!

On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh <[hidden email]>
wrote:

> Andrey,
> Sure, but I couldn't sign up -- "Cannot complete request due to license
> limitations."Let's use github for now.
> Thank you for your review!
> -Roman
>
>
> On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> [hidden email]> wrote:
>
>
> Roman,
>
> I reviewed your code and added comments in JIRA.
>
> May we will try to use Upsource (http://reviews.ignite.apache.org/) for
> code
> review?
>
>
> On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh <[hidden email]>
> wrote:
>
> > Alexey,
> > Thank you for your thorough reviews! I fixed the issues.
> > -Roman
> >
> >
> > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > [hidden email]> wrote:
> >
> >
> > Roman,
> >
> > I reviewed your code and now it looks good for me.
> > But I added two minor comments in JIRA.
> >
> > Also I think Andrey Novikov should take a look, as he has some experience
> > in ignite-rest module.
> >
> > Andrey, take a look:
> >
> > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > PR: https://github.com/apache/ignite/pull/1212
> >
> >
> > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh <[hidden email]
> >
> > wrote:
> >
> > > Alexey,
> > > Thank you!I answered and pushed the changes.
> > > -Roman
> > >
> > >
> > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > [hidden email]> wrote:
> > >
> > >
> > > Roman,
> > >
> > > I made one more review, see my comments in JIRA issue.
> > >
> > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> [hidden email]>
> > > wrote:
> > >
> > > > I will take a look on PR today.
> > > >
> > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > >> Denis,
> > > >> It is https://github.com/apache/ignite/pull/1212
> > > >>
> > > >> Thank you,
> > > >> Roman
> > > >>
> > > >>
> > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > >> [hidden email]> wrote:
> > > >>
> > > >>
> > > >> Roman,
> > > >>
> > > >> Would you mind making a pull-request? It’s not clear and easy to
> > review
> > > >> using the branch you provided
> > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > >>
> > > >> This link provides details how to achieve this
> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > >>
> > > >> Let us know if you have any issue preparing the pull-request.
> > > >>
> > > >> —
> > > >> Denis
> > > >>
> > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> <[hidden email]
> > >
> > > >> wrote:
> > > >> >
> > > >> > Igniters,
> > > >> > Please review the issue.https://issues.apache.or
> > > >> g/jira/browse/IGNITE-3066
> > > >> >
> > > >> > Thank you,Roman
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
> >
> >
>
>
>

dsetrakyan

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman, thanks for the contribution! Is there a documentation where I can
read about the supported Redis commands?

On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
wrote:

> Roman,
>
> I reviewed your PR. Changed it a little and merged to master.
> Thanks for your contribution!
>
> On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> > Andrey,
> > Sure, but I couldn't sign up -- "Cannot complete request due to license
> > limitations."Let's use github for now.
> > Thank you for your review!
> > -Roman
> >
> >
> > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > [hidden email]> wrote:
> >
> >
> > Roman,
> >
> > I reviewed your code and added comments in JIRA.
> >
> > May we will try to use Upsource (http://reviews.ignite.apache.org/) for
> > code
> > review?
> >
> >
> > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh <[hidden email]
> >
> > wrote:
> >
> > > Alexey,
> > > Thank you for your thorough reviews! I fixed the issues.
> > > -Roman
> > >
> > >
> > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > [hidden email]> wrote:
> > >
> > >
> > > Roman,
> > >
> > > I reviewed your code and now it looks good for me.
> > > But I added two minor comments in JIRA.
> > >
> > > Also I think Andrey Novikov should take a look, as he has some
> experience
> > > in ignite-rest module.
> > >
> > > Andrey, take a look:
> > >
> > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > PR: https://github.com/apache/ignite/pull/1212
> > >
> > >
> > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > > > Alexey,
> > > > Thank you!I answered and pushed the changes.
> > > > -Roman
> > > >
> > > >
> > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > [hidden email]> wrote:
> > > >
> > > >
> > > > Roman,
> > > >
> > > > I made one more review, see my comments in JIRA issue.
> > > >
> > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > [hidden email]>
> > > > wrote:
> > > >
> > > > > I will take a look on PR today.
> > > > >
> > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > >> Denis,
> > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > >>
> > > > >> Thank you,
> > > > >> Roman
> > > > >>
> > > > >>
> > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > >> [hidden email]> wrote:
> > > > >>
> > > > >>
> > > > >> Roman,
> > > > >>
> > > > >> Would you mind making a pull-request? It’s not clear and easy to
> > > review
> > > > >> using the branch you provided
> > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > >>
> > > > >> This link provides details how to achieve this
> > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > >>
> > > > >> Let us know if you have any issue preparing the pull-request.
> > > > >>
> > > > >> —
> > > > >> Denis
> > > > >>
> > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > >> wrote:
> > > > >> >
> > > > >> > Igniters,
> > > > >> > Please review the issue.https://issues.apache.or
> > > > >> g/jira/browse/IGNITE-3066
> > > > >> >
> > > > >> > Thank you,Roman
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> > >
> > >
> >
> >
> >
>

Andrey Novikov-3

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Dmitriy,

At this moment supported command can be found in ticket description:
https://issues.apache.org/jira/browse/IGNITE-3066
I think we shout add section for REDIS support on apacheignite.readme.io
like for memcache
Create ticket for documentation:
https://issues.apache.org/jira/browse/IGNITE-4233

On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <[hidden email]>
wrote:

> Roman, thanks for the contribution! Is there a documentation where I can
> read about the supported Redis commands?
>
> On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> wrote:
>
> > Roman,
> >
> > I reviewed your PR. Changed it a little and merged to master.
> > Thanks for your contribution!
> >
> > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh <[hidden email]
> >
> > wrote:
> >
> > > Andrey,
> > > Sure, but I couldn't sign up -- "Cannot complete request due to license
> > > limitations."Let's use github for now.
> > > Thank you for your review!
> > > -Roman
> > >
> > >
> > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > [hidden email]> wrote:
> > >
> > >
> > > Roman,
> > >
> > > I reviewed your code and added comments in JIRA.
> > >
> > > May we will try to use Upsource (http://reviews.ignite.apache.org/)
> for
> > > code
> > > review?
> > >
> > >
> > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > > > Alexey,
> > > > Thank you for your thorough reviews! I fixed the issues.
> > > > -Roman
> > > >
> > > >
> > > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > [hidden email]> wrote:
> > > >
> > > >
> > > > Roman,
> > > >
> > > > I reviewed your code and now it looks good for me.
> > > > But I added two minor comments in JIRA.
> > > >
> > > > Also I think Andrey Novikov should take a look, as he has some
> > experience
> > > > in ignite-rest module.
> > > >
> > > > Andrey, take a look:
> > > >
> > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > PR: https://github.com/apache/ignite/pull/1212
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you!I answered and pushed the changes.
> > > > > -Roman
> > > > >
> > > > >
> > > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > > Roman,
> > > > >
> > > > > I made one more review, see my comments in JIRA issue.
> > > > >
> > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > [hidden email]>
> > > > > wrote:
> > > > >
> > > > > > I will take a look on PR today.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Denis,
> > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > >>
> > > > > >> Thank you,
> > > > > >> Roman
> > > > > >>
> > > > > >>
> > > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > >> [hidden email]> wrote:
> > > > > >>
> > > > > >>
> > > > > >> Roman,
> > > > > >>
> > > > > >> Would you mind making a pull-request? It’s not clear and easy to
> > > > review
> > > > > >> using the branch you provided
> > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > >>
> > > > > >> This link provides details how to achieve this
> > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > >>
> > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > >>
> > > > > >> —
> > > > > >> Denis
> > > > > >>
> > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > >> wrote:
> > > > > >> >
> > > > > >> > Igniters,
> > > > > >> > Please review the issue.https://issues.apache.or
> > > > > >> g/jira/browse/IGNITE-3066
> > > > > >> >
> > > > > >> > Thank you,Roman
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > > >
> > > >
> > >
> > >
> > >
> >
>

dsetrakyan

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/jira/browse/IGNITE-4233

>
>
> On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > Roman, thanks for the contribution! Is there a documentation where I can
> > read about the supported Redis commands?
> >
> > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> > wrote:
> >
> > > Roman,
> > >
> > > I reviewed your PR. Changed it a little and merged to master.
> > > Thanks for your contribution!
> > >
> > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > > > Andrey,
> > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> license
> > > > limitations."Let's use github for now.
> > > > Thank you for your review!
> > > > -Roman
> > > >
> > > >
> > > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > [hidden email]> wrote:
> > > >
> > > >
> > > > Roman,
> > > >
> > > > I reviewed your code and added comments in JIRA.
> > > >
> > > > May we will try to use Upsource (http://reviews.ignite.apache.org/)
> > for
> > > > code
> > > > review?
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > -Roman
> > > > >
> > > > >
> > > > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > > Roman,
> > > > >
> > > > > I reviewed your code and now it looks good for me.
> > > > > But I added two minor comments in JIRA.
> > > > >
> > > > > Also I think Andrey Novikov should take a look, as he has some
> > > experience
> > > > > in ignite-rest module.
> > > > >
> > > > > Andrey, take a look:
> > > > >
> > > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > > PR: https://github.com/apache/ignite/pull/1212
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you!I answered and pushed the changes.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > [hidden email]> wrote:
> > > > > >
> > > > > >
> > > > > > Roman,
> > > > > >
> > > > > > I made one more review, see my comments in JIRA issue.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > [hidden email]>
> > > > > > wrote:
> > > > > >
> > > > > > > I will take a look on PR today.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > > <[hidden email]
> > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Denis,
> > > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > > >>
> > > > > > >> Thank you,
> > > > > > >> Roman
> > > > > > >>
> > > > > > >>
> > > > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > >> [hidden email]> wrote:
> > > > > > >>
> > > > > > >>
> > > > > > >> Roman,
> > > > > > >>
> > > > > > >> Would you mind making a pull-request? It’s not clear and easy
> to
> > > > > review
> > > > > > >> using the branch you provided
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > > >>
> > > > > > >> This link provides details how to achieve this
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > > >>
> > > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > > >>
> > > > > > >> —
> > > > > > >> Denis
> > > > > > >>
> > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > >> wrote:
> > > > > > >> >
> > > > > > >> > Igniters,
> > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > >> >
> > > > > > >> > Thank you,Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> >
>

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Andrey, thank you!
Dmitriy, I will when we have 1.8.0 version on readme.io.
-Roman

On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <[hidden email]> wrote:

Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/jira/browse/IGNITE-4233

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Dmitriy,
I have contents prepared for the Redis category page on https://issues.apache.org/jira/browse/IGNITE-4233Later I will add examples for Java and some other languages.
-Roman

On Thursday, November 17, 2016 9:59 AM, Roman Shtykh <[hidden email]> wrote:

Andrey, thank you!
Dmitriy, I will when we have 1.8.0 version on readme.io.
-Roman

On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <[hidden email]> wrote:

Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/jira/browse/IGNITE-4233

dsetrakyan

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Thanks, Roman! I looked at the content and it looks OK.

Are we going to be adding more Redis commands? If yes, would be nice if we
would mention which commands we plan to add in the nearest future.

D.

On Fri, Nov 18, 2016 at 4:23 AM, Roman Shtykh <[hidden email]>
wrote:

> Dmitriy,
> I have contents prepared for the Redis category page on
> https://issues.apache.org/jira/browse/IGNITE-4233Later I will add
> examples for Java and some other languages.
> -Roman
>
>
> On Thursday, November 17, 2016 9:59 AM, Roman Shtykh
> <[hidden email]> wrote:
>
>
> Andrey, thank you!
> Dmitriy, I will when we have 1.8.0 version on readme.io.
> -Roman
>
>
> On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <
> [hidden email]> wrote:
>
>
> Roman, do you mind contributing the documentation for this feature?
>
> On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
> wrote:
>
> > Dmitriy,
> >
> > At this moment supported command can be found in ticket description:
> > https://issues.apache.org/jira/browse/IGNITE-3066
> > I think we shout add section for REDIS support on apacheignite.readme.io
> > like for memcache
> > Create ticket for documentation:
> > https://issues.apache.org/jira/browse/IGNITE-4233
>
>
> >
> >
> > On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <
> [hidden email]>
> > wrote:
> >
> > > Roman, thanks for the contribution! Is there a documentation where I
> can
> > > read about the supported Redis commands?
> > >
> > > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> > > wrote:
> > >
> > > > Roman,
> > > >
> > > > I reviewed your PR. Changed it a little and merged to master.
> > > > Thanks for your contribution!
> > > >
> > > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Andrey,
> > > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> > license
> > > > > limitations."Let's use github for now.
> > > > > Thank you for your review!
> > > > > -Roman
> > > > >
> > > > >
> > > > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > > Roman,
> > > > >
> > > > > I reviewed your code and added comments in JIRA.
> > > > >
> > > > > May we will try to use Upsource (http://reviews.ignite.apache.org/
> )
> > > for
> > > > > code
> > > > > review?
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > > [hidden email]> wrote:
> > > > > >
> > > > > >
> > > > > > Roman,
> > > > > >
> > > > > > I reviewed your code and now it looks good for me.
> > > > > > But I added two minor comments in JIRA.
> > > > > >
> > > > > > Also I think Andrey Novikov should take a look, as he has some
> > > > experience
> > > > > > in ignite-rest module.
> > > > > >
> > > > > > Andrey, take a look:
> > > > > >
> > > > > > Issue: https://issues.apache.org/jira/browse/IGNITE-3066
> > > > > > PR: https://github.com/apache/ignite/pull/1212
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Alexey,
> > > > > > > Thank you!I answered and pushed the changes.
> > > > > > > -Roman
> > > > > > >
> > > > > > >
> > > > > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > > [hidden email]> wrote:
> > > > > > >
> > > > > > >
> > > > > > > Roman,
> > > > > > >
> > > > > > > I made one more review, see my comments in JIRA issue.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > > [hidden email]>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I will take a look on PR today.
> > > > > > > >
> > > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > > > <[hidden email]
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >> Denis,
> > > > > > > >> It is https://github.com/apache/ignite/pull/1212
> > > > > > > >>
> > > > > > > >> Thank you,
> > > > > > > >> Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > > >> [hidden email]> wrote:
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> Roman,
> > > > > > > >>
> > > > > > > >> Would you mind making a pull-request? It’s not clear and
> easy
> > to
> > > > > > review
> > > > > > > >> using the branch you provided
> > > > > > > >> https://github.com/apache/ignite/tree/ignite-2788 <
> > > > > > > >> https://github.com/apache/ignite/tree/ignite-2788>
> > > > > > > >>
> > > > > > > >> This link provides details how to achieve this
> > > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request <
> > > > > > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+
> > > > > > > >> Contribute#HowtoContribute-1.CreateGitHubpull-request>
> > > > > > > >>
> > > > > > > >> Let us know if you have any issue preparing the
> pull-request.
> > > > > > > >>
> > > > > > > >> —
> > > > > > > >> Denis
> > > > > > > >>
> > > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > > > <[hidden email]
> > > > > > >
> > > > > > > >> wrote:
> > > > > > > >> >
> > > > > > > >> > Igniters,
> > > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > > >> >
> > > > > > > >> > Thank you,Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Alexey Kuznetsov
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
>
>
>

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

In reply to this post by Andrey Novikov-3

Andrey,
I found a problem in INCR/DECR implementation.I think I misunderstood how it works in the current memcached/rest implementation of Ignite, but I modified Redis INCR/DECR now to behave the same way as memcached/rest.
Can you please have a look at https://issues.apache.org/jira/browse/IGNITE-4244 ?
-Roman

On Wednesday, November 16, 2016 8:09 PM, Andrey Novikov <[hidden email]> wrote:

Roman,

I reviewed your PR. Changed it a little and merged to master.
Thanks for your contribution!

On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh <[hidden email]> wrote:

Andrey,
Sure, but I couldn't sign up -- "Cannot complete request due to license limitations."Let's use github for now.
Thank you for your review!
-Roman

On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <[hidden email]> wrote:

Roman,

I reviewed your code and added comments in JIRA.

May we will try to use Upsource (http://reviews.ignite.apache. org/) for code
review?

On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh <[hidden email]>
wrote:

> Alexey,
> Thank you for your thorough reviews! I fixed the issues.
> -Roman
>
>
> On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> [hidden email]> wrote:
>
>
> Roman,
>
> I reviewed your code and now it looks good for me.
> But I added two minor comments in JIRA.
>
> Also I think Andrey Novikov should take a look, as he has some experience
> in ignite-rest module.
>
> Andrey, take a look:
>
> Issue: https://issues.apache.org/ jira/browse/IGNITE-3066
> PR: https://github.com/apache/ ignite/pull/1212
>
>
> On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> > Alexey,
> > Thank you!I answered and pushed the changes.
> > -Roman
> >
> >
> > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > [hidden email]> wrote:
> >
> >
> > Roman,
> >
> > I made one more review, see my comments in JIRA issue.
> >
> > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <[hidden email]>
> > wrote:
> >
> > > I will take a look on PR today.
> > >
> > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > >> Denis,
> > >> It is https://github.com/apache/ ignite/pull/1212
> > >>
> > >> Thank you,
> > >> Roman
> > >>
> > >>
> > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > >> [hidden email]> wrote:
> > >>
> > >>
> > >> Roman,
> > >>
> > >> Would you mind making a pull-request? It’s not clear and easy to
> review
> > >> using the branch you provided
> > >> https://github.com/apache/ ignite/tree/ignite-2788 <
> > >> https://github.com/apache/ ignite/tree/ignite-2788>
> > >>
> > >> This link provides details how to achieve this
> > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+ to+
> > >> Contribute#HowtoContribute-1. CreateGitHubpull-request <
> > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+ to+
> > >> Contribute#HowtoContribute-1. CreateGitHubpull-request>
> > >>
> > >> Let us know if you have any issue preparing the pull-request.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh <[hidden email]
> >
> > >> wrote:
> > >> >
> > >> > Igniters,
> > >> > Please review the issue.https://issues.apache.or
> > >> g/jira/browse/IGNITE-3066
> > >> >
> > >> > Thank you,Roman
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
> >
> >
>
>
>
> --
> Alexey Kuznetsov
>
>
>

Roman Shtykh

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

In reply to this post by dsetrakyan

Dmitriy,
I think additions of some operations on sets and hashes are pretty straightforward.
But I think we need to extend REST implementation to cover even more Redis commands (it won't probably remove all limitations we have now though, like not having expiration on keys), or create a Redis processor to access Ignite Cache API directly (which will give us more freedom on how we implement Redis commands). This is my understanding. I would appreciate more discussion and advice on how to continue (probably in https://issues.apache.org/jira/browse/IGNITE-2788)

Roman

On Friday, November 18, 2016 5:42 PM, Dmitriy Setrakyan <[hidden email]> wrote:

Thanks, Roman! I looked at the content and it looks OK.
Are we going to be adding more Redis commands? If yes, would be nice if we would mention which commands we plan to add in the nearest future.
D.
On Fri, Nov 18, 2016 at 4:23 AM, Roman Shtykh <[hidden email]> wrote:

Dmitriy,
I have contents prepared for the Redis category page on https://issues.apache.org/ jira/browse/IGNITE-4233Later I will add examples for Java and some other languages.
-Roman

On Thursday, November 17, 2016 9:59 AM, Roman Shtykh <[hidden email]> wrote:

Andrey, thank you!
Dmitriy, I will when we have 1.8.0 version on readme.io.
-Roman

On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <[hidden email]> wrote:

Roman, do you mind contributing the documentation for this feature?

On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
wrote:

> Dmitriy,
>
> At this moment supported command can be found in ticket description:
> https://issues.apache.org/ jira/browse/IGNITE-3066
> I think we shout add section for REDIS support on apacheignite.readme.io
> like for memcache
> Create ticket for documentation:
> https://issues.apache.org/ jira/browse/IGNITE-4233

>
>
> On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
>
> > Roman, thanks for the contribution! Is there a documentation where I can
> > read about the supported Redis commands?
> >
> > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> > wrote:
> >
> > > Roman,
> > >
> > > I reviewed your PR. Changed it a little and merged to master.
> > > Thanks for your contribution!
> > >
> > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
> <[hidden email]
> > >
> > > wrote:
> > >
> > > > Andrey,
> > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> license
> > > > limitations."Let's use github for now.
> > > > Thank you for your review!
> > > > -Roman
> > > >
> > > >
> > > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > [hidden email]> wrote:
> > > >
> > > >
> > > > Roman,
> > > >
> > > > I reviewed your code and added comments in JIRA.
> > > >
> > > > May we will try to use Upsource (http://reviews.ignite.apache. org/)
> > for
> > > > code
> > > > review?
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Alexey,
> > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > -Roman
> > > > >
> > > > >
> > > > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > > Roman,
> > > > >
> > > > > I reviewed your code and now it looks good for me.
> > > > > But I added two minor comments in JIRA.
> > > > >
> > > > > Also I think Andrey Novikov should take a look, as he has some
> > > experience
> > > > > in ignite-rest module.
> > > > >
> > > > > Andrey, take a look:
> > > > >
> > > > > Issue: https://issues.apache.org/ jira/browse/IGNITE-3066
> > > > > PR: https://github.com/apache/ ignite/pull/1212
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you!I answered and pushed the changes.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > [hidden email]> wrote:
> > > > > >
> > > > > >
> > > > > > Roman,
> > > > > >
> > > > > > I made one more review, see my comments in JIRA issue.
> > > > > >
> > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > [hidden email]>
> > > > > > wrote:
> > > > > >
> > > > > > > I will take a look on PR today.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > > <[hidden email]
> > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Denis,
> > > > > > >> It is https://github.com/apache/ ignite/pull/1212
> > > > > > >>
> > > > > > >> Thank you,
> > > > > > >> Roman
> > > > > > >>
> > > > > > >>
> > > > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > >> [hidden email]> wrote:
> > > > > > >>
> > > > > > >>
> > > > > > >> Roman,
> > > > > > >>
> > > > > > >> Would you mind making a pull-request? It’s not clear and easy
> to
> > > > > review
> > > > > > >> using the branch you provided
> > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788 <
> > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788>
> > > > > > >>
> > > > > > >> This link provides details how to achieve this
> > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+ to+
> > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request <
> > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+ to+
> > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request>
> > > > > > >>
> > > > > > >> Let us know if you have any issue preparing the pull-request.
> > > > > > >>
> > > > > > >> —
> > > > > > >> Denis
> > > > > > >>
> > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > >> wrote:
> > > > > > >> >
> > > > > > >> > Igniters,
> > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > >> >
> > > > > > >> > Thank you,Roman
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey Kuznetsov
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> >
>

Valentin Kulichenko

Re: IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

Hi Roman,

Do you mean that key expiration is not supported in Ignite? If so, then
this is not true, see the last example here:
https://apacheignite.readme.io/docs/expiry-policies

-Val

On Fri, Nov 18, 2016 at 7:55 PM, Roman Shtykh <[hidden email]>
wrote:

> Dmitriy,
> I think additions of some operations on sets and hashes are pretty
> straightforward.
> But I think we need to extend REST implementation to cover even more Redis
> commands (it won't probably remove all limitations we have now though, like
> not having expiration on keys), or create a Redis processor to access
> Ignite Cache API directly (which will give us more freedom on how we
> implement Redis commands). This is my understanding. I would appreciate
> more discussion and advice on how to continue (probably in
> https://issues.apache.org/jira/browse/IGNITE-2788)
>
> Roman
>
>
>
> On Friday, November 18, 2016 5:42 PM, Dmitriy Setrakyan <
> [hidden email]> wrote:
>
>
> Thanks, Roman! I looked at the content and it looks OK.
> Are we going to be adding more Redis commands? If yes, would be nice if we
> would mention which commands we plan to add in the nearest future.
> D.
> On Fri, Nov 18, 2016 at 4:23 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> Dmitriy,
> I have contents prepared for the Redis category page on
> https://issues.apache.org/ jira/browse/IGNITE-4233Later I will add
> examples for Java and some other languages.
> -Roman
>
>
> On Thursday, November 17, 2016 9:59 AM, Roman Shtykh
> <[hidden email]> wrote:
>
>
> Andrey, thank you!
> Dmitriy, I will when we have 1.8.0 version on readme.io.
> -Roman
>
>
> On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <
> [hidden email]> wrote:
>
>
> Roman, do you mind contributing the documentation for this feature?
>
> On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
> wrote:
>
> > Dmitriy,
> >
> > At this moment supported command can be found in ticket description:
> > https://issues.apache.org/ jira/browse/IGNITE-3066
> > I think we shout add section for REDIS support on apacheignite.readme.io
> > like for memcache
> > Create ticket for documentation:
> > https://issues.apache.org/ jira/browse/IGNITE-4233
>
>
> >
> >
> > On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <
> [hidden email]>
> > wrote:
> >
> > > Roman, thanks for the contribution! Is there a documentation where I
> can
> > > read about the supported Redis commands?
> > >
> > > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> > > wrote:
> > >
> > > > Roman,
> > > >
> > > > I reviewed your PR. Changed it a little and merged to master.
> > > > Thanks for your contribution!
> > > >
> > > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Andrey,
> > > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> > license
> > > > > limitations."Let's use github for now.
> > > > > Thank you for your review!
> > > > > -Roman
> > > > >
> > > > >
> > > > > On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > > Roman,
> > > > >
> > > > > I reviewed your code and added comments in JIRA.
> > > > >
> > > > > May we will try to use Upsource (http://reviews.ignite.apache.
> org/)
> > > for
> > > > > code
> > > > > review?
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > > On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > > [hidden email]> wrote:
> > > > > >
> > > > > >
> > > > > > Roman,
> > > > > >
> > > > > > I reviewed your code and now it looks good for me.
> > > > > > But I added two minor comments in JIRA.
> > > > > >
> > > > > > Also I think Andrey Novikov should take a look, as he has some
> > > > experience
> > > > > > in ignite-rest module.
> > > > > >
> > > > > > Andrey, take a look:
> > > > > >
> > > > > > Issue: https://issues.apache.org/ jira/browse/IGNITE-3066
> > > > > > PR: https://github.com/apache/ ignite/pull/1212
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Alexey,
> > > > > > > Thank you!I answered and pushed the changes.
> > > > > > > -Roman
> > > > > > >
> > > > > > >
> > > > > > > On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > > [hidden email]> wrote:
> > > > > > >
> > > > > > >
> > > > > > > Roman,
> > > > > > >
> > > > > > > I made one more review, see my comments in JIRA issue.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > > [hidden email]>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I will take a look on PR today.
> > > > > > > >
> > > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > > > <[hidden email]
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >> Denis,
> > > > > > > >> It is https://github.com/apache/ ignite/pull/1212
> > > > > > > >>
> > > > > > > >> Thank you,
> > > > > > > >> Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > > >> [hidden email]> wrote:
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> Roman,
> > > > > > > >>
> > > > > > > >> Would you mind making a pull-request? It’s not clear and
> easy
> > to
> > > > > > review
> > > > > > > >> using the branch you provided
> > > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788 <
> > > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788>
> > > > > > > >>
> > > > > > > >> This link provides details how to achieve this
> > > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+
> to+
> > > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request <
> > > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+
> to+
> > > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request>
> > > > > > > >>
> > > > > > > >> Let us know if you have any issue preparing the
> pull-request.
> > > > > > > >>
> > > > > > > >> —
> > > > > > > >> Denis
> > > > > > > >>
> > > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > > > <[hidden email]
> > > > > > >
> > > > > > > >> wrote:
> > > > > > > >> >
> > > > > > > >> > Igniters,
> > > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > > >> >
> > > > > > > >> > Thank you,Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Alexey Kuznetsov
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
>
>
>
>
>
>
>