IGNITE-3066 Set of Redis commands that can be easily implemented via existing REST commands

[Roman Shtykh]

Hi Valentin,

No, I am aware of cache.withExpiryPolicy.

I am just saying it cannot be done with the current rest implementation (and this is just one example of what I try to convey).

Roman


On Saturday, November 19, 2016 4:18 PM, Valentin Kulichenko <[hidden email]> wrote:



Hi Roman,

Do you mean that key expiration is not supported in Ignite? If so, then
this is not true, see the last example here:
https://apacheignite.readme.io/docs/expiry-policies

-Val


On Fri, Nov 18, 2016 at 7:55 PM, Roman Shtykh <[hidden email]>
wrote:

> Dmitriy,
> I think additions of some operations on sets and hashes are pretty
> straightforward.
> But I think we need to extend REST implementation to cover even more Redis
> commands (it won't probably remove all limitations we have now though, like
> not having expiration on keys), or create a Redis processor to access
> Ignite Cache API directly (which will give us more freedom on how we
> implement Redis commands). This is my understanding. I would appreciate
> more discussion and advice on how to continue (probably in
> https://issues.apache.org/jira/browse/IGNITE-2788)
>
> Roman
>
>
>
>     On Friday, November 18, 2016 5:42 PM, Dmitriy Setrakyan <
> [hidden email]> wrote:
>
>
>  Thanks, Roman! I looked at the content and it looks OK.
> Are we going to be adding more Redis commands? If yes, would be nice if we
> would mention which commands we plan to add in the nearest future.
> D.
> On Fri, Nov 18, 2016 at 4:23 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> Dmitriy,
> I have contents prepared for the Redis category page on
> https://issues.apache.org/ jira/browse/IGNITE-4233Later I will add
> examples for Java and some other languages.
> -Roman
>
>
>     On Thursday, November 17, 2016 9:59 AM, Roman Shtykh
> <[hidden email]> wrote:
>
>
>  Andrey, thank you!
> Dmitriy, I will when we have 1.8.0 version on readme.io.
> -Roman
>
>
>     On Wednesday, November 16, 2016 8:38 PM, Dmitriy Setrakyan <
> [hidden email]> wrote:
>
>
>  Roman, do you mind contributing the documentation for this feature?
>
> On Wed, Nov 16, 2016 at 12:27 PM, Andrey Novikov <[hidden email]>
> wrote:
>
> > Dmitriy,
> >
> > At this moment supported command can be found in ticket description:
> > https://issues.apache.org/ jira/browse/IGNITE-3066
> > I think we shout add section for REDIS support on apacheignite.readme.io
> > like for memcache
> > Create ticket for documentation:
> > https://issues.apache.org/ jira/browse/IGNITE-4233
>
>
> >
> >
> > On Wed, Nov 16, 2016 at 6:12 PM, Dmitriy Setrakyan <
> [hidden email]>
> > wrote:
> >
> > > Roman, thanks for the contribution! Is there a documentation where I
> can
> > > read about the supported Redis commands?
> > >
> > > On Wed, Nov 16, 2016 at 12:09 PM, Andrey Novikov <[hidden email]>
> > > wrote:
> > >
> > > > Roman,
> > > >
> > > > I reviewed your PR. Changed it a little and merged to master.
> > > > Thanks for your contribution!
> > > >
> > > > On Wed, Nov 16, 2016 at 9:39 AM, Roman Shtykh
> > <[hidden email]
> > > >
> > > > wrote:
> > > >
> > > > > Andrey,
> > > > > Sure, but I couldn't sign up -- "Cannot complete request due to
> > license
> > > > > limitations."Let's use github for now.
> > > > > Thank you for your review!
> > > > > -Roman
> > > > >
> > > > >
> > > > >    On Tuesday, November 15, 2016 6:12 PM, Andrey Novikov <
> > > > > [hidden email]> wrote:
> > > > >
> > > > >
> > > > >  Roman,
> > > > >
> > > > > I reviewed your code and added comments in JIRA.
> > > > >
> > > > > May we will try to use Upsource (http://reviews.ignite.apache.
> org/)
> > > for
> > > > > code
> > > > > review?
> > > > >
> > > > >
> > > > > On Tue, Nov 15, 2016 at 1:22 PM, Roman Shtykh
> > > <[hidden email]
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Alexey,
> > > > > > Thank you for your thorough reviews! I fixed the issues.
> > > > > > -Roman
> > > > > >
> > > > > >
> > > > > >    On Tuesday, November 15, 2016 12:32 PM, Alexey Kuznetsov <
> > > > > > [hidden email]> wrote:
> > > > > >
> > > > > >
> > > > > >  Roman,
> > > > > >
> > > > > > I reviewed your code and now it looks good for me.
> > > > > > But I added two minor comments in JIRA.
> > > > > >
> > > > > > Also I think Andrey Novikov should take a look, as he has some
> > > > experience
> > > > > > in ignite-rest module.
> > > > > >
> > > > > > Andrey, take a look:
> > > > > >
> > > > > > Issue: https://issues.apache.org/ jira/browse/IGNITE-3066
> > > > > > PR:  https://github.com/apache/ ignite/pull/1212
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 15, 2016 at 9:27 AM, Roman Shtykh
> > > > <[hidden email]
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Alexey,
> > > > > > > Thank you!I answered and pushed the changes.
> > > > > > > -Roman
> > > > > > >
> > > > > > >
> > > > > > >    On Tuesday, November 15, 2016 12:14 AM, Alexey Kuznetsov <
> > > > > > > [hidden email]> wrote:
> > > > > > >
> > > > > > >
> > > > > > >  Roman,
> > > > > > >
> > > > > > > I made one more review,  see my comments in JIRA issue.
> > > > > > >
> > > > > > > On Mon, Nov 7, 2016 at 1:30 PM, Alexey Kuznetsov <
> > > > > [hidden email]>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I will take a look on PR today.
> > > > > > > >
> > > > > > > > On Mon, Nov 7, 2016 at 11:35 AM, Roman Shtykh
> > > > > > <[hidden email]
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >>  Denis,
> > > > > > > >> It is https://github.com/apache/ ignite/pull/1212
> > > > > > > >>
> > > > > > > >> Thank you,
> > > > > > > >> Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>    On Saturday, November 5, 2016 4:56 AM, Denis Magda <
> > > > > > > >> [hidden email]> wrote:
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>  Roman,
> > > > > > > >>
> > > > > > > >> Would you mind making a pull-request? It’s not clear and
> easy
> > to
> > > > > > review
> > > > > > > >> using the branch you provided
> > > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788 <
> > > > > > > >> https://github.com/apache/ ignite/tree/ignite-2788>
> > > > > > > >>
> > > > > > > >> This link provides details how to achieve this
> > > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+
> to+
> > > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request <
> > > > > > > >> https://cwiki.apache.org/ confluence/display/IGNITE/How+
> to+
> > > > > > > >> Contribute#HowtoContribute-1. CreateGitHubpull-request>
> > > > > > > >>
> > > > > > > >> Let us know if you have any issue preparing the
> pull-request.
> > > > > > > >>
> > > > > > > >> —
> > > > > > > >> Denis
> > > > > > > >>
> > > > > > > >> > On Nov 3, 2016, at 6:24 PM, Roman Shtykh
> > > > > <[hidden email]
> > > > > > >
> > > > > > > >> wrote:
> > > > > > > >> >
> > > > > > > >> > Igniters,
> > > > > > > >> > Please review the issue.https://issues.apache.or
> > > > > > > >> g/jira/browse/IGNITE-3066
> > > > > > > >> >
> > > > > > > >> > Thank you,Roman
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Alexey Kuznetsov
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Alexey Kuznetsov
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Alexey Kuznetsov
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
>
>
>
>
>
>
>

[Alexey Kuznetsov]

Roman,

I think we should better implement REDIS processor (if needed) and use
Ignite API directly.
In this case we will not be limited by current REST implementation.
Also calling Ignite API directly should be faster (I think).

--
Alexey Kuznetsov

[Roman Shtykh]

Alexey,

I also think this is the way to go. Thank you. Any other opinions?

Roman



On Saturday, November 19, 2016 8:21 PM, Alexey Kuznetsov <[hidden email]> wrote:
Roman,

I think we should better implement REDIS processor (if needed) and use
Ignite API directly.
In this case we will not be limited by current REST implementation.
Also calling Ignite API directly should be faster (I think).


--
Alexey Kuznetsov

[dmagda]

Rather then implementing one more processor (for Redis) I would finally renew our existing REST API that is far from an ideal state
https://issues.apache.org/jira/browse/IGNITE-3879 <https://issues.apache.org/jira/browse/IGNITE-3879>

Roman, are you interested in taking over IGNITE-3879? Definitely, the community will help with the design and implementation.

—
Denis

> On Nov 19, 2016, at 5:02 AM, Roman Shtykh <[hidden email]> wrote:
>
> Alexey,
>
> I also think this is the way to go. Thank you. Any other opinions?
>
> Roman
>
>
>
> On Saturday, November 19, 2016 8:21 PM, Alexey Kuznetsov <[hidden email]> wrote:
> Roman,
>
> I think we should better implement REDIS processor (if needed) and use
> Ignite API directly.
> In this case we will not be limited by current REST implementation.
> Also calling Ignite API directly should be faster (I think).
>
>
> --
> Alexey Kuznetsov

[Roman Shtykh]

Denis,

I will think on this, thank you.
And I will initiate another thread in a meanwhile to collect everyone's opinions on what they expect from this redesign.

Roman



On Sunday, November 20, 2016 2:34 AM, Denis Magda <[hidden email]> wrote:
Rather then implementing one more processor (for Redis) I would finally renew our existing REST API that is far from an ideal state
https://issues.apache.org/jira/browse/IGNITE-3879 <https://issues.apache.org/jira/browse/IGNITE-3879>

Roman, are you interested in taking over IGNITE-3879? Definitely, the community will help with the design and implementation.

—
Denis

> On Nov 19, 2016, at 5:02 AM, Roman Shtykh <[hidden email]> wrote:
>
> Alexey,
>
> I also think this is the way to go. Thank you. Any other opinions?
>
> Roman
>
>
>
> On Saturday, November 19, 2016 8:21 PM, Alexey Kuznetsov <[hidden email]> wrote:
> Roman,
>
> I think we should better implement REDIS processor (if needed) and use
> Ignite API directly.
> In this case we will not be limited by current REST implementation.
> Also calling Ignite API directly should be faster (I think).
>
>
> --
> Alexey Kuznetsov