[GitHub] ignite pull request #895: IGNITE-3323 Use maven dependencies for Jetbrains a...

[andrey-kuznetsov]

GitHub user jayho opened a pull request:

    https://github.com/apache/ignite/pull/895

    IGNITE-3323 Use maven dependencies for Jetbrains annotations

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jayho/ignite ignite-3323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #895
   
----
commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
Author: Jens Hoffmann <[hidden email]>
Date:   2016-07-25T22:38:13Z

    IGNITE-3323 Use maven dependencies for Jetbrains annotations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[Jens Hoffmann]

Ready for review:
https://issues.apache.org/jira/browse/IGNITE-3323

I ran a number of TC tests, almost all are passing apart from 3 that
are failing, but the failures don't seem to be related to the change
and also fail in other runs.

Cheers,
Jens

On Tue, Jul 26, 2016 at 12:40 AM, jayho <[hidden email]> wrote:

> GitHub user jayho opened a pull request:
>
>     https://github.com/apache/ignite/pull/895
>
>     IGNITE-3323 Use maven dependencies for Jetbrains annotations
>
>
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/jayho/ignite ignite-3323
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/ignite/pull/895.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #895
>
> ----
> commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
> Author: Jens Hoffmann <[hidden email]>
> Date:   2016-07-25T22:38:13Z
>
>     IGNITE-3323 Use maven dependencies for Jetbrains annotations
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---

[Jens Hoffmann]

Hi Anton, devs,

it seems that a commit was missed in the merge for
https://issues.apache.org/jira/browse/IGNITE-3323
The current state of master might not be good. Please see my comments
on the ticket.

Thanks
Jens




On Tue, Jul 26, 2016 at 9:59 AM, NoTrueScotsman
<[hidden email]> wrote:

> Ready for review:
> https://issues.apache.org/jira/browse/IGNITE-3323
>
> I ran a number of TC tests, almost all are passing apart from 3 that
> are failing, but the failures don't seem to be related to the change
> and also fail in other runs.
>
> Cheers,
> Jens
>
> On Tue, Jul 26, 2016 at 12:40 AM, jayho <[hidden email]> wrote:
>> GitHub user jayho opened a pull request:
>>
>>     https://github.com/apache/ignite/pull/895
>>
>>     IGNITE-3323 Use maven dependencies for Jetbrains annotations
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>>     $ git pull https://github.com/jayho/ignite ignite-3323
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>>     https://github.com/apache/ignite/pull/895.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>>     This closes #895
>>
>> ----
>> commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
>> Author: Jens Hoffmann <[hidden email]>
>> Date:   2016-07-25T22:38:13Z
>>
>>     IGNITE-3323 Use maven dependencies for Jetbrains annotations
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at [hidden email] or file a JIRA ticket
>> with INFRA.
>> ---

[andrey-kuznetsov]

Github user jayho closed the pull request at:

    https://github.com/apache/ignite/pull/895


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---