Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

kcheng.mvp
Hi All,

My first fix for Ignite https://issues.apache.org/jira/browse/IGNITE-1226
is ready.
Can someone grant the write privilege to github?


Thanks,
kcheng
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

kcheng.mvp
grant me the write privilege to github, as I need user/password to push my
fix.

Thanks,
kcheng

On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]> wrote:

> Hi All,
>
> My first fix for Ignite https://issues.apache.org/jira/browse/IGNITE-1226
> is ready.
> Can someone grant the write privilege to github?
>
>
> Thanks,
> kcheng
>
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Alexey Kuznetsov-2
Ken,

Please, get familiar with process
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute

In short, you should fork apache-ignite on git hub, create branch, push you
fixes and create a pull request.

Someone from committers will review your patch and merge it or give you a
review comments.

Hope this help.

On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]> wrote:

> grant me the write privilege to github, as I need user/password to push my
> fix.
>
> Thanks,
> kcheng
>
> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]> wrote:
>
> > Hi All,
> >
> > My first fix for Ignite
> https://issues.apache.org/jira/browse/IGNITE-1226
> > is ready.
> > Can someone grant the write privilege to github?
> >
> >
> > Thanks,
> > kcheng
> >
>



--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

kcheng.mvp


Just as the screen shows, I have created a branch with the Jira number, but when I try to push my fix it promotes me to input username/password, I tried with my github account but got the authentication failure. 

Thanks,
kcheng

On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <[hidden email]> wrote:
Ken,

Please, get familiar with process
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute

In short, you should fork apache-ignite on git hub, create branch, push you
fixes and create a pull request.

Someone from committers will review your patch and merge it or give you a
review comments.

Hope this help.

On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]> wrote:

> grant me the write privilege to github, as I need user/password to push my
> fix.
>
> Thanks,
> kcheng
>
> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]> wrote:
>
> > Hi All,
> >
> > My first fix for Ignite
> https://issues.apache.org/jira/browse/IGNITE-1226
> > is ready.
> > Can someone grant the write privilege to github?
> >
> >
> > Thanks,
> > kcheng
> >
>



--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Pavel Tupitsyn-3
Hi Ken,

Looks like you have cloned Apache repository directly. Instead, please
create a fork in your GitHub account.
Btw, Apache mail does not support inline images.

Thanks,

On Tue, Aug 25, 2015 at 12:49 PM, Ken Cheng <[hidden email]> wrote:

> [image: Inline image 1]
>
> Just as the screen shows, I have created a branch with the Jira number,
> but when I try to push my fix it promotes me to input username/password, I
> tried with my github account but got the authentication failure.
>
> Thanks,
> kcheng
>
> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <[hidden email]
> > wrote:
>
>> Ken,
>>
>> Please, get familiar with process
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>>
>> In short, you should fork apache-ignite on git hub, create branch, push
>> you
>> fixes and create a pull request.
>>
>> Someone from committers will review your patch and merge it or give you a
>> review comments.
>>
>> Hope this help.
>>
>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]> wrote:
>>
>> > grant me the write privilege to github, as I need user/password to push
>> my
>> > fix.
>> >
>> > Thanks,
>> > kcheng
>> >
>> > On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]>
>> wrote:
>> >
>> > > Hi All,
>> > >
>> > > My first fix for Ignite
>> > https://issues.apache.org/jira/browse/IGNITE-1226
>> > > is ready.
>> > > Can someone grant the write privilege to github?
>> > >
>> > >
>> > > Thanks,
>> > > kcheng
>> > >
>> >
>>
>>
>>
>> --
>> Alexey Kuznetsov
>> GridGain Systems
>> www.gridgain.com
>>
>
>


--
--
Pavel Tupitsyn
GridGain Systems, Inc.
www.gridgain.com
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Raul Kripalani-2
In reply to this post by kcheng.mvp
The Github repo of Ignite is read only. It's just a mirror of the Apache
repo.

You need to fork it into your own Github account. Then you clone the fork
locally and push the branch to it.

Later, you open a Pull Request to the apache/ignite repo, making sure that
you include the ticket number (IGNITE-nnnn) in the description.

The ASF Github bot will pick up the pull request and notify the Dev team on
the mailing list and on JIRA.
On 25 Aug 2015 10:49, "Ken Cheng" <[hidden email]> wrote:

> [image: Inline image 1]
>
> Just as the screen shows, I have created a branch with the Jira number,
> but when I try to push my fix it promotes me to input username/password, I
> tried with my github account but got the authentication failure.
>
> Thanks,
> kcheng
>
> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <[hidden email]
> > wrote:
>
>> Ken,
>>
>> Please, get familiar with process
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>>
>> In short, you should fork apache-ignite on git hub, create branch, push
>> you
>> fixes and create a pull request.
>>
>> Someone from committers will review your patch and merge it or give you a
>> review comments.
>>
>> Hope this help.
>>
>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]> wrote:
>>
>> > grant me the write privilege to github, as I need user/password to push
>> my
>> > fix.
>> >
>> > Thanks,
>> > kcheng
>> >
>> > On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]>
>> wrote:
>> >
>> > > Hi All,
>> > >
>> > > My first fix for Ignite
>> > https://issues.apache.org/jira/browse/IGNITE-1226
>> > > is ready.
>> > > Can someone grant the write privilege to github?
>> > >
>> > >
>> > > Thanks,
>> > > kcheng
>> > >
>> >
>>
>>
>>
>> --
>> Alexey Kuznetsov
>> GridGain Systems
>> www.gridgain.com
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Branko Čibej
On 25.08.2015 11:58, Raul Kripalani wrote:

> The Github repo of Ignite is read only. It's just a mirror of the Apache
> repo.
>
> You need to fork it into your own Github account. Then you clone the fork
> locally and push the branch to it.
>
> Later, you open a Pull Request to the apache/ignite repo, making sure that
> you include the ticket number (IGNITE-nnnn) in the description.
>
> The ASF Github bot will pick up the pull request and notify the Dev team on
> the mailing list and on JIRA.


And does everyone who's writing these instructions really think this is
a reasonable process for new contributors? Why not just clone from
git-wip-us, make the change on a local branch and either send the patch
to the dev list or attach it to the Jira issue? There's no sane reason
to involve GitHub at all.

As it is, you're telling him to jump through 4 hoops when he could just
as easily get the same done by jumping through 2. Meh.

-- Brane



> On 25 Aug 2015 10:49, "Ken Cheng" <[hidden email]> wrote:
>
>> [image: Inline image 1]
>>
>> Just as the screen shows, I have created a branch with the Jira number,
>> but when I try to push my fix it promotes me to input username/password, I
>> tried with my github account but got the authentication failure.
>>
>> Thanks,
>> kcheng
>>
>> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <[hidden email]
>>> wrote:
>>> Ken,
>>>
>>> Please, get familiar with process
>>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>>>
>>> In short, you should fork apache-ignite on git hub, create branch, push
>>> you
>>> fixes and create a pull request.
>>>
>>> Someone from committers will review your patch and merge it or give you a
>>> review comments.
>>>
>>> Hope this help.
>>>
>>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]> wrote:
>>>
>>>> grant me the write privilege to github, as I need user/password to push
>>> my
>>>> fix.
>>>>
>>>> Thanks,
>>>> kcheng
>>>>
>>>> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]>
>>> wrote:
>>>>> Hi All,
>>>>>
>>>>> My first fix for Ignite
>>>> https://issues.apache.org/jira/browse/IGNITE-1226
>>>>> is ready.
>>>>> Can someone grant the write privilege to github?
>>>>>
>>>>>
>>>>> Thanks,
>>>>> kcheng
>>>>>
>>>
>>>
>>> --
>>> Alexey Kuznetsov
>>> GridGain Systems
>>> www.gridgain.com
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

yzhdanov
Brane, you can still go with patches. However, I find pull requests more
convenient for larger change sets.

--Yakov

2015-08-25 13:35 GMT+03:00 Branko Čibej <[hidden email]>:

> On 25.08.2015 11:58, Raul Kripalani wrote:
> > The Github repo of Ignite is read only. It's just a mirror of the Apache
> > repo.
> >
> > You need to fork it into your own Github account. Then you clone the fork
> > locally and push the branch to it.
> >
> > Later, you open a Pull Request to the apache/ignite repo, making sure
> that
> > you include the ticket number (IGNITE-nnnn) in the description.
> >
> > The ASF Github bot will pick up the pull request and notify the Dev team
> on
> > the mailing list and on JIRA.
>
>
> And does everyone who's writing these instructions really think this is
> a reasonable process for new contributors? Why not just clone from
> git-wip-us, make the change on a local branch and either send the patch
> to the dev list or attach it to the Jira issue? There's no sane reason
> to involve GitHub at all.
>
> As it is, you're telling him to jump through 4 hoops when he could just
> as easily get the same done by jumping through 2. Meh.
>
> -- Brane
>
>
>
> > On 25 Aug 2015 10:49, "Ken Cheng" <[hidden email]> wrote:
> >
> >> [image: Inline image 1]
> >>
> >> Just as the screen shows, I have created a branch with the Jira number,
> >> but when I try to push my fix it promotes me to input
> username/password, I
> >> tried with my github account but got the authentication failure.
> >>
> >> Thanks,
> >> kcheng
> >>
> >> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <
> [hidden email]
> >>> wrote:
> >>> Ken,
> >>>
> >>> Please, get familiar with process
> >>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >>>
> >>> In short, you should fork apache-ignite on git hub, create branch, push
> >>> you
> >>> fixes and create a pull request.
> >>>
> >>> Someone from committers will review your patch and merge it or give
> you a
> >>> review comments.
> >>>
> >>> Hope this help.
> >>>
> >>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]>
> wrote:
> >>>
> >>>> grant me the write privilege to github, as I need user/password to
> push
> >>> my
> >>>> fix.
> >>>>
> >>>> Thanks,
> >>>> kcheng
> >>>>
> >>>> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]>
> >>> wrote:
> >>>>> Hi All,
> >>>>>
> >>>>> My first fix for Ignite
> >>>> https://issues.apache.org/jira/browse/IGNITE-1226
> >>>>> is ready.
> >>>>> Can someone grant the write privilege to github?
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>> kcheng
> >>>>>
> >>>
> >>>
> >>> --
> >>> Alexey Kuznetsov
> >>> GridGain Systems
> >>> www.gridgain.com
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

kcheng.mvp
In reply to this post by Branko Čibej
Yeah, that's straight simple, every one can easily understand.

Thanks,
kcheng

On Tue, Aug 25, 2015 at 6:35 PM, Branko Čibej <[hidden email]> wrote:

> On 25.08.2015 11:58, Raul Kripalani wrote:
> > The Github repo of Ignite is read only. It's just a mirror of the Apache
> > repo.
> >
> > You need to fork it into your own Github account. Then you clone the fork
> > locally and push the branch to it.
> >
> > Later, you open a Pull Request to the apache/ignite repo, making sure
> that
> > you include the ticket number (IGNITE-nnnn) in the description.
> >
> > The ASF Github bot will pick up the pull request and notify the Dev team
> on
> > the mailing list and on JIRA.
>
>
> And does everyone who's writing these instructions really think this is
> a reasonable process for new contributors? Why not just clone from
> git-wip-us, make the change on a local branch and either send the patch
> to the dev list or attach it to the Jira issue? There's no sane reason
> to involve GitHub at all.
>
> As it is, you're telling him to jump through 4 hoops when he could just
> as easily get the same done by jumping through 2. Meh.
>
> -- Brane
>
>
>
> > On 25 Aug 2015 10:49, "Ken Cheng" <[hidden email]> wrote:
> >
> >> [image: Inline image 1]
> >>
> >> Just as the screen shows, I have created a branch with the Jira number,
> >> but when I try to push my fix it promotes me to input
> username/password, I
> >> tried with my github account but got the authentication failure.
> >>
> >> Thanks,
> >> kcheng
> >>
> >> On Tue, Aug 25, 2015 at 5:44 PM, Alexey Kuznetsov <
> [hidden email]
> >>> wrote:
> >>> Ken,
> >>>
> >>> Please, get familiar with process
> >>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >>>
> >>> In short, you should fork apache-ignite on git hub, create branch, push
> >>> you
> >>> fixes and create a pull request.
> >>>
> >>> Someone from committers will review your patch and merge it or give
> you a
> >>> review comments.
> >>>
> >>> Hope this help.
> >>>
> >>> On Tue, Aug 25, 2015 at 4:40 PM, Ken Cheng <[hidden email]>
> wrote:
> >>>
> >>>> grant me the write privilege to github, as I need user/password to
> push
> >>> my
> >>>> fix.
> >>>>
> >>>> Thanks,
> >>>> kcheng
> >>>>
> >>>> On Tue, Aug 25, 2015 at 5:36 PM, Ken Cheng <[hidden email]>
> >>> wrote:
> >>>>> Hi All,
> >>>>>
> >>>>> My first fix for Ignite
> >>>> https://issues.apache.org/jira/browse/IGNITE-1226
> >>>>> is ready.
> >>>>> Can someone grant the write privilege to github?
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>> kcheng
> >>>>>
> >>>
> >>>
> >>> --
> >>> Alexey Kuznetsov
> >>> GridGain Systems
> >>> www.gridgain.com
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Raul Kripalani-2
In reply to this post by Branko Čibej
On Tue, Aug 25, 2015 at 11:35 AM, Branko Čibej <[hidden email]> wrote:

> And does everyone who's writing these instructions really think this is
> a reasonable process for new contributors? Why not just clone from
> git-wip-us, make the change on a local branch and either send the patch
> to the dev list or attach it to the Jira issue? There's no sane reason
> to involve GitHub at all.
>
> As it is, you're telling him to jump through 4 hoops when he could just
> as easily get the same done by jumping through 2. Meh.
>

To my knowledge, the Apache Ignite community does not enforce Github. It's
just an option.

The user started the discussion by mentioning Github, that's why it
continued in that direction.

In my opinion, what's important as a community is to accept contributions
from as many major channels as possible. And Github surely is a popular one.

- Raúl.
Reply | Threaded
Open this post in threaded view
|

Re: Code is ready for bug fix https://issues.apache.org/jira/browse/IGNITE-1226

Raul Kripalani-2
In reply to this post by yzhdanov
On Tue, Aug 25, 2015 at 11:41 AM, Yakov Zhdanov <[hidden email]> wrote:

> Brane, you can still go with patches. However, I find pull requests more
> convenient for larger change sets.
>

And for the collaboration and review process!

I submitted 2 features in the last weeks and the community required code
modifications on both. Waaaay easier to cycle back and forth by pushing new
commits onto Github – than to have to generate patch over and over again,
attach it, assign the ticket back, etc.

– Raúl.