new patches for Cassandra cache store are available

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

new patches for Cassandra cache store are available

irudyak
Could somebody please look at two new patches:

https://github.com/apache/ignite/pull/956
https://github.com/apache/ignite/pull/974


It's about a week they are waiting for their chance  :-)
Reply | Threaded
Open this post in threaded view
|

Re: new patches for Cassandra cache store are available

Alexey Kuznetsov-2
I will review them today.

Igor, you may ask for review on dev list without waiting for a week :)

25 Авг 2016 г. 6:01 пользователь "Igor Rudyak" <[hidden email]> написал:

> Could somebody please look at two new patches:
>
> https://github.com/apache/ignite/pull/956
> https://github.com/apache/ignite/pull/974
>
>
> It's about a week they are waiting for their chance  :-)
>
Reply | Threaded
Open this post in threaded view
|

Re: new patches for Cassandra cache store are available

irudyak
Ok, good to know. Just thought that once pull request was created,
appropriate notification will be automatically send to dev list.

On Wed, Aug 24, 2016 at 5:56 PM, Alexey Kuznetsov <[hidden email]>
wrote:

> I will review them today.
>
> Igor, you may ask for review on dev list without waiting for a week :)
>
> 25 Авг 2016 г. 6:01 пользователь "Igor Rudyak" <[hidden email]>
> написал:
>
> > Could somebody please look at two new patches:
> >
> > https://github.com/apache/ignite/pull/956
> > https://github.com/apache/ignite/pull/974
> >
> >
> > It's about a week they are waiting for their chance  :-)
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: new patches for Cassandra cache store are available

Alexey Kuznetsov-2
Yes it is. But there a tons of such e-mails and it is hard to understand
what should be reviewed. 90% of PR created for running test on TeamCity.

25 Авг 2016 г. 8:14 пользователь "Igor Rudyak" <[hidden email]> написал:

Ok, good to know. Just thought that once pull request was created,
appropriate notification will be automatically send to dev list.

On Wed, Aug 24, 2016 at 5:56 PM, Alexey Kuznetsov <[hidden email]>
wrote:

> I will review them today.
>
> Igor, you may ask for review on dev list without waiting for a week :)
>
> 25 Авг 2016 г. 6:01 пользователь "Igor Rudyak" <[hidden email]>
> написал:
>
> > Could somebody please look at two new patches:
> >
> > https://github.com/apache/ignite/pull/956
> > https://github.com/apache/ignite/pull/974
> >
> >
> > It's about a week they are waiting for their chance  :-)
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: new patches for Cassandra cache store are available

Alexey Kuznetsov-2
In reply to this post by irudyak
Igor,

I reviewed your patches, made some minor changes (code style and ASF
headers) and pushed to master.
Thanks for your contribution!

On Thu, Aug 25, 2016 at 6:00 AM, Igor Rudyak <[hidden email]> wrote:

> Could somebody please look at two new patches:
>
> https://github.com/apache/ignite/pull/956
> https://github.com/apache/ignite/pull/974
>
>

--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com