log4j2 garbage files

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

log4j2 garbage files

Raul Kripalani
Gianfranco, Artem,

Could you please check why we have garbage source files ending in a twiddle
~ inside the log4j2 module?

https://github.com/apache/ignite/tree/master/modules/log4j2/src/main/java/org/apache/ignite/logger/log4j2

Thanks,

*Raúl Kripalani*
PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
Messaging Engineer
http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
http://blog.raulkr.net | twitter: @raulvk
Reply | Threaded
Open this post in threaded view
|

Re: log4j2 garbage files

Artem Shutak
Hi Raul,

Oh, I was sure I deleted these files.

Fixed in my PR: https://github.com/apache/ignite/pull/188. Raul,
Gianfranco, please, review and merge the fix.

Thanks,
-- Artem --

On Thu, Oct 29, 2015 at 9:46 PM, Raul Kripalani <[hidden email]> wrote:

> Gianfranco, Artem,
>
> Could you please check why we have garbage source files ending in a twiddle
> ~ inside the log4j2 module?
>
>
> https://github.com/apache/ignite/tree/master/modules/log4j2/src/main/java/org/apache/ignite/logger/log4j2
>
> Thanks,
>
> *Raúl Kripalani*
> PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
> Messaging Engineer
> http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> http://blog.raulkr.net | twitter: @raulvk
>
Reply | Threaded
Open this post in threaded view
|

Re: log4j2 garbage files

Gianfranco Murador-2
Hi Artem, I have no write permission to merge the fix
On Oct 30, 2015 11:43 AM, "Artem Shutak" <[hidden email]> wrote:

> Hi Raul,
>
> Oh, I was sure I deleted these files.
>
> Fixed in my PR: https://github.com/apache/ignite/pull/188. Raul,
> Gianfranco, please, review and merge the fix.
>
> Thanks,
> -- Artem --
>
> On Thu, Oct 29, 2015 at 9:46 PM, Raul Kripalani <[hidden email]> wrote:
>
> > Gianfranco, Artem,
> >
> > Could you please check why we have garbage source files ending in a
> twiddle
> > ~ inside the log4j2 module?
> >
> >
> >
> https://github.com/apache/ignite/tree/master/modules/log4j2/src/main/java/org/apache/ignite/logger/log4j2
> >
> > Thanks,
> >
> > *Raúl Kripalani*
> > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
> > Messaging Engineer
> > http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> > http://blog.raulkr.net | twitter: @raulvk
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: log4j2 garbage files

Denis Magda
Guys, I've merged the fix into the master.

Thanks,
Denis

On 10/30/2015 3:43 PM, Gianfranco Murador wrote:

> Hi Artem, I have no write permission to merge the fix
> On Oct 30, 2015 11:43 AM, "Artem Shutak" <[hidden email]> wrote:
>
>> Hi Raul,
>>
>> Oh, I was sure I deleted these files.
>>
>> Fixed in my PR: https://github.com/apache/ignite/pull/188. Raul,
>> Gianfranco, please, review and merge the fix.
>>
>> Thanks,
>> -- Artem --
>>
>> On Thu, Oct 29, 2015 at 9:46 PM, Raul Kripalani <[hidden email]> wrote:
>>
>>> Gianfranco, Artem,
>>>
>>> Could you please check why we have garbage source files ending in a
>> twiddle
>>> ~ inside the log4j2 module?
>>>
>>>
>>>
>> https://github.com/apache/ignite/tree/master/modules/log4j2/src/main/java/org/apache/ignite/logger/log4j2
>>> Thanks,
>>>
>>> *Raúl Kripalani*
>>> PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
>>> Messaging Engineer
>>> http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
>>> http://blog.raulkr.net | twitter: @raulvk
>>>

Reply | Threaded
Open this post in threaded view
|

Re: log4j2 garbage files

Raul Kripalani
Hey guys,

Sorry I missed Artem's request for a review. Glad you got the chance, Denis.

Regards,

*Raúl Kripalani*
PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
Messaging Engineer
http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
http://blog.raulkr.net | twitter: @raulvk

On Tue, Nov 3, 2015 at 10:03 AM, Denis Magda <[hidden email]> wrote:

> Guys, I've merged the fix into the master.
>
> Thanks,
> Denis
>
>
> On 10/30/2015 3:43 PM, Gianfranco Murador wrote:
>
>> Hi Artem, I have no write permission to merge the fix
>> On Oct 30, 2015 11:43 AM, "Artem Shutak" <[hidden email]> wrote:
>>
>> Hi Raul,
>>>
>>> Oh, I was sure I deleted these files.
>>>
>>> Fixed in my PR: https://github.com/apache/ignite/pull/188. Raul,
>>> Gianfranco, please, review and merge the fix.
>>>
>>> Thanks,
>>> -- Artem --
>>>
>>> On Thu, Oct 29, 2015 at 9:46 PM, Raul Kripalani <[hidden email]>
>>> wrote:
>>>
>>> Gianfranco, Artem,
>>>>
>>>> Could you please check why we have garbage source files ending in a
>>>>
>>> twiddle
>>>
>>>> ~ inside the log4j2 module?
>>>>
>>>>
>>>>
>>>>
>>> https://github.com/apache/ignite/tree/master/modules/log4j2/src/main/java/org/apache/ignite/logger/log4j2
>>>
>>>> Thanks,
>>>>
>>>> *Raúl Kripalani*
>>>> PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data
>>>> and
>>>> Messaging Engineer
>>>> http://about.me/raulkripalani |
>>>> http://www.linkedin.com/in/raulkripalani
>>>> http://blog.raulkr.net | twitter: @raulvk
>>>>
>>>>
>