[jira] [Created] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()

[Anton Vinogradov (Jira)]

Dmitry Karachentsev created IGNITE-8896:
-------------------------------------------

             Summary: Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
                 Key: IGNITE-8896
                 URL: https://issues.apache.org/jira/browse/IGNITE-8896
             Project: Ignite
          Issue Type: Bug
    Affects Versions: 2.5
            Reporter: Dmitry Karachentsev
             Fix For: 2.7


Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().

But this is wrong, because first checks back pressure limit and sender thread will be blocked before slow client check. Also, warning checks the value correctly, but message should be "...greater or equal...":
{code:java}
if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >= msgQueueLimit) {
            U.quietAndWarn(log, "Slow client queue limit is set to a value greater than message queue limit " +
                "(slow client queue limit will have no effect) [msgQueueLimit=" + msgQueueLimit +
                ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
        }
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)