[jira] [Created] (IGNITE-11271) Investigate setting discardCustomMsgId to null in prepareNodeAddedMessage

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (IGNITE-11271) Investigate setting discardCustomMsgId to null in prepareNodeAddedMessage

Anton Vinogradov (Jira)
Alexey Goncharuk created IGNITE-11271:
-----------------------------------------

             Summary: Investigate setting discardCustomMsgId to null in prepareNodeAddedMessage
                 Key: IGNITE-11271
                 URL: https://issues.apache.org/jira/browse/IGNITE-11271
             Project: Ignite
          Issue Type: Improvement
            Reporter: Alexey Goncharuk


From debugging IGNITE-10935 it was discovered that NodeAddedMessage contains wrong state: pending messages are already filtered out by discard ID, but at the same time discardId and customDiscardId are set to non-null values. This resulted in a broken pending messages iterator on a newly added node: SkipIterator was skipping all pending messages until a valid discardId was received.

The fix made in IGNITE-10935 was incomplete because we should have set both discardId and customDiscardId to null. However, after running TC tests it turned out that setting discardCustomMsgId to null resulted in duplicate custom events (the particular failed test is AuthenticationProcessorNodeRestartTest#testConcurrentAddUpdateRemoveNodeRestartServer)

The reason behind the failed test is that some of the fired custom events are delivered multiple times. This should be investigated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)