[jira] [Created] (IGNITE-10539) [ML] Make 'with' methods consistent

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (IGNITE-10539) [ML] Make 'with' methods consistent

Anton Vinogradov (Jira)
Artem Malykh created IGNITE-10539:
-------------------------------------

             Summary: [ML] Make 'with' methods consistent
                 Key: IGNITE-10539
                 URL: https://issues.apache.org/jira/browse/IGNITE-10539
             Project: Ignite
          Issue Type: Improvement
            Reporter: Artem Malykh


In some places we have 'with*' methods making inplace changes and returning object itself (for example MLPTrainer::withLoss) while in other places we have them creating new instances with corresponding parameter changed (for example DatasetBuilder::withFilter, DatasetBuilder::withUpstreamTrainsformer). This inconsistency makes user look into javadoc each time and worsens overall API consistensy level. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Created] (IGNITE-10539) [ML] Make 'with' methods consistent

Alexey Zinoviev
In my opinion, the main senario is the 'in-place' changes via with method.
This is a Java and mutability is normal behaviour.

ср, 5 дек. 2018 г. в 13:05, Artem Malykh (JIRA) <[hidden email]>:

> Artem Malykh created IGNITE-10539:
> -------------------------------------
>
>              Summary: [ML] Make 'with' methods consistent
>                  Key: IGNITE-10539
>                  URL: https://issues.apache.org/jira/browse/IGNITE-10539
>              Project: Ignite
>           Issue Type: Improvement
>             Reporter: Artem Malykh
>
>
> In some places we have 'with*' methods making inplace changes and
> returning object itself (for example MLPTrainer::withLoss) while in
> other places we have them creating new instances with corresponding
> parameter changed (for example DatasetBuilder::withFilter,
> DatasetBuilder::withUpstreamTrainsformer). This inconsistency makes user
> look into javadoc each time and worsens overall API consistensy level.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>