ignite-5097 is ready for review (BinaryMarshaller should write ints in "varint" encoding where it makes sense)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

ignite-5097 is ready for review (BinaryMarshaller should write ints in "varint" encoding where it makes sense)

daradurvs
Hi Igniteres!

Java part is ready for review.

BinaryMarshaller should write ints in "varint" encoding where it makes sense
<https://issues.apache.org/jira/browse/IGNITE-5097>
ci.tests <http://ci.ignite.apache.org/viewQueued.html?itemId=599431>
PR <https://github.com/apache/ignite/pull/1902/files>


--
Best Regards, Vyacheslav
Reply | Threaded
Open this post in threaded view
|

Re: ignite-5097 is ready for review (BinaryMarshaller should write ints in "varint" encoding where it makes sense)

daradurvs
Any thoughts about implemented solution?

2017-05-04 13:26 GMT+03:00 Vyacheslav Daradur <[hidden email]>:

> Hi Igniteres!
>
> Java part is ready for review.
>
> BinaryMarshaller should write ints in "varint" encoding where it makes
> sense <https://issues.apache.org/jira/browse/IGNITE-5097>
> ci.tests <http://ci.ignite.apache.org/viewQueued.html?itemId=599431>
> PR <https://github.com/apache/ignite/pull/1902/files>
>
>
> --
> Best Regards, Vyacheslav
>



--
Best Regards, Vyacheslav
Reply | Threaded
Open this post in threaded view
|

Re: ignite-5097 is ready for review (BinaryMarshaller should write ints in "varint" encoding where it makes sense)

dmagda
As I see the discussion is happening in JIRA.

BTW, can we do this improvement without breaking compatibility with 2.0?


Denis

> On May 15, 2017, at 5:08 AM, Vyacheslav Daradur <[hidden email]> wrote:
>
> Any thoughts about implemented solution?
>
> 2017-05-04 13:26 GMT+03:00 Vyacheslav Daradur <[hidden email]>:
>
>> Hi Igniteres!
>>
>> Java part is ready for review.
>>
>> BinaryMarshaller should write ints in "varint" encoding where it makes
>> sense <https://issues.apache.org/jira/browse/IGNITE-5097>
>> ci.tests <http://ci.ignite.apache.org/viewQueued.html?itemId=599431>
>> PR <https://github.com/apache/ignite/pull/1902/files>
>>
>>
>> --
>> Best Regards, Vyacheslav
>>
>
>
>
> --
> Best Regards, Vyacheslav

Reply | Threaded
Open this post in threaded view
|

Re: ignite-5097 is ready for review (BinaryMarshaller should write ints in "varint" encoding where it makes sense)

daradurvs
Denis,

It changes format of serialized data. (arrays, Collection, Map, BigDecimal,
String, Enum)

Data which will have been serialized before this improvement won't be able
to be deserialized after and vice versa.

2017-05-16 2:52 GMT+03:00 Denis Magda <[hidden email]>:

> As I see the discussion is happening in JIRA.
>
> BTW, can we do this improvement without breaking compatibility with 2.0?
>
> —
> Denis
>
> > On May 15, 2017, at 5:08 AM, Vyacheslav Daradur <[hidden email]>
> wrote:
> >
> > Any thoughts about implemented solution?
> >
> > 2017-05-04 13:26 GMT+03:00 Vyacheslav Daradur <[hidden email]>:
> >
> >> Hi Igniteres!
> >>
> >> Java part is ready for review.
> >>
> >> BinaryMarshaller should write ints in "varint" encoding where it makes
> >> sense <https://issues.apache.org/jira/browse/IGNITE-5097>
> >> ci.tests <http://ci.ignite.apache.org/viewQueued.html?itemId=599431>
> >> PR <https://github.com/apache/ignite/pull/1902/files>
> >>
> >>
> >> --
> >> Best Regards, Vyacheslav
> >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav
>
>


--
Best Regards, Vyacheslav