ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

daradurvs
Hello everyone.

Please review changes: *https://issues.apache.org/jira/browse/IGNITE-4823
<https://issues.apache.org/jira/browse/IGNITE-4823>*

I found this when I worked on an another issue.

If I'm not mistaken it's wrong implementation.

--
Best Regards, Vyacheslav
Reply | Threaded
Open this post in threaded view
|

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Valentin Kulichenko
Vyacheslav,

I will review and merge in nearest time.

-Val

On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <[hidden email]>
wrote:

> Hello everyone.
>
> Please review changes: *https://issues.apache.org/jira/browse/IGNITE-4823
> <https://issues.apache.org/jira/browse/IGNITE-4823>*
>
> I found this when I worked on an another issue.
>
> If I'm not mistaken it's wrong implementation.
>
> --
> Best Regards, Vyacheslav
>
Reply | Threaded
Open this post in threaded view
|

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

daradurvs
Valentin, ok, thank you.

2017-03-16 18:39 GMT+03:00 Valentin Kulichenko <
[hidden email]>:

> Vyacheslav,
>
> I will review and merge in nearest time.
>
> -Val
>
> On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <[hidden email]>
> wrote:
>
> > Hello everyone.
> >
> > Please review changes: *https://issues.apache.org/
> jira/browse/IGNITE-4823
> > <https://issues.apache.org/jira/browse/IGNITE-4823>*
> >
> > I found this when I worked on an another issue.
> >
> > If I'm not mistaken it's wrong implementation.
> >
> > --
> > Best Regards, Vyacheslav
> >
>



--
Best Regards, Vyacheslav
Reply | Threaded
Open this post in threaded view
|

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Valentin Kulichenko
Hi Vyacheslav,

I reviewed and merged you changes to master. Thanks for the contribution!

-Val

On Fri, Mar 17, 2017 at 12:06 AM, Vyacheslav Daradur <[hidden email]>
wrote:

> Valentin, ok, thank you.
>
> 2017-03-16 18:39 GMT+03:00 Valentin Kulichenko <
> [hidden email]>:
>
> > Vyacheslav,
> >
> > I will review and merge in nearest time.
> >
> > -Val
> >
> > On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <[hidden email]
> >
> > wrote:
> >
> > > Hello everyone.
> > >
> > > Please review changes: *https://issues.apache.org/
> > jira/browse/IGNITE-4823
> > > <https://issues.apache.org/jira/browse/IGNITE-4823>*
> > >
> > > I found this when I worked on an another issue.
> > >
> > > If I'm not mistaken it's wrong implementation.
> > >
> > > --
> > > Best Regards, Vyacheslav
> > >
> >
>
>
>
> --
> Best Regards, Vyacheslav
>