guard() and checkClusterState() checks in Ignite Kernal

[Ilya Kasnacheev]

Dear Igniters,

I would like to know if guard() and checkClusterState() methods are always
called consistently in IgniteKernal.

Let's look at the list:
Out of cluster(), localNode(), compute(), message(), events(),
executorService(), services() only the last one is guarded by
checkClusterState()
Is this correct?

pingNode() is not checked or guarded, but pingNodeByAddress() is guarded.
Is this correct?

undeployTaskFromGrid() and executeTask() are neither checked nor guarded.

eventUserRecordable() and allEventsUserRecordable() are guarded but not
cheked. Is this correct?

getOrCreateCaches() and destroyCachesAsync() are guarded but not checked -
am I correct in trying to fix that in
https://github.com/apache/ignite/pull/2526 ?

destroyCache() and destroyCaches() are neither guarded nor checked, but
destroyCacheAsync() both guarded and checked. What's the reason for that?

binary() and affinity() are checked but not guarded.

active(), resetLostPartitions(), memoryMetrics(), persistentStoreMetrics(),
atomicSequence() are guarded but not checked.

I appreciate your support.

--
Ilya Kasnacheev

[Ilya Kasnacheev]

Rehi,

After some discussions https://github.com/apache/ignite/pull/2526 seems to
have correct changeset that covers two methods which seem to have been
overlooked before.
It's already reviewed by another contributor, please merge it into master
you seem fit.

Regards,
Ilya.

--
Ilya Kasnacheev

2017-08-29 15:42 GMT+03:00 Ilya Kasnacheev <[hidden email]>:

> Dear Igniters,
>
> I would like to know if guard() and checkClusterState() methods are always
> called consistently in IgniteKernal.
>
> Let's look at the list:
> Out of cluster(), localNode(), compute(), message(), events(),
> executorService(), services() only the last one is guarded by
> checkClusterState()
> Is this correct?
>
> pingNode() is not checked or guarded, but pingNodeByAddress() is guarded.
> Is this correct?
>
> undeployTaskFromGrid() and executeTask() are neither checked nor guarded.
>
> eventUserRecordable() and allEventsUserRecordable() are guarded but not
> cheked. Is this correct?
>
> getOrCreateCaches() and destroyCachesAsync() are guarded but not checked -
> am I correct in trying to fix that in https://github.com/apache/
> ignite/pull/2526 ?
>
> destroyCache() and destroyCaches() are neither guarded nor checked, but
> destroyCacheAsync() both guarded and checked. What's the reason for that?
>
> binary() and affinity() are checked but not guarded.
>
> active(), resetLostPartitions(), memoryMetrics(),
> persistentStoreMetrics(), atomicSequence() are guarded but not checked.
>
> I appreciate your support.
>
> --
> Ilya Kasnacheev
>

[dsetrakyan]

Is there a ticket for this change?

On Tue, Sep 12, 2017 at 4:25 AM, Ilya Kasnacheev <[hidden email]>
wrote:

> Rehi,
>
> After some discussions https://github.com/apache/ignite/pull/2526 seems to
> have correct changeset that covers two methods which seem to have been
> overlooked before.
> It's already reviewed by another contributor, please merge it into master
> you seem fit.
>
> Regards,
> Ilya.
>
> --
> Ilya Kasnacheev
>
> 2017-08-29 15:42 GMT+03:00 Ilya Kasnacheev <[hidden email]>:
>
> > Dear Igniters,
> >
> > I would like to know if guard() and checkClusterState() methods are
> always
> > called consistently in IgniteKernal.
> >
> > Let's look at the list:
> > Out of cluster(), localNode(), compute(), message(), events(),
> > executorService(), services() only the last one is guarded by
> > checkClusterState()
> > Is this correct?
> >
> > pingNode() is not checked or guarded, but pingNodeByAddress() is guarded.
> > Is this correct?
> >
> > undeployTaskFromGrid() and executeTask() are neither checked nor guarded.
> >
> > eventUserRecordable() and allEventsUserRecordable() are guarded but not
> > cheked. Is this correct?
> >
> > getOrCreateCaches() and destroyCachesAsync() are guarded but not checked
> -
> > am I correct in trying to fix that in https://github.com/apache/
> > ignite/pull/2526 ?
> >
> > destroyCache() and destroyCaches() are neither guarded nor checked, but
> > destroyCacheAsync() both guarded and checked. What's the reason for that?
> >
> > binary() and affinity() are checked but not guarded.
> >
> > active(), resetLostPartitions(), memoryMetrics(),
> > persistentStoreMetrics(), atomicSequence() are guarded but not checked.
> >
> > I appreciate your support.
> >
> > --
> > Ilya Kasnacheev
> >
>

[Ilya Kasnacheev]

Hello Dmitriy,

Yes, there is: https://issues.apache.org/jira/browse/IGNITE-6184

Regards,

--
Ilya Kasnacheev

2017-09-13 1:46 GMT+03:00 Dmitriy Setrakyan <[hidden email]>:

> Is there a ticket for this change?
>
> On Tue, Sep 12, 2017 at 4:25 AM, Ilya Kasnacheev <
> [hidden email]>
> wrote:
>
> > Rehi,
> >
> > After some discussions https://github.com/apache/ignite/pull/2526 seems
> to
> > have correct changeset that covers two methods which seem to have been
> > overlooked before.
> > It's already reviewed by another contributor, please merge it into master
> > you seem fit.
> >
> > Regards,
> > Ilya.
> >
> > --
> > Ilya Kasnacheev
> >
> > 2017-08-29 15:42 GMT+03:00 Ilya Kasnacheev <[hidden email]>:
> >
> > > Dear Igniters,
> > >
> > > I would like to know if guard() and checkClusterState() methods are
> > always
> > > called consistently in IgniteKernal.
> > >
> > > Let's look at the list:
> > > Out of cluster(), localNode(), compute(), message(), events(),
> > > executorService(), services() only the last one is guarded by
> > > checkClusterState()
> > > Is this correct?
> > >
> > > pingNode() is not checked or guarded, but pingNodeByAddress() is
> guarded.
> > > Is this correct?
> > >
> > > undeployTaskFromGrid() and executeTask() are neither checked nor
> guarded.
> > >
> > > eventUserRecordable() and allEventsUserRecordable() are guarded but not
> > > cheked. Is this correct?
> > >
> > > getOrCreateCaches() and destroyCachesAsync() are guarded but not
> checked
> > -
> > > am I correct in trying to fix that in https://github.com/apache/
> > > ignite/pull/2526 ?
> > >
> > > destroyCache() and destroyCaches() are neither guarded nor checked, but
> > > destroyCacheAsync() both guarded and checked. What's the reason for
> that?
> > >
> > > binary() and affinity() are checked but not guarded.
> > >
> > > active(), resetLostPartitions(), memoryMetrics(),
> > > persistentStoreMetrics(), atomicSequence() are guarded but not checked.
> > >
> > > I appreciate your support.
> > >
> > > --
> > > Ilya Kasnacheev
> > >
> >
>