Committers, especially Anton V. and Vovan,
I’ve been looking at the following ticket [1] and found out that the issue happens simply because both org.apache.ignite.binary.BinaryObjectBuilder and org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl are not added to META-INF/classnames.properties file. However, when I build the project from scratch I don’t see the file to be updated. There is still no entries for BinaryObjectBuilder* classes. Even more, if I download 1.8 release there is not META-INF/classnames.properties file at all. Did we introduce a bug or change the logic? [1] https://issues.apache.org/jira/browse/IGNITE-2422 <https://issues.apache.org/jira/browse/IGNITE-2422> — Denis |
I'm not sure about sources.
But "mvn clean package" should generate "modules/core/target/classes/META-INF/classnames.properties" And yes, I think we should also push "fresh" classnames.properties as one of pre-release steps. On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <[hidden email]> wrote: > Committers, especially Anton V. and Vovan, > > I’ve been looking at the following ticket [1] and found out that the issue > happens simply because both > > org.apache.ignite.binary.BinaryObjectBuilder > > and > > org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl > > are not added to META-INF/classnames.properties file. > > However, when I build the project from scratch I don’t see the file to be > updated. There is still no entries for BinaryObjectBuilder* classes. Even > more, if I download 1.8 release there is not META-INF/classnames.properties > file at all. Did we introduce a bug or change the logic? > > > [1] https://issues.apache.org/jira/browse/IGNITE-2422 < > https://issues.apache.org/jira/browse/IGNITE-2422> > > — > Denis -- Alexey Kuznetsov GridGain Systems www.gridgain.com |
Well, the “classnames.properties” is not fully updated at build time. I’ve corrected the description of the ticket.
https://issues.apache.org/jira/browse/IGNITE-2422 <https://issues.apache.org/jira/browse/IGNITE-2422> Maksim Kozlov, would you handle this? Anton V. and Vladimir O. can assist you going forward. — Denis > On Jan 9, 2017, at 10:18 PM, Alexey Kuznetsov <[hidden email]> wrote: > > I'm not sure about sources. > > But "mvn clean package" should generate > "modules/core/target/classes/META-INF/classnames.properties" > > And yes, I think we should also push "fresh" classnames.properties as one > of pre-release steps. > > On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <[hidden email]> wrote: > >> Committers, especially Anton V. and Vovan, >> >> I’ve been looking at the following ticket [1] and found out that the issue >> happens simply because both >> >> org.apache.ignite.binary.BinaryObjectBuilder >> >> and >> >> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl >> >> are not added to META-INF/classnames.properties file. >> >> However, when I build the project from scratch I don’t see the file to be >> updated. There is still no entries for BinaryObjectBuilder* classes. Even >> more, if I download 1.8 release there is not META-INF/classnames.properties >> file at all. Did we introduce a bug or change the logic? >> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-2422 < >> https://issues.apache.org/jira/browse/IGNITE-2422> >> >> — >> Denis > > > > > -- > Alexey Kuznetsov > GridGain Systems > www.gridgain.com |
Well, I've seen the updated ticket.
2017-01-12 1:07 GMT+03:00 Denis Magda <[hidden email]>: > Well, the “classnames.properties” is not fully updated at build time. I’ve > corrected the description of the ticket. > https://issues.apache.org/jira/browse/IGNITE-2422 < > https://issues.apache.org/jira/browse/IGNITE-2422> > > Maksim Kozlov, would you handle this? Anton V. and Vladimir O. can assist > you going forward. > > — > Denis > > > On Jan 9, 2017, at 10:18 PM, Alexey Kuznetsov <[hidden email]> > wrote: > > > > I'm not sure about sources. > > > > But "mvn clean package" should generate > > "modules/core/target/classes/META-INF/classnames.properties" > > > > And yes, I think we should also push "fresh" classnames.properties as one > > of pre-release steps. > > > > On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <[hidden email]> wrote: > > > >> Committers, especially Anton V. and Vovan, > >> > >> I’ve been looking at the following ticket [1] and found out that the > issue > >> happens simply because both > >> > >> org.apache.ignite.binary.BinaryObjectBuilder > >> > >> and > >> > >> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl > >> > >> are not added to META-INF/classnames.properties file. > >> > >> However, when I build the project from scratch I don’t see the file to > be > >> updated. There is still no entries for BinaryObjectBuilder* classes. > Even > >> more, if I download 1.8 release there is not > META-INF/classnames.properties > >> file at all. Did we introduce a bug or change the logic? > >> > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-2422 < > >> https://issues.apache.org/jira/browse/IGNITE-2422> > >> > >> — > >> Denis > > > > > > > > > > -- > > Alexey Kuznetsov > > GridGain Systems > > www.gridgain.com > > -- Best regards, Maks Kozlov |
Free forum by Nabble | Edit this page |