Apache Ignite Developers - Legacy Mail Archive

ci.ignite.apache: Run all for patch (jira number)

Classic

List

Threaded

7 messages Options

Cergey

ci.ignite.apache: Run all for patch (jira number)

Hi, igniters,

When trying to run "Run all for patch" build with parameter "jira number" (existing, e.g. IGNITE-6745 or random), build fails (https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAllTestBuilds) with exception: java.net.ConnectException: Connection timed out. Is this functionality not supported or I incorrectly set the jira number ?

Cergey

RE: ci.ignite.apache: Run all for patch (jira number)

Probably, I missed something in the patch (https://issues.apache.org/jira/browse/IGNITE-6745 ) as builds do not (and did not) start automatically. What may be wrong ?

-----Original Message-----
From: Cergey [mailto:[hidden email]]
Sent: Friday, December 1, 2017 12:31 AM
To: [hidden email]
Subject: ci.ignite.apache: Run all for patch (jira number)

Hi, igniters,

When trying to run "Run all for patch" build with parameter "jira number" (existing, e.g. IGNITE-6745 or random), build fails (https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAllTestBuilds) with exception: java.net.ConnectException: Connection timed out. Is this functionality not supported or I incorrectly set the jira number ?

dmagda

Re: ci.ignite.apache: Run all for patch (jira number)

Cergey,

You need to run the tests agains the pull-request. In your case it should be this one - pull/2970/merge

—
Denis

> On Nov 30, 2017, at 12:36 PM, Cergey <[hidden email]> wrote:
>
> Probably, I missed something in the patch (https://issues.apache.org/jira/browse/IGNITE-6745 ) as builds do not (and did not) start automatically. What may be wrong ?
>
> -----Original Message-----
> From: Cergey [mailto:[hidden email]]
> Sent: Friday, December 1, 2017 12:31 AM
> To: [hidden email]
> Subject: ci.ignite.apache: Run all for patch (jira number)
>
> Hi, igniters,
>
> When trying to run "Run all for patch" build with parameter "jira number" (existing, e.g. IGNITE-6745 or random), build fails (https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAllTestBuilds) with exception: java.net.ConnectException: Connection timed out. Is this functionality not supported or I incorrectly set the jira number ?
>
>

Cergey

RE: ci.ignite.apache: Run all for patch (jira number)

But I want to run the tests against the patch in jira (it is kinda easier to make changes in the patch). Is that feasible ?

-----Original Message-----
From: Denis Magda [mailto:[hidden email]]
Sent: Friday, December 1, 2017 4:53 AM
To: [hidden email]
Subject: Re: ci.ignite.apache: Run all for patch (jira number)

Cergey,

You need to run the tests agains the pull-request. In your case it should be this one - pull/2970/merge

—
Denis

dmagda

Re: ci.ignite.apache: Run all for patch (jira number)

It’s possible but requires you to create a branch and pass its name into TeamCity:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file>

However, this approach works only for Ignite committers who have enough permissions for branches creation.

Plus, it’s easier for a reviewer to check the changes via pull-requests and leave comments there.

—
Denis

> On Nov 30, 2017, at 11:28 PM, Cergey <[hidden email]> wrote:
>
> But I want to run the tests against the patch in jira (it is kinda easier to make changes in the patch). Is that feasible ?
>
> -----Original Message-----
> From: Denis Magda [mailto:[hidden email]]
> Sent: Friday, December 1, 2017 4:53 AM
> To: [hidden email]
> Subject: Re: ci.ignite.apache: Run all for patch (jira number)
>
> Cergey,
>
> You need to run the tests agains the pull-request. In your case it should be this one - pull/2970/merge
>
> —
> Denis
>
>> On Nov 30, 2017, at 12:36 PM, Cergey <[hidden email]> wrote:
>>
>> Probably, I missed something in the patch (https://issues.apache.org/jira/browse/IGNITE-6745 ) as builds do not (and did not) start automatically. What may be wrong ?
>>
>> -----Original Message-----
>> From: Cergey [mailto:[hidden email]]
>> Sent: Friday, December 1, 2017 12:31 AM
>> To: [hidden email]
>> Subject: ci.ignite.apache: Run all for patch (jira number)
>>
>> Hi, igniters,
>>
>> When trying to run "Run all for patch" build with parameter "jira number" (existing, e.g. IGNITE-6745 or random), build fails (https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAllTestBuilds) with exception: java.net.ConnectException: Connection timed out. Is this functionality not supported or I incorrectly set the jira number ?
>>
>>
>
>

Dmitriy Pavlov

Re: ci.ignite.apache: Run all for patch (jira number)

Hi Cergey,

for pull requests I use pull/####/head branch specification in changes
field (e.g pull/2970/head)
and
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll run
configuration.

Recently we've updated link on GitHub page so new contributors can see
correct link.

Not sure if `run all for patch` works fine.

Sincerely,
Dmitriy Pavlov

пт, 1 дек. 2017 г. в 20:42, Denis Magda <[hidden email]>:

> It’s possible but requires you to create a branch and pass its name into
> TeamCity:
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
> <
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
> >
>
> However, this approach works only for Ignite committers who have enough
> permissions for branches creation.
>
> Plus, it’s easier for a reviewer to check the changes via pull-requests
> and leave comments there.
>
> —
> Denis
>
> > On Nov 30, 2017, at 11:28 PM, Cergey <[hidden email]> wrote:
> >
> > But I want to run the tests against the patch in jira (it is kinda
> easier to make changes in the patch). Is that feasible ?
> >
> > -----Original Message-----
> > From: Denis Magda [mailto:[hidden email]]
> > Sent: Friday, December 1, 2017 4:53 AM
> > To: [hidden email]
> > Subject: Re: ci.ignite.apache: Run all for patch (jira number)
> >
> > Cergey,
> >
> > You need to run the tests agains the pull-request. In your case it
> should be this one - pull/2970/merge
> >
> > —
> > Denis
> >
> >> On Nov 30, 2017, at 12:36 PM, Cergey <[hidden email]> wrote:
> >>
> >> Probably, I missed something in the patch (
> https://issues.apache.org/jira/browse/IGNITE-6745 ) as builds do not (and
> did not) start automatically. What may be wrong ?
> >>
> >> -----Original Message-----
> >> From: Cergey [mailto:[hidden email]]
> >> Sent: Friday, December 1, 2017 12:31 AM
> >> To: [hidden email]
> >> Subject: ci.ignite.apache: Run all for patch (jira number)
> >>
> >> Hi, igniters,
> >>
> >> When trying to run "Run all for patch" build with parameter "jira
> number" (existing, e.g. IGNITE-6745 or random), build fails (
> https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAllTestBuilds)
> with exception: java.net.ConnectException: Connection timed out. Is this
> functionality not supported or I incorrectly set the jira number ?
> >>
> >>
> >
> >
>
>

Cergey

RE: ci.ignite.apache: Run all for patch (jira number)

The idea of doing so arose after I uploaded the changed patch second time and it didn't appear in teamcity to run against (changes). Should automatic build triggering work ? Anyway, I'll go for patch then.

-----Original Message-----
From: Dmitry Pavlov [mailto:[hidden email]]
Sent: Saturday, December 2, 2017 2:02 AM
To: [hidden email]
Subject: Re: ci.ignite.apache: Run all for patch (jira number)

Hi Cergey,

for pull requests I use pull/####/head branch specification in changes field (e.g pull/2970/head) and https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll run configuration.

Recently we've updated link on GitHub page so new contributors can see correct link.

Not sure if `run all for patch` works fine.

Sincerely,
Dmitriy Pavlov

пт, 1 дек. 2017 г. в 20:42, Denis Magda <[hidden email]>:

> It’s possible but requires you to create a branch and pass its name
> into
> TeamCity:
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#H
> owtoContribute-2.CreateaPatch-file
> <
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#H
> owtoContribute-2.CreateaPatch-file
> >
>
> However, this approach works only for Ignite committers who have
> enough permissions for branches creation.
>
> Plus, it’s easier for a reviewer to check the changes via
> pull-requests and leave comments there.
>
> —
> Denis
>
> > On Nov 30, 2017, at 11:28 PM, Cergey <[hidden email]> wrote:
> >
> > But I want to run the tests against the patch in jira (it is kinda
> easier to make changes in the patch). Is that feasible ?
> >
> > -----Original Message-----
> > From: Denis Magda [mailto:[hidden email]]
> > Sent: Friday, December 1, 2017 4:53 AM
> > To: [hidden email]
> > Subject: Re: ci.ignite.apache: Run all for patch (jira number)
> >
> > Cergey,
> >
> > You need to run the tests agains the pull-request. In your case it
> should be this one - pull/2970/merge
> >
> > —
> > Denis
> >
> >> On Nov 30, 2017, at 12:36 PM, Cergey <[hidden email]> wrote:
> >>
> >> Probably, I missed something in the patch (
> https://issues.apache.org/jira/browse/IGNITE-6745 ) as builds do not
> (and did not) start automatically. What may be wrong ?
> >>
> >> -----Original Message-----
> >> From: Cergey [mailto:[hidden email]]
> >> Sent: Friday, December 1, 2017 12:31 AM
> >> To: [hidden email]
> >> Subject: ci.ignite.apache: Run all for patch (jira number)
> >>
> >> Hi, igniters,
> >>
> >> When trying to run "Run all for patch" build with parameter "jira
> number" (existing, e.g. IGNITE-6745 or random), build fails (
> https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_R
> unAllTestBuilds) with exception: java.net.ConnectException: Connection
> timed out. Is this functionality not supported or I incorrectly set
> the jira number ?
> >>
> >>
> >
> >
>
>