cache store usability

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

cache store usability

dsetrakyan
Igniters,

This is another usability issue that can be addressed quickly. Apparently,
setWriteBehindEnabled(true) is not enough to enable CacheStore, the
setWriteThrough(true) also needs to be enabled.

https://stackoverflow.com/questions/50118842/write-behind-and-write-through

Why not make it easier for our users? If there are no objections, I would
like to fie a ticket to enable the CacheStore if
setWriteBehindEnabled(true) was turned on.

D.
Reply | Threaded
Open this post in threaded view
|

Re: cache store usability

daradurvs
I agree I have noticed that too.

But we can't just call setWriteThrough(true) if
setWriteBehindEnabled(true) was turned on because in this case
CacheStoryFactory should be properly set before.

Maybe it will be better to print to the log a warning which will
notify the user that setWriteBehindEnabled (true) doesn't have effect
without setWriteThrough(true)?



On Wed, May 2, 2018 at 6:23 PM, Dmitriy Setrakyan <[hidden email]> wrote:

> Igniters,
>
> This is another usability issue that can be addressed quickly. Apparently,
> setWriteBehindEnabled(true) is not enough to enable CacheStore, the
> setWriteThrough(true) also needs to be enabled.
>
> https://stackoverflow.com/questions/50118842/write-behind-and-write-through
>
> Why not make it easier for our users? If there are no objections, I would
> like to fie a ticket to enable the CacheStore if
> setWriteBehindEnabled(true) was turned on.
>
> D.



--
Best Regards, Vyacheslav D.
Reply | Threaded
Open this post in threaded view
|

Re: cache store usability

Valentin Kulichenko
Vyacheslav,

There is already a warning for this:
https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java#L225

-Val

On Wed, May 2, 2018 at 11:31 AM, Vyacheslav Daradur <[hidden email]>
wrote:

> I agree I have noticed that too.
>
> But we can't just call setWriteThrough(true) if
> setWriteBehindEnabled(true) was turned on because in this case
> CacheStoryFactory should be properly set before.
>
> Maybe it will be better to print to the log a warning which will
> notify the user that setWriteBehindEnabled (true) doesn't have effect
> without setWriteThrough(true)?
>
>
>
> On Wed, May 2, 2018 at 6:23 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
> > Igniters,
> >
> > This is another usability issue that can be addressed quickly.
> Apparently,
> > setWriteBehindEnabled(true) is not enough to enable CacheStore, the
> > setWriteThrough(true) also needs to be enabled.
> >
> > https://stackoverflow.com/questions/50118842/write-
> behind-and-write-through
> >
> > Why not make it easier for our users? If there are no objections, I would
> > like to fie a ticket to enable the CacheStore if
> > setWriteBehindEnabled(true) was turned on.
> >
> > D.
>
>
>
> --
> Best Regards, Vyacheslav D.
>
Reply | Threaded
Open this post in threaded view
|

Re: cache store usability

dsetrakyan
On Wed, May 2, 2018 at 4:15 PM, Valentin Kulichenko <
[hidden email]> wrote:

> Vyacheslav,
>
> There is already a warning for this:
> https://github.com/apache/ignite/blob/master/modules/
> core/src/main/java/org/apache/ignite/internal/processors/cache/store/
> GridCacheStoreManagerAdapter.java#L225


Val, why not enable write through if either one is set to true?