Apache Ignite Developers - Legacy Mail Archive

abbrevation rules plugin

Classic

List

Threaded

26 messages Options

voipp

abbrevation rules plugin

Igntrs!
There is a plugin , mentioned in Abbreviation Rules
<https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules> page
that performs on-the-fly check.Is somebody going to add it some day?
--

*Best Regards,*

*Kuznetsov Aleksey*

Valentin Kulichenko

Re: abbrevation rules plugin

The plugin actually exists, not sure why it's not attached. Does anyone has
it?

-Val

On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <[hidden email]>
wrote:

> Igntrs!
> There is a plugin , mentioned in Abbreviation Rules
> <https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
> page
> that performs on-the-fly check.Is somebody going to add it some day?
> --
>
> *Best Regards,*
>
> *Kuznetsov Aleksey*
>

Dmitriy Pavlov

Re: abbrevation rules plugin

Hi, Val,

No, this plugin is not available in apache-ignite code base.
May be we should remove reference from JIRA or add this plugin (and also
other code inspections) into AI code base.
Thoughts?

Sincerely,
Dmitriy Pavlov

вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
[hidden email]>:

> The plugin actually exists, not sure why it's not attached. Does anyone has
> it?
>
> -Val
>
> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> [hidden email]>
> wrote:
>
> > Igntrs!
> > There is a plugin , mentioned in Abbreviation Rules
> > <https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
> > page
> > that performs on-the-fly check.Is somebody going to add it some day?
> > --
> >
> > *Best Regards,*
> >
> > *Kuznetsov Aleksey*
> >
>

voipp

Re: abbrevation rules plugin

Yeah, it would be very helpful.

вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:

> Hi, Val,
>
> No, this plugin is not available in apache-ignite code base.
> May be we should remove reference from JIRA or add this plugin (and also
> other code inspections) into AI code base.
> Thoughts?
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
> [hidden email]>:
>
> > The plugin actually exists, not sure why it's not attached. Does anyone
> has
> > it?
> >
> > -Val
> >
> > On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> > [hidden email]>
> > wrote:
> >
> > > Igntrs!
> > > There is a plugin , mentioned in Abbreviation Rules
> > > <https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
> >
> > > page
> > > that performs on-the-fly check.Is somebody going to add it some day?
> > > --
> > >
> > > *Best Regards,*
> > >
> > > *Kuznetsov Aleksey*
> > >
> >
>

--

*Best Regards,*

*Kuznetsov Aleksey*

Dmitriy Pavlov

Re: abbrevation rules plugin

Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698 for
this task.

It is not clear for me yet how to publish correctly - is it possible to
publish JAR.

ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <[hidden email]>:

> Yeah, it would be very helpful.
>
> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
>
> > Hi, Val,
> >
> > No, this plugin is not available in apache-ignite code base.
> > May be we should remove reference from JIRA or add this plugin (and also
> > other code inspections) into AI code base.
> > Thoughts?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
> > [hidden email]>:
> >
> > > The plugin actually exists, not sure why it's not attached. Does anyone
> > has
> > > it?
> > >
> > > -Val
> > >
> > > On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> > > [hidden email]>
> > > wrote:
> > >
> > > > Igntrs!
> > > > There is a plugin , mentioned in Abbreviation Rules
> > > > <
> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
> > >
> > > > page
> > > > that performs on-the-fly check.Is somebody going to add it some day?
> > > > --
> > > >
> > > > *Best Regards,*
> > > >
> > > > *Kuznetsov Aleksey*
> > > >
> > >
> >
> --
>
> *Best Regards,*
>
> *Kuznetsov Aleksey*
>

Dmitriy Pavlov

Re: abbrevation rules plugin

Hi Igniters,

Could you please share your opinion about this topic?

The question is as follows: Is it allowed to place abbreviation plugin as
jar file into ignite source code? Abbrev-plugin.jar is jar file and I am
not aware if it is allowed to place jars in git.

Sincerely,
Dmitriy Pavlov

ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:

> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698 for
> this task.
>
> It is not clear for me yet how to publish correctly - is it possible to
> publish JAR.
>
> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <[hidden email]>:
>
>> Yeah, it would be very helpful.
>>
>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
>>
>> > Hi, Val,
>> >
>> > No, this plugin is not available in apache-ignite code base.
>> > May be we should remove reference from JIRA or add this plugin (and also
>> > other code inspections) into AI code base.
>> > Thoughts?
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> > вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
>> > [hidden email]>:
>> >
>> > > The plugin actually exists, not sure why it's not attached. Does
>> anyone
>> > has
>> > > it?
>> > >
>> > > -Val
>> > >
>> > > On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
>> > > [hidden email]>
>> > > wrote:
>> > >
>> > > > Igntrs!
>> > > > There is a plugin , mentioned in Abbreviation Rules
>> > > > <
>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
>> > >
>> > > > page
>> > > > that performs on-the-fly check.Is somebody going to add it some day?
>> > > > --
>> > > >
>> > > > *Best Regards,*
>> > > >
>> > > > *Kuznetsov Aleksey*
>> > > >
>> > >
>> >
>> --
>>
>> *Best Regards,*
>>
>> *Kuznetsov Aleksey*
>>
>

dsetrakyan

Re: abbrevation rules plugin

Hi Dmitriy,

The answer is No. We should put it as a source code and integrate it into
our build procedure.

D.

On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]> wrote:

> Hi Igniters,
>
> Could you please share your opinion about this topic?
>
> The question is as follows: Is it allowed to place abbreviation plugin as
> jar file into ignite source code? Abbrev-plugin.jar is jar file and I am
> not aware if it is allowed to place jars in git.
>
> Sincerely,
> Dmitriy Pavlov
>
>
> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
>
> > Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698 for
> > this task.
> >
> > It is not clear for me yet how to publish correctly - is it possible to
> > publish JAR.
> >
> > ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <[hidden email]
> >:
> >
> >> Yeah, it would be very helpful.
> >>
> >> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
> >>
> >> > Hi, Val,
> >> >
> >> > No, this plugin is not available in apache-ignite code base.
> >> > May be we should remove reference from JIRA or add this plugin (and
> also
> >> > other code inspections) into AI code base.
> >> > Thoughts?
> >> >
> >> > Sincerely,
> >> > Dmitriy Pavlov
> >> >
> >> > вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
> >> > [hidden email]>:
> >> >
> >> > > The plugin actually exists, not sure why it's not attached. Does
> >> anyone
> >> > has
> >> > > it?
> >> > >
> >> > > -Val
> >> > >
> >> > > On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> >> > > [hidden email]>
> >> > > wrote:
> >> > >
> >> > > > Igntrs!
> >> > > > There is a plugin , mentioned in Abbreviation Rules
> >> > > > <
> >> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
> >> > >
> >> > > > page
> >> > > > that performs on-the-fly check.Is somebody going to add it some
> day?
> >> > > > --
> >> > > >
> >> > > > *Best Regards,*
> >> > > >
> >> > > > *Kuznetsov Aleksey*
> >> > > >
> >> > >
> >> >
> >> --
> >>
> >> *Best Regards,*
> >>
> >> *Kuznetsov Aleksey*
> >>
> >
>

dmagda

Re: abbrevation rules plugin

Guys,

Let’s make things simple and attach the jar of the plugin to the wiki page that refers to it:
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>

This should be fine from ASF standpoint.

—
Denis

> On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <[hidden email]> wrote:
>
> Hi Dmitriy,
>
> The answer is No. We should put it as a source code and integrate it into
> our build procedure.
>
> D.
>
> On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]> wrote:
>
>> Hi Igniters,
>>
>> Could you please share your opinion about this topic?
>>
>> The question is as follows: Is it allowed to place abbreviation plugin as
>> jar file into ignite source code? Abbrev-plugin.jar is jar file and I am
>> not aware if it is allowed to place jars in git.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>>
>> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
>>
>>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698 for
>>> this task.
>>>
>>> It is not clear for me yet how to publish correctly - is it possible to
>>> publish JAR.
>>>
>>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <[hidden email]
>>> :
>>>
>>>> Yeah, it would be very helpful.
>>>>
>>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
>>>>
>>>>> Hi, Val,
>>>>>
>>>>> No, this plugin is not available in apache-ignite code base.
>>>>> May be we should remove reference from JIRA or add this plugin (and
>> also
>>>>> other code inspections) into AI code base.
>>>>> Thoughts?
>>>>>
>>>>> Sincerely,
>>>>> Dmitriy Pavlov
>>>>>
>>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
>>>>> [hidden email]>:
>>>>>
>>>>>> The plugin actually exists, not sure why it's not attached. Does
>>>> anyone
>>>>> has
>>>>>> it?
>>>>>>
>>>>>> -Val
>>>>>>
>>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
>>>>>> [hidden email]>
>>>>>> wrote:
>>>>>>
>>>>>>> Igntrs!
>>>>>>> There is a plugin , mentioned in Abbreviation Rules
>>>>>>> <
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
>>>>>>
>>>>>>> page
>>>>>>> that performs on-the-fly check.Is somebody going to add it some
>> day?
>>>>>>> --
>>>>>>>
>>>>>>> *Best Regards,*
>>>>>>>
>>>>>>> *Kuznetsov Aleksey*
>>>>>>>
>>>>>>
>>>>>
>>>> --
>>>>
>>>> *Best Regards,*
>>>>
>>>> *Kuznetsov Aleksey*
>>>>
>>>
>>

dsetrakyan

Re: abbrevation rules plugin

Denis,

Apache cannot have any binary files anywhere in its code bases. All binary
JARs must be produced from a build process. If we are adding this plugin,
then the source for it needs to be committed to AI code base and the JAR
should be generated from the build.

Once the JAR is generated, only then you can include it on a web page to
download.

D.

On Wed, Jul 5, 2017 at 3:19 PM, Denis Magda <[hidden email]> wrote:

> Guys,
>
> Let’s make things simple and attach the jar of the plugin to the wiki page
> that refers to it:
> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <
> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
>
> This should be fine from ASF standpoint.
>
> —
> Denis
>
> > On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <[hidden email]>
> wrote:
> >
> > Hi Dmitriy,
> >
> > The answer is No. We should put it as a source code and integrate it into
> > our build procedure.
> >
> > D.
> >
> > On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]>
> wrote:
> >
> >> Hi Igniters,
> >>
> >> Could you please share your opinion about this topic?
> >>
> >> The question is as follows: Is it allowed to place abbreviation plugin
> as
> >> jar file into ignite source code? Abbrev-plugin.jar is jar file and I am
> >> not aware if it is allowed to place jars in git.
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
> >>
> >> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
> >>
> >>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698
> for
> >>> this task.
> >>>
> >>> It is not clear for me yet how to publish correctly - is it possible to
> >>> publish JAR.
> >>>
> >>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <
> [hidden email]
> >>> :
> >>>
> >>>> Yeah, it would be very helpful.
> >>>>
> >>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
> >>>>
> >>>>> Hi, Val,
> >>>>>
> >>>>> No, this plugin is not available in apache-ignite code base.
> >>>>> May be we should remove reference from JIRA or add this plugin (and
> >> also
> >>>>> other code inspections) into AI code base.
> >>>>> Thoughts?
> >>>>>
> >>>>> Sincerely,
> >>>>> Dmitriy Pavlov
> >>>>>
> >>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
> >>>>> [hidden email]>:
> >>>>>
> >>>>>> The plugin actually exists, not sure why it's not attached. Does
> >>>> anyone
> >>>>> has
> >>>>>> it?
> >>>>>>
> >>>>>> -Val
> >>>>>>
> >>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> >>>>>> [hidden email]>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Igntrs!
> >>>>>>> There is a plugin , mentioned in Abbreviation Rules
> >>>>>>> <
> >>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
> >>>>>>
> >>>>>>> page
> >>>>>>> that performs on-the-fly check.Is somebody going to add it some
> >> day?
> >>>>>>> --
> >>>>>>>
> >>>>>>> *Best Regards,*
> >>>>>>>
> >>>>>>> *Kuznetsov Aleksey*
> >>>>>>>
> >>>>>>
> >>>>>
> >>>> --
> >>>>
> >>>> *Best Regards,*
> >>>>
> >>>> *Kuznetsov Aleksey*
> >>>>
> >>>
> >>
>
>

dmagda

Re: abbrevation rules plugin

Dmitriy,

I’m not suggesting to add the JAR to the source code or to any binary package but rather treat it as a third party plugin developed by someone for Ignite’s development simplification. It’s similar to the way the community uses Intellij IDEA’s plugins or Team City or many other maven modules imported in the project - they don’t need to be a part of Ignite sources or binaries to be used.

—
Denis

> On Jul 5, 2017, at 4:13 PM, Dmitriy Setrakyan <[hidden email]> wrote:
>
> Denis,
>
> Apache cannot have any binary files anywhere in its code bases. All binary
> JARs must be produced from a build process. If we are adding this plugin,
> then the source for it needs to be committed to AI code base and the JAR
> should be generated from the build.
>
> Once the JAR is generated, only then you can include it on a web page to
> download.
>
> D.
>
> On Wed, Jul 5, 2017 at 3:19 PM, Denis Magda <[hidden email]> wrote:
>
>> Guys,
>>
>> Let’s make things simple and attach the jar of the plugin to the wiki page
>> that refers to it:
>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <
>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
>>
>> This should be fine from ASF standpoint.
>>
>> —
>> Denis
>>
>>> On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <[hidden email]>
>> wrote:
>>>
>>> Hi Dmitriy,
>>>
>>> The answer is No. We should put it as a source code and integrate it into
>>> our build procedure.
>>>
>>> D.
>>>
>>> On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]>
>> wrote:
>>>
>>>> Hi Igniters,
>>>>
>>>> Could you please share your opinion about this topic?
>>>>
>>>> The question is as follows: Is it allowed to place abbreviation plugin
>> as
>>>> jar file into ignite source code? Abbrev-plugin.jar is jar file and I am
>>>> not aware if it is allowed to place jars in git.
>>>>
>>>> Sincerely,
>>>> Dmitriy Pavlov
>>>>
>>>>
>>>> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
>>>>
>>>>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698
>> for
>>>>> this task.
>>>>>
>>>>> It is not clear for me yet how to publish correctly - is it possible to
>>>>> publish JAR.
>>>>>
>>>>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <
>> [hidden email]
>>>>> :
>>>>>
>>>>>> Yeah, it would be very helpful.
>>>>>>
>>>>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
>>>>>>
>>>>>>> Hi, Val,
>>>>>>>
>>>>>>> No, this plugin is not available in apache-ignite code base.
>>>>>>> May be we should remove reference from JIRA or add this plugin (and
>>>> also
>>>>>>> other code inspections) into AI code base.
>>>>>>> Thoughts?
>>>>>>>
>>>>>>> Sincerely,
>>>>>>> Dmitriy Pavlov
>>>>>>>
>>>>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
>>>>>>> [hidden email]>:
>>>>>>>
>>>>>>>> The plugin actually exists, not sure why it's not attached. Does
>>>>>> anyone
>>>>>>> has
>>>>>>>> it?
>>>>>>>>
>>>>>>>> -Val
>>>>>>>>
>>>>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
>>>>>>>> [hidden email]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Igntrs!
>>>>>>>>> There is a plugin , mentioned in Abbreviation Rules
>>>>>>>>> <
>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
>>>>>>>>
>>>>>>>>> page
>>>>>>>>> that performs on-the-fly check.Is somebody going to add it some
>>>> day?
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>> *Best Regards,*
>>>>>>>>>
>>>>>>>>> *Kuznetsov Aleksey*
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>> --
>>>>>>
>>>>>> *Best Regards,*
>>>>>>
>>>>>> *Kuznetsov Aleksey*
>>>>>>
>>>>>
>>>>
>>
>>

dsetrakyan

Re: abbrevation rules plugin

On Wed, Jul 5, 2017 at 4:35 PM, Denis Magda <[hidden email]> wrote:

> Dmitriy,
>
> I’m not suggesting to add the JAR to the source code or to any binary
> package but rather treat it as a third party plugin developed by someone
> for Ignite’s development simplification. It’s similar to the way the
> community uses Intellij IDEA’s plugins or Team City or many other maven
> modules imported in the project - they don’t need to be a part of Ignite
> sources or binaries to be used.
>

In this case AI should not host the download itself, but provide a link for
the plugin to be downloaded elsewhere. If AI hosts it and distributes it,
then it needs to be built from the source code.

>
> —
> Denis
>
> > On Jul 5, 2017, at 4:13 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
> >
> > Denis,
> >
> > Apache cannot have any binary files anywhere in its code bases. All
> binary
> > JARs must be produced from a build process. If we are adding this plugin,
> > then the source for it needs to be committed to AI code base and the JAR
> > should be generated from the build.
> >
> > Once the JAR is generated, only then you can include it on a web page to
> > download.
> >
> > D.
> >
> > On Wed, Jul 5, 2017 at 3:19 PM, Denis Magda <[hidden email]> wrote:
> >
> >> Guys,
> >>
> >> Let’s make things simple and attach the jar of the plugin to the wiki
> page
> >> that refers to it:
> >> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <
> >> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
> >>
> >> This should be fine from ASF standpoint.
> >>
> >> —
> >> Denis
> >>
> >>> On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <[hidden email]>
> >> wrote:
> >>>
> >>> Hi Dmitriy,
> >>>
> >>> The answer is No. We should put it as a source code and integrate it
> into
> >>> our build procedure.
> >>>
> >>> D.
> >>>
> >>> On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]>
> >> wrote:
> >>>
> >>>> Hi Igniters,
> >>>>
> >>>> Could you please share your opinion about this topic?
> >>>>
> >>>> The question is as follows: Is it allowed to place abbreviation plugin
> >> as
> >>>> jar file into ignite source code? Abbrev-plugin.jar is jar file and I
> am
> >>>> not aware if it is allowed to place jars in git.
> >>>>
> >>>> Sincerely,
> >>>> Dmitriy Pavlov
> >>>>
> >>>>
> >>>> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
> >>>>
> >>>>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698
> >> for
> >>>>> this task.
> >>>>>
> >>>>> It is not clear for me yet how to publish correctly - is it possible
> to
> >>>>> publish JAR.
> >>>>>
> >>>>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <
> >> [hidden email]
> >>>>> :
> >>>>>
> >>>>>> Yeah, it would be very helpful.
> >>>>>>
> >>>>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
> >>>>>>
> >>>>>>> Hi, Val,
> >>>>>>>
> >>>>>>> No, this plugin is not available in apache-ignite code base.
> >>>>>>> May be we should remove reference from JIRA or add this plugin (and
> >>>> also
> >>>>>>> other code inspections) into AI code base.
> >>>>>>> Thoughts?
> >>>>>>>
> >>>>>>> Sincerely,
> >>>>>>> Dmitriy Pavlov
> >>>>>>>
> >>>>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
> >>>>>>> [hidden email]>:
> >>>>>>>
> >>>>>>>> The plugin actually exists, not sure why it's not attached. Does
> >>>>>> anyone
> >>>>>>> has
> >>>>>>>> it?
> >>>>>>>>
> >>>>>>>> -Val
> >>>>>>>>
> >>>>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
> >>>>>>>> [hidden email]>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Igntrs!
> >>>>>>>>> There is a plugin , mentioned in Abbreviation Rules
> >>>>>>>>> <
> >>>>>> https://cwiki.apache.org/confluence/display/IGNITE/
> Abbreviation+Rules
> >>>>>>>>
> >>>>>>>>> page
> >>>>>>>>> that performs on-the-fly check.Is somebody going to add it some
> >>>> day?
> >>>>>>>>> --
> >>>>>>>>>
> >>>>>>>>> *Best Regards,*
> >>>>>>>>>
> >>>>>>>>> *Kuznetsov Aleksey*
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>> --
> >>>>>>
> >>>>>> *Best Regards,*
> >>>>>>
> >>>>>> *Kuznetsov Aleksey*
> >>>>>>
> >>>>>
> >>>>
> >>
> >>
>
>

dmagda

Re: abbrevation rules plugin

Ok, what if we make sure the plugin is available on GitHub (not Ignite) and give a link to it on the documentation page? This seems to be the easiest way to handle the topic.

—
Denis

> On Jul 5, 2017, at 4:37 PM, Dmitriy Setrakyan <[hidden email]> wrote:
>
> On Wed, Jul 5, 2017 at 4:35 PM, Denis Magda <[hidden email]> wrote:
>
>> Dmitriy,
>>
>> I’m not suggesting to add the JAR to the source code or to any binary
>> package but rather treat it as a third party plugin developed by someone
>> for Ignite’s development simplification. It’s similar to the way the
>> community uses Intellij IDEA’s plugins or Team City or many other maven
>> modules imported in the project - they don’t need to be a part of Ignite
>> sources or binaries to be used.
>>
>
> In this case AI should not host the download itself, but provide a link for
> the plugin to be downloaded elsewhere. If AI hosts it and distributes it,
> then it needs to be built from the source code.
>
>
>>
>> —
>> Denis
>>
>>> On Jul 5, 2017, at 4:13 PM, Dmitriy Setrakyan <[hidden email]>
>> wrote:
>>>
>>> Denis,
>>>
>>> Apache cannot have any binary files anywhere in its code bases. All
>> binary
>>> JARs must be produced from a build process. If we are adding this plugin,
>>> then the source for it needs to be committed to AI code base and the JAR
>>> should be generated from the build.
>>>
>>> Once the JAR is generated, only then you can include it on a web page to
>>> download.
>>>
>>> D.
>>>
>>> On Wed, Jul 5, 2017 at 3:19 PM, Denis Magda <[hidden email]> wrote:
>>>
>>>> Guys,
>>>>
>>>> Let’s make things simple and attach the jar of the plugin to the wiki
>> page
>>>> that refers to it:
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
>>>>
>>>> This should be fine from ASF standpoint.
>>>>
>>>> —
>>>> Denis
>>>>
>>>>> On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <[hidden email]>
>>>> wrote:
>>>>>
>>>>> Hi Dmitriy,
>>>>>
>>>>> The answer is No. We should put it as a source code and integrate it
>> into
>>>>> our build procedure.
>>>>>
>>>>> D.
>>>>>
>>>>> On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <[hidden email]>
>>>> wrote:
>>>>>
>>>>>> Hi Igniters,
>>>>>>
>>>>>> Could you please share your opinion about this topic?
>>>>>>
>>>>>> The question is as follows: Is it allowed to place abbreviation plugin
>>>> as
>>>>>> jar file into ignite source code? Abbrev-plugin.jar is jar file and I
>> am
>>>>>> not aware if it is allowed to place jars in git.
>>>>>>
>>>>>> Sincerely,
>>>>>> Dmitriy Pavlov
>>>>>>
>>>>>>
>>>>>> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <[hidden email]>:
>>>>>>
>>>>>>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698
>>>> for
>>>>>>> this task.
>>>>>>>
>>>>>>> It is not clear for me yet how to publish correctly - is it possible
>> to
>>>>>>> publish JAR.
>>>>>>>
>>>>>>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <
>>>> [hidden email]
>>>>>>> :
>>>>>>>
>>>>>>>> Yeah, it would be very helpful.
>>>>>>>>
>>>>>>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <[hidden email]>:
>>>>>>>>
>>>>>>>>> Hi, Val,
>>>>>>>>>
>>>>>>>>> No, this plugin is not available in apache-ignite code base.
>>>>>>>>> May be we should remove reference from JIRA or add this plugin (and
>>>>>> also
>>>>>>>>> other code inspections) into AI code base.
>>>>>>>>> Thoughts?
>>>>>>>>>
>>>>>>>>> Sincerely,
>>>>>>>>> Dmitriy Pavlov
>>>>>>>>>
>>>>>>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <
>>>>>>>>> [hidden email]>:
>>>>>>>>>
>>>>>>>>>> The plugin actually exists, not sure why it's not attached. Does
>>>>>>>> anyone
>>>>>>>>> has
>>>>>>>>>> it?
>>>>>>>>>>
>>>>>>>>>> -Val
>>>>>>>>>>
>>>>>>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV <
>>>>>>>>>> [hidden email]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Igntrs!
>>>>>>>>>>> There is a plugin , mentioned in Abbreviation Rules
>>>>>>>>>>> <
>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/
>> Abbreviation+Rules
>>>>>>>>>>
>>>>>>>>>>> page
>>>>>>>>>>> that performs on-the-fly check.Is somebody going to add it some
>>>>>> day?
>>>>>>>>>>> --
>>>>>>>>>>>
>>>>>>>>>>> *Best Regards,*
>>>>>>>>>>>
>>>>>>>>>>> *Kuznetsov Aleksey*
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> *Best Regards,*
>>>>>>>>
>>>>>>>> *Kuznetsov Aleksey*
>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>>>
>>
>>

dsetrakyan

Re: abbrevation rules plugin

On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]> wrote:

> Ok, what if we make sure the plugin is available on GitHub (not Ignite)
> and give a link to it on the documentation page? This seems to be the
> easiest way to handle the topic.

I think this will work.

dmagda

Re: abbrevation rules plugin

Dmitriy P.,

Does it sound good to you? If yes, please make sure the plugin is available via a public GitHub repo and refer to it from the doc.

—
Denis

> On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <[hidden email]> wrote:
>
> On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]> wrote:
>
>> Ok, what if we make sure the plugin is available on GitHub (not Ignite)
>> and give a link to it on the documentation page? This seems to be the
>> easiest way to handle the topic.
>
>
> I think this will work.

Dmitriy Pavlov

Re: abbrevation rules plugin

Hi Dmitriy, Denis,

Thank you for your effort to find out solution.
It sound good for me, I have assigned IGNITE-5698 to myself.

Best Regards,
Dmitriy Pavlov

чт, 6 июл. 2017 г. в 2:45, Denis Magda <[hidden email]>:

> Dmitriy P.,
>
> Does it sound good to you? If yes, please make sure the plugin is
> available via a public GitHub repo and refer to it from the doc.
>
> —
> Denis
>
> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <[hidden email]>
> wrote:
> >
> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]> wrote:
> >
> >> Ok, what if we make sure the plugin is available on GitHub (not Ignite)
> >> and give a link to it on the documentation page? This seems to be the
> >> easiest way to handle the topic.
> >
> >
> > I think this will work.
>
>

daradurvs

Re: abbrevation rules plugin

Hi, Igniters!

I got into the task [1] in agreement with Dmitry.

I’ve prepared the PR [2] with following changes:
- added Apache 2.0 license to the header of each file
- replaced prefix ‘Grid’ by ‘Ignite’ in class names
- added README.md with a simple description
- changed version 2.6.3 -> 3.0.0 because the project has own GitHub
releases tab and completely new versioning isn't preferable IMO

Also, I’ve built new artifact and tested it, it works well.

Am I understood the task correct?
If not, please share your notes I will fix them shortly.

As far as I understand someone of GridGain employee should confirm the
plugin's code's donation. It’d be great to confirm that by corporate
email.

[1] https://issues.apache.org/jira/browse/IGNITE-5698
[2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1

On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <[hidden email]> wrote:

> Hi Dmitriy, Denis,
>
> Thank you for your effort to find out solution.
> It sound good for me, I have assigned IGNITE-5698 to myself.
>
> Best Regards,
> Dmitriy Pavlov
>
>
> чт, 6 июл. 2017 г. в 2:45, Denis Magda <[hidden email]>:
>
>> Dmitriy P.,
>>
>> Does it sound good to you? If yes, please make sure the plugin is
>> available via a public GitHub repo and refer to it from the doc.
>>
>> —
>> Denis
>>
>> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <[hidden email]>
>> wrote:
>> >
>> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]> wrote:
>> >
>> >> Ok, what if we make sure the plugin is available on GitHub (not Ignite)
>> >> and give a link to it on the documentation page? This seems to be the
>> >> easiest way to handle the topic.
>> >
>> >
>> > I think this will work.
>>
>>

--
Best Regards, Vyacheslav D.

Anton Vinogradov-2

Re: abbrevation rules plugin

Awesome!

Dmitriy,
please confirm donation and apply the patch.

BTW, we can relocate plugin to apache repo like we did for release scripts
[1].

[1] https://github.com/apache/ignite-release

2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <[hidden email]>:

> Hi, Igniters!
>
> I got into the task [1] in agreement with Dmitry.
>
> I’ve prepared the PR [2] with following changes:
> - added Apache 2.0 license to the header of each file
> - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> - added README.md with a simple description
> - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> releases tab and completely new versioning isn't preferable IMO
>
> Also, I’ve built new artifact and tested it, it works well.
>
> Am I understood the task correct?
> If not, please share your notes I will fix them shortly.
>
> As far as I understand someone of GridGain employee should confirm the
> plugin's code's donation. It’d be great to confirm that by corporate
> email.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-5698
> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
>
>
> On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <[hidden email]>
> wrote:
> > Hi Dmitriy, Denis,
> >
> > Thank you for your effort to find out solution.
> > It sound good for me, I have assigned IGNITE-5698 to myself.
> >
> > Best Regards,
> > Dmitriy Pavlov
> >
> >
> > чт, 6 июл. 2017 г. в 2:45, Denis Magda <[hidden email]>:
> >
> >> Dmitriy P.,
> >>
> >> Does it sound good to you? If yes, please make sure the plugin is
> >> available via a public GitHub repo and refer to it from the doc.
> >>
> >> —
> >> Denis
> >>
> >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <[hidden email]>
> >> wrote:
> >> >
> >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]>
> wrote:
> >> >
> >> >> Ok, what if we make sure the plugin is available on GitHub (not
> Ignite)
> >> >> and give a link to it on the documentation page? This seems to be the
> >> >> easiest way to handle the topic.
> >> >
> >> >
> >> > I think this will work.
> >>
> >>
>
>
>
> --
> Best Regards, Vyacheslav D.
>

Dmitriy Pavlov

Re: abbrevation rules plugin

Thank you, Vyaceslav.

Excellent patch, I've applied PR to
https://github.com/dspavlov/ignite-abbrev-plugin

If we want code style will be learned by all contributors, this donation is
unavoidable.

Dmitriy S,

what do you think?

Lets keep current code base in my github and add build and link to build to
wiki page
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules .

Sincerely,
Dmitriy Pavlov

вт, 3 апр. 2018 г. в 19:46, Anton Vinogradov <[hidden email]>:

> Awesome!
>
> Dmitriy,
> please confirm donation and apply the patch.
>
> BTW, we can relocate plugin to apache repo like we did for release scripts
> [1].
>
> [1] https://github.com/apache/ignite-release
>
>
> 2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur <[hidden email]>:
>
> > Hi, Igniters!
> >
> > I got into the task [1] in agreement with Dmitry.
> >
> > I’ve prepared the PR [2] with following changes:
> > - added Apache 2.0 license to the header of each file
> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names
> > - added README.md with a simple description
> > - changed version 2.6.3 -> 3.0.0 because the project has own GitHub
> > releases tab and completely new versioning isn't preferable IMO
> >
> > Also, I’ve built new artifact and tested it, it works well.
> >
> > Am I understood the task correct?
> > If not, please share your notes I will fix them shortly.
> >
> > As far as I understand someone of GridGain employee should confirm the
> > plugin's code's donation. It’d be great to confirm that by corporate
> > email.
> >
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-5698
> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1
> >
> >
> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov <[hidden email]>
> > wrote:
> > > Hi Dmitriy, Denis,
> > >
> > > Thank you for your effort to find out solution.
> > > It sound good for me, I have assigned IGNITE-5698 to myself.
> > >
> > > Best Regards,
> > > Dmitriy Pavlov
> > >
> > >
> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <[hidden email]>:
> > >
> > >> Dmitriy P.,
> > >>
> > >> Does it sound good to you? If yes, please make sure the plugin is
> > >> available via a public GitHub repo and refer to it from the doc.
> > >>
> > >> —
> > >> Denis
> > >>
> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan <
> [hidden email]>
> > >> wrote:
> > >> >
> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda <[hidden email]>
> > wrote:
> > >> >
> > >> >> Ok, what if we make sure the plugin is available on GitHub (not
> > Ignite)
> > >> >> and give a link to it on the documentation page? This seems to be
> the
> > >> >> easiest way to handle the topic.
> > >> >
> > >> >
> > >> > I think this will work.
> > >>
> > >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >
>

Dmitriy Pavlov

Re: abbrevation rules plugin

In reply to this post by Anton Vinogradov-2

Anton, I also agree here.

Personal github repo is ok for very beginning of tool development, but
eventually apache repo is better.

вт, 3 апр. 2018 г. в 19:46, Anton Vinogradov <[hidden email]>:

agura

Re: abbrevation rules plugin

In reply to this post by daradurvs

Both prefixes "Grid" and "Ignite" in class names are redundant for most
cases. So there is no any rules for this.

вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <[hidden email]>: