Wrong off-heap size is reported for a node

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Wrong off-heap size is reported for a node

Dmitriy Pavlov
Oops, my fault. It seems I forgot to cherry-pick to 2.7, but I resolved
ticket with 2.7 assigned.

I will fix it tomorrow.

ср, 26 сент. 2018 г. в 21:52, Denis Magda <[hidden email]>:

> Thanks, Pavel and the rest of the Igniters involved.
>
> That simple usability improvement is a big deal for those who use Ignite in
> production.
>
> Are we getting it in 2.7?
>
> --
> Denis
>
> On Wed, Sep 26, 2018 at 10:11 AM Dmitriy Pavlov <[hidden email]>
> wrote:
>
> > Hi Igniters,
> >
> > Thanks to everyone, who has participated in this discussion and shared
> > their view and ideas.
> >
> > I've merged fix of changes related to logging only. Fixing of cluster
> > metrics can be done in a separate ticket/discussion.
> >
> > Pavel, thank you for your contribution and for answering my questions.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 24 сент. 2018 г. в 18:52, Pavel Pereslegin <[hidden email]>:
> >
> > > Andrei,
> > > I totally agree with you and I think that "ClusterMetrics" should also
> > > be fixed, I'm just not sure that we should include this change in the
> > > same ticket.
> > > пн, 24 сент. 2018 г. в 18:43, aealexsandrov <[hidden email]>:
> > > >
> > > > Hi,
> > > >
> > > > OK, the user can use it to calculate the off-heap. But I think that
> the
> > > > reason for your changes to fix the calculation of the nonHeap used in
> > > Ignite
> > > > now. For example now REST return "-1" for nonHeapMemoryMaximum. I
> think
> > > that
> > > > it can't be used somehow. So REST possible should be updated as you
> did
> > > for
> > > > log metrics and it will require for the same logic.
> > > >
> > > > BR,
> > > > Andrei
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Wrong off-heap size is reported for a node

Dmitriy Pavlov
Fixed, now the fix is in the ignite-2.7 branch.

ср, 26 сент. 2018 г. в 23:18, Dmitriy Pavlov <[hidden email]>:

> Oops, my fault. It seems I forgot to cherry-pick to 2.7, but I resolved
> ticket with 2.7 assigned.
>
> I will fix it tomorrow.
>
> ср, 26 сент. 2018 г. в 21:52, Denis Magda <[hidden email]>:
>
>> Thanks, Pavel and the rest of the Igniters involved.
>>
>> That simple usability improvement is a big deal for those who use Ignite
>> in
>> production.
>>
>> Are we getting it in 2.7?
>>
>> --
>> Denis
>>
>> On Wed, Sep 26, 2018 at 10:11 AM Dmitriy Pavlov <[hidden email]>
>> wrote:
>>
>> > Hi Igniters,
>> >
>> > Thanks to everyone, who has participated in this discussion and shared
>> > their view and ideas.
>> >
>> > I've merged fix of changes related to logging only. Fixing of cluster
>> > metrics can be done in a separate ticket/discussion.
>> >
>> > Pavel, thank you for your contribution and for answering my questions.
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> > пн, 24 сент. 2018 г. в 18:52, Pavel Pereslegin <[hidden email]>:
>> >
>> > > Andrei,
>> > > I totally agree with you and I think that "ClusterMetrics" should also
>> > > be fixed, I'm just not sure that we should include this change in the
>> > > same ticket.
>> > > пн, 24 сент. 2018 г. в 18:43, aealexsandrov <[hidden email]
>> >:
>> > > >
>> > > > Hi,
>> > > >
>> > > > OK, the user can use it to calculate the off-heap. But I think that
>> the
>> > > > reason for your changes to fix the calculation of the nonHeap used
>> in
>> > > Ignite
>> > > > now. For example now REST return "-1" for nonHeapMemoryMaximum. I
>> think
>> > > that
>> > > > it can't be used somehow. So REST possible should be updated as you
>> did
>> > > for
>> > > > log metrics and it will require for the same logic.
>> > > >
>> > > > BR,
>> > > > Andrei
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>> > >
>> >
>>
>
12