Upsource update required

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Upsource update required

Anton Vinogradov-2
Igniters.

Who is responsible for Upsource [1]?
I see some strange things at reviews, a lot of fake changes inside reviews.
I don't see such changes at PRs.
Could you please check we're using stable version and update if necessary?


[1] https://reviews.ignite.apache.org
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

Dmitriy Pavlov
Hi Igniters, Anton,

According to my experience upsource works well, except 1 suspicious case
with my PR.

So I'm not sure if there are Upsource problems, probably there are problems
with some of our PRs?

My example is https://github.com/apache/ignite/pull/3243 PR and
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-513 ,- it is quite
old PR, so I can suppose it is some commit problem.

Sinerely,
Dmitriy Pavlov

пт, 6 апр. 2018 г. в 14:23, Anton Vinogradov <[hidden email]>:

> Igniters.
>
> Who is responsible for Upsource [1]?
> I see some strange things at reviews, a lot of fake changes inside reviews.
> I don't see such changes at PRs.
> Could you please check we're using stable version and update if necessary?
>
>
> [1] https://reviews.ignite.apache.org
>
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

daradurvs
Dmitry, I confirm that a problem existed.

Upsource can't handle situations of merging master to PR branch, in
this case, Upsorce shows changes which are not related to a pull
request.

I know only one workaround solution: rebasing branch on master and
never merge it, but in this case, we lost mapping between existing
comments and the commits in a pull request.


On Fri, Apr 6, 2018 at 3:05 PM, Dmitry Pavlov <[hidden email]> wrote:

> Hi Igniters, Anton,
>
> According to my experience upsource works well, except 1 suspicious case
> with my PR.
>
> So I'm not sure if there are Upsource problems, probably there are problems
> with some of our PRs?
>
> My example is https://github.com/apache/ignite/pull/3243 PR and
> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-513 ,- it is quite
> old PR, so I can suppose it is some commit problem.
>
> Sinerely,
> Dmitriy Pavlov
>
> пт, 6 апр. 2018 г. в 14:23, Anton Vinogradov <[hidden email]>:
>
>> Igniters.
>>
>> Who is responsible for Upsource [1]?
>> I see some strange things at reviews, a lot of fake changes inside reviews.
>> I don't see such changes at PRs.
>> Could you please check we're using stable version and update if necessary?
>>
>>
>> [1] https://reviews.ignite.apache.org
>>



--
Best Regards, Vyacheslav D.
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

Dmitriy Pavlov
Defenetely, it may be reason of my PR / CR problem because I've merged
master into my branch. Thank you.

пт, 6 апр. 2018 г. в 15:14, Vyacheslav Daradur <[hidden email]>:

> Dmitry, I confirm that a problem existed.
>
> Upsource can't handle situations of merging master to PR branch, in
> this case, Upsorce shows changes which are not related to a pull
> request.
>
> I know only one workaround solution: rebasing branch on master and
> never merge it, but in this case, we lost mapping between existing
> comments and the commits in a pull request.
>
>
> On Fri, Apr 6, 2018 at 3:05 PM, Dmitry Pavlov <[hidden email]>
> wrote:
> > Hi Igniters, Anton,
> >
> > According to my experience upsource works well, except 1 suspicious case
> > with my PR.
> >
> > So I'm not sure if there are Upsource problems, probably there are
> problems
> > with some of our PRs?
> >
> > My example is https://github.com/apache/ignite/pull/3243 PR and
> > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-513 ,- it is
> quite
> > old PR, so I can suppose it is some commit problem.
> >
> > Sinerely,
> > Dmitriy Pavlov
> >
> > пт, 6 апр. 2018 г. в 14:23, Anton Vinogradov <[hidden email]>:
> >
> >> Igniters.
> >>
> >> Who is responsible for Upsource [1]?
> >> I see some strange things at reviews, a lot of fake changes inside
> reviews.
> >> I don't see such changes at PRs.
> >> Could you please check we're using stable version and update if
> necessary?
> >>
> >>
> >> [1] https://reviews.ignite.apache.org
> >>
>
>
>
> --
> Best Regards, Vyacheslav D.
>
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

Anton Vinogradov-2
Anyway,

We have to find the reason why merge from master breaks upsource review
when PR is ok.

2018-04-06 15:28 GMT+03:00 Dmitry Pavlov <[hidden email]>:

> Defenetely, it may be reason of my PR / CR problem because I've merged
> master into my branch. Thank you.
>
> пт, 6 апр. 2018 г. в 15:14, Vyacheslav Daradur <[hidden email]>:
>
> > Dmitry, I confirm that a problem existed.
> >
> > Upsource can't handle situations of merging master to PR branch, in
> > this case, Upsorce shows changes which are not related to a pull
> > request.
> >
> > I know only one workaround solution: rebasing branch on master and
> > never merge it, but in this case, we lost mapping between existing
> > comments and the commits in a pull request.
> >
> >
> > On Fri, Apr 6, 2018 at 3:05 PM, Dmitry Pavlov <[hidden email]>
> > wrote:
> > > Hi Igniters, Anton,
> > >
> > > According to my experience upsource works well, except 1 suspicious
> case
> > > with my PR.
> > >
> > > So I'm not sure if there are Upsource problems, probably there are
> > problems
> > > with some of our PRs?
> > >
> > > My example is https://github.com/apache/ignite/pull/3243 PR and
> > > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-513 ,- it is
> > quite
> > > old PR, so I can suppose it is some commit problem.
> > >
> > > Sinerely,
> > > Dmitriy Pavlov
> > >
> > > пт, 6 апр. 2018 г. в 14:23, Anton Vinogradov <[hidden email]>:
> > >
> > >> Igniters.
> > >>
> > >> Who is responsible for Upsource [1]?
> > >> I see some strange things at reviews, a lot of fake changes inside
> > reviews.
> > >> I don't see such changes at PRs.
> > >> Could you please check we're using stable version and update if
> > necessary?
> > >>
> > >>
> > >> [1] https://reviews.ignite.apache.org
> > >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

Vitaliy Osipov
In reply to this post by Anton Vinogradov-2
Hi All

Upsource server (https://reviews.ignite.apache.org) has been upgraded to
build 2017.3.2888



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

Dmitriy Pavlov
Hi Vitaliy,

Thank you for your time and updating Upsource.

It seems for PR branches with master merge into branch, Upsource still
shows different changes with PR (github). Example
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-556  &
https://github.com/apache/ignite/pull/3243

This means we probably need to re-create PR for case `master` was merged
into branch. I guess if such PR will be merged with squash to new branch
and new PR created, Upsource will show correct picture.

Sincerely,
Dmitriy Pavlov

пн, 9 апр. 2018 г. в 14:56, Vitaliy Osipov <[hidden email]>:

> Hi All
>
> Upsource server (https://reviews.ignite.apache.org) has been upgraded to
> build 2017.3.2888
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
Reply | Threaded
Open this post in threaded view
|

Re: Upsource update required

daradurvs
Vitaliy, thank you!

Dmitriy, review recreating may help if Upsource fixed the problem.

On Mon, Apr 9, 2018 at 4:40 PM, Dmitry Pavlov <[hidden email]> wrote:

> Hi Vitaliy,
>
> Thank you for your time and updating Upsource.
>
> It seems for PR branches with master merge into branch, Upsource still
> shows different changes with PR (github). Example
> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-556  &
> https://github.com/apache/ignite/pull/3243
>
> This means we probably need to re-create PR for case `master` was merged
> into branch. I guess if such PR will be merged with squash to new branch
> and new PR created, Upsource will show correct picture.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 9 апр. 2018 г. в 14:56, Vitaliy Osipov <[hidden email]>:
>
>> Hi All
>>
>> Upsource server (https://reviews.ignite.apache.org) has been upgraded to
>> build 2017.3.2888
>>
>>
>>
>> --
>> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>>



--
Best Regards, Vyacheslav D.