Test failure on build

[Michael Zhuravlev]

Hello, everybody!

I'm new to Ignite and have just try to build it from master brunch. And
I've got test failure on test NetworkFailureTest. I've got some questions
about this test:
1. Why there are hardcoded ip addresses like 192.168.0.100? I have no such
network on my network card. I thing it's wrong to assume that every machine
that runs this test got such network address.
2. Test testSocketCloseOnTimeout work incorrectly on my machine with
specified timeouts. It's turns out it's machine specific test.

May be it's a bug? Do we have ticket on it? I could fix.

Best regards,
Mike Zhuravlev

[Nikolay Izhikov]

Hello, Michael.

Did you run commands described in docs?

https://ignite.apache.org/community/contribute.html

```
# Build project.
$ mvn clean package -DskipTests

# Run Apache RAT
$ mvn clean validate -Pcheck-licenses
```

Can you provide command you run and detailed stack trace you got?



2017-10-24 15:57 GMT+03:00 Michael Zhuravlev <[hidden email]>:

> Hello, everybody!
>
> I'm new to Ignite and have just try to build it from master brunch. And
> I've got test failure on test NetworkFailureTest. I've got some questions
> about this test:
> 1. Why there are hardcoded ip addresses like 192.168.0.100? I have no such
> network on my network card. I thing it's wrong to assume that every machine
> that runs this test got such network address.
> 2. Test testSocketCloseOnTimeout work incorrectly on my machine with
> specified timeouts. It's turns out it's machine specific test.
>
> May be it's a bug? Do we have ticket on it? I could fix.
>
> Best regards,
> Mike Zhuravlev
>

--
Nikolay Izhikov
[hidden email]

[Michael Zhuravlev]

I ran "mvn package", without -DskiptTests. Is it ok to build project
without test?

2017-10-24 16:03 GMT+03:00 Николай Ижиков <[hidden email]>:

> Hello, Michael.
>
> Did you run commands described in docs?
>
> https://ignite.apache.org/community/contribute.html
>
> ```
> # Build project.
> $ mvn clean package -DskipTests
>
> # Run Apache RAT
> $ mvn clean validate -Pcheck-licenses
> ```
>
> Can you provide command you run and detailed stack trace you got?
>
>
>
> 2017-10-24 15:57 GMT+03:00 Michael Zhuravlev <[hidden email]>:
>
> > Hello, everybody!
> >
> > I'm new to Ignite and have just try to build it from master brunch. And
> > I've got test failure on test NetworkFailureTest. I've got some questions
> > about this test:
> > 1. Why there are hardcoded ip addresses like 192.168.0.100? I have no
> such
> > network on my network card. I thing it's wrong to assume that every
> machine
> > that runs this test got such network address.
> > 2. Test testSocketCloseOnTimeout work incorrectly on my machine with
> > specified timeouts. It's turns out it's machine specific test.
> >
> > May be it's a bug? Do we have ticket on it? I could fix.
> >
> > Best regards,
> > Mike Zhuravlev
> >
>
>
>
> --
> Nikolay Izhikov
> [hidden email]
>

[Nikolay Izhikov]

Hello, Michael.

Yes, it OK for local build.
Do you have a chance to read a link from my previous mail?


2017-10-24 16:39 GMT+03:00 Michael Zhuravlev <[hidden email]>:

> I ran "mvn package", without -DskiptTests. Is it ok to build project
> without test?
>
> 2017-10-24 16:03 GMT+03:00 Николай Ижиков <[hidden email]>:
>
> > Hello, Michael.
> >
> > Did you run commands described in docs?
> >
> > https://ignite.apache.org/community/contribute.html
> >
> > ```
> > # Build project.
> > $ mvn clean package -DskipTests
> >
> > # Run Apache RAT
> > $ mvn clean validate -Pcheck-licenses
> > ```
> >
> > Can you provide command you run and detailed stack trace you got?
> >
> >
> >
> > 2017-10-24 15:57 GMT+03:00 Michael Zhuravlev <[hidden email]>:
> >
> > > Hello, everybody!
> > >
> > > I'm new to Ignite and have just try to build it from master brunch. And
> > > I've got test failure on test NetworkFailureTest. I've got some
> questions
> > > about this test:
> > > 1. Why there are hardcoded ip addresses like 192.168.0.100? I have no
> > such
> > > network on my network card. I thing it's wrong to assume that every
> > machine
> > > that runs this test got such network address.
> > > 2. Test testSocketCloseOnTimeout work incorrectly on my machine with
> > > specified timeouts. It's turns out it's machine specific test.
> > >
> > > May be it's a bug? Do we have ticket on it? I could fix.
> > >
> > > Best regards,
> > > Mike Zhuravlev
> > >
> >
> >
> >
> > --
> > Nikolay Izhikov
> > [hidden email]
> >
>

--
Nikolay Izhikov
[hidden email]

[Michael Zhuravlev]

Yes, I've read it. It seems strange build with skiptTest. Well, let it be.

2017-10-24 16:46 GMT+03:00 Николай Ижиков <[hidden email]>:

> Hello, Michael.
>
> Yes, it OK for local build.
> Do you have a chance to read a link from my previous mail?
>
>
> 2017-10-24 16:39 GMT+03:00 Michael Zhuravlev <[hidden email]>:
>
> > I ran "mvn package", without -DskiptTests. Is it ok to build project
> > without test?
> >
> > 2017-10-24 16:03 GMT+03:00 Николай Ижиков <[hidden email]>:
> >
> > > Hello, Michael.
> > >
> > > Did you run commands described in docs?
> > >
> > > https://ignite.apache.org/community/contribute.html
> > >
> > > ```
> > > # Build project.
> > > $ mvn clean package -DskipTests
> > >
> > > # Run Apache RAT
> > > $ mvn clean validate -Pcheck-licenses
> > > ```
> > >
> > > Can you provide command you run and detailed stack trace you got?
> > >
> > >
> > >
> > > 2017-10-24 15:57 GMT+03:00 Michael Zhuravlev <[hidden email]>:
> > >
> > > > Hello, everybody!
> > > >
> > > > I'm new to Ignite and have just try to build it from master brunch.
> And
> > > > I've got test failure on test NetworkFailureTest. I've got some
> > questions
> > > > about this test:
> > > > 1. Why there are hardcoded ip addresses like 192.168.0.100? I have no
> > > such
> > > > network on my network card. I thing it's wrong to assume that every
> > > machine
> > > > that runs this test got such network address.
> > > > 2. Test testSocketCloseOnTimeout work incorrectly on my machine with
> > > > specified timeouts. It's turns out it's machine specific test.
> > > >
> > > > May be it's a bug? Do we have ticket on it? I could fix.
> > > >
> > > > Best regards,
> > > > Mike Zhuravlev
> > > >
> > >
> > >
> > >
> > > --
> > > Nikolay Izhikov
> > > [hidden email]
> > >
> >
>
>
>
> --
> Nikolay Izhikov
> [hidden email]
>