TeamCity. Spark Data Frame. RDD suite should be reconfigured

[Nikolay Izhikov-2]

Hello, Igniters.

I found that RDD suite doesn't run all scala tests and should be reconfigured.

1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".

Petr, can you edit this settings?
Seems, this settings inherited from some template.

I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534

[vveider]

I did not understand how should I reconfigure RDD build configuration.

1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?

> On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
>
> Hello, Igniters.
>
> I found that RDD suite doesn't run all scala tests and should be reconfigured.
>
> 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
> 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
>
> Petr, can you edit this settings?
> Seems, this settings inherited from some template.
>
> I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534

[Nikolay Izhikov-2]

Petr.

1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.

2. `scala-2.10` has to be removed.

3. We need both `scala` and `scala-test` profile.


В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:

> I did not understand how should I reconfigure RDD build configuration.
>
> 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
> 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
>
>
>
> > On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
> >
> > Hello, Igniters.
> >
> > I found that RDD suite doesn't run all scala tests and should be reconfigured.
> >
> > 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
> > 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
> >
> > Petr, can you edit this settings?
> > Seems, this settings inherited from some template.
> >
> > I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534
>
>

[vveider]

I’ve modified list of suites and added ‘scala’ and ’scala-test’ to profiles list.
Please check build.

> On 26 Jun 2018, at 14:28, Nikolay Izhikov <[hidden email]> wrote:
>
> Petr.
>
> 1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.
>
> 2. `scala-2.10` has to be removed.
>
> 3. We need both `scala` and `scala-test` profile.
>
>
> В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:
>> I did not understand how should I reconfigure RDD build configuration.
>>
>> 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
>> 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
>>
>>
>>
>>> On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
>>>
>>> Hello, Igniters.
>>>
>>> I found that RDD suite doesn't run all scala tests and should be reconfigured.
>>>
>>> 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
>>> 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
>>>
>>> Petr, can you edit this settings?
>>> Seems, this settings inherited from some template.
>>>
>>> I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534
>>

[Nikolay Izhikov-2]

Please, remove `scala-2.10` from profiles, also.

В Вт, 26/06/2018 в 14:39 +0300, Petr Ivanov пишет:

> I’ve modified list of suites and added ‘scala’ and ’scala-test’ to profiles list.
> Please check build.
>
>
>
> > On 26 Jun 2018, at 14:28, Nikolay Izhikov <[hidden email]> wrote:
> >
> > Petr.
> >
> > 1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.
> >
> > 2. `scala-2.10` has to be removed.
> >
> > 3. We need both `scala` and `scala-test` profile.
> >
> >
> > В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:
> > > I did not understand how should I reconfigure RDD build configuration.
> > >
> > > 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
> > > 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
> > >
> > >
> > >
> > > > On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
> > > >
> > > > Hello, Igniters.
> > > >
> > > > I found that RDD suite doesn't run all scala tests and should be reconfigured.
> > > >
> > > > 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
> > > > 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
> > > >
> > > > Petr, can you edit this settings?
> > > > Seems, this settings inherited from some template.
> > > >
> > > > I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534
>
>

[Nikolay Izhikov-2]

For `RDD` suite, we need use `test` goal instead of `surefire:test`, also.

Because, scala tests runs with org.scalatest:scalatest-maven-plugin:2.0.0


В Вт, 26/06/2018 в 14:53 +0300, Nikolay Izhikov пишет:

> Please, remove `scala-2.10` from profiles, also.
>
> В Вт, 26/06/2018 в 14:39 +0300, Petr Ivanov пишет:
> > I’ve modified list of suites and added ‘scala’ and ’scala-test’ to profiles list.
> > Please check build.
> >
> >
> >
> > > On 26 Jun 2018, at 14:28, Nikolay Izhikov <[hidden email]> wrote:
> > >
> > > Petr.
> > >
> > > 1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.
> > >
> > > 2. `scala-2.10` has to be removed.
> > >
> > > 3. We need both `scala` and `scala-test` profile.
> > >
> > >
> > > В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:
> > > > I did not understand how should I reconfigure RDD build configuration.
> > > >
> > > > 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
> > > > 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
> > > >
> > > >
> > > >
> > > > > On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
> > > > >
> > > > > Hello, Igniters.
> > > > >
> > > > > I found that RDD suite doesn't run all scala tests and should be reconfigured.
> > > > >
> > > > > 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
> > > > > 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
> > > > >
> > > > > Petr, can you edit this settings?
> > > > > Seems, this settings inherited from some template.
> > > > >
> > > > > I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534

[vveider]

Why should I?

It is project wide configuration (used in all build in project) and scala-2.10 still exists in root pom.xml
This profile only adds some modules to reactor and does not effect any other configuration.

> On 26 Jun 2018, at 14:53, Nikolay Izhikov <[hidden email]> wrote:
>
> Please, remove `scala-2.10` from profiles, also.
>
> В Вт, 26/06/2018 в 14:39 +0300, Petr Ivanov пишет:
>> I’ve modified list of suites and added ‘scala’ and ’scala-test’ to profiles list.
>> Please check build.
>>
>>
>>
>>> On 26 Jun 2018, at 14:28, Nikolay Izhikov <[hidden email]> wrote:
>>>
>>> Petr.
>>>
>>> 1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.
>>>
>>> 2. `scala-2.10` has to be removed.
>>>
>>> 3. We need both `scala` and `scala-test` profile.
>>>
>>>
>>> В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:
>>>> I did not understand how should I reconfigure RDD build configuration.
>>>>
>>>> 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
>>>> 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
>>>>
>>>>
>>>>
>>>>> On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
>>>>>
>>>>> Hello, Igniters.
>>>>>
>>>>> I found that RDD suite doesn't run all scala tests and should be reconfigured.
>>>>>
>>>>> 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
>>>>> 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
>>>>>
>>>>> Petr, can you edit this settings?
>>>>> Seems, this settings inherited from some template.
>>>>>
>>>>> I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534
>>

[vveider]

It is already set to test.

> On 26 Jun 2018, at 15:26, Nikolay Izhikov <[hidden email]> wrote:
>
> For `RDD` suite, we need use `test` goal instead of `surefire:test`, also.
>
> Because, scala tests runs with org.scalatest:scalatest-maven-plugin:2.0.0
>
>
> В Вт, 26/06/2018 в 14:53 +0300, Nikolay Izhikov пишет:
>> Please, remove `scala-2.10` from profiles, also.
>>
>> В Вт, 26/06/2018 в 14:39 +0300, Petr Ivanov пишет:
>>> I’ve modified list of suites and added ‘scala’ and ’scala-test’ to profiles list.
>>> Please check build.
>>>
>>>
>>>
>>>> On 26 Jun 2018, at 14:28, Nikolay Izhikov <[hidden email]> wrote:
>>>>
>>>> Petr.
>>>>
>>>> 1. We need *only* TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite" other Specs included in this two.
>>>>
>>>> 2. `scala-2.10` has to be removed.
>>>>
>>>> 3. We need both `scala` and `scala-test` profile.
>>>>
>>>>
>>>> В Вт, 26/06/2018 в 14:10 +0300, Petr Ivanov пишет:
>>>>> I did not understand how should I reconfigure RDD build configuration.
>>>>>
>>>>> 1. TEST_SUITE currently has value of 'IgniteRDDTestSuite,AbstractDataFrameSpec,Entity,EntityTestAllTypeFields,IgniteCatalogSpec,IgniteDataFrameSchemaSpec,IgniteDataFrameSuite,IgniteDataFrameWrongConfigSpec,IgniteRDDSpec,IgniteSQLDataFrameIgniteSessionWriteSpec,IgniteSQLDataFrameSpec,IgniteSQLDataFrameWriteSpec’ — both ‘IgniteRDDTestSuite' and ‘IgniteDataFrameSuite’ are present.
>>>>> 2. Step3 Maven task had ‘-Pall-java,scala-2.10,tensorflow’ — should I add ’scala’ and 'scala-test’ profiles as well?
>>>>>
>>>>>
>>>>>
>>>>>> On 25 Jun 2018, at 16:21, Nikolay Izhikov <[hidden email]> wrote:
>>>>>>
>>>>>> Hello, Igniters.
>>>>>>
>>>>>> I found that RDD suite doesn't run all scala tests and should be reconfigured.
>>>>>>
>>>>>> 1. Parameter. TEST_SUITE = "IgniteRDDTestSuite,IgniteDataFrameSuite"
>>>>>> 2. Buil Steps. Step3. Additional Maven command line parameters: "-Pall-java,scala,scala-test".
>>>>>>
>>>>>> Petr, can you edit this settings?
>>>>>> Seems, this settings inherited from some template.
>>>>>>
>>>>>> I need this edits to continue review of https://issues.apache.org/jira/browse/IGNITE-8534