TeamCity. Ignite RDD tests

[Dmitriy Pavlov]

Hi Nikolay,

IMO you can merge. Just check if following suites work correct and still
execute its tests:

Ignite Scalar Examples [Scala]
Ignite Visor Console [Scala]

Sincerely,
Dmitriy Pavlov

вт, 27 февр. 2018 г. в 19:15, Nikolay Izhikov <[hidden email]>:

> Hello,
>
> If there are no any objections I merge the fix tomorrow.
>
> https://github.com/apache/ignite/pull/3570
>
> В Вт, 27/02/2018 в 13:27 +0300, Nikolay Izhikov пишет:
> > Hello, Alexey, what do you think?
> >
> > Let's fix this issue!
> >
> > В Пн, 26/02/2018 в 16:29 +0000, Dmitry Pavlov пишет:
> > > I agree.
> > >
> > > Alexey K, what do you think?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пн, 26 февр. 2018 г. в 19:17, Nikolay Izhikov <[hidden email]>:
> > >
> > > > Hello, Dmitriy.
> > > >
> > > > scalatest-maven-plugin doesn't handle "test" property.
> > > > So when "scala" profile enabled it will execute all Scala Spark
> tests for
> > > > any test plan.
> > > >
> > > > I propose to hide scalatest plugin declaration into profile
> "scala-test"
> > > > [1]
> > > >
> > > > And enable it only for specific team city plans.
> > > > I.e "Ignite RDD" and "Ignite RDD spark 2_10".
> > > >
> > > > Thoughts?
> > > >
> > > > [1] https://github.com/apache/ignite/pull/3570
> > > >
> > > > В Пн, 26/02/2018 в 14:35 +0300, Nikolay Izhikov пишет:
> > > > > Hello, Dmitriy.
> > > > >
> > > > > I'm investigate issue and share results later today.
> > > > >
> > > > > В Пн, 26/02/2018 в 11:31 +0000, Dmitry Pavlov пишет:
> > > > > > Hi Nikolay,
> > > > > >
> > > > > > Are there any news about these tests apperance in suites?
> > > > > >
> > > > > > It seems I've found one more example in
> > > > > >
> > > >
> > > >
> https://ci.ignite.apache.org/viewLog.html?buildId=1106598&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteOSGi
> > > > > > (other
> > > > > > change PR run). I'm not sure that OSGI build configuration is
> > > >
> > > > appropriate
> > > > > > suite to run these tests.
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > чт, 22 февр. 2018 г. в 16:13, Nikolay Izhikov <
> [hidden email]>:
> > > > > >
> > > > > > > Dmitriy.
> > > > > > >
> > > > > > > OK, I get it.
> > > > > > >
> > > > > > > Looks like scala-test-plugin I added in IGNITE-7042 doesn't
> handle
> > > > > > > `-Dtest=XXX` properly.
> > > > > > > I will investigate and fixed it.
> > > > > > >
> > > > > > > В Чт, 22/02/2018 в 10:28 +0000, Dmitry Pavlov пишет:
> > > > > > > > It seems that tests I've previously muted were started in
> wrong
> > > >
> > > > configs.
> > > > > > > >
> > > > > > > > Is it possible IgniteRDDSpec.IgniteRDD  became unit tests,
> which is
> > > > > > >
> > > > > > > started
> > > > > > > > with code compile?
> > > > > > > >
> > > > > > > > This can be reason these tests appeared in suites which is
> not
> > > >
> > > > related to
> > > > > > > > IgniteRDD, such as Scala Examples.
> > > > > > > >
> > > > > > > > чт, 22 февр. 2018 г. в 13:20, Nikolay Izhikov <
> [hidden email]
> > > > >
> > > > > :
> > > > > > > >
> > > > > > > > > Hello, Dmitriy
> > > > > > > > >
> > > > > > > > > I'm looked in TeamCity but not sure what should I do.
> > > > > > > > > Can you explain it to me, please?
> > > > > > > > >
> > > > > > > > > В Чт, 22/02/2018 в 10:13 +0000, Dmitry Pavlov пишет:
> > > > > > > > > > Hi Nikolay,
> > > > > > > > > >
> > > > > > > > > > It seems
> > > > > > > > > > IgniteRDDSpec.IgniteRDD  has appeared in configurations
> it is
> > > >
> > > > not
> > > > > > > > >
> > > > > > > > > expected
> > > > > > > > > > to run.
> > > > > > > > > >
> > > > > > > > > > Please see investigations assigned to you. What can we
> change
> > > >
> > > > to
> > > > > > >
> > > > > > > avoid
> > > > > > > > > > these tests to be included into run other suites?
> > > > > > > > > >
> > > > > > > > > > Sincerely,
> > > > > > > > > > Dmitriy Pavlov
> > > > > > > > > >
> > > > > > > > > > пт, 16 февр. 2018 г. в 7:35, Nikolay Izhikov <
> > > >
> > > > [hidden email]>:
> > > > > > > > > >
> > > > > > > > > > > Hello, Igniters.
> > > > > > > > > > >
> > > > > > > > > > > I'm working on issue [1].
> > > > > > > > > > >
> > > > > > > > > > > Team City doesn't collect info about scalatest
> execution
> > > >
> > > > because of
> > > > > > > > >
> > > > > > > > > wrong
> > > > > > > > > > > pom.xml
> > > > > > > > > > > I'm fixed it in PR [3]
> > > > > > > > > > >
> > > > > > > > > > > It happens there is a 2 broken tests written in Scala
> - [4]
> > > > > > > > > > >
> > > > > > > > > > > 1. IgniteRDDSpec.IgniteRDD should successfully store
> data to
> > > >
> > > > ignite
> > > > > > > > >
> > > > > > > > > using
> > > > > > > > > > > saveValues
> > > > > > > > > > > 2. IgniteRDDSpec.IgniteRDD should successfully store
> data to
> > > >
> > > > ignite
> > > > > > > > >
> > > > > > > > > using
> > > > > > > > > > > saveValues with inline transformation
> > > > > > > > > > >
> > > > > > > > > > > It seems they are been here for a while.
> > > > > > > > > > > I propose to mute or disable it on TeamCity before
> merging
> > > >
> > > > my PR.
> > > > > > > > > > > I've created ticket for fixing tests - [5].
> > > > > > > > > > >
> > > > > > > > > > > Thoughts?
> > > > > > > > > > >
> > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-7042
> > > > > > > > > > >
> > > > > > > > > > > [2]
> > > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > > > >
> > > >
> > > >
> https://ci.ignite.apache.org/viewLog.html?buildId=1096059&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteRdd
> > > > > > > > > > >
> > > > > > > > > > > [3] https://github.com/apache/ignite/pull/3530
> > > > > > > > > > >
> > > > > > > > > > > [4]
> > > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > > > >
> > > >
> > > >
> https://ci.ignite.apache.org/viewLog.html?buildId=1095218&buildTypeId=IgniteTests24Java8_IgniteRdd&tab=testsInfo
> > > > > > > > > > >
> > > > > > > > > > > [5] https://issues.apache.org/jira/browse/IGNITE-7727

[Dmitriy Pavlov]

Hi Nikolay,

your changes helped. Tests no longer appeared.

Thank you.

вт, 27 февр. 2018 г. в 19:19, Dmitry Pavlov <[hidden email]>:

> Hi Nikolay,
>
> IMO you can merge. Just check if following suites work correct and still
> execute its tests:
>
> Ignite Scalar Examples [Scala]
> Ignite Visor Console [Scala]
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 27 февр. 2018 г. в 19:15, Nikolay Izhikov <[hidden email]>:
>
>> Hello,
>>
>> If there are no any objections I merge the fix tomorrow.
>>
>> https://github.com/apache/ignite/pull/3570
>>
>> В Вт, 27/02/2018 в 13:27 +0300, Nikolay Izhikov пишет:
>> > Hello, Alexey, what do you think?
>> >
>> > Let's fix this issue!
>> >
>> > В Пн, 26/02/2018 в 16:29 +0000, Dmitry Pavlov пишет:
>> > > I agree.
>> > >
>> > > Alexey K, what do you think?
>> > >
>> > > Sincerely,
>> > > Dmitriy Pavlov
>> > >
>> > > пн, 26 февр. 2018 г. в 19:17, Nikolay Izhikov <[hidden email]>:
>> > >
>> > > > Hello, Dmitriy.
>> > > >
>> > > > scalatest-maven-plugin doesn't handle "test" property.
>> > > > So when "scala" profile enabled it will execute all Scala Spark
>> tests for
>> > > > any test plan.
>> > > >
>> > > > I propose to hide scalatest plugin declaration into profile
>> "scala-test"
>> > > > [1]
>> > > >
>> > > > And enable it only for specific team city plans.
>> > > > I.e "Ignite RDD" and "Ignite RDD spark 2_10".
>> > > >
>> > > > Thoughts?
>> > > >
>> > > > [1] https://github.com/apache/ignite/pull/3570
>> > > >
>> > > > В Пн, 26/02/2018 в 14:35 +0300, Nikolay Izhikov пишет:
>> > > > > Hello, Dmitriy.
>> > > > >
>> > > > > I'm investigate issue and share results later today.
>> > > > >
>> > > > > В Пн, 26/02/2018 в 11:31 +0000, Dmitry Pavlov пишет:
>> > > > > > Hi Nikolay,
>> > > > > >
>> > > > > > Are there any news about these tests apperance in suites?
>> > > > > >
>> > > > > > It seems I've found one more example in
>> > > > > >
>> > > >
>> > > >
>> https://ci.ignite.apache.org/viewLog.html?buildId=1106598&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteOSGi
>> > > > > > (other
>> > > > > > change PR run). I'm not sure that OSGI build configuration is
>> > > >
>> > > > appropriate
>> > > > > > suite to run these tests.
>> > > > > >
>> > > > > > Sincerely,
>> > > > > > Dmitriy Pavlov
>> > > > > >
>> > > > > > чт, 22 февр. 2018 г. в 16:13, Nikolay Izhikov <
>> [hidden email]>:
>> > > > > >
>> > > > > > > Dmitriy.
>> > > > > > >
>> > > > > > > OK, I get it.
>> > > > > > >
>> > > > > > > Looks like scala-test-plugin I added in IGNITE-7042 doesn't
>> handle
>> > > > > > > `-Dtest=XXX` properly.
>> > > > > > > I will investigate and fixed it.
>> > > > > > >
>> > > > > > > В Чт, 22/02/2018 в 10:28 +0000, Dmitry Pavlov пишет:
>> > > > > > > > It seems that tests I've previously muted were started in
>> wrong
>> > > >
>> > > > configs.
>> > > > > > > >
>> > > > > > > > Is it possible IgniteRDDSpec.IgniteRDD  became unit tests,
>> which is
>> > > > > > >
>> > > > > > > started
>> > > > > > > > with code compile?
>> > > > > > > >
>> > > > > > > > This can be reason these tests appeared in suites which is
>> not
>> > > >
>> > > > related to
>> > > > > > > > IgniteRDD, such as Scala Examples.
>> > > > > > > >
>> > > > > > > > чт, 22 февр. 2018 г. в 13:20, Nikolay Izhikov <
>> [hidden email]
>> > > > >
>> > > > > :
>> > > > > > > >
>> > > > > > > > > Hello, Dmitriy
>> > > > > > > > >
>> > > > > > > > > I'm looked in TeamCity but not sure what should I do.
>> > > > > > > > > Can you explain it to me, please?
>> > > > > > > > >
>> > > > > > > > > В Чт, 22/02/2018 в 10:13 +0000, Dmitry Pavlov пишет:
>> > > > > > > > > > Hi Nikolay,
>> > > > > > > > > >
>> > > > > > > > > > It seems
>> > > > > > > > > > IgniteRDDSpec.IgniteRDD  has appeared in configurations
>> it is
>> > > >
>> > > > not
>> > > > > > > > >
>> > > > > > > > > expected
>> > > > > > > > > > to run.
>> > > > > > > > > >
>> > > > > > > > > > Please see investigations assigned to you. What can we
>> change
>> > > >
>> > > > to
>> > > > > > >
>> > > > > > > avoid
>> > > > > > > > > > these tests to be included into run other suites?
>> > > > > > > > > >
>> > > > > > > > > > Sincerely,
>> > > > > > > > > > Dmitriy Pavlov
>> > > > > > > > > >
>> > > > > > > > > > пт, 16 февр. 2018 г. в 7:35, Nikolay Izhikov <
>> > > >
>> > > > [hidden email]>:
>> > > > > > > > > >
>> > > > > > > > > > > Hello, Igniters.
>> > > > > > > > > > >
>> > > > > > > > > > > I'm working on issue [1].
>> > > > > > > > > > >
>> > > > > > > > > > > Team City doesn't collect info about scalatest
>> execution
>> > > >
>> > > > because of
>> > > > > > > > >
>> > > > > > > > > wrong
>> > > > > > > > > > > pom.xml
>> > > > > > > > > > > I'm fixed it in PR [3]
>> > > > > > > > > > >
>> > > > > > > > > > > It happens there is a 2 broken tests written in Scala
>> - [4]
>> > > > > > > > > > >
>> > > > > > > > > > > 1. IgniteRDDSpec.IgniteRDD should successfully store
>> data to
>> > > >
>> > > > ignite
>> > > > > > > > >
>> > > > > > > > > using
>> > > > > > > > > > > saveValues
>> > > > > > > > > > > 2. IgniteRDDSpec.IgniteRDD should successfully store
>> data to
>> > > >
>> > > > ignite
>> > > > > > > > >
>> > > > > > > > > using
>> > > > > > > > > > > saveValues with inline transformation
>> > > > > > > > > > >
>> > > > > > > > > > > It seems they are been here for a while.
>> > > > > > > > > > > I propose to mute or disable it on TeamCity before
>> merging
>> > > >
>> > > > my PR.
>> > > > > > > > > > > I've created ticket for fixing tests - [5].
>> > > > > > > > > > >
>> > > > > > > > > > > Thoughts?
>> > > > > > > > > > >
>> > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-7042
>> > > > > > > > > > >
>> > > > > > > > > > > [2]
>> > > > > > > > > > >
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > >
>> > > > > > >
>> > > >
>> > > >
>> https://ci.ignite.apache.org/viewLog.html?buildId=1096059&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteRdd
>> > > > > > > > > > >
>> > > > > > > > > > > [3] https://github.com/apache/ignite/pull/3530
>> > > > > > > > > > >
>> > > > > > > > > > > [4]
>> > > > > > > > > > >
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > >
>> > > > > > >
>> > > >
>> > > >
>> https://ci.ignite.apache.org/viewLog.html?buildId=1095218&buildTypeId=IgniteTests24Java8_IgniteRdd&tab=testsInfo
>> > > > > > > > > > >
>> > > > > > > > > > > [5] https://issues.apache.org/jira/browse/IGNITE-7727
>
>