TC hell

[Valentin Kulichenko]

Igniters,

We currently have >200 builds in TC queue and it will take around 15 hours
to run everything. This is becoming unusable.

It seems to me that it got worse after we switched to pull requests,
because builds are triggered each time someone pushes to the branch that is
tied up with existing PR. I'm sure that not all of these builds are really
needed, so I suggest to disable automatic trigger and always start builds
manually (we already have 'Run All' configuration in case you need all
suites).

The only issue - right now manual run is not possible under Guest account.
So we will have to either change Guest permissions or add special account
for this.

Thoughts?

-Val

[Denis Magda]

Definitely we have to change something here.

I would use a manual triggering  granting access through a special
account available only to contributors and commiters.

--
Denis

On 8/27/2015 9:51 AM, Valentin Kulichenko wrote:

> Igniters,
>
> We currently have >200 builds in TC queue and it will take around 15 hours
> to run everything. This is becoming unusable.
>
> It seems to me that it got worse after we switched to pull requests,
> because builds are triggered each time someone pushes to the branch that is
> tied up with existing PR. I'm sure that not all of these builds are really
> needed, so I suggest to disable automatic trigger and always start builds
> manually (we already have 'Run All' configuration in case you need all
> suites).
>
> The only issue - right now manual run is not possible under Guest account.
> So we will have to either change Guest permissions or add special account
> for this.
>
> Thoughts?
>
> -Val
>

[Raul Kripalani-2]

I'm not familiar with TC, but I've seen other projects have set it up in a
way to trigger a build when a committer types a magic comment in the PR
such as: "TC please build".

Not sure if they're using TC or something else, but it's definitely worth
investigating.
On 27 Aug 2015 07:56, "Denis Magda" <[hidden email]> wrote:

> Definitely we have to change something here.
>
> I would use a manual triggering  granting access through a special account
> available only to contributors and commiters.
>
> --
> Denis
>
> On 8/27/2015 9:51 AM, Valentin Kulichenko wrote:
>
>> Igniters,
>>
>> We currently have >200 builds in TC queue and it will take around 15 hours
>> to run everything. This is becoming unusable.
>>
>> It seems to me that it got worse after we switched to pull requests,
>> because builds are triggered each time someone pushes to the branch that
>> is
>> tied up with existing PR. I'm sure that not all of these builds are really
>> needed, so I suggest to disable automatic trigger and always start builds
>> manually (we already have 'Run All' configuration in case you need all
>> suites).
>>
>> The only issue - right now manual run is not possible under Guest account.
>> So we will have to either change Guest permissions or add special account
>> for this.
>>
>> Thoughts?
>>
>> -Val
>>
>>
>

[Sergi]

I think we have to switch to manual TC runs, this will solve the problem.
Guest account should not be able to run anything in my view anyways,
it must be allowed only for registered contributors.

Sergi

2015-08-27 12:16 GMT+03:00 Raul Kripalani <[hidden email]>:

> I'm not familiar with TC, but I've seen other projects have set it up in a
> way to trigger a build when a committer types a magic comment in the PR
> such as: "TC please build".
>
> Not sure if they're using TC or something else, but it's definitely worth
> investigating.
> On 27 Aug 2015 07:56, "Denis Magda" <[hidden email]> wrote:
>
> > Definitely we have to change something here.
> >
> > I would use a manual triggering  granting access through a special
> account
> > available only to contributors and commiters.
> >
> > --
> > Denis
> >
> > On 8/27/2015 9:51 AM, Valentin Kulichenko wrote:
> >
> >> Igniters,
> >>
> >> We currently have >200 builds in TC queue and it will take around 15
> hours
> >> to run everything. This is becoming unusable.
> >>
> >> It seems to me that it got worse after we switched to pull requests,
> >> because builds are triggered each time someone pushes to the branch that
> >> is
> >> tied up with existing PR. I'm sure that not all of these builds are
> really
> >> needed, so I suggest to disable automatic trigger and always start
> builds
> >> manually (we already have 'Run All' configuration in case you need all
> >> suites).
> >>
> >> The only issue - right now manual run is not possible under Guest
> account.
> >> So we will have to either change Guest permissions or add special
> account
> >> for this.
> >>
> >> Thoughts?
> >>
> >> -Val
> >>
> >>
> >
>

[Raul Kripalani]

On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <[hidden email]>
wrote:

> I think we have to switch to manual TC runs, this will solve the problem.
> Guest account should not be able to run anything in my view anyways,
> it must be allowed only for registered contributors.
>

Just to be clear, I said "committer" in my email meaning ASF committers,
not any Github contributor.

BTW - I found the plugin I was on about: https://github.com/janinko/ghprb.
However, it's for Jenkins.

I've seen it in action and it's pretty cool.

Raúl.

[Valentin Kulichenko]

Raul,

AFAIK, TC supports comment-based triggering, but I don't see much sense in
it. It's easier to click one button on UI. Moreover, this way you can
choose suites you need to run, while any automatic trigger will always run
all of them.

-Val

On Thu, Aug 27, 2015 at 7:29 AM, Raul Kripalani <[hidden email]> wrote:

> On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <[hidden email]>
> wrote:
>
> > I think we have to switch to manual TC runs, this will solve the problem.
> > Guest account should not be able to run anything in my view anyways,
> > it must be allowed only for registered contributors.
> >
>
> Just to be clear, I said "committer" in my email meaning ASF committers,
> not any Github contributor.
>
> BTW - I found the plugin I was on about: https://github.com/janinko/ghprb.
> However, it's for Jenkins.
>
> I've seen it in action and it's pretty cool.
>
> Raúl.
>

[Valentin Kulichenko]

BTW, looks like TC server didn't like our talks and stopped working :)

Anyone knows the reason?

-Val

On Thu, Aug 27, 2015 at 11:01 AM, Valentin Kulichenko <
[hidden email]> wrote:

> Raul,
>
> AFAIK, TC supports comment-based triggering, but I don't see much sense in
> it. It's easier to click one button on UI. Moreover, this way you can
> choose suites you need to run, while any automatic trigger will always run
> all of them.
>
> -Val
>
> On Thu, Aug 27, 2015 at 7:29 AM, Raul Kripalani <[hidden email]> wrote:
>
>> On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <[hidden email]
>> >
>> wrote:
>>
>> > I think we have to switch to manual TC runs, this will solve the
>> problem.
>> > Guest account should not be able to run anything in my view anyways,
>> > it must be allowed only for registered contributors.
>> >
>>
>> Just to be clear, I said "committer" in my email meaning ASF committers,
>> not any Github contributor.
>>
>> BTW - I found the plugin I was on about: https://github.com/janinko/ghprb
>> .
>> However, it's for Jenkins.
>>
>> I've seen it in action and it's pretty cool.
>>
>> Raúl.
>>
>
>

[Konstantin Boudnik-2]

BTW,

the contributors of the patches should always do some initial testing on their
own instead of throwing everything to TC, which is a scarce resource.

Cos

On Thu, Aug 27, 2015 at 11:01AM, Valentin Kulichenko wrote:

> Raul,
>
> AFAIK, TC supports comment-based triggering, but I don't see much sense in
> it. It's easier to click one button on UI. Moreover, this way you can
> choose suites you need to run, while any automatic trigger will always run
> all of them.
>
> -Val
>
> On Thu, Aug 27, 2015 at 7:29 AM, Raul Kripalani <[hidden email]> wrote:
>
> > On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <[hidden email]>
> > wrote:
> >
> > > I think we have to switch to manual TC runs, this will solve the problem.
> > > Guest account should not be able to run anything in my view anyways,
> > > it must be allowed only for registered contributors.
> > >
> >
> > Just to be clear, I said "committer" in my email meaning ASF committers,
> > not any Github contributor.
> >
> > BTW - I found the plugin I was on about: https://github.com/janinko/ghprb.
> > However, it's for Jenkins.
> >
> > I've seen it in action and it's pretty cool.
> >
> > Raúl.
> >

[Artem Shutak]

I've checked and currently everyone can create TC account for yourself and
the account will have privileges to trigger builds (without any
administrative privileges).

-- Artem --

On Thu, Aug 27, 2015 at 10:01 PM, Konstantin Boudnik <[hidden email]> wrote:

> BTW,
>
> the contributors of the patches should always do some initial testing on
> their
> own instead of throwing everything to TC, which is a scarce resource.
>
> Cos
>
> On Thu, Aug 27, 2015 at 11:01AM, Valentin Kulichenko wrote:
> > Raul,
> >
> > AFAIK, TC supports comment-based triggering, but I don't see much sense
> in
> > it. It's easier to click one button on UI. Moreover, this way you can
> > choose suites you need to run, while any automatic trigger will always
> run
> > all of them.
> >
> > -Val
> >
> > On Thu, Aug 27, 2015 at 7:29 AM, Raul Kripalani <[hidden email]>
> wrote:
> >
> > > On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <
> [hidden email]>
> > > wrote:
> > >
> > > > I think we have to switch to manual TC runs, this will solve the
> problem.
> > > > Guest account should not be able to run anything in my view anyways,
> > > > it must be allowed only for registered contributors.
> > > >
> > >
> > > Just to be clear, I said "committer" in my email meaning ASF
> committers,
> > > not any Github contributor.
> > >
> > > BTW - I found the plugin I was on about:
> https://github.com/janinko/ghprb.
> > > However, it's for Jenkins.
> > >
> > > I've seen it in action and it's pretty cool.
> > >
> > > Raúl.
> > >
>

[Artem Shutak]

So, I've disabled auto triggering for pull-requests.

-- Artem --

On Fri, Aug 28, 2015 at 12:17 PM, Artem Shutak <[hidden email]> wrote:

> I've checked and currently everyone can create TC account for yourself and
> the account will have privileges to trigger builds (without any
> administrative privileges).
>
> -- Artem --
>
> On Thu, Aug 27, 2015 at 10:01 PM, Konstantin Boudnik <[hidden email]>
> wrote:
>
>> BTW,
>>
>> the contributors of the patches should always do some initial testing on
>> their
>> own instead of throwing everything to TC, which is a scarce resource.
>>
>> Cos
>>
>> On Thu, Aug 27, 2015 at 11:01AM, Valentin Kulichenko wrote:
>> > Raul,
>> >
>> > AFAIK, TC supports comment-based triggering, but I don't see much sense
>> in
>> > it. It's easier to click one button on UI. Moreover, this way you can
>> > choose suites you need to run, while any automatic trigger will always
>> run
>> > all of them.
>> >
>> > -Val
>> >
>> > On Thu, Aug 27, 2015 at 7:29 AM, Raul Kripalani <[hidden email]>
>> wrote:
>> >
>> > > On Thu, Aug 27, 2015 at 2:24 PM, Sergi Vladykin <
>> [hidden email]>
>> > > wrote:
>> > >
>> > > > I think we have to switch to manual TC runs, this will solve the
>> problem.
>> > > > Guest account should not be able to run anything in my view anyways,
>> > > > it must be allowed only for registered contributors.
>> > > >
>> > >
>> > > Just to be clear, I said "committer" in my email meaning ASF
>> committers,
>> > > not any Github contributor.
>> > >
>> > > BTW - I found the plugin I was on about:
>> https://github.com/janinko/ghprb.
>> > > However, it's for Jenkins.
>> > >
>> > > I've seen it in action and it's pretty cool.
>> > >
>> > > Raúl.
>> > >
>>
>
>