Started working on IGNITE-1164 (NPE in ServerImpl)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Started working on IGNITE-1164 (NPE in ServerImpl)

Denis Magda
More info is available here:
https://issues.apache.org/jira/browse/IGNITE-1164

--
Denis
Reply | Threaded
Open this post in threaded view
|

Re: Started working on IGNITE-1164 (NPE in ServerImpl)

Denis Magda
The bug was silly and the fix is trivial. IMHO, we don't need to check
it with TeamCity cause in my understanding is the same as to fix a
documentation or test.

Could anyone from committers review the fix? Use the link below for review.

--
Denis

On 7/29/2015 12:31 PM, Denis Magda wrote:
> More info is available here:
> https://issues.apache.org/jira/browse/IGNITE-1164
>
> --
> Denis

Reply | Threaded
Open this post in threaded view
|

Re: Started working on IGNITE-1164 (NPE in ServerImpl)

dsetrakyan
On Wed, Jul 29, 2015 at 2:59 AM, Denis Magda <[hidden email]> wrote:

> The bug was silly and the fix is trivial. IMHO, we don't need to check it
> with TeamCity cause in my understanding is the same as to fix a
> documentation or test.
>

Denis, while I agree with you that the fix is trivial and can be reviewed
before the CI tests complete, I still would insist that we need to make
sure that CI passes before the final merge.


> Could anyone from committers review the fix? Use the link below for review.
>
> --
> Denis
>
> On 7/29/2015 12:31 PM, Denis Magda wrote:
>
>> More info is available here:
>> https://issues.apache.org/jira/browse/IGNITE-1164
>>
>> --
>> Denis
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Started working on IGNITE-1164 (NPE in ServerImpl)

Denis Magda


On 7/29/2015 9:20 PM, Dmitriy Setrakyan wrote:
> On Wed, Jul 29, 2015 at 2:59 AM, Denis Magda <[hidden email]> wrote:
>
>> The bug was silly and the fix is trivial. IMHO, we don't need to check it
>> with TeamCity cause in my understanding is the same as to fix a
>> documentation or test.
>>
> Denis, while I agree with you that the fix is trivial and can be reviewed
> before the CI tests complete, I still would insist that we need to make
> sure that CI passes before the final merge.
Dmitriy, did a TC run, everything is ok.

--
Denis

>
>> Could anyone from committers review the fix? Use the link below for review.
>>
>> --
>> Denis
>>
>> On 7/29/2015 12:31 PM, Denis Magda wrote:
>>
>>> More info is available here:
>>> https://issues.apache.org/jira/browse/IGNITE-1164
>>>
>>> --
>>> Denis
>>>
>>