SqlLine script and Java9

[dsetrakyan]

Igniters,

Any reason SqlLine tool shipped with Ignite does not work with Java 9? This
is the error I got.


> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
> incorrect.*
> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK 1.8.**You
> can also download latest JDK at http://java.com/download
> <http://java.com/download>.*


D.

[vveider]

Filed the ticket [1], will fix.


[1] https://issues.apache.org/jira/browse/IGNITE-8478 <https://issues.apache.org/jira/browse/IGNITE-8478>

> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email]> wrote:
>
> Igniters,
>
> Any reason SqlLine tool shipped with Ignite does not work with Java 9? This
> is the error I got.
>
>
>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
>> incorrect.*
>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK 1.8.**You
>> can also download latest JDK at http://java.com/download
>> <http://java.com/download>.*
>
>
> D.

[vveider]

Prepared patch [1], review and testing is required.


[1] https://github.com/apache/ignite/pull/3989 <https://github.com/apache/ignite/pull/3989>

> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email]> wrote:
>
> Filed the ticket [1], will fix.
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <https://issues.apache.org/jira/browse/IGNITE-8478>
>
>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Igniters,
>>
>> Any reason SqlLine tool shipped with Ignite does not work with Java 9? This
>> is the error I got.
>>
>>
>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
>>> incorrect.*
>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK 1.8.**You
>>> can also download latest JDK at http://java.com/download <http://java.com/download>
>>> <http://java.com/download <http://java.com/download>>.*
>>
>>
>> D.
>

[vveider]

Tested, review and merged to master and ignite-2.5 branches (thanks to Andrey Gura for operativeness).

> On 14 May 2018, at 11:40, Petr Ivanov <[hidden email]> wrote:
>
> Prepared patch [1], review and testing is required.
>
>
> [1] https://github.com/apache/ignite/pull/3989 <https://github.com/apache/ignite/pull/3989>
>
>
>
>> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Filed the ticket [1], will fix.
>>
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <https://issues.apache.org/jira/browse/IGNITE-8478>
>>
>>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Igniters,
>>>
>>> Any reason SqlLine tool shipped with Ignite does not work with Java 9? This
>>> is the error I got.
>>>
>>>
>>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
>>>> incorrect.*
>>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK 1.8.**You
>>>> can also download latest JDK at http://java.com/download <http://java.com/download>
>>>> <http://java.com/download <http://java.com/download>>.*
>>>
>>>
>>> D.
>>
>

[dsetrakyan]

Thanks Petr,

How about Java 10? Do we support it for SqlLine as well?

D.

On Mon, May 14, 2018 at 1:53 PM, Petr Ivanov <[hidden email]> wrote:

> Tested, review and merged to master and ignite-2.5 branches (thanks to
> Andrey Gura for operativeness).
>
>
>
> > On 14 May 2018, at 11:40, Petr Ivanov <[hidden email]> wrote:
> >
> > Prepared patch [1], review and testing is required.
> >
> >
> > [1] https://github.com/apache/ignite/pull/3989 <
> https://github.com/apache/ignite/pull/3989>
> >
> >
> >
> >> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email] <mailto:
> [hidden email]>> wrote:
> >>
> >> Filed the ticket [1], will fix.
> >>
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <
> https://issues.apache.org/jira/browse/IGNITE-8478>
> >>
> >>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email]
> <mailto:[hidden email]>> wrote:
> >>>
> >>> Igniters,
> >>>
> >>> Any reason SqlLine tool shipped with Ignite does not work with Java 9?
> This
> >>> is the error I got.
> >>>
> >>>
> >>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
> >>>> incorrect.*
> >>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK
> 1.8.**You
> >>>> can also download latest JDK at http://java.com/download <
> http://java.com/download>
> >>>> <http://java.com/download <http://java.com/download>>.*
> >>>
> >>>
> >>> D.
> >>
> >
>
>

[vveider]

Not yet.

After 2.5 release, I plan to prepare a roadmap for Apache Ignite support of future Java releases (based on their’s current release cycle) and to coordinate corresponding works for introducing support of future Java versions.

> On 15 May 2018, at 01:55, Dmitriy Setrakyan <[hidden email]> wrote:
>
> Thanks Petr,
>
> How about Java 10? Do we support it for SqlLine as well?
>
> D.
>
> On Mon, May 14, 2018 at 1:53 PM, Petr Ivanov <[hidden email]> wrote:
>
>> Tested, review and merged to master and ignite-2.5 branches (thanks to
>> Andrey Gura for operativeness).
>>
>>
>>
>>> On 14 May 2018, at 11:40, Petr Ivanov <[hidden email]> wrote:
>>>
>>> Prepared patch [1], review and testing is required.
>>>
>>>
>>> [1] https://github.com/apache/ignite/pull/3989 <
>> https://github.com/apache/ignite/pull/3989>
>>>
>>>
>>>
>>>> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email] <mailto:
>> [hidden email]>> wrote:
>>>>
>>>> Filed the ticket [1], will fix.
>>>>
>>>>
>>>> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <
>> https://issues.apache.org/jira/browse/IGNITE-8478>
>>>>
>>>>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Igniters,
>>>>>
>>>>> Any reason SqlLine tool shipped with Ignite does not work with Java 9?
>> This
>>>>> is the error I got.
>>>>>
>>>>>
>>>>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
>>>>>> incorrect.*
>>>>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK
>> 1.8.**You
>>>>>> can also download latest JDK at http://java.com/download <
>> http://java.com/download>
>>>>>> <http://java.com/download <http://java.com/download>>.*
>>>>>
>>>>>
>>>>> D.
>>>>
>>>
>>
>>

[dsetrakyan]

Petr, do we really need to check Java version for SqlLine at all? I think
it will work with any version of Java, so restricting it to a certain
version is just wrong.

What do you think about removing the Java version check altogether from the
SqlLine script?

D.


On Tue, May 15, 2018 at 10:21 AM, Petr Ivanov <[hidden email]> wrote:

> Not yet.
>
> After 2.5 release, I plan to prepare a roadmap for Apache Ignite support
> of future Java releases (based on their’s current release cycle) and to
> coordinate corresponding works for introducing support of future Java
> versions.
>
>
>
> > On 15 May 2018, at 01:55, Dmitriy Setrakyan <[hidden email]>
> wrote:
> >
> > Thanks Petr,
> >
> > How about Java 10? Do we support it for SqlLine as well?
> >
> > D.
> >
> > On Mon, May 14, 2018 at 1:53 PM, Petr Ivanov <[hidden email]>
> wrote:
> >
> >> Tested, review and merged to master and ignite-2.5 branches (thanks to
> >> Andrey Gura for operativeness).
> >>
> >>
> >>
> >>> On 14 May 2018, at 11:40, Petr Ivanov <[hidden email]> wrote:
> >>>
> >>> Prepared patch [1], review and testing is required.
> >>>
> >>>
> >>> [1] https://github.com/apache/ignite/pull/3989 <
> >> https://github.com/apache/ignite/pull/3989>
> >>>
> >>>
> >>>
> >>>> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email] <mailto:
> >> [hidden email]>> wrote:
> >>>>
> >>>> Filed the ticket [1], will fix.
> >>>>
> >>>>
> >>>> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <
> >> https://issues.apache.org/jira/browse/IGNITE-8478>
> >>>>
> >>>>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email]
> >> <mailto:[hidden email]>> wrote:
> >>>>>
> >>>>> Igniters,
> >>>>>
> >>>>> Any reason SqlLine tool shipped with Ignite does not work with Java
> 9?
> >> This
> >>>>> is the error I got.
> >>>>>
> >>>>>
> >>>>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
> >>>>>> incorrect.*
> >>>>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK
> >> 1.8.**You
> >>>>>> can also download latest JDK at http://java.com/download <
> >> http://java.com/download>
> >>>>>> <http://java.com/download <http://java.com/download>>.*
> >>>>>
> >>>>>
> >>>>> D.
> >>>>
> >>>
> >>
> >>
>
>

[vveider]

I am not the author of the Java checks in this scripts.
To say more about necessity / absence of necessity of Java checks, I will have to hold an investigation.

I have filed the issue [1] and add it to backlog for next release (approx. 2.6).


[1] https://issues.apache.org/jira/browse/IGNITE-8496

> On 15 May 2018, at 13:17, Dmitriy Setrakyan <[hidden email]> wrote:
>
> Petr, do we really need to check Java version for SqlLine at all? I think
> it will work with any version of Java, so restricting it to a certain
> version is just wrong.
>
> What do you think about removing the Java version check altogether from the
> SqlLine script?
>
> D.
>
>
> On Tue, May 15, 2018 at 10:21 AM, Petr Ivanov <[hidden email]> wrote:
>
>> Not yet.
>>
>> After 2.5 release, I plan to prepare a roadmap for Apache Ignite support
>> of future Java releases (based on their’s current release cycle) and to
>> coordinate corresponding works for introducing support of future Java
>> versions.
>>
>>
>>
>>> On 15 May 2018, at 01:55, Dmitriy Setrakyan <[hidden email]>
>> wrote:
>>>
>>> Thanks Petr,
>>>
>>> How about Java 10? Do we support it for SqlLine as well?
>>>
>>> D.
>>>
>>> On Mon, May 14, 2018 at 1:53 PM, Petr Ivanov <[hidden email]>
>> wrote:
>>>
>>>> Tested, review and merged to master and ignite-2.5 branches (thanks to
>>>> Andrey Gura for operativeness).
>>>>
>>>>
>>>>
>>>>> On 14 May 2018, at 11:40, Petr Ivanov <[hidden email]> wrote:
>>>>>
>>>>> Prepared patch [1], review and testing is required.
>>>>>
>>>>>
>>>>> [1] https://github.com/apache/ignite/pull/3989 <
>>>> https://github.com/apache/ignite/pull/3989>
>>>>>
>>>>>
>>>>>
>>>>>> On 14 May 2018, at 10:35, Petr Ivanov <[hidden email] <mailto:
>>>> [hidden email]>> wrote:
>>>>>>
>>>>>> Filed the ticket [1], will fix.
>>>>>>
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-8478 <
>>>> https://issues.apache.org/jira/browse/IGNITE-8478>
>>>>>>
>>>>>>> On 12 May 2018, at 20:10, Dmitriy Setrakyan <[hidden email]
>>>> <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>> Igniters,
>>>>>>>
>>>>>>> Any reason SqlLine tool shipped with Ignite does not work with Java
>> 9?
>>>> This
>>>>>>> is the error I got.
>>>>>>>
>>>>>>>
>>>>>>>> *The version of JAVA installed in C:\Program Files\Java\jdk-9.0.1 is
>>>>>>>> incorrect.*
>>>>>>>> *Please point JAVA_HOME variable to installation of JDK 1.7 or JDK
>>>> 1.8.**You
>>>>>>>> can also download latest JDK at http://java.com/download <
>>>> http://java.com/download>
>>>>>>>> <http://java.com/download <http://java.com/download>>.*
>>>>>>>
>>>>>>>
>>>>>>> D.
>>>>>>
>>>>>
>>>>
>>>>
>>
>>