Review of IGNITE-11521

[Lukas Polacek]

Hi,
this is my first contribution to Apache Ignite. I've created a bug
<https://issues.apache.org/jira/browse/IGNITE-11521>, made a pull request
<https://github.com/apache/ignite/pull/6252> which the TC Bot is happy about
<https://issues.apache.org/jira/browse/IGNITE-11521?focusedCommentId=16790439&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16790439>.
What are the next steps? Will someone review it?

Cheers,
Lukas Polacek

[Ivan Pavlukhin]

Hi Lukas,

Thank you for your efforts! I am not 100% sure but perhaps
IgniteConfiguration#setLocalEventListeners can help in your use case?
But added BEFORE_CLUSTER_CONNNECTION lifecycle event can be still
valuable. It is good idea to describe implemented approach in jira
ticket and how can it be used to register listeners before joining the
cluster.

вт, 12 мар. 2019 г. в 14:48, Lukas Polacek <[hidden email]>:

>
> Hi,
> this is my first contribution to Apache Ignite. I've created a bug
> <https://issues.apache.org/jira/browse/IGNITE-11521>, made a pull request
> <https://github.com/apache/ignite/pull/6252> which the TC Bot is happy about
> <https://issues.apache.org/jira/browse/IGNITE-11521?focusedCommentId=16790439&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16790439>.
> What are the next steps? Will someone review it?
>
> Cheers,
> Lukas Polacek

--
Best regards,
Ivan Pavlukhin

[Lukas Polacek]

Hi,
I didn't know that IgniteConfiguration#setLocalEventListeners existed,
since we followed the documentation at readme.io
<https://apacheignite.readme.io/docs/events> which only mentions
'Ignite.events().localListen'. We'll try it to see if it works for us.

In the meantime I'll expand the JIRA ticket.


On Tue, Mar 12, 2019 at 1:33 PM Павлухин Иван <[hidden email]> wrote:

> Hi Lukas,
>
> Thank you for your efforts! I am not 100% sure but perhaps
> IgniteConfiguration#setLocalEventListeners can help in your use case?
> But added BEFORE_CLUSTER_CONNNECTION lifecycle event can be still
> valuable. It is good idea to describe implemented approach in jira
> ticket and how can it be used to register listeners before joining the
> cluster.
>
> вт, 12 мар. 2019 г. в 14:48, Lukas Polacek <[hidden email]
> >:
> >
> > Hi,
> > this is my first contribution to Apache Ignite. I've created a bug
> > <https://issues.apache.org/jira/browse/IGNITE-11521>, made a pull
> request
> > <https://github.com/apache/ignite/pull/6252> which the TC Bot is happy
> about
> > <
> https://issues.apache.org/jira/browse/IGNITE-11521?focusedCommentId=16790439&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16790439
> >.
> > What are the next steps? Will someone review it?
> >
> > Cheers,
> > Lukas Polacek
>
>
>
> --
> Best regards,
> Ivan Pavlukhin
>

[yzhdanov]

Lukas, would you be so kind as to suggest edits for the mentioned
documentation page. Your suggesions will be reviewed and incorporated.

Thanks!

--Yakov

[Lukas Polacek]

We've changed our code to use IgniteConfiguration#setLocalEventListeners
instead and it works fine, so at this point we don't need to get the pull
request accepted. However, if you think it will be useful, I don't mind
finishing the work.

Yakov, should I create a bug for the documentation update? What is the
procedure?



On Wed, Mar 13, 2019 at 10:19 AM Yakov Zhdanov <[hidden email]> wrote:

> Lukas, would you be so kind as to suggest edits for the mentioned
> documentation page. Your suggesions will be reviewed and incorporated.
>
> Thanks!
>
> --Yakov
>

[yzhdanov]

I think there should be a link on the page - Suggest edits

--Yakov

[Lukas Polacek]

Hi,
I've suggested an edit of the documentation at readme.io
<https://apacheignite.readme.io/docs/events> and updated the issue
<https://issues.apache.org/jira/browse/IGNITE-11521> with a different
description. If you can think of other use-cases for this event, please let
me know.

On Wed, Mar 13, 2019 at 10:47 AM Yakov Zhdanov <[hidden email]> wrote:

> I think there should be a link on the page - Suggest edits
>
> --Yakov
>