Review IGNITE-8859

[dkarachentsev]

Hi guys,

I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please
review.

I'm not sure if there exist tests, but I tested on Windows/Linux for
1.7, 1.8, 9 and 10 JDKs manually.

Thanks!

[dkarachentsev]

Forgot a link to the ticket
https://issues.apache.org/jira/browse/IGNITE-8859

29.06.2018 17:06, Dmitry Karachentsev пишет:

> Hi guys,
>
> I've enhanced our scripts a bit to allow run Ignite on Java 10+.
> Please review.
>
> I'm not sure if there exist tests, but I tested on Windows/Linux for
> 1.7, 1.8, 9 and 10 JDKs manually.
>
> Thanks!
>

[vveider]

Looks good.

Did you intentionally not mentioned JDK10 in warning/error texts?
Also have you tested running built Apache Ignite under JDK10?

> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <[hidden email]> wrote:
>
> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
>
> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>> Hi guys,
>>
>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>>
>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>>
>> Thanks!
>>
>

[dkarachentsev]

Hi Petr,

Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
In waring showed JAVA_HOME directory. If it would be useful, I can add
detected version.

Thanks!

29.06.2018 17:34, Petr Ivanov пишет:

> Looks good.
>
> Did you intentionally not mentioned JDK10 in warning/error texts?
> Also have you tested running built Apache Ignite under JDK10?
>
>
>> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <[hidden email]> wrote:
>>
>> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
>>
>> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>>> Hi guys,
>>>
>>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>>>
>>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>>>
>>> Thanks!
>>>

[vveider]

Very nice!


I’ll try to review changes at weekend.

> On 29 Jun 2018, at 17:40, Dmitry Karachentsev <[hidden email]> wrote:
>
> Hi Petr,
>
> Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
> In waring showed JAVA_HOME directory. If it would be useful, I can add detected version.
>
> Thanks!
>
> 29.06.2018 17:34, Petr Ivanov пишет:
>> Looks good.
>>
>> Did you intentionally not mentioned JDK10 in warning/error texts?
>> Also have you tested running built Apache Ignite under JDK10?
>>
>>
>>> On 29 Jun 2018, at 17:06, Dmitry Karachentsev <[hidden email]> wrote:
>>>
>>> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
>>>
>>> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>>>> Hi guys,
>>>>
>>>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.
>>>>
>>>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 9 and 10 JDKs manually.
>>>>
>>>> Thanks!
>>>>
>