Review IGNITE-11411 'Remove tearDown, setUp from JUnit3TestLegacySupport'

[Ivan Fedotov]

Hi Igniters!

Now I am working on iep-30[1] which is about fully 4->5 migration and
includes some moments according to JUnit 3->4 migration.
I am on the first stage and finishing ticket about removing tearDown, setUp
from JUnit3TestLegacySupport [2].

In nutshell: I removed setUp, tearDown from JUnit3TestLegacySupport and
replaced them by beforeTest, afterTest in tests where they are used. That
brings us to the JUnit5 test scenario because setUp and tearDown are used
under Rule annotation in GridAbstractTest.

Could somebody review this ticket, please?

[1]
https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5
[2] https://issues.apache.org/jira/browse/IGNITE-11411

--
Ivan Fedotov.

[hidden email]

[Eduard Shangareev]

Hi.

I am interested in. If nobody did it I would do it next week.

On Tue, Mar 19, 2019 at 10:20 AM Ivan Fedotov <[hidden email]> wrote:

> Hi Igniters!
>
> Now I am working on iep-30[1] which is about fully 4->5 migration and
> includes some moments according to JUnit 3->4 migration.
> I am on the first stage and finishing ticket about removing tearDown, setUp
> from JUnit3TestLegacySupport [2].
>
> In nutshell: I removed setUp, tearDown from JUnit3TestLegacySupport and
> replaced them by beforeTest, afterTest in tests where they are used. That
> brings us to the JUnit5 test scenario because setUp and tearDown are used
> under Rule annotation in GridAbstractTest.
>
> Could somebody review this ticket, please?
>
> [1]
>
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5
> [2] https://issues.apache.org/jira/browse/IGNITE-11411
>
> --
> Ivan Fedotov.
>
> [hidden email]
>

[Ivan Fedotov]

Hi Eduard.

Thank you for your participation in the review. In case of any questions
feel free to ask me.

вт, 19 мар. 2019 г. в 11:04, Eduard Shangareev <[hidden email]
>:

> Hi.
>
> I am interested in. If nobody did it I would do it next week.
>
> On Tue, Mar 19, 2019 at 10:20 AM Ivan Fedotov <[hidden email]> wrote:
>
> > Hi Igniters!
> >
> > Now I am working on iep-30[1] which is about fully 4->5 migration and
> > includes some moments according to JUnit 3->4 migration.
> > I am on the first stage and finishing ticket about removing tearDown,
> setUp
> > from JUnit3TestLegacySupport [2].
> >
> > In nutshell: I removed setUp, tearDown from JUnit3TestLegacySupport and
> > replaced them by beforeTest, afterTest in tests where they are used. That
> > brings us to the JUnit5 test scenario because setUp and tearDown are used
> > under Rule annotation in GridAbstractTest.
> >
> > Could somebody review this ticket, please?
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5
> > [2] https://issues.apache.org/jira/browse/IGNITE-11411
> >
> > --
> > Ivan Fedotov.
> >
> > [hidden email]
> >
>

--
Ivan Fedotov.

[hidden email]

[Ivan Pavlukhin]

Ivan,

I noticed that you updated PR [1] recently and changed an execution
flow of setUp and tearDown methods in GridAbstractTest making it
similar to what we have in master now. What did not work in an initial
implementation? I spent some time seaching the reason why did we
introduce JUnit3TestLegacySupport and faced troubles. If we have some
special case here it sounds a good idea to add neccessary comments in
the code.

[1] https://github.com/apache/ignite/pull/6227

вт, 19 мар. 2019 г. в 11:59, Ivan Fedotov <[hidden email]>:

>
> Hi Eduard.
>
> Thank you for your participation in the review. In case of any questions
> feel free to ask me.
>
> вт, 19 мар. 2019 г. в 11:04, Eduard Shangareev <[hidden email]
> >:
>
> > Hi.
> >
> > I am interested in. If nobody did it I would do it next week.
> >
> > On Tue, Mar 19, 2019 at 10:20 AM Ivan Fedotov <[hidden email]> wrote:
> >
> > > Hi Igniters!
> > >
> > > Now I am working on iep-30[1] which is about fully 4->5 migration and
> > > includes some moments according to JUnit 3->4 migration.
> > > I am on the first stage and finishing ticket about removing tearDown,
> > setUp
> > > from JUnit3TestLegacySupport [2].
> > >
> > > In nutshell: I removed setUp, tearDown from JUnit3TestLegacySupport and
> > > replaced them by beforeTest, afterTest in tests where they are used. That
> > > brings us to the JUnit5 test scenario because setUp and tearDown are used
> > > under Rule annotation in GridAbstractTest.
> > >
> > > Could somebody review this ticket, please?
> > >
> > > [1]
> > >
> > >
> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5
> > > [2] https://issues.apache.org/jira/browse/IGNITE-11411
> > >
> > > --
> > > Ivan Fedotov.
> > >
> > > [hidden email]
> > >
> >
>
>
> --
> Ivan Fedotov.
>
> [hidden email]

--
Best regards,
Ivan Pavlukhin