Request for review/merge couple of small JUnit patches

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for review/merge couple of small JUnit patches

Ivan Pavlukhin
Hi Igniters,

Recently I created 2 PRs with simple changes related our testing framework.
1. Remove several @RunWith(JUnit4.class) lines left after migration to
junit 4 [1].
2. Remove custom assumption handler in order to improve reporting on
TC for tests skipped by failed assumption [2]. See the ticket for more
details.

First patch is rather trivial. Second patch was already reviewed but
it still waits for someone able to merge it.

Please take a look.

[1] https://issues.apache.org/jira/browse/IGNITE-11398
[2] https://issues.apache.org/jira/browse/IGNITE-11356

--
Best regards,
Ivan Pavlukhin
Reply | Threaded
Open this post in threaded view
|

Re: Request for review/merge couple of small JUnit patches

Ilya Kasnacheev
Hello!

Did the first, can you rebase the second one? I'm relying on script and it
requires that change will merge flawlessly.

Regards,
--
Ilya Kasnacheev


вс, 17 мар. 2019 г. в 21:29, Павлухин Иван <[hidden email]>:

> Hi Igniters,
>
> Recently I created 2 PRs with simple changes related our testing framework.
> 1. Remove several @RunWith(JUnit4.class) lines left after migration to
> junit 4 [1].
> 2. Remove custom assumption handler in order to improve reporting on
> TC for tests skipped by failed assumption [2]. See the ticket for more
> details.
>
> First patch is rather trivial. Second patch was already reviewed but
> it still waits for someone able to merge it.
>
> Please take a look.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-11398
> [2] https://issues.apache.org/jira/browse/IGNITE-11356
>
> --
> Best regards,
> Ivan Pavlukhin
>
Reply | Threaded
Open this post in threaded view
|

Re: Request for review/merge couple of small JUnit patches

Ivan Pavlukhin
Hi Ilya,

Thanks a lot!

I rebased second PR. Can you please take a look?

пн, 18 мар. 2019 г. в 12:57, Ilya Kasnacheev <[hidden email]>:

>
> Hello!
>
> Did the first, can you rebase the second one? I'm relying on script and it
> requires that change will merge flawlessly.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вс, 17 мар. 2019 г. в 21:29, Павлухин Иван <[hidden email]>:
>
> > Hi Igniters,
> >
> > Recently I created 2 PRs with simple changes related our testing framework.
> > 1. Remove several @RunWith(JUnit4.class) lines left after migration to
> > junit 4 [1].
> > 2. Remove custom assumption handler in order to improve reporting on
> > TC for tests skipped by failed assumption [2]. See the ticket for more
> > details.
> >
> > First patch is rather trivial. Second patch was already reviewed but
> > it still waits for someone able to merge it.
> >
> > Please take a look.
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-11398
> > [2] https://issues.apache.org/jira/browse/IGNITE-11356
> >
> > --
> > Best regards,
> > Ivan Pavlukhin
> >



--
Best regards,
Ivan Pavlukhin