Request for review IGNITE-4198

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for review IGNITE-4198

Roman Shtykh
Igniters,
Can anyone have a look and give comment on this issue?
IGNITE-4198: Kafka Connect sink option to transform Kafka values.
https://issues.apache.org/jira/browse/IGNITE-4198

-Roman
Reply | Threaded
Open this post in threaded view
|

Re: Request for review IGNITE-4198

Vladimir Ozerov
Hi Roman,

Reviewed. My comments are in the ticket.

Vladimir.

On Thu, Nov 10, 2016 at 8:00 AM, Roman Shtykh <[hidden email]>
wrote:

> Igniters,
> Can anyone have a look and give comment on this issue?
> IGNITE-4198: Kafka Connect sink option to transform Kafka values.
> https://issues.apache.org/jira/browse/IGNITE-4198
>
> -Roman
>
Reply | Threaded
Open this post in threaded view
|

Re: Request for review IGNITE-4198

Roman Shtykh
Hi Vladimir,
Thanks a lot for the review!I pushed the changes. Please let me know if it is good to merge now.
-Roman
 

    On Friday, November 11, 2016 11:50 PM, Vladimir Ozerov <[hidden email]> wrote:
 

 Hi Roman,

Reviewed. My comments are in the ticket.

Vladimir.

On Thu, Nov 10, 2016 at 8:00 AM, Roman Shtykh <[hidden email]>
wrote:

> Igniters,
> Can anyone have a look and give comment on this issue?
> IGNITE-4198: Kafka Connect sink option to transform Kafka values.
> https://issues.apache.org/jira/browse/IGNITE-4198
>
> -Roman
>


   
Reply | Threaded
Open this post in threaded view
|

Re: Request for review IGNITE-4198

Vladimir Ozerov
Hi Roman,

Reviewed. One minor comment from my side in the ticket.

Vladimir.

On Tue, Nov 15, 2016 at 5:30 AM, Roman Shtykh <[hidden email]>
wrote:

> Hi Vladimir,
> Thanks a lot for the review!I pushed the changes. Please let me know if it
> is good to merge now.
> -Roman
>
>
>     On Friday, November 11, 2016 11:50 PM, Vladimir Ozerov <
> [hidden email]> wrote:
>
>
>  Hi Roman,
>
> Reviewed. My comments are in the ticket.
>
> Vladimir.
>
> On Thu, Nov 10, 2016 at 8:00 AM, Roman Shtykh <[hidden email]>
> wrote:
>
> > Igniters,
> > Can anyone have a look and give comment on this issue?
> > IGNITE-4198: Kafka Connect sink option to transform Kafka values.
> > https://issues.apache.org/jira/browse/IGNITE-4198
> >
> > -Roman
> >
>
>
>
>