Removed ignite field from TcpDiscoveryIpFinderAdapter, breaking change

[Ilya Kasnacheev]

Hello!

I can see that in this commit
https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7

protected Ignite ignite; were removed from TcpDiscoveryIpFinderAdapter.java
<https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7#diff-becacbc5a46c8170e896a34c037dfaa9>

This is part of public API and one which have very good chances to be used
(extended) in code of our users. They will get compilation errors or even
runtime errors against existing compiled code.

I think that this field should be brought back to this class, compatibility
restored. WDYT?

Regards.
--
Ilya Kasnacheev

[Pavel Pereslegin]

Hi, Ilya,

thank you for pointing this out.
I am the author of this fix [1], and from my point of view, if changes
in TcpDiscoveryIpFinderAdapter may violate public API, we definitely
should  rolling them back.

[1] https://issues.apache.org/jira/browse/IGNITE-9858

сб, 19 янв. 2019 г. в 01:38, Ilya Kasnacheev <[hidden email]>:

>
> Hello!
>
> I can see that in this commit
> https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7
>
> protected Ignite ignite; were removed from TcpDiscoveryIpFinderAdapter.java
> <https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7#diff-becacbc5a46c8170e896a34c037dfaa9>
>
> This is part of public API and one which have very good chances to be used
> (extended) in code of our users. They will get compilation errors or even
> runtime errors against existing compiled code.
>
> I think that this field should be brought back to this class, compatibility
> restored. WDYT?
>
> Regards.
> --
> Ilya Kasnacheev

[Ilya Kasnacheev]

Hello!

Filed https://issues.apache.org/jira/browse/IGNITE-11004

Regards,
--
Ilya Kasnacheev


пн, 21 янв. 2019 г. в 11:05, Pavel Pereslegin <[hidden email]>:

> Hi, Ilya,
>
> thank you for pointing this out.
> I am the author of this fix [1], and from my point of view, if changes
> in TcpDiscoveryIpFinderAdapter may violate public API, we definitely
> should  rolling them back.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9858
>
> сб, 19 янв. 2019 г. в 01:38, Ilya Kasnacheev <[hidden email]>:
>
>
> >
> > Hello!
> >
> > I can see that in this commit
> >
> https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7
> >
> > protected Ignite ignite; were removed from
> TcpDiscoveryIpFinderAdapter.java
> > <
> https://github.com/apache/ignite/commit/50dd28d28359930e020cf53d3000066965fc56b7#diff-becacbc5a46c8170e896a34c037dfaa9
> >
> >
> > This is part of public API and one which have very good chances to be
> used
> > (extended) in code of our users. They will get compilation errors or even
> > runtime errors against existing compiled code.
> >
> > I think that this field should be brought back to this class,
> compatibility
> > restored. WDYT?
> >
> > Regards.
> > --
> > Ilya Kasnacheev
>