Re[2]: [DISCUSSION] Request for thread unsafe Compute functionality deprecation.

[Zhenya Stanilovsky]

Ilya, as previously agreed, ticket [1], examples of concurrent tests you can find here GridDifferentLocalDeploymentSelfTest and here IgniteExplicitImplicitDeploymentSelfTest , TC in progress.
 
thanks !
 
[1]  https://issues.apache.org/jira/browse/IGNITE-14131
   
>Hello!
>
>Please publish it. I don't see why not.
>
>Regards,
 
 
 
   
----------------------------------------------------------------------
 
 
 

[Ilya Kasnacheev]

Hello!

In the test GridDifferentLocalDeploymentSelfTest, I can see that some count
of internal data structure yanked from a class field is not equal expected
(without the fix).
But I don't see why it is a problem. Do you have some reproducer where bad
things (such as task failure, deadlock, critical error) happen?

Regards,
--
Ilya Kasnacheev


пт, 5 февр. 2021 г. в 16:00, Zhenya Stanilovsky <[hidden email]>:

>
> Ilya, as previously agreed, ticket [1], examples of concurrent tests you
> can find here GridDifferentLocalDeploymentSelfTest and here
> IgniteExplicitImplicitDeploymentSelfTest
> <https://github.com/apache/ignite/pull/8759/files#diff-802af604a112f46b1282431673f3b143da5f2bfc4da70dbc8f0cbc93a3ed0f80>,
> TC in progress.
>
> thanks !
>
> [1] https://issues.apache.org/jira/browse/IGNITE-14131
>
>
>
> Hello!
>
> Please publish it. I don't see why not.
>
> Regards,
>
>
>
>
>
>
> ------------------------------
>
>
>
>

[Zhenya Stanilovsky]

Hello Ilya !

 
>Hello!
>
>In the test GridDifferentLocalDeploymentSelfTest, I can see that some count
>of internal data structure yanked from a class field is not equal expected
>(without the fix).
 
GridDifferentLocalDeploymentSelfTest checks that inner deployment machinery are not «leak» the only test without fix will generate huge number of 
SharedDeployment instances which will lead to jvm metaspace oom. Previous algorithm just replace old execution implementation with new one  
what led to new ClassLoaderId generation each time classloader was changed in client node.
 
The second IgniteExplicitImplicitDeploymentSelfTest demonstrates correct concurrent job calling.    
 

>But I don't see why it is a problem. Do you have some reproducer where bad
>things (such as task failure, deadlock, critical error) happen?
>
>Regards,
>--
>Ilya Kasnacheev
>
>
>пт, 5 февр. 2021 г. в 16:00, Zhenya Stanilovsky < [hidden email] >:
> 
>>
>> Ilya, as previously agreed, ticket [1], examples of concurrent tests you
>> can find here GridDifferentLocalDeploymentSelfTest and here
>> IgniteExplicitImplicitDeploymentSelfTest
>> < https://github.com/apache/ignite/pull/8759/files#diff-802af604a112f46b1282431673f3b143da5f2bfc4da70dbc8f0cbc93a3ed0f80 >,
>> TC in progress.
>>
>> thanks !
>>
>> [1]  https://issues.apache.org/jira/browse/IGNITE-14131
>>
>>
>>
>> Hello!
>>
>> Please publish it. I don't see why not.
>>
>> Regards,
>>
>>
>>
>>
>>
>>
>> ------------------------------
>>
>>
>>
>>