Pull request for minor fix in index page documentation

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Pull request for minor fix in index page documentation

Sumit Deshinge
Hi team,

I just made a minor change in apache ignite index page documentation.
But I am not sure the pull request raised is sufficient or do I need to
follow any additional steps. Please let me know/advice on the same.
Also is there any way to verify these changes as these are related to
documentation being loaded on the ignite website and not related to code?
https://github.com/sumitdeshinge/ignite/pull/1


--
Regards,
Sumit Deshinge
Reply | Threaded
Open this post in threaded view
|

Re: Pull request for minor fix in index page documentation

dmagda
Hi Sumit,

Thanks for catching the issue and preparing a pull-request! The
pull-request merges changes to your Ignite master branch rather than to the
Ignite master. Not a bid deal. I see where the problem is. @Nikita Safonov
<[hidden email]>, @Viktor Chemodanov <[hidden email]>,
could any of your correct the broken link on the page?

As for the docs contribution process, it's here. There is a step that
explains how to build the HTML version of the docs locally before pushing
live:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document#HowtoDocument-ContributingtoDocumentation

-
Denis


On Tue, Dec 8, 2020 at 2:21 AM Sumit Deshinge <[hidden email]>
wrote:

> Hi team,
>
> I just made a minor change in apache ignite index page documentation.
> But I am not sure the pull request raised is sufficient or do I need to
> follow any additional steps. Please let me know/advice on the same.
> Also is there any way to verify these changes as these are related to
> documentation being loaded on the ignite website and not related to code?
> https://github.com/sumitdeshinge/ignite/pull/1
>
>
> --
> Regards,
> Sumit Deshinge
>
Reply | Threaded
Open this post in threaded view
|

Re: Pull request for minor fix in index page documentation

Sumit Deshinge
Great, thanks Denis.

On Tue, Dec 8, 2020 at 11:35 PM Denis Magda <[hidden email]> wrote:

> Hi Sumit,
>
> Thanks for catching the issue and preparing a pull-request! The
> pull-request merges changes to your Ignite master branch rather than to the
> Ignite master. Not a bid deal. I see where the problem is. @Nikita Safonov
> <[hidden email]>, @Viktor Chemodanov <[hidden email]>,
> could any of your correct the broken link on the page?
>
> As for the docs contribution process, it's here. There is a step that
> explains how to build the HTML version of the docs locally before pushing
> live:
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document#HowtoDocument-ContributingtoDocumentation
>
> -
> Denis
>
>
> On Tue, Dec 8, 2020 at 2:21 AM Sumit Deshinge <[hidden email]>
> wrote:
>
>> Hi team,
>>
>> I just made a minor change in apache ignite index page documentation.
>> But I am not sure the pull request raised is sufficient or do I need to
>> follow any additional steps. Please let me know/advice on the same.
>> Also is there any way to verify these changes as these are related to
>> documentation being loaded on the ignite website and not related to code?
>> https://github.com/sumitdeshinge/ignite/pull/1
>>
>>
>> --
>> Regards,
>> Sumit Deshinge
>>
>

--
Regards,
Sumit Deshinge
Reply | Threaded
Open this post in threaded view
|

Re: Pull request for minor fix in index page documentation

dmagda
Nikita, thanks for fixing the issue:
https://github.com/apache/ignite/pull/8570

I've merged the changes and republished the docs on the website. Thanks for
contributing to our documentation!

-
Denis


On Wed, Dec 9, 2020 at 1:22 AM Sumit Deshinge <[hidden email]>
wrote:

> Great, thanks Denis.
>
> On Tue, Dec 8, 2020 at 11:35 PM Denis Magda <[hidden email]> wrote:
>
>> Hi Sumit,
>>
>> Thanks for catching the issue and preparing a pull-request! The
>> pull-request merges changes to your Ignite master branch rather than to the
>> Ignite master. Not a bid deal. I see where the problem is. @Nikita
>> Safonov <[hidden email]>, @Viktor Chemodanov
>> <[hidden email]>, could any of your correct the broken link on
>> the page?
>>
>> As for the docs contribution process, it's here. There is a step that
>> explains how to build the HTML version of the docs locally before pushing
>> live:
>>
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document#HowtoDocument-ContributingtoDocumentation
>>
>> -
>> Denis
>>
>>
>> On Tue, Dec 8, 2020 at 2:21 AM Sumit Deshinge <[hidden email]>
>> wrote:
>>
>>> Hi team,
>>>
>>> I just made a minor change in apache ignite index page documentation.
>>> But I am not sure the pull request raised is sufficient or do I need to
>>> follow any additional steps. Please let me know/advice on the same.
>>> Also is there any way to verify these changes as these are related to
>>> documentation being loaded on the ignite website and not related to code?
>>> https://github.com/sumitdeshinge/ignite/pull/1
>>>
>>>
>>> --
>>> Regards,
>>> Sumit Deshinge
>>>
>>
>
> --
> Regards,
> Sumit Deshinge
>
>