Proxy serialization issue

[Valentin Kulichenko]

Igniters,

I fixed java.lang.reflect.Proxy serialization in both optimized and binary
marshaller. Can someone familiar with marshalling code review my changes
before I merge? Patch is attached to the ticket [1].

[1] https://issues.apache.org/jira/browse/IGNITE-2450

Thanks!

-Val

[Alexey Goncharuk]

Val,

The code looks good to me. The only place that made me wonder was
out.unsafeEnsure(1 + 4) call which extends the stream by 5 bytes, however
we can write significantly more bytes. I see that we use the same approach
in other places, so I was wondering if this is a required call or a
performance hint?

[Valentin Kulichenko]

Alex,

I don't know in advance how many bytes I will write because some classes
can be successfully registered, but some not. Therefore I can't extend by
more than 5 bytes at this point.

Makes sense?

-Val

On Fri, Feb 5, 2016 at 4:02 AM, Alexey Goncharuk <[hidden email]
> wrote:

> Val,
>
> The code looks good to me. The only place that made me wonder was
> out.unsafeEnsure(1 + 4) call which extends the stream by 5 bytes, however
> we can write significantly more bytes. I see that we use the same approach
> in other places, so I was wondering if this is a required call or a
> performance hint?
>