Possible problems with closing AsyncFileIO

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible problems with closing AsyncFileIO

antonovsergey93
Hello, Igniters!

 I found bug in org.apache
.ignite.internal.processors.cache.persistence.file.AsyncFileIO#close(): If
one of  async futures (ChannelOpFuture) throw IgniteCheckedException
AsynchronousFileChannel associated with AsyncFileIO instance will not be
closed.
It's correct behaviour or bug?

--
BR, Sergey Antonov
Reply | Threaded
Open this post in threaded view
|

Re: Possible problems with closing AsyncFileIO

Nikolay Izhikov-2
Hello, Sergey.

If some resources are not closed after usage it certainly a bug.
Can you create a ticket and attach a simplest reproducer for desribed issue?

В Вт, 04/09/2018 в 17:44 +0300, Sergey Antonov пишет:
> Hello, Igniters!
>
>  I found bug in org.apache
> .ignite.internal.processors.cache.persistence.file.AsyncFileIO#close(): If
> one of  async futures (ChannelOpFuture) throw IgniteCheckedException
> AsynchronousFileChannel associated with AsyncFileIO instance will not be
> closed.
> It's correct behaviour or bug?
>

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Possible problems with closing AsyncFileIO

Mmuzaf
Sergey, Nikolay

Looks like the channel is not closing properly in case of an exception
thrown. We have an
active issue `Methods may fail to close the stream in core module` [1] for
other similar cases.

Maybe we should fix it there?

[1] https://issues.apache.org/jira/browse/IGNITE-9165

On Tue, 4 Sep 2018 at 17:49 Nikolay Izhikov <[hidden email]> wrote:

> Hello, Sergey.
>
> If some resources are not closed after usage it certainly a bug.
> Can you create a ticket and attach a simplest reproducer for desribed
> issue?
>
> В Вт, 04/09/2018 в 17:44 +0300, Sergey Antonov пишет:
> > Hello, Igniters!
> >
> >  I found bug in org.apache
> > .ignite.internal.processors.cache.persistence.file.AsyncFileIO#close():
> If
> > one of  async futures (ChannelOpFuture) throw IgniteCheckedException
> > AsynchronousFileChannel associated with AsyncFileIO instance will not be
> > closed.
> > It's correct behaviour or bug?
> >

--
--
Maxim Muzafarov