Plugins in tests

[yzhdanov]

Hello!

I see this output in each test I run:

[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
Configured plugins:
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- TestPlatformPlugin 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- -
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- TestReconnectPlugin 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^--
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- StanByClusterTestProvider 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- null
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]

I see that plugins were added by D. Karachentsev, P. Tupitsyn and D.
Govorukhin. Guys, are these plugins required for each test we run? I doubt
if it is true. Can we move them to another module similar to p2p classes
and plug them in only when required? Otherwise they are always in class
path and always activated which alters default Ignite configuration in
which we have no any plugin configured.

Thoughts?

--Yakov

[Pavel Tupitsyn]

TestPlatformPlugin is only needed for .NET tests.
I would gladly move it somewhere else, just not sure how to do this
properly, because .NET uses ignite-core only.
Any advice? Create a new module?

Pavel

On Fri, Jul 28, 2017 at 2:57 PM, Yakov Zhdanov <[hidden email]> wrote:

> Hello!
>
> I see this output in each test I run:
>
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> Configured plugins:
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- TestPlatformPlugin 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- -
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- TestReconnectPlugin 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^--
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- StanByClusterTestProvider 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- null
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>
> I see that plugins were added by D. Karachentsev, P. Tupitsyn and D.
> Govorukhin. Guys, are these plugins required for each test we run? I doubt
> if it is true. Can we move them to another module similar to p2p classes
> and plug them in only when required? Otherwise they are always in class
> path and always activated which alters default Ignite configuration in
> which we have no any plugin configured.
>
> Thoughts?
>
> --Yakov
>

[yzhdanov]

Pavel, I would create a new module just like "modules/extdata/p2p".

--Yakov

[Pavel Tupitsyn]

Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879

On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov <[hidden email]> wrote:

> Pavel, I would create a new module just like "modules/extdata/p2p".
>
> --Yakov
>

[daradurvs]

Hi,

>> ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
I've done it, could someone review it?

2017-07-31 11:13 GMT+03:00 Pavel Tupitsyn <[hidden email]>:

> Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
>
> On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov <[hidden email]>
> wrote:
>
> > Pavel, I would create a new module just like "modules/extdata/p2p".
> >
> > --Yakov
> >
>

--
Best Regards, Vyacheslav D.

[Pavel Tupitsyn]

I've replied in JIRA. Yakov, please have a look as well.

On Wed, Aug 23, 2017 at 6:44 PM, Vyacheslav Daradur <[hidden email]>
wrote:

> Hi,
>
> >> ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
> I've done it, could someone review it?
>
> 2017-07-31 11:13 GMT+03:00 Pavel Tupitsyn <[hidden email]>:
>
> > Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
> >
> > On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov <[hidden email]>
> > wrote:
> >
> > > Pavel, I would create a new module just like "modules/extdata/p2p".
> > >
> > > --Yakov
> > >
> >
>
>
>
> --
> Best Regards, Vyacheslav D.
>