PR : Please help do the code review for IGNITE-1069

[kcheng.mvp]

Dear Ignite Developers,


I have raised a PR https://github.com/apache/ignite/pull/440 for bug
https://issues.apache.org/jira/browse/IGNITE-1069


please help do a code review.



Thanks,
kcheng

[kcheng.mvp]

@Ilya Suntsov
<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas>,

You logged this issue, please help to reivew it. Thanks.

Thanks,
kcheng

On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]> wrote:

>
> Dear Ignite Developers,
>
>
> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> https://issues.apache.org/jira/browse/IGNITE-1069
>
>
> please help do a code review.
>
>
>
> Thanks,
> kcheng
>

[Denis Magda]

Hi Ken,

I think that Alex Kuznetsov as a maintainer of visorcmd will be able to review your contribution.

Regards,
Denis

> On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]> wrote:
>
> @Ilya Suntsov
> <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas>,
>
> You logged this issue, please help to reivew it. Thanks.
>
> Thanks,
> kcheng
>
> On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]> wrote:
>
>>
>> Dear Ignite Developers,
>>
>>
>> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
>> https://issues.apache.org/jira/browse/IGNITE-1069
>>
>>
>> please help do a code review.
>>
>>
>>
>> Thanks,
>> kcheng
>>

[Alexey Kuznetsov-2]

Hi Ken!
I will review you PR shortly.


On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <[hidden email]> wrote:

> Hi Ken,
>
> I think that Alex Kuznetsov as a maintainer of visorcmd will be able to
> review your contribution.
>
> Regards,
> Denis
>
> > On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]> wrote:
> >
> > @Ilya Suntsov
> > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas>,
> >
> > You logged this issue, please help to reivew it. Thanks.
> >
> > Thanks,
> > kcheng
> >
> > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]> wrote:
> >
> >>
> >> Dear Ignite Developers,
> >>
> >>
> >> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> >> https://issues.apache.org/jira/browse/IGNITE-1069
> >>
> >>
> >> please help do a code review.
> >>
> >>
> >>
> >> Thanks,
> >> kcheng
> >>
>
>

--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

[kcheng.mvp]

Hi Alexey Kuznetsov,

*All the related test cases are passed, please check the detail in jira. I
have paste the build link.*

Thanks,
kcheng

On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov <[hidden email]>
wrote:

> Hi Ken!
> I will review you PR shortly.
>
>
> On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <[hidden email]> wrote:
>
> > Hi Ken,
> >
> > I think that Alex Kuznetsov as a maintainer of visorcmd will be able to
> > review your contribution.
> >
> > Regards,
> > Denis
> >
> > > On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]> wrote:
> > >
> > > @Ilya Suntsov
> > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas>,
> > >
> > > You logged this issue, please help to reivew it. Thanks.
> > >
> > > Thanks,
> > > kcheng
> > >
> > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]>
> wrote:
> > >
> > >>
> > >> Dear Ignite Developers,
> > >>
> > >>
> > >> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > >>
> > >>
> > >> please help do a code review.
> > >>
> > >>
> > >>
> > >> Thanks,
> > >> kcheng
> > >>
> >
> >
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

[Alexey Kuznetsov-2]

Ken,

I done with review, all looks good, I merged your PR to master.
Thanks for your contribution.


On Sat, Jan 30, 2016 at 11:19 PM, Ken Cheng <[hidden email]> wrote:

> Hi Alexey Kuznetsov,
>
> *All the related test cases are passed, please check the detail in jira. I
> have paste the build link.*
>
> Thanks,
> kcheng
>
> On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov <[hidden email]
> >
> wrote:
>
> > Hi Ken!
> > I will review you PR shortly.
> >
> >
> > On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <[hidden email]>
> wrote:
> >
> > > Hi Ken,
> > >
> > > I think that Alex Kuznetsov as a maintainer of visorcmd will be able to
> > > review your contribution.
> > >
> > > Regards,
> > > Denis
> > >
> > > > On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]>
> wrote:
> > > >
> > > > @Ilya Suntsov
> > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas>,
> > > >
> > > > You logged this issue, please help to reivew it. Thanks.
> > > >
> > > > Thanks,
> > > > kcheng
> > > >
> > > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]>
> > wrote:
> > > >
> > > >>
> > > >> Dear Ignite Developers,
> > > >>
> > > >>
> > > >> I have raised a PR https://github.com/apache/ignite/pull/440 for
> bug
> > > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > > >>
> > > >>
> > > >> please help do a code review.
> > > >>
> > > >>
> > > >>
> > > >> Thanks,
> > > >> kcheng
> > > >>
> > >
> > >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>

--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

[kcheng.mvp]

Hi Alexey,

Thank you very much!

but I noticed the PR https://github.com/apache/ignite/pull/440 is still at
open status

Thanks,
kcheng

On Mon, Feb 1, 2016 at 11:16 AM, Alexey Kuznetsov <[hidden email]>
wrote:

> Ken,
>
> I done with review, all looks good, I merged your PR to master.
> Thanks for your contribution.
>
>
> On Sat, Jan 30, 2016 at 11:19 PM, Ken Cheng <[hidden email]> wrote:
>
> > Hi Alexey Kuznetsov,
> >
> > *All the related test cases are passed, please check the detail in jira.
> I
> > have paste the build link.*
> >
> > Thanks,
> > kcheng
> >
> > On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov <
> [hidden email]
> > >
> > wrote:
> >
> > > Hi Ken!
> > > I will review you PR shortly.
> > >
> > >
> > > On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <[hidden email]>
> > wrote:
> > >
> > > > Hi Ken,
> > > >
> > > > I think that Alex Kuznetsov as a maintainer of visorcmd will be able
> to
> > > > review your contribution.
> > > >
> > > > Regards,
> > > > Denis
> > > >
> > > > > On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]>
> > wrote:
> > > > >
> > > > > @Ilya Suntsov
> > > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas
> >,
> > > > >
> > > > > You logged this issue, please help to reivew it. Thanks.
> > > > >
> > > > > Thanks,
> > > > > kcheng
> > > > >
> > > > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]>
> > > wrote:
> > > > >
> > > > >>
> > > > >> Dear Ignite Developers,
> > > > >>
> > > > >>
> > > > >> I have raised a PR https://github.com/apache/ignite/pull/440 for
> > bug
> > > > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > > > >>
> > > > >>
> > > > >> please help do a code review.
> > > > >>
> > > > >>
> > > > >>
> > > > >> Thanks,
> > > > >> kcheng
> > > > >>
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

[Alexey Kuznetsov-2]

Hi Ken,

That was my fault. Fixed.

Thanks!

On Mon, Feb 1, 2016 at 10:36 AM, Ken Cheng <[hidden email]> wrote:

> Hi Alexey,
>
> Thank you very much!
>
> but I noticed the PR https://github.com/apache/ignite/pull/440 is still at
> open status
>
> Thanks,
> kcheng
>
> On Mon, Feb 1, 2016 at 11:16 AM, Alexey Kuznetsov <[hidden email]
> >
> wrote:
>
> > Ken,
> >
> > I done with review, all looks good, I merged your PR to master.
> > Thanks for your contribution.
> >
> >
> > On Sat, Jan 30, 2016 at 11:19 PM, Ken Cheng <[hidden email]>
> wrote:
> >
> > > Hi Alexey Kuznetsov,
> > >
> > > *All the related test cases are passed, please check the detail in
> jira.
> > I
> > > have paste the build link.*
> > >
> > > Thanks,
> > > kcheng
> > >
> > > On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov <
> > [hidden email]
> > > >
> > > wrote:
> > >
> > > > Hi Ken!
> > > > I will review you PR shortly.
> > > >
> > > >
> > > > On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <[hidden email]>
> > > wrote:
> > > >
> > > > > Hi Ken,
> > > > >
> > > > > I think that Alex Kuznetsov as a maintainer of visorcmd will be
> able
> > to
> > > > > review your contribution.
> > > > >
> > > > > Regards,
> > > > > Denis
> > > > >
> > > > > > On 30 янв. 2016 г., at 11:59, Ken Cheng <[hidden email]>
> > > wrote:
> > > > > >
> > > > > > @Ilya Suntsov
> > > > > > <
> https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas
> > >,
> > > > > >
> > > > > > You logged this issue, please help to reivew it. Thanks.
> > > > > >
> > > > > > Thanks,
> > > > > > kcheng
> > > > > >
> > > > > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <[hidden email]
> >
> > > > wrote:
> > > > > >
> > > > > >>
> > > > > >> Dear Ignite Developers,
> > > > > >>
> > > > > >>
> > > > > >> I have raised a PR https://github.com/apache/ignite/pull/440
> for
> > > bug
> > > > > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > > > > >>
> > > > > >>
> > > > > >> please help do a code review.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> Thanks,
> > > > > >> kcheng
> > > > > >>
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > > GridGain Systems
> > > > www.gridgain.com
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>

--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

[Pavel Konstantinov]

Guys,

I've added my thoughts in the ticket.

Ken, could you please take a look?

[kcheng.mvp]

Hi Pavel,

I will take care of it.



Thanks,
kcheng

On Mon, Feb 1, 2016 at 2:42 PM, Pavel Konstantinov <
[hidden email]> wrote:

> Guys,
>
> I've added my thoughts in the ticket.
>
> Ken, could you please take a look?
>

[kcheng.mvp]

Hi Pavel,

Raised PR. All the tests passed

http://204.14.53.151/viewLog.html?buildId=105755&buildTypeId=IgniteTests_IgniteVisorConsoleTestDetach&tab=buildResultsDiv

Thanks,
kcheng

On Mon, Feb 1, 2016 at 2:46 PM, Ken Cheng <[hidden email]> wrote:

> Hi Pavel,
>
> I will take care of it.
>
>
>
> Thanks,
> kcheng
>
> On Mon, Feb 1, 2016 at 2:42 PM, Pavel Konstantinov <
> [hidden email]> wrote:
>
>> Guys,
>>
>> I've added my thoughts in the ticket.
>>
>> Ken, could you please take a look?
>>
>
>