PR IGNITE-1094 Ignite.createCache(CacheConfiguration) hangs if some exception occurs during cache initialization

[voipp]

Plz, review my changes
https://issues.apache.org/jira/browse/IGNITE-1094

https://github.com/apache/ignite/pull/1581
--

*Best Regards,*

*Kuznetsov Aleksey*

[yzhdanov]

Alexey, I will take a look at this in couple of days.

--Yakov

2017-03-01 11:25 GMT+03:00 ALEKSEY KUZNETSOV <[hidden email]>:

> Plz, review my changes
> https://issues.apache.org/jira/browse/IGNITE-1094
>
> https://github.com/apache/ignite/pull/1581
> --
>
> *Best Regards,*
>
> *Kuznetsov Aleksey*
>

[Yakov Zhdanov-2]

Alexey, my comments are in the ticket. Please address them.

Thanks!
--
Yakov Zhdanov, Director R&D
*GridGain Systems*
www.gridgain.com

2017-03-01 12:15 GMT+03:00 Yakov Zhdanov <[hidden email]>:

> Alexey, I will take a look at this in couple of days.
>
> --Yakov
>
> 2017-03-01 11:25 GMT+03:00 ALEKSEY KUZNETSOV <[hidden email]>:
>
>> Plz, review my changes
>> https://issues.apache.org/jira/browse/IGNITE-1094
>>
>> https://github.com/apache/ignite/pull/1581
>> --
>>
>> *Best Regards,*
>>
>> *Kuznetsov Aleksey*
>>
>
>

[voipp]

Regarding your comment in ticket. Do you mean broken factory node ought to
send notifications to cache nodes through sharedCtx.io().send(...) ?

пт, 3 мар. 2017 г. в 11:33, Yakov Zhdanov <[hidden email]>:

> Alexey, my comments are in the ticket. Please address them.
>
> Thanks!
> --
> Yakov Zhdanov, Director R&D
> *GridGain Systems*
> www.gridgain.com
>
> 2017-03-01 12:15 GMT+03:00 Yakov Zhdanov <[hidden email]>:
>
> > Alexey, I will take a look at this in couple of days.
> >
> > --Yakov
> >
> > 2017-03-01 11:25 GMT+03:00 ALEKSEY KUZNETSOV <[hidden email]>:
> >
> >> Plz, review my changes
> >> https://issues.apache.org/jira/browse/IGNITE-1094
> >>
> >> https://github.com/apache/ignite/pull/1581
> >> --
> >>
> >> *Best Regards,*
> >>
> >> *Kuznetsov Aleksey*
> >>
> >
> >
>

--

*Best Regards,*

*Kuznetsov Aleksey*

[voipp]

Regarding your comment in ticket. Do you mean broken factory node ought to
send notifications to cache nodes through sharedCtx.io().send(...) ?

вт, 7 мар. 2017 г. в 14:23, ALEKSEY KUZNETSOV <[hidden email]>:

> Regarding your comment in ticket. Do you mean broken factory node ought to
> send notifications to cache nodes through sharedCtx.io().send(...) ?
>
> пт, 3 мар. 2017 г. в 11:33, Yakov Zhdanov <[hidden email]>:
>
> Alexey, my comments are in the ticket. Please address them.
>
> Thanks!
> --
> Yakov Zhdanov, Director R&D
> *GridGain Systems*
> www.gridgain.com
>
> 2017-03-01 12:15 GMT+03:00 Yakov Zhdanov <[hidden email]>:
>
> > Alexey, I will take a look at this in couple of days.
> >
> > --Yakov
> >
> > 2017-03-01 11:25 GMT+03:00 ALEKSEY KUZNETSOV <[hidden email]>:
> >
> >> Plz, review my changes
> >> https://issues.apache.org/jira/browse/IGNITE-1094
> >>
> >> https://github.com/apache/ignite/pull/1581
> >> --
> >>
> >> *Best Regards,*
> >>
> >> *Kuznetsov Aleksey*
> >>
> >
> >
>
> --
>
> *Best Regards,*
>
> *Kuznetsov Aleksey*
>

--

*Best Regards,*

*Kuznetsov Aleksey*

[yzhdanov]

Alexey, you should understand how caches startup and partition map exchange
work. I would suggest you start couple of nodes in single VM and simply do
step-by-step debug in your IDE.

I don't think you will need to introduce any new message, but I think you
will have to add info to GridDhtPartitionsSingleMessage and
GridDhtPartitionsFullMessage. These messages are being sent via
communication as you described.

Thanks!

--Yakov

[voipp]

Its not simple as you say) Im confused with numerous sender\listener etc.
methods. It looks like, coordinator node sends DynamicCacheChangeBatch
message, with cache create request over cacheProcessor to smbd. But i
cannot trace cache startup flow from this point.

чт, 9 мар. 2017 г. в 17:46, Yakov Zhdanov <[hidden email]>:

> Alexey, you should understand how caches startup and partition map exchange
> work. I would suggest you start couple of nodes in single VM and simply do
> step-by-step debug in your IDE.
>
> I don't think you will need to introduce any new message, but I think you
> will have to add info to GridDhtPartitionsSingleMessage and
> GridDhtPartitionsFullMessage. These messages are being sent via
> communication as you described.
>
> Thanks!
>
> --Yakov
>

--

*Best Regards,*

*Kuznetsov Aleksey*

[voipp]

It still unclear , how could i notify coordinator that cache creation failed

чт, 9 мар. 2017 г. в 17:46, Yakov Zhdanov <[hidden email]>:

Alexey, you should understand how caches startup and partition map exchange


work. I would suggest you start couple of nodes in single VM and simply do
step-by-step debug in your IDE.

I don't think you will need to introduce any new message, but I think you
will have to add info to GridDhtPartitionsSingleMessage and
GridDhtPartitionsFullMessage. These messages are being sent via
communication as you described.

Thanks!

--Yakov

--

*Best Regards,*

*Kuznetsov Aleksey*