Not the best name for WAL on/off command in SQL

[dmagda]

Vladimir, Anton,

I've been reviewing the docs of WAL on/off capabilities [1] added to 2.4
and personally think that LOGGING/NOLOGGING is not the best name to turn
WAL on/off with ALTER TABLE [2].

May I suggest to name it in a more human-friendly fashion such as:
ALTER TABLE table *[WAL_ON|WAL_OFF]*

Hope you can do the renaming while 2.4 is still being tested and
benchmarked. Sorry for late notice, but I missed the general review of the
API.

[1] https://issues.apache.org/jira/browse/IGNITE-7415?filter=12342590
[2] https://apacheignite-sql.readme.io/v2.3/docs/alter-table_24_hidden

--
Denis

[dsetrakyan]

Denis, I am not sure I like the underscore. I believe Vladimir took the
command name from other RDBMS systems, but I will let him comment.

D.

On Thu, Feb 22, 2018 at 4:27 PM, Denis Magda <[hidden email]> wrote:

> Vladimir, Anton,
>
> I've been reviewing the docs of WAL on/off capabilities [1] added to 2.4
> and personally think that LOGGING/NOLOGGING is not the best name to turn
> WAL on/off with ALTER TABLE [2].
>
> May I suggest to name it in a more human-friendly fashion such as:
> ALTER TABLE table *[WAL_ON|WAL_OFF]*
>
> Hope you can do the renaming while 2.4 is still being tested and
> benchmarked. Sorry for late notice, but I missed the general review of the
> API.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7415?filter=12342590
> [2] https://apacheignite-sql.readme.io/v2.3/docs/alter-table_24_hidden
>
> --
> Denis
>

[Vladimir Ozerov]

Logging/no logging is common naming for journal management commands. No
reason to change it.

пт, 23 февр. 2018 г. в 6:06, Dmitriy Setrakyan <[hidden email]>:

> Denis, I am not sure I like the underscore. I believe Vladimir took the
> command name from other RDBMS systems, but I will let him comment.
>
> D.
>
> On Thu, Feb 22, 2018 at 4:27 PM, Denis Magda <[hidden email]> wrote:
>
>> Vladimir, Anton,
>>
>> I've been reviewing the docs of WAL on/off capabilities [1] added to 2.4
>> and personally think that LOGGING/NOLOGGING is not the best name to turn
>> WAL on/off with ALTER TABLE [2].
>>
>> May I suggest to name it in a more human-friendly fashion such as:
>> ALTER TABLE table *[WAL_ON|WAL_OFF]*
>>
>> Hope you can do the renaming while 2.4 is still being tested and
>> benchmarked. Sorry for late notice, but I missed the general review of the
>> API.
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-7415?filter=12342590
>> [2] https://apacheignite-sql.readme.io/v2.3/docs/alter-table_24_hidden
>>
>> --
>> Denis
>>
>
>

[dmagda]

Got you, thanks. Let's leave it this way then if it's a standard naming
approach.

--
Denis

On Fri, Feb 23, 2018 at 4:45 AM, Vladimir Ozerov <[hidden email]>
wrote:

> Logging/no logging is common naming for journal management commands. No
> reason to change it.
>
> пт, 23 февр. 2018 г. в 6:06, Dmitriy Setrakyan <[hidden email]>:
>
> > Denis, I am not sure I like the underscore. I believe Vladimir took the
> > command name from other RDBMS systems, but I will let him comment.
> >
> > D.
> >
> > On Thu, Feb 22, 2018 at 4:27 PM, Denis Magda <[hidden email]> wrote:
> >
> >> Vladimir, Anton,
> >>
> >> I've been reviewing the docs of WAL on/off capabilities [1] added to 2.4
> >> and personally think that LOGGING/NOLOGGING is not the best name to turn
> >> WAL on/off with ALTER TABLE [2].
> >>
> >> May I suggest to name it in a more human-friendly fashion such as:
> >> ALTER TABLE table *[WAL_ON|WAL_OFF]*
> >>
> >> Hope you can do the renaming while 2.4 is still being tested and
> >> benchmarked. Sorry for late notice, but I missed the general review of
> the
> >> API.
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-7415?filter=12342590
> >> [2] https://apacheignite-sql.readme.io/v2.3/docs/alter-table_24_hidden
> >>
> >> --
> >> Denis
> >>
> >
> >
>