Node attribute filter

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Node attribute filter

Valentin Kulichenko
Guys,

I created a simple implementation of IgnitePredicate<ClusterNode> based on
user attributes. This is the most commonly used approach for node filters,
but currently users are forced to create their own implementations each
time. Would be useful to have it out of the box.

Can someone take a look at the implementation and tell me if there is
anything wrong/missed?

Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
PR: https://github.com/apache/ignite/pull/1369

-Val
Reply | Threaded
Open this post in threaded view
|

Re: Node attribute filter

dmagda
Val, thanks. Reviewed. Looks good to merge.


Denis

> On Dec 20, 2016, at 3:27 PM, Valentin Kulichenko <[hidden email]> wrote:
>
> Guys,
>
> I created a simple implementation of IgnitePredicate<ClusterNode> based on
> user attributes. This is the most commonly used approach for node filters,
> but currently users are forced to create their own implementations each
> time. Would be useful to have it out of the box.
>
> Can someone take a look at the implementation and tell me if there is
> anything wrong/missed?
>
> Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
> PR: https://github.com/apache/ignite/pull/1369
>
> -Val

Reply | Threaded
Open this post in threaded view
|

Re: Node attribute filter

Valentin Kulichenko
Thanks, Denis! Will merge shortly.

On Thu, Dec 22, 2016 at 11:55 AM, Denis Magda <[hidden email]> wrote:

> Val, thanks. Reviewed. Looks good to merge.
>
> —
> Denis
>
> > On Dec 20, 2016, at 3:27 PM, Valentin Kulichenko <
> [hidden email]> wrote:
> >
> > Guys,
> >
> > I created a simple implementation of IgnitePredicate<ClusterNode> based
> on
> > user attributes. This is the most commonly used approach for node
> filters,
> > but currently users are forced to create their own implementations each
> > time. Would be useful to have it out of the box.
> >
> > Can someone take a look at the implementation and tell me if there is
> > anything wrong/missed?
> >
> > Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
> > PR: https://github.com/apache/ignite/pull/1369
> >
> > -Val
>
>