New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

Jens Hoffmann
Hi all,

I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
Jira) as my newbie contribution.

Could you add me to the list of Ignite contributors?
Jira username: thehoff

Cheers
Jens
Reply | Threaded
Open this post in threaded view
|

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

Semyon Boikov
Hi,

I added you in the contributors list.

On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <[hidden email]>
wrote:

> Hi all,
>
> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
> Jira) as my newbie contribution.
>
> Could you add me to the list of Ignite contributors?
> Jira username: thehoff
>
> Cheers
> Jens
>
Reply | Threaded
Open this post in threaded view
|

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

Jens Hoffmann
Thanks Semyon.

I created a pull request a short while ago, however I am not quite
sure what I need to do in TeamCity. Do I need to register and run the
test suite that I changed, or can I move the ticket to ready for
review?

Thanks
Jens

On Thu, Jul 21, 2016 at 1:07 PM, Semyon Boikov <[hidden email]> wrote:

> Hi,
>
> I added you in the contributors list.
>
> On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <[hidden email]>
> wrote:
>
>> Hi all,
>>
>> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
>> Jira) as my newbie contribution.
>>
>> Could you add me to the list of Ignite contributors?
>> Jira username: thehoff
>>
>> Cheers
>> Jens
>>
Reply | Threaded
Open this post in threaded view
|

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

Saikat Maitra
Hi

You can register in TeamCity and run the TestSuite on your pull request.
Once the tests passes you can submit the jira ticket as Submit Patch.

https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-SubmittingForReview

Regards
Saikat

On Thu, Jul 21, 2016 at 6:05 PM, NoTrueScotsman <[hidden email]>
wrote:

> Thanks Semyon.
>
> I created a pull request a short while ago, however I am not quite
> sure what I need to do in TeamCity. Do I need to register and run the
> test suite that I changed, or can I move the ticket to ready for
> review?
>
> Thanks
> Jens
>
> On Thu, Jul 21, 2016 at 1:07 PM, Semyon Boikov <[hidden email]>
> wrote:
> > Hi,
> >
> > I added you in the contributors list.
> >
> > On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <
> [hidden email]>
> > wrote:
> >
> >> Hi all,
> >>
> >> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
> >> Jira) as my newbie contribution.
> >>
> >> Could you add me to the list of Ignite contributors?
> >> Jira username: thehoff
> >>
> >> Cheers
> >> Jens
> >>
>
Reply | Threaded
Open this post in threaded view
|

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

Jens Hoffmann
Thanks Saikat.

I registered and had to find my way TC around a bit, but managed to
run the test suite. I'll add some clarification to the Wiki that will
hopefully help other newcomers.

Many thanks
Jens



On Sat, Jul 23, 2016 at 3:30 PM, Saikat Maitra <[hidden email]> wrote:

> Hi
>
> You can register in TeamCity and run the TestSuite on your pull request.
> Once the tests passes you can submit the jira ticket as Submit Patch.
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-SubmittingForReview
>
> Regards
> Saikat
>
> On Thu, Jul 21, 2016 at 6:05 PM, NoTrueScotsman <[hidden email]>
> wrote:
>
>> Thanks Semyon.
>>
>> I created a pull request a short while ago, however I am not quite
>> sure what I need to do in TeamCity. Do I need to register and run the
>> test suite that I changed, or can I move the ticket to ready for
>> review?
>>
>> Thanks
>> Jens
>>
>> On Thu, Jul 21, 2016 at 1:07 PM, Semyon Boikov <[hidden email]>
>> wrote:
>> > Hi,
>> >
>> > I added you in the contributors list.
>> >
>> > On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <
>> [hidden email]>
>> > wrote:
>> >
>> >> Hi all,
>> >>
>> >> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
>> >> Jira) as my newbie contribution.
>> >>
>> >> Could you add me to the list of Ignite contributors?
>> >> Jira username: thehoff
>> >>
>> >> Cheers
>> >> Jens
>> >>
>>