Need review IGNITE-8661

[Dmitriy Govorukhin]

Folks,

I fixed a problem with an iterator. [1] WALItreater is not stopped if can
not deserialize record or fail read record with corrupted content. Please
review [2][3].

[1] IGNITIGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661>
[2] PR-4155 <https://github.com/apache/ignite/pull/4155>
[3] CR-637 <https://reviews.ignite.apache.org/ignite/review/IGNT-CR-637>

dev-list discussion: WAL iterator unexpected behavior

[Eduard Shangareev]

Dmitriy,

Great job!

I will look.

On Thu, Jun 14, 2018 at 4:53 PM, Dmitriy Govorukhin <
[hidden email]> wrote:

> Folks,
>
> I fixed a problem with an iterator. [1] WALItreater is not stopped if can
> not deserialize record or fail read record with corrupted content. Please
> review [2][3].
>
> [1] IGNITIGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661>
> [2] PR-4155 <https://github.com/apache/ignite/pull/4155>
> [3] CR-637 <https://reviews.ignite.apache.org/ignite/review/IGNT-CR-637>
>
> dev-list discussion: WAL iterator unexpected behavior
>

[dsetrakyan]

Dmitriy, great job! Very important fix to a very bad problem in the product
that could cause data consistency issue.

Will it be included into 2.6, or will we have to wait for 2.7?

D.

On Thu, Jun 14, 2018 at 6:53 AM, Dmitriy Govorukhin <
[hidden email]> wrote:

> Folks,
>
> I fixed a problem with an iterator. [1] WALItreater is not stopped if can
> not deserialize record or fail read record with corrupted content. Please
> review [2][3].
>
> [1] IGNITIGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661>
> [2] PR-4155 <https://github.com/apache/ignite/pull/4155>
> [3] CR-637 <https://reviews.ignite.apache.org/ignite/review/IGNT-CR-637>
>
> dev-list discussion: WAL iterator unexpected behavior
>

[Ivan Rakov]

Dmitriy G.,

I will take a look as well, just in case.

Best Regards,
Ivan Rakov

On 15.06.2018 2:36, Dmitriy Setrakyan wrote:

> Dmitriy, great job! Very important fix to a very bad problem in the product
> that could cause data consistency issue.
>
> Will it be included into 2.6, or will we have to wait for 2.7?
>
> D.
>
> On Thu, Jun 14, 2018 at 6:53 AM, Dmitriy Govorukhin <
> [hidden email]> wrote:
>
>> Folks,
>>
>> I fixed a problem with an iterator. [1] WALItreater is not stopped if can
>> not deserialize record or fail read record with corrupted content. Please
>> review [2][3].
>>
>> [1] IGNITIGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661>
>> [2] PR-4155 <https://github.com/apache/ignite/pull/4155>
>> [3] CR-637 <https://reviews.ignite.apache.org/ignite/review/IGNT-CR-637>
>>
>> dev-list discussion: WAL iterator unexpected behavior
>>

[Dmitriy Govorukhin]

Dmitriy,

I think we can try to include it in 2.6.

On Fri, Jun 15, 2018 at 7:10 PM Ivan Rakov <[hidden email]> wrote:

> Dmitriy G.,
>
> I will take a look as well, just in case.
>
> Best Regards,
> Ivan Rakov
>
> On 15.06.2018 2:36, Dmitriy Setrakyan wrote:
> > Dmitriy, great job! Very important fix to a very bad problem in the
> product
> > that could cause data consistency issue.
> >
> > Will it be included into 2.6, or will we have to wait for 2.7?
> >
> > D.
> >
> > On Thu, Jun 14, 2018 at 6:53 AM, Dmitriy Govorukhin <
> > [hidden email]> wrote:
> >
> >> Folks,
> >>
> >> I fixed a problem with an iterator. [1] WALItreater is not stopped if
> can
> >> not deserialize record or fail read record with corrupted content.
> Please
> >> review [2][3].
> >>
> >> [1] IGNITIGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661
> >
> >> [2] PR-4155 <https://github.com/apache/ignite/pull/4155>
> >> [3] CR-637 <https://reviews.ignite.apache.org/ignite/review/IGNT-CR-637
> >
> >>
> >> dev-list discussion: WAL iterator unexpected behavior
> >>
>
>