Need Review IGNITE-7616 Mxbeans thread display.

[DaveWHarvey]

   1.
      This is my second newbie submission, it could use a review, and I
      keep getting snapshot dependency errors in teamcity that seem like the
      cannot be related to my changes, even after rebasing 2 twice.
I couldn't
      find a crisp defintion of what a snapshot dependency is.

      It is a low regression risk fix to the mxbeans display of thread
      pools, where one type of pool mxbeans registration was simply
miscoded, and
      another type of pool was completely missing any code to display it.  It
      provides insight at runtime into two thread pools that are currently
      opaque.    It makes one very modest change to actual production code.

      2. IGNITE-7616
<https://jira.apache.org/jira/browse/IGNITE-7616>GridDataStreamExecutor
   and GridCallbackExecutor JMX beans return incorrect values due to invalid
   interface registration.


https://github.com/apache/ignite/pull/4732
-DH

PS I have seen this movie before, and the future got much brighter future
when we completed the equivalent of making teamcity  whole again.

[Dmitriy Pavlov]

Hi David,

Snapshot Dependency Error is TeamCity term means some from dependent builds
failed.

Because some percent of tests have constant floating failures, almost all
runs will get this error.

I will do some tests validation shortly.

Sincerely,
Dmitriy Pavlov

пт, 28 сент. 2018 г. в 15:17, David Harvey <[hidden email]>:

>    1.
>       This is my second newbie submission, it could use a review, and I
>       keep getting snapshot dependency errors in teamcity that seem like
> the
>       cannot be related to my changes, even after rebasing 2 twice.
> I couldn't
>       find a crisp defintion of what a snapshot dependency is.
>
>       It is a low regression risk fix to the mxbeans display of thread
>       pools, where one type of pool mxbeans registration was simply
> miscoded, and
>       another type of pool was completely missing any code to display it.
> It
>       provides insight at runtime into two thread pools that are currently
>       opaque.    It makes one very modest change to actual production code.
>
>       2. IGNITE-7616
> <https://jira.apache.org/jira/browse/IGNITE-7616>GridDataStreamExecutor
>    and GridCallbackExecutor JMX beans return incorrect values due to
> invalid
>    interface registration.
>
>
> https://github.com/apache/ignite/pull/4732
> -DH
>
> PS I have seen this movie before, and the future got much brighter future
> when we completed the equivalent of making teamcity  whole again.
>

[Dmitriy Pavlov]

I've checked run.

There are no suspicious test failures here, all failures are more or less
the same with the master.

пт, 28 сент. 2018 г. в 20:03, Dmitriy Pavlov <[hidden email]>:

> Hi David,
>
> Snapshot Dependency Error is TeamCity term means some from dependent
> builds failed.
>
> Because some percent of tests have constant floating failures, almost all
> runs will get this error.
>
> I will do some tests validation shortly.
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 28 сент. 2018 г. в 15:17, David Harvey <[hidden email]>:
>
>>    1.
>>       This is my second newbie submission, it could use a review, and I
>>       keep getting snapshot dependency errors in teamcity that seem like
>> the
>>       cannot be related to my changes, even after rebasing 2 twice.
>> I couldn't
>>       find a crisp defintion of what a snapshot dependency is.
>>
>>       It is a low regression risk fix to the mxbeans display of thread
>>       pools, where one type of pool mxbeans registration was simply
>> miscoded, and
>>       another type of pool was completely missing any code to display
>> it.  It
>>       provides insight at runtime into two thread pools that are currently
>>       opaque.    It makes one very modest change to actual production
>> code.
>>
>>       2. IGNITE-7616
>> <https://jira.apache.org/jira/browse/IGNITE-7616>GridDataStreamExecutor
>>    and GridCallbackExecutor JMX beans return incorrect values due to
>> invalid
>>    interface registration.
>>
>>
>> https://github.com/apache/ignite/pull/4732
>> -DH
>>
>> PS I have seen this movie before, and the future got much brighter future
>> when we completed the equivalent of making teamcity  whole again.
>>
>