Move CacheStore::loadCache to a separate interface

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Move CacheStore::loadCache to a separate interface

Stanislav Lukyanov
Hi Igniters,

I’ve just created a ticket to move CacheStore::loadCache to a separate interface:
https://issues.apache.org/jira/browse/IGNITE-8952
In short, this is to provide a way to only implement loadCache without messing with other methods CacheStore implements. More details are in the JIRA.
I believe this would make the API a bit cleaner than it is right now.

This is a small change, I just wanted to highlight it on the dev-list as it’s a proposed adjustment to a very old core API.
Feel free to comment here or in JIRA.

Thanks,
Stan
Reply | Threaded
Open this post in threaded view
|

Re: Move CacheStore::loadCache to a separate interface

Dmitriy Pavlov
As far as I understand we should to wait 3.0, shouldn't we?

пт, 6 июл. 2018 г. в 16:17, Stanislav Lukyanov <[hidden email]>:

> Hi Igniters,
>
> I’ve just created a ticket to move CacheStore::loadCache to a separate
> interface:
> https://issues.apache.org/jira/browse/IGNITE-8952
> In short, this is to provide a way to only implement loadCache without
> messing with other methods CacheStore implements. More details are in the
> JIRA.
> I believe this would make the API a bit cleaner than it is right now.
>
> This is a small change, I just wanted to highlight it on the dev-list as
> it’s a proposed adjustment to a very old core API.
> Feel free to comment here or in JIRA.
>
> Thanks,
> Stan
>
Reply | Threaded
Open this post in threaded view
|

RE: Move CacheStore::loadCache to a separate interface

Stanislav Lukyanov
Not really, extracting a method to a superinterface is a fully compatible change.
There won’t be any compatibility issues because of this (disregarding possible bugs, of course ;) ).

In any case, I’m not planning to fix it right away – this isn’t anywhere near critical or urgent, obviously.
I think it would be a nice newbie ticket.

Stan

From: Dmitry Pavlov
Sent: 6 июля 2018 г. 16:25
To: [hidden email]
Subject: Re: Move CacheStore::loadCache to a separate interface

As far as I understand we should to wait 3.0, shouldn't we?

пт, 6 июл. 2018 г. в 16:17, Stanislav Lukyanov <[hidden email]>:

> Hi Igniters,
>
> I’ve just created a ticket to move CacheStore::loadCache to a separate
> interface:
> https://issues.apache.org/jira/browse/IGNITE-8952
> In short, this is to provide a way to only implement loadCache without
> messing with other methods CacheStore implements. More details are in the
> JIRA.
> I believe this would make the API a bit cleaner than it is right now.
>
> This is a small change, I just wanted to highlight it on the dev-list as
> it’s a proposed adjustment to a very old core API.
> Feel free to comment here or in JIRA.
>
> Thanks,
> Stan
>

Reply | Threaded
Open this post in threaded view
|

Re: Move CacheStore::loadCache to a separate interface

yzhdanov
Stan, feel free to file the ticket. Just make sure to add detailed
description to it. Your suggestion seems to make sense.

--Yakov